Help Weekly Olympiads

[maxicroma]

Hello, I am using the files of l2mythras (the same ones that are posted in these forums).

I am trying to set up the Olympiads to be weekly and not monthly.

This its the config file

#==============================================
# 				Olympiad Settings			  #
#==============================================
EnableOlympiad = True
EnableOlympiadSpectating = True

# Olympiad Manager Shout Just one message 
# Official = False
OlyManagerShoutJustOneMessage = True

#==============================================#
#             ANTI FEED OPTION                 #
#==============================================#
# Don't Allow Clan Members to fight VS same Clan
# Official = False

# Maximum number in Stadion Preparation (standard: 160)
OlympiadStadiasCount = 160

# Olympiad Start Time in Military hours Default 8pm (20)
AltOlyStartTime = 18
# Olympiad Start Time for Min's, Default 00 so at the start of the hour.
AltOlyMin = 00

# Olympiad Compeition Period, Default 8 hours.
# (If set different, should be increment by 10mins)
AltOlyCPeriod = 28800000

# Olympiad Weekly Period, Default: 604800000
AltOlyWPeriod = 604800000

# Olympiad Validation Period, Default 12 Hours.
# Default: 43200000
AltOlyVPeriod = 43200000

# If you change the config make a request to the database: DELETE FROM `server_variables` WHERE `name` = 'Olympiad_End';
# Example (every two weeks):
# AltOlyDateEnd = 1,15
AltOlyDateEnd = 15

ClassGameMin = 2
NonClassGameMin = 2
TeamGameMin = 15

# Number used for displaying amount of registered participants, messages "Fewer than ..." or "More than ...".
# 0 for displaying digits instead of text phrase (old style).
# Default: 100
AltOlyRegistrationDisplayNumber = 10

# Olympiad battle winner reward.
# Default: 13722
AltOlyBattleRewItem = 13722

# Default: 50
AltOlyClassedRewItemCount = 50

# Default: 40
AltOlyNonClassedRewItemCount = 40

# Default: 50
AltOlyTeamRewItemCount = 50

# ItemId for this reward.
# Default: 13722
AltOlyCompRewItem = 13722

# Rate to exchange points to reward item.
# Default: 1000
AltOlyGPPerPoint = 1000

# Noblesse points awarded to Heros.
# Default: 200
AltOlyHeroPoints = 200

# Noblesse points awarded to Rank 1 members.
# Default: 100
AltOlyRank1Points = 100

# Noblesse points awarded to Rank 2 members.
# Default: 75
AltOlyRank2Points = 75

# Noblesse points awarded to Rank 3 members.
# Default: 55
AltOlyRank3Points = 55

# Noblesse points awarded to Rank 4 members.
# Default: 40
AltOlyRank4Points = 40

# Noblesse points awarded to Rank 5 members.
# Default: 30
AltOlyRank5Points = 30

# Maximum fighting gallop can be made
GameMaxLimit = 70
# Limit the fighting in class
GameClassesCountLimit = 30
# Limit fighting outside class
GameNoClassesCountLimit = 60
# Limit fighting team
GameTeamCountLimit = 10

# The number of fights per month required for tokens
OlympiadBattlesForReward = 15

# The number of points issued on receipt nubla and earlier this month
OlympiadPointsDefault = 50
# The number of points given out in a week
OlympiadPointsWeekly = 25

# Show /olympiadstat in the old version (only you)
OlympiadOldStyleStat = False

# Block Gulf twinks at the Olympics (check for IP)
OlympiadPlayerIp = True

# Время ожидания до порта на арену, использовать только значения стандартного ряда (120,60,30,15,5,4,3,2,1)
# Default: 120
AltOlyWaitTime = 60
# Время ожидания порта в город после боя, использовать только значения стандартного ряда (20,10,5,4,3,2,1)
# Default: 20
AltOlyPortBackTime = 20

# Config for maximum grinding equip to fight in the Olympics
# False to disable
OlyEnchantLimit = false
OlyEnchantLimitWeapon = 6
OlyEnchantLimitArmor = 6
OlyEnchantLimitJewel = 6

# Clear peretochennye things?
# Works only when the OlyEnchantLimit!
OlympiadUnEquipBadEnchantItem = True

# Time to teleport to the stadium
OlympiadBeginTime = 60

 

Im thinking that the value to change its this one

 

# If you change the config make a request to the database: DELETE FROM `server_variables` WHERE `name` = 'Olympiad_End';
# Example (every two weeks):
# AltOlyDateEnd = 1,15
AltOlyDateEnd = 15

 

 

Try putting 1.15 as it says up there and did the update of the server_variables table.
I played some matches with the characters with all the requirements (9 fights and at least 1 won), then forward the windows date (so that the 2 weeks pass) but it never lets you ask for hero status.

If anyone could give me a hand.
Thank you so much
Regards

 

 

 

[SweeTs]

Paste it under notepad or so, copy it again and paste into eclipse. That way you can avoid encoding issues. I had such issue recently and that way helped :) 

[Solomun]

29 minutes ago, SweeTs said:

Paste it under notepad or so, copy it again and paste into eclipse. That way you can avoid encoding issues. I had such issue recently and that way helped :) 

Eclipse some times is warning you that there is a problem with encoding. Maybe he didnt pay any attention and closed the dialog.

[Nightw0lf]

fixes:

add those lines to a txt file and save it as utf8

delete spaces type only code

type the text from scratch

 

the ??????? characters after the ; are spaces in non utf8 character set you can convert them in eclipse too when you save the file it asks you, you propably pressed the wrong answer.

[maxicroma]

8 hours ago, Solomun said:

Try to delete the lines and write them without copt paste. As far i can see, it is an encoding problem. Which means something foes wrong when you copy paste my code. Maybe your browser or maxcheaters or something. Write them by hand and check...

Yes was a encoding problem.

About the code i added a little part of it only this part

currentTime.set(Calendar.DAY_OF_WEEK, Calendar.SUNDAY);
        currentTime.set(Calendar.AM_PM, Calendar.AM);
        currentTime.set(Calendar.HOUR, 12);
        currentTime.set(Calendar.MINUTE, 0);
        currentTime.set(Calendar.SECOND, 0);
        if (currentTime.getTimeInMillis() < System.currentTimeMillis())
            currentTime.add(Calendar.WEEK_OF_MONTH, 1);

the rest of the code you give me it this one (Was giving errors "Cannot Resolv Variables"

  _olympiadEnd = currentTime.getTimeInMillis();
        
        Calendar nextChange = Calendar.getInstance();
        _nextWeeklyChange = nextChange.getTimeInMillis() + WEEKLY_PERIOD;
        scheduleWeeklyChange();
    }

 Btw i compiled it sucessfull with the little code part ,run the sql update on server_variables table.

But when i turn on the server on the olympiad charge it start to spam with a olympiad error

 

[Solomun]

You should change only the lines that contain calendar.set.

 

The code you show. The variable olympiadEnd is never used. Or at least it seems to be.

[maxicroma]

39 minutes ago, Solomun said:

You should change only the lines that contain calendar.set.

 

The code you show. The variable olympiadEnd is never used. Or at least it seems to be.

Well i think its working now at least it say "period ends in 3 days(sunday)".

What about the Weekly Change times , it says (6 days and 23 hours)

Should i change the default value

# Olympiad Weekly Period, Default: 604800000
AltOlyWPeriod = 604800000

 

To AltOlyWPeriod = 151200000

?

 

[SweeTs]

Weekly period is about 'points addition', if I'm not wrong. From memory. So yeah, if that's the case you should decrease it. Must be lower that the oly period. 

[Solomun]

Copy the period end time into weekly end time record in database and "synchronize" them. See what happens :P

[maxicroma]

1 hour ago, Solomun said:

Copy the period end time into weekly end time record in database and "synchronize" them. See what happens :P

Now it will give you weekly points when a new season start im right?

 

[Solomun]

1 hour ago, maxicroma said:

Now it will give you weekly points when a new season start im right?

 

I think yes. If it does not, it is the same thing for players since period is 1 week.

[maxicroma]

22 hours ago, Solomun said:

I think yes. If it does not, it is the same thing for players since period is 1 week.

Im keep having this same problem even when i copy the period end time into weekly end time record in database and "synchronize" them

[Solomun]

You did something wrong. I think Instead of giving the value of system current time and the calendar i give you, you only give system current time.

Edited August 3, 2018 by Solomun

[maxicroma]

package l2f.gameserver.model.entity.olympiad;

import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.ArrayList;
import java.util.Calendar;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;

import l2f.commons.dbutils.DbUtils;
import l2f.gameserver.Announcements;
import l2f.gameserver.Config;
import l2f.gameserver.dao.OlympiadNobleDAO;
import l2f.gameserver.database.DatabaseFactory;
import l2f.gameserver.instancemanager.ServerVariables;
import l2f.gameserver.model.base.ClassId;
import l2f.gameserver.network.serverpackets.SystemMessage;
import l2f.gameserver.network.serverpackets.SystemMessage2;
import l2f.gameserver.network.serverpackets.components.SystemMsg;
import l2f.gameserver.templates.StatsSet;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class OlympiadDatabase
{
	private static final Logger _log = LoggerFactory.getLogger(OlympiadDatabase.class);

	public static synchronized void loadNoblesRank()
	{
		Olympiad._noblesRank = new ConcurrentHashMap<Integer, Integer>();
		Map<Integer, Integer> tmpPlace = new HashMap<Integer, Integer>();

		Connection con = null;
		PreparedStatement statement = null;
		ResultSet rset = null;
		try
		{
			con = DatabaseFactory.getInstance().getConnection();
			statement = con.prepareStatement(OlympiadNobleDAO.GET_ALL_CLASSIFIED_NOBLESS);
			rset = statement.executeQuery();
			int place = 1;
			while (rset.next())
				tmpPlace.put(rset.getInt(Olympiad.CHAR_ID), place++);

		}
		catch(Exception e)
		{
			_log.error("Olympiad System: Error!", e);
		}
		finally
		{
			DbUtils.closeQuietly(con, statement, rset);
		}

		int rank1 = (int) Math.round(tmpPlace.size() * 0.01);
		int rank2 = (int) Math.round(tmpPlace.size() * 0.10);
		int rank3 = (int) Math.round(tmpPlace.size() * 0.25);
		int rank4 = (int) Math.round(tmpPlace.size() * 0.50);

		if (rank1 == 0)
		{
			rank1 = 1;
			rank2++;
			rank3++;
			rank4++;
		}

		for (int charId : tmpPlace.keySet())
			if (tmpPlace.get(charId) <= rank1)
				Olympiad._noblesRank.put(charId, 1);
			else if (tmpPlace.get(charId) <= rank2)
				Olympiad._noblesRank.put(charId, 2);
			else if (tmpPlace.get(charId) <= rank3)
				Olympiad._noblesRank.put(charId, 3);
			else if (tmpPlace.get(charId) <= rank4)
				Olympiad._noblesRank.put(charId, 4);
			else
				Olympiad._noblesRank.put(charId, 5);
	}

	/**
	 * Сбрасывает информацию о ноблесах, сохраняя очки за предыдущий период
	 */
	public static synchronized void cleanupNobles()
	{
		_log.info("Olympiad: Calculating last period...");
		Connection con = null;
		PreparedStatement statement = null;
		try
		{
			con = DatabaseFactory.getInstance().getConnection();
			statement = con.prepareStatement(OlympiadNobleDAO.OLYMPIAD_CALCULATE_LAST_PERIOD);
			statement.setInt(1, Config.OLYMPIAD_BATTLES_FOR_REWARD);
			statement.execute();
			DbUtils.close(statement);

			statement = con.prepareStatement(OlympiadNobleDAO.OLYMPIAD_CLEANUP_NOBLES);
			statement.setInt(1, Config.OLYMPIAD_POINTS_DEFAULT);
			statement.execute();
		}
		catch(Exception e)
		{
			_log.error("Olympiad System: Couldn't calculate last period!", e);
		}
		finally
		{
			DbUtils.closeQuietly(con, statement);
		}

		for (Integer nobleId : Olympiad._nobles.keySet())
		{
			StatsSet nobleInfo = Olympiad._nobles.get(nobleId);
			int points = nobleInfo.getInteger(Olympiad.POINTS);
			int compDone = nobleInfo.getInteger(Olympiad.COMP_DONE);
			nobleInfo.set(Olympiad.POINTS, Config.OLYMPIAD_POINTS_DEFAULT);
			if (compDone >= Config.OLYMPIAD_BATTLES_FOR_REWARD)
			{
				nobleInfo.set(Olympiad.POINTS_PAST, points);
				nobleInfo.set(Olympiad.POINTS_PAST_STATIC, points);
			}
			else
			{
				nobleInfo.set(Olympiad.POINTS_PAST, 0);
				nobleInfo.set(Olympiad.POINTS_PAST_STATIC, 0);
			}
			nobleInfo.set(Olympiad.COMP_DONE, 0);
			nobleInfo.set(Olympiad.COMP_WIN, 0);
			nobleInfo.set(Olympiad.COMP_LOOSE, 0);
			nobleInfo.set(Olympiad.GAME_CLASSES_COUNT, 0);
			nobleInfo.set(Olympiad.GAME_NOCLASSES_COUNT, 0);
			nobleInfo.set(Olympiad.GAME_TEAM_COUNT, 0);
		}
	}

	public static List<String> getClassLeaderBoard(int classId)
	{
		List<String> names = new ArrayList<String>();

		try (Connection con = DatabaseFactory.getInstance().getConnection();
		    PreparedStatement statement = con.prepareStatement(classId == 132 ? OlympiadNobleDAO.GET_EACH_PAST_CLASS_LEADER_SOULHOUND : OlympiadNobleDAO.GET_EACH_PAST_CLASS_LEADER))
		{
			statement.setInt(1, classId);

			try (ResultSet rset = statement.executeQuery())
			{
				while (rset.next())
					names.add(rset.getString(Olympiad.CHAR_NAME));
			}
		}
		catch (SQLException e)
		{
			_log.error("Olympiad System: Couldn't get old noble ranking from db!", e);
		}

		return names;
	}

	/**
	 * Returning List of Character Names 
	 * Names are ordered DESC by olympiad_points(current Period) 
	 * Name is taken into consideration only if base class = classId 
	 * @param classId Id of the Base Class we is looking for 
	 * @return Names of the best players 
	 */
	public static List<String> getClassLeaderBoardCurrent(int classId)
	{
		List<String> names = new ArrayList<String>();

		try (Connection con = DatabaseFactory.getInstance().getConnection();
		    PreparedStatement statement = con.prepareStatement(classId == 132 ? OlympiadNobleDAO.GET_EACH_CURRENT_CLASS_LEADER_SOULHOUND  : OlympiadNobleDAO.GET_EACH_CURRENT_CLASS_LEADER))
		{
			statement.setInt(1, classId);
			statement.setInt(2, Config.OLYMPIAD_BATTLES_FOR_REWARD);

			try (ResultSet rset = statement.executeQuery())
			{
				while (rset.next())
					names.add(rset.getString(Olympiad.CHAR_NAME));
			}
		}
		catch (SQLException e)
		{
			_log.error("Olympiad System: Couldn't get current noble ranking from db!", e);
		}

		return names;
	}

	public static synchronized void sortHerosToBe()
	{
		if (Olympiad._period != 1)
			return;

		Olympiad._heroesToBe = new ArrayList<StatsSet>();

		Connection con = null;
		PreparedStatement statement = null;
		ResultSet rset = null;
		try
		{
			con = DatabaseFactory.getInstance().getConnection();
			StatsSet hero;

			for (ClassId id : ClassId.VALUES)
			{
				if (id.getId() == 133)
					continue;
				if (id.level() == 3)
				{
					statement = con.prepareStatement(id.getId() == 132 ? OlympiadNobleDAO.OLYMPIAD_GET_HEROS_SOULHOUND : OlympiadNobleDAO.OLYMPIAD_GET_HEROS);
					statement.setInt(1, id.getId());
					statement.setInt(2, Config.OLYMPIAD_BATTLES_FOR_REWARD);
					rset = statement.executeQuery();

					if (rset.next())
					{
						hero = new StatsSet();
						hero.set(Olympiad.CLASS_ID, id.getId());
						hero.set(Olympiad.CHAR_ID, rset.getInt(Olympiad.CHAR_ID));
						hero.set(Olympiad.CHAR_NAME, rset.getString(Olympiad.CHAR_NAME));

						Olympiad._heroesToBe.add(hero);
					}
					DbUtils.close(statement, rset);
				}
			}
		}
		catch(Exception e)
		{
			_log.error("Olympiad System: Couldnt heros from db!", e);
		}
		finally
		{
			DbUtils.closeQuietly(con, statement, rset);
		}
	}

	public static synchronized void saveNobleData(int nobleId)
	{
		OlympiadNobleDAO.getInstance().replace(nobleId);
	}

	public static synchronized void saveNobleData()
	{
		if (Olympiad._nobles == null)
			return;
		for (Integer nobleId : Olympiad._nobles.keySet())
			saveNobleData(nobleId);
	}

	public static synchronized void setNewOlympiadEnd()
	{
		Announcements.getInstance().announceToAll(new SystemMessage(SystemMsg.ROUND_S1_OF_THE_GRAND_OLYMPIAD_GAMES_HAS_STARTED).addNumber(Olympiad._currentCycle));

		Calendar currentTime = Calendar.getInstance();
		currentTime.set(Calendar.DAY_OF_WEEK, Calendar.SUNDAY);
		currentTime.set(Calendar.AM_PM, Calendar.AM);
		currentTime.set(Calendar.HOUR, 12);
		currentTime.set(Calendar.MINUTE, 0);
		currentTime.set(Calendar.SECOND, 0);
		Olympiad._olympiadEnd = currentTime.getTimeInMillis();
		     currentTime.add(Calendar.WEEK_OF_MONTH, 1);
		
		Calendar nextChange = Calendar.getInstance();
		Olympiad._nextWeeklyChange = nextChange.getTimeInMillis() + Config.ALT_OLY_WPERIOD;

		Olympiad._isOlympiadEnd = false;
		Announcements.getInstance().announceToAll(new SystemMessage2(SystemMsg.OLYMPIAD_PERIOD_S1_HAS_STARTED).addInteger(Olympiad._currentCycle));
	}

	public static void save()
	{
		saveNobleData();
		ServerVariables.set("Olympiad_CurrentCycle", Olympiad._currentCycle);
		ServerVariables.set("Olympiad_Period", Olympiad._period);
		ServerVariables.set("Olympiad_End", Olympiad._olympiadEnd);
		ServerVariables.set("Olympiad_ValdationEnd", Olympiad._validationEnd);
		ServerVariables.set("Olympiad_NextWeeklyChange", Olympiad._nextWeeklyChange);
	}
}

Thats the whole archive i miss somethink?

[Solomun]

Yes you do. Try to see my code better. The if statement and so.

[maxicroma]

18 hours ago, Solomun said:

Yes you do. Try to see my code better. The if statement and so.

Well i added some lines more 

public static synchronized void setNewOlympiadEnd()
	{
		Announcements.getInstance().announceToAll(new SystemMessage(SystemMsg.ROUND_S1_OF_THE_GRAND_OLYMPIAD_GAMES_HAS_STARTED).addNumber(Olympiad._currentCycle));

		Calendar currentTime = Calendar.getInstance();
		currentTime.set(Calendar.DAY_OF_WEEK, Calendar.SUNDAY);
		currentTime.set(Calendar.AM_PM, Calendar.AM);
		currentTime.set(Calendar.HOUR, 12);
		currentTime.set(Calendar.MINUTE, 0);
		currentTime.set(Calendar.SECOND, 0);
		if (currentTime.getTimeInMillis() < System.currentTimeMillis())
            currentTime.add(Calendar.WEEK_OF_MONTH, 1);

        _olympiadEnd = currentTime.getTimeInMillis();
		
		Calendar nextChange = Calendar.getInstance();
		Olympiad._nextWeeklyChange = nextChange.getTimeInMillis() + Config.ALT_OLY_WPERIOD;

		Olympiad._isOlympiadEnd = false;
		Announcements.getInstance().announceToAll(new SystemMessage2(SystemMsg.OLYMPIAD_PERIOD_S1_HAS_STARTED).addInteger(Olympiad._currentCycle));
	}

And wheare says _olympiadEnd = currentTime.getTimeInMillis() ;

I get this error