Help Add item player Offline aCis

[l2jkain]

Hello I put event monument in my acis however the player only wins the item if you have online if the player had ofline appears that mistake someone help me?

 

 

    private static void addReward(int obj_id, boolean duple)
    {
        Player player = World.getInstance().getPlayer(obj_id);
        
        if(player != null && player.isOnline())
        {
            InventoryUpdate iu = new InventoryUpdate();
            final Item reward = ItemTable.getInstance().getTemplate(Config.EVENT_MONUMENT_STATUET_REWARD_ID);
            
            player.getInventory().addItem("top", Config.EVENT_MONUMENT_STATUET_REWARD_ID, duple ? Config.EVENT_MONUMENT_STATUET_REWARD_AMOUNT * 2 : Config.EVENT_MONUMENT_STATUET_REWARD_AMOUNT,player, null);
            player.sendMessage("Voce ganhou " + reward.getName() + ".");
            player.getInventory().updateDatabase();
            player.sendPacket(iu);
        }
        else
        {
            addOfflineItem(obj_id, Config.EVENT_MONUMENT_STATUET_REWARD_ID, duple ? Config.EVENT_MONUMENT_STATUET_REWARD_AMOUNT * 2 : Config.EVENT_MONUMENT_STATUET_REWARD_AMOUNT);
        }
    }
    
    private static void addOfflineItem(int owner_id, int item_id, int count)
    {
        try(Connection con = L2DatabaseFactory.getInstance().getConnection())
        {
            PreparedStatement st = con.prepareStatement("SELECT count FROM items WHERE item_id = ? and owner_id = ?");
            st.setInt(1,item_id);
            st.setInt(2,owner_id);
            ResultSet rs = st.executeQuery();
            int total = 0;
            
            while (rs.next())
            {
                total = rs.getInt("count");
            }
            
            st.close();
            rs.close();

            st = con.prepareStatement("SELECT MAX(object_id) as objid FROM items");
            st.executeQuery();
            rs = st.executeQuery();
            
            int obj_id = 0;
            
            while (rs.next())
            {
                obj_id = rs.getInt("objid") + 1000;
            }
            
            st.close();
            rs.close();
            
            if(total == 0)
            {
                st = con.prepareStatement("INSERT INTO items VALUES (?, ?, ?, ?, 0, 'INVENTORY', 0, 0, 0, NULL, 0, 0, -1)");
                st.setLong(1,owner_id);
                st.setLong(2,obj_id);
                st.setInt(3,item_id);
                st.setInt(4, count);
                st.execute();
                st.close();
            }
            else
            {
                st = con.prepareStatement("UPDATE items SET count = ? WHERE owner_id = ? and item_id = ? ");
                st.setInt(1, total + count);
                st.setLong(2, owner_id);
                st.setLong(3, item_id);
                st.execute();
                st.close();
            }
        }
        catch (SQLException e)
        {
            _log.severe("Could not update item char: " + e);
        }
    }
    

 

[Antartico™]

Try this:

 

private static void addOfflineItem(int owner_id, int item_id, int count)
{
    try(Connection con = L2DatabaseFactory.getInstance().getConnection())
    {
        PreparedStatement st = con.prepareStatement("SELECT count FROM items WHERE item_id=? AND owner_id=?");
        st.setInt(1, item_id);
        st.setInt(2, owner_id);

        ResultSet rs = st.executeQuery();
        
        if(rs.next())
        {
            st = con.prepareStatement("UPDATE items SET count=? WHERE owner_id=? and item_id=?");
            st.setInt(1, rs.getInt("count") + count);
            st.setInt(2, owner_id);
            st.setInt(3, item_id);
        }
        else
        {
            st = con.prepareStatement("INSERT INTO items VALUES (?, ?, ?, ?, 0, 'INVENTORY', 0, 0, 0, NULL, 0, 0, -1)");
            st.setInt(1, owner_id);
            st.setInt(2, IdFactory.getInstance().getNextId())
            st.setInt(3, item_id);
            st.setInt(4, count);
        }

        st.execute();
        rs.close();
        st.close();
    }
    catch (SQLException e)
    {
        _log.severe("Could not update item char: " + e);
    }
}

I changed the Long for Int (because that's your input on the function), also your "objectId" generation method was wrong.
Remember to import net.sf.l2j.gameserver.idfactory.IdFactory;

 

 

[SweeTs]

You don't rly need that. Part of my code, rewarding offline player. Using ItemInstance, create item and attach it to player. Example

item.setOwnerId(player.getObjectId());
item.setEnchantLevel(item.getEnchantLevel());
item.setLocation(ItemLocation.WAREHOUSE);
item.updateDatabase();

[l2jkain]

2 hours ago, Antartico™ said:

Try this:

 

private static void addOfflineItem(int owner_id, int item_id, int count)
{
    try(Connection con = L2DatabaseFactory.getInstance().getConnection())
    {
        PreparedStatement st = con.prepareStatement("SELECT count FROM items WHERE item_id=? AND owner_id=?");
        st.setInt(1, item_id);
        st.setInt(2, owner_id);

        ResultSet rs = st.executeQuery();
        
        if(rs.next())
        {
            st = con.prepareStatement("UPDATE items SET count=? WHERE owner_id=? and item_id=?");
            st.setInt(1, rs.getInt("count") + count);
            st.setInt(2, owner_id);
            st.setInt(3, item_id);
        }
        else
        {
            st = con.prepareStatement("INSERT INTO items VALUES (?, ?, ?, ?, 0, 'INVENTORY', 0, 0, 0, NULL, 0, 0, -1)");
            st.setInt(1, owner_id);
            st.setInt(2, IdFactory.getInstance().getNextId())
            st.setInt(3, item_id);
            st.setInt(4, count);
        }

        st.execute();
        rs.close();
        st.close();
    }
    catch (SQLException e)
    {
        _log.severe("Could not update item char: " + e);
    }
}

I changed the Long for Int (because that's your input on the function), also your "objectId" generation method was wrong.
Remember to import net.sf.l2j.gameserver.idfactory.IdFactory;

 

 

 

gave the same thing

[l2jkain]

is giving error saying that count does not exist

Edited January 15, 2018 by l2jkain

[Tryskell]

SweeTs said it all.

As a sidenote you can merge both queries using "ON DUPLICATE KEY UPDATE".  At least that's what I did for player skill acquisition cleanup.

[l2jkain]

I have refacted the code but it does not add anything in the player's bag offilne

On 14/01/2018 at 8:28 PM, SweeTs said:

You don't rly need that. Part of my code, rewarding offline player. Using ItemInstance, create item and attach it to player. Example

 

item.setOwnerId(player.getObjectId());
item.setEnchantLevel(item.getEnchantLevel());
item.setLocation(ItemLocation.WAREHOUSE);
item.updateDatabase();

 

 

On 15/01/2018 at 4:15 AM, Tryskell said:

SweeTs said it all.

As a sidenote you can merge both queries using "ON DUPLICATE KEY UPDATE".  At least that's what I did for player skill acquisition cleanup.

private static void addOfflineItem(int owner_id, int item_id, int count)
    {
        ItemInstance item = new ItemInstance(IdFactory.getInstance().getNextId(), count);
        
        try(Connection con = L2DatabaseFactory.getInstance().getConnection())
        {
            PreparedStatement stm_items = con.prepareStatement("INSERT INTO items (owner_id,item_id,count,loc,loc_data,enchant_level,object_id,custom_type1,custom_type2,mana_left,time) VALUES (?,?,?,?,?,?,?,?,?,?,?)");
            
            stm_items.setInt(1, owner_id);
            stm_items.setInt(2, item.getItemId());
            stm_items.setInt(3, count);
            item.setLocation(ItemLocation.WAREHOUSE);
            stm_items.setInt(5, 0);
            stm_items.setInt(6, item.getEnchantLevel());
            stm_items.setInt(7, item.getObjectId());
            stm_items.setInt(8, 0);
            stm_items.setInt(9, 0);
            stm_items.setInt(10, -1);
            stm_items.setLong(11, System.currentTimeMillis());
            stm_items.executeUpdate();
            stm_items.close();
        }
        catch (SQLException e)
        {
            _log.severe("Could not update item char: " + e);
        }
    }

[l2jkain]

thank you very much, I can do it Close the topic.