Help acis have problem with packets

[tazerman2]

hello i have make a automatically party create for event's but i have big problem with

packets like i have open 6 box like 3vs3 in one team i see last player and have double add same player

like

1 tester

2 tester1

3 tester2

4 tester2

 

all is good on event he add 3 player pet party and in party.java use same 3 vs 3 add

i use threadpool if maybe have problem with fast add and with delay he make party good

as normal

image for hava a idea

 

so how can help or tell me whare is the problem? i have test it all.

and code is this

Spoiler

    // create party players
    public void createPartyOfTeam(int teamId)
    {
        
        final List<PcInstance> _players = new ArrayList<>();
        
        for (PcInstance p : players.keySet())
        {
            if (getTeam(p) == teamId)
            {
                if (p.isInParty())
                {
                    p.getParty().removePartyMember(p, MessageType.EXPELLED);
                }
                System.out.println(p.getName() + "   ");
                _players.add(p);
            }
        }
        
        if (_players.size() >= 2)
        {
            int i = 0;
            PcInstance leader = _players.get(0);
            Party party = new Party(leader, _players.get(1), LootRule.ITEM_RANDOM);
            leader.setParty(party);
            
            
            for (PcInstance player : _players)
            {
                if (i < 2)
                {
                    i++;
                }
                else
                {
                    party.addPartyMember(player);
                    player.setParty(party);
                    i++;
                }
            }
            Announcement.announceToAll("i time run " + i);
            
        }
    }

 

Edited November 25, 2017 by tazerman2

[Tryskell]

Since you use regular ArrayList, order is probably not retained.

 

There is no problems with ThreadPool, MMOCore or even Party. Recode your crap.

[`Son]

Can u explain it on Greek? Your english is meh .. >.>

[`Son]

1 minute ago, Tryskell said:

Recode your crap.

You should recode most of your crap instead of just renaming, just saying.

[pirama]

leader.setParty(party);

player.setParty(party);

this don't needed on code 

 

on new Party(leader, _players.get(1), LootRule.ITEM_RANDOM);

they set leader.setParty(party);

and on  party.addPartyMember(player); has set for player.setParty(party);

 

this method can create max 1 party 

because new party is up of for 

try this

 // create party players
    public void createPartyOfTeam(int teamId)
    {
        
        final List<PcInstance> _players = new ArrayList<>();
        
        for (PcInstance p : players.keySet())
        {
            if (getTeam(p) == teamId)
            {
                if (p.isInParty())
                   p.getParty().removePartyMember(p, MessageType.EXPELLED);
              
                _players.add(p);
            }
        }
        
		int i = 0;
		PcInstance leader = null;
		Party party = null;

		for (PcInstance player : _players)
		{
			if (i == 0)
				leader = player;
			else if (i == 1 || party == null)
				party = new Party(leader, player, LootRule.ITEM_RANDOM);
			else if (i < 9)
				party.addPartyMember(player);
			else
			{
				i = 0;
				leader = player;
			}
			
			i++;
		}
    }

 

Edited November 25, 2017 by pirama

[Tryskell]

13 hours ago, `Son said:

You should recode most of your crap instead of just renaming, just saying.

 

Do you have an exemple or are you just barking ? When I rename, I generally cleanup in the same time, which mean fix issues / improve performance / improve readability. I never rename for the pleasure to rename.

 

Did you share anything for my pack ? Any fix, any rework ? If no, then stfu and stick inside your hole.

 

There are fixes on every single aCis revision. You should maybe take a look on changesets descriptions.

Edited November 25, 2017 by Tryskell

[`Son]

19 hours ago, Tryskell said:

Did you share anything for my pack ? Any fix, any rework ? If no, then stfu and stick inside your hole.

Can't see any reason contributing in such a project. You're pretty much the same arrogant craphead as xxdem.

Also please change your signature. Your name combined with the word mature in the same paragraph just insults the meaning of the word.

[Tryskell]

5 hours ago, `Son said:

Can't see any reason contributing in such a project. You're pretty much the same arrogant craphead as xxdem.

Also please change your signature. Your name combined with the word mature in the same paragraph just insults the meaning of the word.

 

Continue to bark then. No exemples or proofs, just words. Keep your opinion for yourself when you can't argue, randomer.

Edited November 26, 2017 by Tryskell

[`Son]

Isnt this a public forum? You're the one barking when you get some negative feedback about your project. Acis used to be good yes sometime in the past. The last months theres no progress and useless commits in ur git/svn or w/e u use. You should just either deal with it or just commit something when theres some real rework which someone worths spending money on ur freemium system. 

[Tryskell]

4 hours ago, `Son said:

Isnt this a public forum? You're the one barking when you get some negative feedback about your project. Acis used to be good yes sometime in the past. The last months theres no progress and useless commits in ur git/svn or w/e u use. You should just either deal with it or just commit something when theres some real rework which someone worths spending money on ur freemium system. 

 

"No progress" ? I would like to see your own project, over 6y. What, you don't have ? Ah ok.

"Used to be good" ? What makes it WORST than before ?

 

Barking = people who complains but aren't able to reproduce anything near what they complain from, or even wish to help. Like a helpless chihuahua.

 

A negative feedback must be constructive and based on facts. My useless commits dropped something like 40 reports those last months. So your arguments are invalid, and what you think pointless can be important for another people. Moreover, if you find it doesn't go fast, you can help. It's a collaborative project.

 

Stick to L2JFrozen/Hellas/Archid/vanilla  if you're unhappy. I don't force you to use my pack.

 

Ppl as you - who don't share, don't help, don't participate to communities, don't code but think they can have an opinion - are simply garbage.

 

Anyway I wasted enough time answering you. I leave you with your hatred, I continue to not moving on aCis.

Edited November 27, 2017 by Tryskell

[`Son]

1 hour ago, Tryskell said:

 

"No progress" ? I would like to see your own project, over 6y. What, you don't have ? Ah ok.

"Used to be good" ? What makes it WORST than before ?

 

Barking = people who complains but aren't able to reproduce anything near what they complain from, or even wish to help. Like a helpless chihuahua.

 

A negative feedback must be constructive and based on facts. My useless commits dropped something like 40 reports those last months. So your arguments are invalid, and what you think pointless can be important for another people. Moreover, if you find it doesn't go fast, you can help. It's a collaborative project.

 

Stick to L2JFrozen/Hellas/Archid/vanilla  if you're unhappy. I don't force you to use my pack.

 

Ppl as you - who don't share, don't help, don't participate to communities, don't code but think they can have an opinion - are simply garbage.

 

Anyway I wasted enough time answering you. I leave you with your hatred, I continue to not moving on aCis.

First of all, im just comparing pretty simple stuff. The fact that you are selling 10 revisions per each period of aCis is just some garbage logic because as pretty much said any kind of customer expects to see innovative things plus some future plan on the project. Something that aCis lack for many reasons.

The last big rework you did was like hmm maybe a year ago or even more with Knownlists which could really make some difference affecting the game in total.

After that your project remained ALMOST the same ridiculizing urself and your big ego as the grand leader of THE grand project and you delivered almost nothing. 

 

"Used to be good" ? What makes it WORST than before ? --> 

Yes it used to be better when you've been active reworking core issues. There are million of things to start reworking but still u just stay commiting bullshit micro-optimizations which have minimal meaning in the end of the day.

 

Moreover, if you find it doesn't go fast, you can help. It's a collaborative project. -->

Being an ass in every single topic doesnt really help collaboration. Skill differs from coder to coder but still. Being the same kid as xxDem doesnt really help at all.

 

Stick to L2JFrozen/Hellas/Archid/vanilla  if you're unhappy. I don't force you to use my pack. -->

Im refering to aCis and not to any other garbage Greek or Russian project since they never really had any kind of potential in contradiction with aCis so get real.