Jump to content
  • 0

Blow Skills' Success Sound Effect


Question

Posted

on offmod when a character land a blow skill (deadly, mortal, lethal etc..) successfully it has a critical strike effect, but on l2j it has the same effect for both success and fail. I never saw it working properly on l2j. why?

 

here is a video about it.

 

Recommended Posts

  • 0
Posted

My first guess, because its NPC, some packs block dmg on NPC, therefore they get no damage and make no sound/effect/stance etc.

  • 0
Posted

My first guess, because its NPC, some packs block dmg on NPC, therefore they get no damage and make no sound/effect/stance etc.

Its the same on npc and mobs, so its something else

  • 0
Posted (edited)

My first guess, because its NPC, some packs block dmg on NPC, therefore they get no damage and make no sound/effect/stance etc.

Sound effect is not linking with npcs block or what ever with 'targets'.. its clearly about the attacker and his conditions

 

so which pack has it right? I tested it on acis btw

 

acis havent implemented this one as i know. i dont know where you can find it completed .. im working with my own so .. :/

Edited by melron
  • 0
Posted (edited)

Since we are speaking for effect nothing to do with damage..

Should work normally..

Test it here l2centos.com

Edited by Reborn12
  • 0
Posted (edited)

My first guess, because its NPC, some packs block dmg on NPC, therefore they get no damage and make no sound/effect/stance etc.

L2j Developer ? wtf ? what is this ? just tell me what are you going there ?

 

they show on video how work on  official and ask how can fix it on l2j and you talk about packs ? wtf ?

 

one Moderator can get this membership from this new " java dev " ( it is ridiculous )

 

[OnTopic]

 

package net.sf.l2j.gameserver.handler.skillhandlers;

Blow.java

 

on success send packet sound

Edited by pirama
  • 0
Posted (edited)

how can I do that exactly?

 

find this

if (activeChar instanceof L2PcInstance)
        ((L2PcInstance) activeChar).sendDamageMessage(target, (int) damage, false, true, false);

and make it

if (activeChar instanceof L2PcInstance)
{
	((L2PcInstance) activeChar).sendDamageMessage(target, (int) damage, false, crit, false);
	activeChar.sendPacket(new PlaySound("skillsound.critical_hit_02"));
}
Edited by pirama
  • 0
Posted

 

find this

if (activeChar instanceof L2PcInstance)
        ((L2PcInstance) activeChar).sendDamageMessage(target, (int) damage, false, true, false);

and make it

if (activeChar instanceof L2PcInstance)
{
	((L2PcInstance) activeChar).sendDamageMessage(target, (int) damage, false, crit, false);
	activeChar.sendPacket(new PlaySound("skillsound.critical_hit_02"));
}

It says playsound cannot be resolved to a type after I edit the code. sry for being a nab Im new at this

  • 0
Posted (edited)

It says playsound cannot be resolved to a type after I edit the code. sry for being a nab Im new at this

you mean this (new PlaySound ...... )   ?

 

you have add the import ?

 

import net.sf.l2j.gameserver.network.serverpackets.PlaySound;

 

your pack is ?

 

go the mouse on error and get print screen

Edited by pirama
  • 0
Posted (edited)

you mean this (new PlaySound ...... )   ?

 

your pack is ?

 

go the mouse on error and get print screen

 

here u go

 

GAlOVon.png

Edited by showma
Guest
This topic is now closed to further replies.


  • Posts

    • First, don't really follow the "main voice", moreover if you consider it an hobby. Simply do what you want, you got only one life so use it as you want. If you make it an hobby, it's exactly like piano, or velo - only practice makes you better.   Secondly, how do you learn things ? It's actually a really important question, since some can simply be scholar, read books (theory) then practice ; and some simply can't read books. I'm the second type, I hated school, I find it boring - my knowledge in Java comes from try-and-fail. You improve your coding style every year or so, I can myself rewrite my own code (which I already considered top-notched) after a while. You always learn something new - even if Java barely evolves. L2J is a fun way to learn programming, it's a giant sandbox where you can edit anything, and I believe it should be taken as it.   My own way of learning was as follow : Add existing customs, no matter what they are : the point is to know main classes used by L2J / customs. L2J is barely Java knowledge ; the true knowledge is to know WHAT to search in WHICH location (what I call, organization). You have to understand than EVERYTHING you think already exists, in a form on another, in the source code. A custom is only the association of the different mechanisms you found "here and there", glued together in a proper goal. Once you know main classes to edit, and the customs you added are compiling fine, the main point is to know WHAT exactly you DID. Try to understand WHY and WHERE you actually copied the code. Third point would be to MANIPULATE the customs you added in order to fit your wish. First edit little values, then logic conditions ; eventually add a new Config, or a new functionality to the custom. Fourth point would be to begin to craft your own ideas. Once again, EVERYTHING already exists, in a form or another. You want a cycled event ? You got Seven Signs main task as exemple. Npc ? Search any type of Npc and figure out what it does. Fifth point would be to understand Java - mostly containers (WHAT and WHERE to use them), variables types and main Java mechanisms (inheritance, static modifier, etc). You should also begin to cut your code into maintainable classes or methods. Java can actually run without optimization, but bigger your ideas, more optimized and well-thought it should be. It's direct saved time in the future, and you would thank yourself doing so. Main tips : ALWAYS use any type of versioning system - GIT or SVN. It allows to save your work, step by step and eventually revert back anytime you want if you terribly messed up. L2J is 80% organization knowledge, and 20% Java knowledge. Basically, if you know WHAT and WHERE to search, if you aren't dumb, it's easy to replicate and re-use things. Cherry on top is to use a already good coded pack to avoid copy-paste crap and get bad habits. Avoid any type of russian or brazilian packs, for exemple - their best ability is to leak someone's else code. Obviously you need some default sense of logic, but Java and programming in general help you to improve it.   Finally, most of your questions could be solved joining related Discord (at least for aCis, I can't speak for others) - from the moment your question was correctly asked (and you seemed to search for the answer). My community (and myself) welcomes newbies, but got some issues with noobies.   The simpliest is to try, fail and repeat until you succeed - it sounds stupid, but that's basically how life works.
    • WTS: - AQ - Baium - Zaken  - Frintezza - Vesper Fighter Focus Fire Element   pm for detalis
    • We have the best price! L2Reborn.org Signature x1 Franz NEW!! 1KK = $20 HURRY TO BUY AT THE TOP PRICE discord - adver745645
  • Topics

×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock