Help .change L2Jacis

[l2jkain]

Hello, I'm creating a code for users to change passwords for a .change command, but I'm not able to get an html for the code. I've taken a part of a npc and help me code it down

 

 

/*
 * This program is free software: you can redistribute it and/or modify it under
 * the terms of the GNU General Public License as published by the Free Software
 * Foundation, either version 3 of the License, or (at your option) any later
 * version.
 * 
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
 * details.
 * 
 * You should have received a copy of the GNU General Public License along with
 * this program. If not, see <http://www.gnu.org/licenses/>.
 */
package net.sf.l2j.gameserver.handler.voicedcommandhandlers;
 
import java.security.MessageDigest;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.util.Base64;
import java.util.StringTokenizer;
import java.util.logging.Logger;
 
import net.sf.l2j.commons.concurrent.ThreadPool;
 
import net.sf.l2j.L2DatabaseFactory;
import net.sf.l2j.gameserver.handler.IVoicedCommandHandler;
import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
 
/**
 * @author williams
 *
 */
public class ChangePassword implements IVoicedCommandHandler
{
private static final Logger _log = Logger.getLogger(ChangePassword.class.getName());
 
private static final String[] _voicedCommands =
{
"change"
};
 
@Override
public boolean useVoicedCommand(String command, L2PcInstance activeChar, String target)
{
if(command.equalsIgnoreCase("change") && target != null)
{
StringTokenizer st = new StringTokenizer(target);
st.nextToken();
String curPass = null;
String newPass = null;
String repPass = null;
try
{
if (st.hasMoreTokens())
{
curPass = st.nextToken();
newPass = st.nextToken();
repPass = st.nextToken();
}
else
{
activeChar.sendMessage("Please fill in all the blanks before requesting for a password change.");
return false;
}
changePassword(curPass, newPass, repPass, activeChar);
}
catch (StringIndexOutOfBoundsException e)
{
e.printStackTrace();
}
}
return false;
}
 
@SuppressWarnings("null")
public static boolean changePassword(String currPass, String newPass, String repeatNewPass, L2PcInstance activeChar)
{
if (newPass.length() < 3)
{
activeChar.sendMessage("The new password is too short!");
return false;
}
if (newPass.length() > 16)
{
activeChar.sendMessage("The new password is too long!");
return false;
}
if (!newPass.equals(repeatNewPass))
{
activeChar.sendMessage("Repeated password doesn't match the new password.");
return false;
}
 
Connection con = null;
String password = null;
try
{
MessageDigest md = MessageDigest.getInstance("SHA");
byte[] raw = currPass.getBytes("UTF-8");
raw = md.digest(raw);
String currPassEncoded = Base64.getEncoder().encodeToString(raw);
 
con = L2DatabaseFactory.getInstance().getConnection();
PreparedStatement statement = con.prepareStatement("SELECT password FROM accounts WHERE login=?");
statement.setString(1, activeChar.getAccountName());
ResultSet rset = statement.executeQuery();
while (rset.next())
{
password = rset.getString("password");
}
rset.close();
statement.close();
byte[] password2 = null;
if (currPassEncoded.equals(password))
{
password2 = newPass.getBytes("UTF-8");
password2 = md.digest(password2);
 
PreparedStatement statement2 = con.prepareStatement("UPDATE accounts SET password=? WHERE login=?");
statement2.setString(1, Base64.getEncoder().encodeToString(password2));
statement2.setString(2, activeChar.getAccountName());
statement2.executeUpdate();
statement2.close();
 
activeChar.sendMessage("Your password has been changed successfully! For security reasons, You will be disconnected in 3 Seconds. Please login again!");
try
{
ThreadPool.schedule(() -> activeChar.logout(false), 3000);
}
catch (Exception e)
{
{
e.printStackTrace();
}
}
 
activeChar.broadcastUserInfo();
activeChar.decayMe();
activeChar.spawnMe();
}
else
{
activeChar.sendMessage("The current password you've inserted is incorrect! Please try again!");
 
return password2 != null;
}
}
catch (Exception e)
{
_log.warning("could not update the password of account: " + activeChar.getAccountName());
e.printStackTrace();
}
finally
{
if (con != null)
try
{
con.close();
con = null;
}
catch (final Throwable e){}
}
return true;
}
 
@Override
public String[] getVoicedCommandList()
{
return _voicedCommands;
} 
}

[Reborn12]

  On 1/22/2017 at 1:03 PM, l2jkain said:

Hello, I'm creating a code for users to change passwords for a .change command, but I'm not able to get an html for the code. I've taken a part of a npc and help me code it down

 

 

/*
 * This program is free software: you can redistribute it and/or modify it under
 * the terms of the GNU General Public License as published by the Free Software
 * Foundation, either version 3 of the License, or (at your option) any later
 * version.
 * 
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
 * details.
 * 
 * You should have received a copy of the GNU General Public License along with
 * this program. If not, see <http://www.gnu.org/licenses/>.
 */
package net.sf.l2j.gameserver.handler.voicedcommandhandlers;
 
import java.security.MessageDigest;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.util.Base64;
import java.util.StringTokenizer;
import java.util.logging.Logger;
 
import net.sf.l2j.commons.concurrent.ThreadPool;
 
import net.sf.l2j.L2DatabaseFactory;
import net.sf.l2j.gameserver.handler.IVoicedCommandHandler;
import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
 
/**
 * @author williams
 *
 */
public class ChangePassword implements IVoicedCommandHandler
{
private static final Logger _log = Logger.getLogger(ChangePassword.class.getName());
 
private static final String[] _voicedCommands =
{
"change"
};
 
@Override
public boolean useVoicedCommand(String command, L2PcInstance activeChar, String target)
{
if(command.equalsIgnoreCase("change") && target != null)
{
StringTokenizer st = new StringTokenizer(target);
st.nextToken();
String curPass = null;
String newPass = null;
String repPass = null;
try
{
if (st.hasMoreTokens())
{
curPass = st.nextToken();
newPass = st.nextToken();
repPass = st.nextToken();
}
else
{
activeChar.sendMessage("Please fill in all the blanks before requesting for a password change.");
return false;
}
changePassword(curPass, newPass, repPass, activeChar);
}
catch (StringIndexOutOfBoundsException e)
{
e.printStackTrace();
}
}
return false;
}
 
@SuppressWarnings("null")
public static boolean changePassword(String currPass, String newPass, String repeatNewPass, L2PcInstance activeChar)
{
if (newPass.length() < 3)
{
activeChar.sendMessage("The new password is too short!");
return false;
}
if (newPass.length() > 16)
{
activeChar.sendMessage("The new password is too long!");
return false;
}
if (!newPass.equals(repeatNewPass))
{
activeChar.sendMessage("Repeated password doesn't match the new password.");
return false;
}
 
Connection con = null;
String password = null;
try
{
MessageDigest md = MessageDigest.getInstance("SHA");
byte[] raw = currPass.getBytes("UTF-8");
raw = md.digest(raw);
String currPassEncoded = Base64.getEncoder().encodeToString(raw);
 
con = L2DatabaseFactory.getInstance().getConnection();
PreparedStatement statement = con.prepareStatement("SELECT password FROM accounts WHERE login=?");
statement.setString(1, activeChar.getAccountName());
ResultSet rset = statement.executeQuery();
while (rset.next())
{
password = rset.getString("password");
}
rset.close();
statement.close();
byte[] password2 = null;
if (currPassEncoded.equals(password))
{
password2 = newPass.getBytes("UTF-8");
password2 = md.digest(password2);
 
PreparedStatement statement2 = con.prepareStatement("UPDATE accounts SET password=? WHERE login=?");
statement2.setString(1, Base64.getEncoder().encodeToString(password2));
statement2.setString(2, activeChar.getAccountName());
statement2.executeUpdate();
statement2.close();
 
activeChar.sendMessage("Your password has been changed successfully! For security reasons, You will be disconnected in 3 Seconds. Please login again!");
try
{
ThreadPool.schedule(() -> activeChar.logout(false), 3000);
}
catch (Exception e)
{
{
e.printStackTrace();
}
}
 
activeChar.broadcastUserInfo();
activeChar.decayMe();
activeChar.spawnMe();
}
else
{
activeChar.sendMessage("The current password you've inserted is incorrect! Please try again!");
 
return password2 != null;
}
}
catch (Exception e)
{
_log.warning("could not update the password of account: " + activeChar.getAccountName());
e.printStackTrace();
}
finally
{
if (con != null)
try
{
con.close();
con = null;
}
catch (final Throwable e){}
}
return true;
}
 
@Override
public String[] getVoicedCommandList()
{
return _voicedCommands;
} 
}
 

Because there no html in code you have to write it in chat..

[An4rchy]

command.equalsIgnoreCase("change")

This should be:

command.startsWith("change")

This:

StringTokenizer st = new StringTokenizer(target);

Should be:

StringTokenizer st = new StringTokenizer(command);

Make sure you register the voiced command in VoicedCommandHandler. The command works like: .change currentpass newpass newpass

 

However, the checks are not correct and if someone presses for example .change currentpass newpass (he doesn't repeat the new pass) you are going to get an error. (if (st.hasMoreTokens() will return true even if it has 1 more token, when you need 3 more tokens. Try st.countTokens().)