Jump to content
  • 0

Idk How...help Me On That Please


Question

Posted (edited)

  1. I want to put if Human , Elf , Dwarf female setGood(true)  and if Orc , delf, male dwarf setEvil(true) i made the code but doesnt work correctly , thinking to delete setevil and change the setGood retail code here:http://pastebin.com/0wdWBjT5
  2.  generally i deleted the setevil and changed the setgood to setdestiny i want just to press the button and check if race suits then go to the faction.. Goods : human , elf , female dwarf 

    evil : orc, d.elf , male dwarf

  3. package net.sf.l2j;
    	
    	
    	 
    	
    	
    	import java.sql.Connection;
    	
    	
    	import java.sql.PreparedStatement;
    	
    	
    	import java.sql.ResultSet;
    	
    	
    	import java.util.StringTokenizer;
    	
    	
    	import java.util.logging.Logger;
    	
    	
    	 
    	
    	
    	import net.sf.l2j.commons.random.Rnd;
    	
    	
    	import net.sf.l2j.gameserver.ai.CtrlIntention;
    	
    	
    	import net.sf.l2j.gameserver.model.L2World;
    	
    	
    	import net.sf.l2j.gameserver.model.actor.instance.L2NpcInstance;
    	
    	
    	import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
    	
    	
    	import net.sf.l2j.gameserver.model.actor.template.NpcTemplate;
    	
    	
    	import net.sf.l2j.gameserver.network.serverpackets.ActionFailed;
    	
    	
    	import net.sf.l2j.gameserver.network.serverpackets.MyTargetSelected;
    	
    	
    	import net.sf.l2j.gameserver.network.serverpackets.NpcHtmlMessage;
    	
    	
    	import net.sf.l2j.gameserver.network.serverpackets.SocialAction;
    	
    	
    	import net.sf.l2j.gameserver.network.serverpackets.ValidateLocation;
    	
    	
    	 
    	
    	
    	 
    	
    	
    	 
    	
    	
    	public class L2FactionInstance extends L2NpcInstance
    	
    	
    	{
    	
    	
    	 
    	
    	
    	    public L2FactionInstance(int objectId, NpcTemplate template)
    	
    	
    	    {
    	
    	
    	        super(objectId, template);
    	
    	
    	    }
    	
    	
    	 
    	
    	
    	    private final static Logger _log = Logger.getLogger(L2FactionInstance.class.getName());
    	
    	
    	 
    	
    	
    	    @Override
    	
    	
    	    public void onBypassFeedback(L2PcInstance player, String command)
    	
    	
    	    {
    	
    	
    	        player.sendPacket(ActionFailed.STATIC_PACKET);
    	
    	
    	        StringTokenizer st = new StringTokenizer(command, " ");
    	
    	
    	        String actualCommand = st.nextToken();
    	
    	
    	        @SuppressWarnings("unused")
    	
    	
    	        String val = "";
    	
    	
    	        if (st.countTokens() >= 1)
    	
    	
    	        {
    	
    	
    	            val = st.nextToken();
    	
    	
    	    }
    	
    	
    	 
    	
    	
    	        else if (actualCommand.equalsIgnoreCase("setdestiny"))
    	
    	
    	        {
    	
    	
    	           
    	
    	
    	        setTarget(player);
    	
    	
    	       
    	
    	
    	            if (player.isGood())
    	
    	
    	            {
    	
    	
    	                player.sendMessage("You already are in " + Config.FACTION_NAME_TEAM_GOOD + " faction ");
    	
    	
    	                player.sendPacket(new ActionFailed());
    	
    	
    	            }
    	
    	
    	           if(player.getRace blabla bla 
    	
    	
    	                    {
    	
    	
    	                    player.setGood(true);
    	
    	
    	                    Connection connection = null;
    	
    	
    	                        try
    	
    	
    	                        {
    	
    	
    	                            connection = L2DatabaseFactory.getInstance().getConnection();
    	
    	
    	                            PreparedStatement statement = connection.prepareStatement("SELECT obj_Id FROM characters where char_name=?");
    	
    	
    	                            statement.setString(1, player.getName());
    	
    	
    	                            ResultSet rset = statement.executeQuery();
    	
    	
    	                            int objId = 0;
    	
    	
    	                        if (rset.next())
    	
    	
    	                            {
    	
    	
    	                                objId = rset.getInt(1);
    	
    	
    	                            }
    	
    	
    	                            rset.close();
    	
    	
    	                            statement.close();
    	
    	
    	                            if (objId == 0)
    	
    	
    	                            {
    	
    	
    	                                connection.close();
    	
    	
    	                                return;
    	
    	
    	                            }
    	
    	
    	                            statement = connection.prepareStatement("UPDATE characters SET good=1 WHERE obj_Id=?");
    	
    	
    	                        statement.setInt(1, objId);
    	
    	
    	                            statement.execute();
    	
    	
    	                            statement.close();
    	
    	
    	                            connection.close();
    	
    	
    	                        }
    	
    	
    	                        catch (Exception e)
    	
    	
    	                        {
    	
    	
    	                            _log.info("could not set good status of char:");
    	
    	
    	                        }
    	
    	
    	                        finally
    	
    	
    	                        {
    	
    	
    	                            try
    	
    	
    	                            {
    	
    	
    	                                connection.close();
    	
    	
    	                            }
    	
    	
    	                            catch (Exception e)
    	
    	
    	                            {
    	
    	
    	                            }
    	
    	
    	                        }
    	
    	
    	                   
    	
    	
    	                        if (player.isGood())
    	
    	
    	                        {
    	
    	
    	                            player.broadcastUserInfo();
    	
    	
    	                            player.sendMessage("You Are fighiting Now for" + Config.FACTION_NAME_TEAM_GOOD + " Faction ");
    	
    	
    	                            player.getAppearance().setNameColor(Config.FACTION_COLOR_NAME_GOOD);
    	
    	
    	                            player.teleToLocation(Config.GOODX, Config.GOODY, Config.GOODZ);
    	
    	
    	                            player.setTitle(Config.FACTION_NAME_TEAM_GOOD);
    	
    	
    	                        }
    	
    	
    	                    }
    	
    	
    	                }
    	
    	
    	        }
    	
    	
    	        }
    	
    	
    	           
    	
    	
    	                    else if(player.getRace() == Race.Orc() bla bla bla
    	
    	
    	                    {
    	
    	
    	                        player.setEvil(true);
    	
    	
    	                        Connection connection = null;
    	
    	
    	                        try
    	
    	
    	                        {
    	
    	
    	                            connection = L2DatabaseFactory.getInstance().getConnection();
    	
    	
    	                            PreparedStatement statement = connection.prepareStatement("SELECT obj_Id FROM characters where char_name=?");
    	
    	
    	                            statement.setString(1, player.getName());
    	
    	
    	                            ResultSet rset = statement.executeQuery();
    	
    	
    	                            int objId = 0;
    	
    	
    	                            if (rset.next())
    	
    	
    	                        {
    	
    	
    	                                objId = rset.getInt(1);
    	
    	
    	                        }
    	
    	
    	                            rset.close();
    	
    	
    	                            statement.close();
    	
    	
    	                            if (objId == 0)
    	
    	
    	                            {
    	
    	
    	                                connection.close();
    	
    	
    	                                return;
    	
    	
    	                            }
    	
    	
    	                            statement = connection.prepareStatement("UPDATE characters SET evil=1 WHERE obj_Id=?");
    	
    	
    	                            statement.setInt(1, objId);
    	
    	
    	                            statement.execute();
    	
    	
    	                            statement.close();
    	
    	
    	                            connection.close();
    	
    	
    	                        }
    	
    	
    	                        catch (Exception e)
    	
    	
    	                        {
    	
    	
    	                            _log.info("could not set evil status of char:");
    	
    	
    	                        }
    	
    	
    	                        finally
    	
    	
    	                        {
    	
    	
    	                            try
    	
    	
    	                            {
    	
    	
    	                                connection.close();
    	
    	
    	                            }
    	
    	
    	                            catch (Exception e)
    	
    	
    	                            {
    	
    	
    	                            }
    	
    	
    	                        }
    	
    	
    	                   
    	
    	
    	                        if (player.isEvil())
    	
    	
    	                        {
    	
    	
    	                            player.broadcastUserInfo();
    	
    	
    	                            player.sendMessage("You Are fighiting Now for " + Config.FACTION_NAME_TEAM_EVIL + " Faction ");
    	
    	
    	                            player.getAppearance().setNameColor(Config.FACTION_COLOR_NAME_EVIL);
    	
    	
    	                            player.teleToLocation(Config.EVILX, Config.EVILY, Config.EVILZ);
    	
    	
    	                            player.setTitle(Config.FACTION_NAME_TEAM_EVIL);
    	
    	
    	                        }
    	
    	
    	                    }
    	
    	
    	                }
    	
    	
    	            
    	
    	
    	        else if (actualCommand.equalsIgnoreCase("setnobless"))
    	
    	
    	        {
    	
    	
    	       
    	
    	
    	            L2PcInstance activeChar = player;
    	
    	
    	            if (activeChar.isNoble())
    	
    	
    	                activeChar.sendMessage("You Are Already A Noblesse!.");
    	
    	
    	            else
    	
    	
    	            {
    	
    	
    	                activeChar.setNoble(true, true);
    	
    	
    	                activeChar.sendMessage("You Are Now a Noble,You Are Granted With Noblesse Status , And Noblesse Skills.");
    	
    	
    	                activeChar.broadcastUserInfo();
    	
    	
    	                activeChar.getInventory().addItem("Tiara", 7694, 1, activeChar, null);
    	
    	
    	            }
    	
    	
    	        }
    	
    	
    	        else
    	
    	
    	        {
    	
    	
    	            super.onBypassFeedback(player, command);
    	
    	
    	        }
    	
    	
    	    }
    	
    	
    	   
    	
    	
    	    @Override
    	
    	
    	    public String getHtmlPath(int npcId, int val)
    	
    	
    	    {
    	
    	
    	        return "data/html/mods/faction/main.htm";
    	
    	
    	    }
    	
    	
    	 
    	
    	
    	}
Edited by Kelrzher

Recommended Posts

  • 0
Posted (edited)

 

trolling ... not just kidding lul

 

 

if(....){
...
return true;
}
return false;
 
ftw style

 

It's style actually, because the code is still clear and it doesn't cause any performance issues... I've never written "return smth == smthelse;" in my practice, so, I wouldn't start now. :lol:

Edited by Tessa
  • 0
Posted (edited)

It's style actually, because the code is still clear and it doesn't cause any performance issues... I've never written "return smth == smthelse;" in my practice, so, I wouldn't start now. :lol:

well,i m neither familiar with it,even if i use(d) it in other languages from time to time like python

 

anyway,gonna grab popcorn again ... fighting for the best l2j dev "throne".damn

Edited by bravetobe
  • 0
Posted (edited)

well,i m neither familiar with it,even if i use(d) it in other languages from time to time like python

 

anyway,gonna grab popcorn again ... fighting for the best l2j dev "throne".damn

Wait till the devs wake up, I'm not pretending to be a dev at all... :lol:

Edited by Tessa
  • 0
Posted

Well 3 pages of nonsense :D Tryskell gave you the best solution on the first reply of this topic :D No idea why you completely ignored him and kept posting more trash code.

  • 0
Posted

It's style actually, because the code is still clear and it doesn't cause any performance issues... I've never written "return smth == smthelse;" in my practice, so, I wouldn't start now. :lol:

It does.

  • 0
Posted

Inline comparsion is faster than if statement?

 

inline instructions exist in asm level and there are ways to do it in C++, in Java theoretically it is possible aswell but not in all cases

  • 0
Posted

inline instructions exist in asm level and there are ways to do it in C++, in Java theoretically it is possible aswell but not in all cases

I'm editing my answer right now, I just benchmarket it, and I saw the difference. :lol:

  • 0
Posted

neither do i , so to be honest i wait someone to give me de solution

What solution? Just implement the code from the first page. :lol:

Guest
This topic is now closed to further replies.



  • Posts

    • WTB Character on Lineage 2 Reborn - Origins 1x Server   Looking for lvl 80+ character (3 subclasses )+ clean email  Classes im mostly intrested about are: Mystic Muse Adventurer Ghost Hunter Soul Hound Grand Khavatari Titan   Im looking forward for your PM's here on Max website or leave a comment down below with your discord or any contact in case you have any of those classes. If you have any other class that are not mentioned drop a PM aswell might be intrested in other classes i haven't mentioned aswell if its high lvl and has good potential.
    • Thanks for showing us this post, it is clearly seen that some user names pulling hate in that post, have the same name here in maxcheaters.... it is very interesting information, as it shows that the same users here at maxcheaters are scouring other forum posts to spew their hate. this does not affect much, as the customers understand, that there are only 4 or 5 people globally trying to harm our project.... the rest are all happy, luckily 🙂   Greetings. PD: You still don't understand that this is going to spread to many servers and it's something you can't avoid... you understand that, don't you? By the way, if you used an extender like ours, maybe you wouldn't have to reopen your server hundreds of times over the years.
    • 🚨 L2MID RETURNS IN 2025! 🚨 After 3 long years… The wait is FINALLY over! One of the most legendary Lineage 2 server is coming back stronger, sharper, and more competitive than ever before. 💎 All users who vote will receive exclusive gifts in the future! 👉 Cast your vote now!  https://l2mid.com/vote/ Let’s make this the most epic comeback ever! Stay tuned for more updates and invite your friends L2Mid is BACK!
    • Yeah I also “heard” you are pretty popular over there 🙂 especially in Ukraine/RU   https://mmo-dev.info/threads/⭐-l2off-h5-gx-ext⭐.33144/
    • I do not disclose information about my clients 🙂 you will see them online for example, in brazil, argentina and chile. Have great sales.   Best regards.
  • Topics

×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock