Help No Damage When Player Has No Mp

[GameBlonD]

hi ,

 

 

The problem is when a player spam Deadly blow(for example)  and get the message Not Enough MP and together spam Attack the result is NO damage no message nothing the only message is : Not Enough MP

Edited September 5, 2016 by GameBlonD

[GameBlonD]

Ok it doesn't work in latest revision of l2j also i found the issue causing this you can lock it , thanks.

[AccessDenied]

hi ,

 

 

The problem is when a player spam Deadly blow(for example)  and get the message Not Enough MP and together spam Attack the result is NO damage no message nothing the only message is : Not Enough MP

you mean he cast the skill but no dmg even when mp is 0 ?

[GameBlonD]

He tries to cast the Skill but get message Not Enough Mp(because he doesnt have MP) so he spam The skill deadly blow and also tries to hit with simple hits the result= simple hits doesn't even have system messages nothing  only consumption of ss.

[AccessDenied]

He tries to cast the Skill but get message Not Enough Mp(because he doesnt have MP) so he spam The skill deadly blow and also tries to hit with simple hits the result= simple hits doesn't even have system messages nothing  only consumption of ss.

What pack are you using?  

[bravetobe]

Mom's spaggheti with sauce + loop

It supposed to check the mana if someone use skill,and not attack.

 

Post code tho

(Just a huge guess from somoene who doesnt know l2j)

 

EDIT RIP guess. FailFish

Edited September 5, 2016 by bravetobe

[AccessDenied]

Mom's spaggheti with sauce + loop

It supposed to check the mana if someone use skill,and not attack.

 

(Just a guess)

Depends if it happen with all skills then is doCast problem else is more specific 

[GameBlonD]

                        if (getCurrentMp() < mpConsume)
                        {
                            // If L2PcInstance doesn't have enough MP, stop the attack
                            ThreadPoolManager.getInstance().scheduleAi(new NotifyAITask(CtrlEvent.EVT_READY_TO_ACT), 1000);
                            sendPacket(new SystemMessage(SystemMessageId.NOT_ENOUGH_MP));
                            sendPacket(ActionFailed.STATIC_PACKET);
                            return;
                        }

        // Check if the caster has enough MP
        if (getCurrentMp() < getStat().getMpConsume(skill) + getStat().getMpInitialConsume(skill))
        {
            // Send a System Message to the caster
            sendPacket(new SystemMessage(SystemMessageId.NOT_ENOUGH_MP));
            
            // Send a Server->Client packet ActionFailed to the L2PcInstance
            sendPacket(ActionFailed.STATIC_PACKET);
            return false;
        }

This  two are the only one that displays Not Enough mp what should i change?

[bravetobe]

How about editting the one of them in the first place ? :D (A unique system message,so u can find out).

I think its the second .It still checks the skill.

 

 getCurrentMp() < getStat().getMpConsume(skill) + getStat().getMpInitialConsume(skill)

Hm...

 

P.S i have no idea about l2j. Kappa

Edited September 5, 2016 by bravetobe

[GameBlonD]

Maybe this happen because client spam failed packets?

[bravetobe]

Does this happen until the skill (Deadly blow) is able to be casted? I mean until the consumed mp from the skill <= current mp?

What about adding a "&& not autoattack" in the second one.Can u confirm that it doesnt keep checking the last skill casted even if u make autos?

Since i dont know l2j,i m not sure what this getMpInitialConsume(skill) does

 

Maybe someone can help u out but throwing ideas in the table might give u an idea :)

Edited September 5, 2016 by bravetobe

[AccessDenied]

                        if (getCurrentMp() < mpConsume)

                        {

                            // If L2PcInstance doesn't have enough MP, stop the attack

                            ThreadPoolManager.getInstance().scheduleAi(new NotifyAITask(CtrlEvent.EVT_READY_TO_ACT), 1000);

                            sendPacket(new SystemMessage(SystemMessageId.NOT_ENOUGH_MP));

                            sendPacket(ActionFailed.STATIC_PACKET);

                            return;

                        }

 

        // Check if the caster has enough MP

        if (getCurrentMp() < getStat().getMpConsume(skill) + getStat().getMpInitialConsume(skill))

        {

            // Send a System Message to the caster

            sendPacket(new SystemMessage(SystemMessageId.NOT_ENOUGH_MP));

            

            // Send a Server->Client packet ActionFailed to the L2PcInstance

            sendPacket(ActionFailed.STATIC_PACKET);

            return false;

        }

 

This  two are the only one that displays Not Enough mp what should i change?

the variable mpConsume from what method takes value? 

[GameBlonD]

Yes if players has mp and spam skills = auto attack works fine the problem is when he doesn't have mp

[GameBlonD]

                        int saMpConsume = (int) getStat().calcStat(Stats.MP_CONSUME, 0, null, null);
                        int mpConsume = saMpConsume == 0 ? weaponItem.getMpConsume() : saMpConsume;
                        mpConsume = (int) calcStat(Stats.BOW_MP_CONSUME_RATE, mpConsume, null, null);

[bravetobe]

That comes to my mind.

11/10 eminem rating

10/10 spaggheti

 

if someone does autoattack

    if someone doesnt wear bow

        deal damage blabla

        return true

    else

        if he has enough mp for attack with bow

            deal damage

            return true

        else               // or even without it.

            return false

else

     ur shit u coded above

 

#

Edited September 5, 2016 by bravetobe

[GameBlonD]

So i checked l2j last revisions and they use the same code... i dont know if this bug happens and inside the game maybe i test it later.
So the problem is  here:
        if (getCurrentMp() < getStat().getMpConsume(skill) + getStat().getMpInitialConsume(skill) && !isAttackingNow())
I added !isAttackingNow  and now it does ->one skill - auto attack player dead but he does skill with 0 mp :P

I will try to improve it somehow if some1 has a way let me know.
 

Edited September 5, 2016 by GameBlonD