Help Territory War Save Issue

[GameBlonD]

Hello i added this code

private void storeParticipantsPoints(Map<Integer,Integer[]> points)
{
Connection con = null;
PreparedStatement statement = null;
Integer[] reward;
int count = 0;
try
{
con = L2DatabaseFactory.getInstance().getConnection();
for (int playerId : points.keySet())
{
reward = points.get(playerId);
if (reward[6] < 10 || (reward[1] + reward[2] + reward[3] + reward[4] + reward[5]) == 0)
continue;
statement = con.prepareStatement("INSERT INTO character_territorywar VALUES (?,?,?,?,?,?,?,?)");
statement.setInt(1, playerId);
statement.setInt(2, reward[0]);
statement.setInt(3, reward[1]);
statement.setInt(4, reward[2]);
statement.setInt(5, reward[3]);
statement.setInt(6, reward[4]);
statement.setInt(7, reward[5]);
statement.setInt(8, reward[6]);
statement.execute();
ResourceUtil.closeStatement(statement);
count++;
}
}
catch (Exception e)
{
}
finally
{
ResourceUtil.closeStatement(statement);
ResourceUtil.closeConnection(con);
}
}

private void restoreParticipantsPoints()
{
Connection con = null;
PreparedStatement statement = null;
ResultSet rset = null;
Integer[] data = new Integer[7];
try
{
con = L2DatabaseFactory.getInstance().getConnection();
statement = con.prepareStatement("SELECT * FROM character_territorywar");
rset = statement.executeQuery();
while (rset.next())
{
data[0] = rset.getInt("siegeSide");
data[1] = rset.getInt("points1");
data[2] = rset.getInt("points2");
data[3] = rset.getInt("points3");
data[4] = rset.getInt("points4");
data[5] = rset.getInt("points5");
data[6] = rset.getInt("onlineTime");
_participantPoints.put(rset.getInt("charId"), data);
}
}
catch (Exception e)
{
}
finally
{
ResourceUtil.closeResultSet(rset);
ResourceUtil.closeStatement(statement);
ResourceUtil.closeConnection(con);
}
}

private void truncateParticipantsPoints()
{
Connection con = null;
PreparedStatement statement = null;
try
{
con = L2DatabaseFactory.getInstance().getConnection();
statement = con.prepareStatement("TRUNCATE TABLE character_territorywar");
statement.execute();
}
catch (Exception e)
{
}
finally
{
ResourceUtil.closeStatement(statement);
ResourceUtil.closeConnection(con);
}
}

private void removeParticipantPoints(int playerId)
{
Connection con = null;
PreparedStatement statement = null;
try
{
con = L2DatabaseFactory.getInstance().getConnection();
statement = con.prepareStatement("DELETE FROM character_territorywar WHERE charId = ?");
statement.setInt(1, playerId);
statement.execute();
}
catch (Exception e)
{
}
finally
{
ResourceUtil.closeStatement(statement);
ResourceUtil.closeConnection(con);
}
}

All works fine and data saved into database but when i speak to Territory manager Npc says That i work in Dion but character was registered in Goddard

For some reason the code can't read siegeSide from database and always choose the Min Territory ID

Also if i talk to Territory manager before server restart it works fine the issue is after server restart that trying to read the data from the database.

Any ideas to where to look in order to fix it?

Thanks.

[Tryskell]

getCastle() of L2Npc normally.

 

- Use try-with-ressources instead of finally/RessourceUtil

- Use Map.Entry instead of

for (int playerId : points.keySet())
{
reward = points.get(playerId);

which delivers a poor performance.

Edited May 4, 2016 by Tryskell

[GameBlonD]

Tryskell

Thanks for your answer , about improvements etc but i am looking for a quick fix to existing code :

 

I can't understand why Territory Manager can't read siegeSide -

Example on what happening:

DB table:

CREATE TABLE `character_territorywar` (
  `charId` int(10) unsigned NOT NULL DEFAULT '0',
  `siegeSide` smallint(3) NOT NULL DEFAULT '0',
  `points1` smallint(4) NOT NULL DEFAULT '0',
  `points2` smallint(4) NOT NULL DEFAULT '0',
  `points3` smallint(4) NOT NULL DEFAULT '0',
  `points4` smallint(4) NOT NULL DEFAULT '0',
  `points5` smallint(4) NOT NULL DEFAULT '0',
  `onlineTime` smallint(4) NOT NULL DEFAULT '0',
  PRIMARY KEY (`charId`),
  CONSTRAINT `character_territorywar_ibfk_1` FOREIGN KEY (`charId`) REFERENCES `characters` (`charId`) ON DELETE CASCADE ON UPDATE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

-- ----------------------------
-- Records
-- ----------------------------
INSERT INTO `character_territorywar` VALUES ('268482384', '87', '7', '1', '0', '0', '0', '18');
INSERT INTO `character_territorywar` VALUES ('269823770', '85', '5', '1', '0', '0', '0', '18');
INSERT INTO `character_territorywar` VALUES ('270590661', '82', '17', '1', '0', '0', '0', '18');

So if i speak to npc with charid: 268482384 instead of giving me reward of 87 its say to speak to Dion (82)

for some reason it always choose the MIN Territory ID.

    private void restoreParticipantsPoints()
    {
        Connection con = null;
        PreparedStatement statement = null;
        ResultSet rset = null;
        Integer[] data = new Integer[7];
        try
        {
            con = L2DatabaseFactory.getInstance().getConnection();
            statement = con.prepareStatement("SELECT * FROM character_territorywar");
            rset = statement.executeQuery();
            while (rset.next())
            {
                data[0] = rset.getInt("siegeSide");
                data[1] = rset.getInt("points1");
                data[2] = rset.getInt("points2");
                data[3] = rset.getInt("points3");
                data[4] = rset.getInt("points4");
                data[5] = rset.getInt("points5");
                data[6] = rset.getInt("onlineTime");
                _participantPoints.put(rset.getInt("charId"), data);
            }
        }
        catch (Exception e)
        {
        }
        finally
        {
            ResourceUtil.closeResultSet(rset);
            ResourceUtil.closeStatement(statement);
            ResourceUtil.closeConnection(con);
        }
    }

Edited May 5, 2016 by GameBlonD

[SweeTs]

Shouldn't you use query like

"SELECT * FROM character_territorywar WHERE obj_Id = ?"

Edited May 5, 2016 by SweeTs

[GameBlonD]

 

Shouldn't you use query like

"SELECT * FROM character_territorywar WHERE obj_Id = ?"

didnt work :P

[Tryskell]

I told you, you should verify what getCastle() - or whatever is used for territory - is before going further.

 

I know than getCastle() is computed based on territory he is actually putted.

 

Maybe in your case it's the reverse, the npc is hold on territory based on whatever data (castle id, zone id, bypass, or whatever else).

[GameBlonD]

            else if (actualCommand.equalsIgnoreCase("CalcRewards"))
            {
                int territoryId = Integer.parseInt(st.nextToken());
                int[] reward = TerritoryWarManager.getInstance().calcReward(activeChar);
                NpcHtmlMessage html = new NpcHtmlMessage(mercman.getObjectId());
                if (TerritoryWarManager.getInstance().isTWInProgress() || reward[0] == 0)
                    html.setFile(activeChar.getHtmlPrefix(), "data/html/mercmanager/reward-0a.htm");
                else if (reward[0] != territoryId)
                {
                    html.setFile(activeChar.getHtmlPrefix(), "data/html/mercmanager/reward-0b.htm");
                    html.replace("%castle%", CastleManager.getInstance().getCastleById(reward[0] - 80).getName());
                }
                else if (reward[1] == 0)
                    html.setFile(activeChar.getHtmlPrefix(), "data/html/mercmanager/reward-0a.htm");
                else
                {
                    html.setFile(activeChar.getHtmlPrefix(), "data/html/mercmanager/reward-1.htm");
                    html.replace("%castle%", CastleManager.getInstance().getCastleById(reward[0] - 80).getName());
                    html.replace("%badge%", String.valueOf(reward[1]));
                    html.replace("%adena%", String.valueOf(reward[1] * 5000));
                }
                html.replace("%territoryId%", String.valueOf(territoryId));
                html.replace("%objectId%", String.valueOf(mercman.getObjectId()));
                activeChar.sendPacket(html);
                activeChar.sendPacket(ActionFailed.STATIC_PACKET);
            }
            else if (actualCommand.equalsIgnoreCase("ReceiveRewards"))
            {
                int territoryId = Integer.parseInt(st.nextToken());
                int badgeId = 57;
                if (TerritoryWarManager.getInstance().TERRITORY_ITEM_IDS.containsKey(territoryId))
                    badgeId = TerritoryWarManager.getInstance().TERRITORY_ITEM_IDS.get(territoryId);
                int[] reward = TerritoryWarManager.getInstance().calcReward(activeChar);
                NpcHtmlMessage html = new NpcHtmlMessage(mercman.getObjectId());
                if (TerritoryWarManager.getInstance().isTWInProgress() || reward[0] == 0)
                    html.setFile(activeChar.getHtmlPrefix(), "data/html/mercmanager/reward-0a.htm");
                else if (reward[0] != territoryId)
                {
                    html.setFile(activeChar.getHtmlPrefix(), "data/html/mercmanager/reward-0b.htm");
                    html.replace("%castle%", CastleManager.getInstance().getCastleById(reward[0] - 80).getName());
                }
                else if (reward[1] == 0)
                    html.setFile(activeChar.getHtmlPrefix(), "data/html/mercmanager/reward-0a.htm");
                else
                {
                    html.setFile(activeChar.getHtmlPrefix(), "data/html/mercmanager/reward-2.htm");
                    activeChar.addItem("QUEST", badgeId, reward[1], mercman, true);
                    activeChar.addAdena("QUEST", reward[1] * 5000, mercman, true);
                    TerritoryWarManager.getInstance().resetReward(activeChar);
                }
                
                html.replace("%objectId%", String.valueOf(mercman.getObjectId()));
                activeChar.sendPacket(html);
                activeChar.sendPacket(ActionFailed.STATIC_PACKET);
            }
            return true;
        }
        catch (Exception e)
        {
            _log.info("Exception in " + getClass().getSimpleName());
        }
        return false;
    }

Territory manager in game pop up this : reward-0b.htm (can't read the correct siegeSide)

 

Maybe this is wrong?

                int territoryId = Integer.parseInt(st.nextToken());

 

and should be something like this?

        int territoryId = Integer.parseInt(command.substring(_command.length() + 1).trim());