Jump to content
  • 0

Hpconsume Skills Doesn't Consume Hp (Freya)


Question

Posted

hello there. Like title saying all hpconsume skills dont consume any hp. For example sacrifice will heal without consuming any HP.
 
The skill in data/stats/skills XML file is just fine (checked more than 100 times)...
 
About L2Character.java hp consume, it is fine too.

// Consume HP if necessary and Send the Server->Client packet StatusUpdate with current HP and MP to all other L2PcInstance to inform
			if (skill.getHpConsume() > 0)
			{
				double consumeHp;
				
				consumeHp = calcStat(Stats.HP_CONSUME_RATE, skill.getHpConsume(), null, null);
				if ((consumeHp + 1) >= getCurrentHp())
				{
					consumeHp = getCurrentHp() - 1.0;
				}
				
				getStatus().reduceHp(consumeHp, this, true);
				
				su.addAttribute(StatusUpdate.CUR_HP, (int) getCurrentHp());
				isSendStatus = true;
			}

I checked every singe line to find any problems but nothing...everything seems normal

 

Im working on Freya client l2jserver. 
 

7 answers to this question

Recommended Posts

  • 0
Posted

If you don't know how to use Eclipse debug mode, put a log into the if block, if it reaches it, it's a problem of calculation, if it doesn't reach it, you are blocked way before it reaches the method.

  • 0
Posted

I already did and works fine...All IF methods working properly...I used to have an old freya pack that those skills were working...I transfered all methods from there and still nothing

  • 0
Posted
public void reduceHp(double value, L2Character attacker, boolean isHpConsumption)
	{
		_log.warning("it goes here");
		reduceHp(value, attacker, true, false, isHpConsumption);
	}
	
	public void reduceHp(double value, L2Character attacker, boolean awake, boolean isDOT, boolean isHPConsumption)
	{
		_log.warning("wtf");
		if (getActiveChar().isDead())
		{
			return;
		}
		
		// invul handling
		if (getActiveChar().isInvul())
		{
			// other chars can't damage
			if (attacker != getActiveChar())
			{
				return;
			}
			
			// only DOT and HP consumption allowed for damage self
			if (!isDOT && !isHPConsumption)
			{
				return;
			}
		}
		
		if (attacker != null)
		{
			final L2PcInstance attackerPlayer = attacker.getActingPlayer();
			if ((attackerPlayer != null) && attackerPlayer.isGM() && !attackerPlayer.getAccessLevel().canGiveDamage())
			{
				return;
			}
		}
		
		if (!isDOT && !isHPConsumption)
		{
			getActiveChar().stopEffectsOnDamage(awake);
			if (getActiveChar().isStunned() && (Rnd.get(10) == 0))
			{
				getActiveChar().stopStunning(true);
			}
		}
		
		if (value > 0)
		{
			setCurrentHp(Math.max(getCurrentHp() - value, 0));
		}
		
		if ((getActiveChar().getCurrentHp() < 0.5) && getActiveChar().isMortal()) // Die
		{
			getActiveChar().abortAttack();
			getActiveChar().abortCast();
			
			if (Config.DEBUG)
			{
				_log.fine("char is dead.");
			}
			
			getActiveChar().doDie(attacker);
		}
	}

L2Character goes to the first method which it seems to working fine. After there, ti doesnt even go to the seconds reduceHp method...So _log.warning("wtf") doesnt appear on my console...It makes totally no sense

  • 0
Posted (edited)

Where is that code ? With what type of instance do you want to test it ?

 

You have to know, depending about your instance, than if a

public void reduceHp(double value, L2Character attacker, boolean awake, boolean isDOT, boolean isHPConsumption)

exists on a children, it will use it. So if you test a player, and put logs on L2Character, verify you got no overidden reduceHp on L2Playable and L2PcInstance. The only "wrong" thing about what I say is if children overidden method already uses "super.reduceHp". In that case, you're kinda screwed and I'm out of idea.

Edited by Tryskell
  • 0
Posted
public void reduceHp(double value, L2Character attacker, boolean isHpConsumption)
    {
        _log.warning("it goes here");
        reduceHp2(value, attacker, true, false, isHpConsumption);
    }
    
    public void reduceHp2(double value, L2Character attacker, boolean awake, boolean isDOT, boolean isHPConsumption)
    {
        _log.warning("wtf");
        if (getActiveChar().isDead())
        {
            return;
        }
        
        // invul handling
        if (getActiveChar().isInvul())
        {
            // other chars can't damage
            if (attacker != getActiveChar())
            {
                return;
            }
            
            // only DOT and HP consumption allowed for damage self
            if (!isDOT && !isHPConsumption)
            {
                return;
            }
        }
        
        if (attacker != null)
        {
            final L2PcInstance attackerPlayer = attacker.getActingPlayer();
            if ((attackerPlayer != null) && attackerPlayer.isGM() && !attackerPlayer.getAccessLevel().canGiveDamage())
            {
                return;
            }
        }
        
        if (!isDOT && !isHPConsumption)
        {
            getActiveChar().stopEffectsOnDamage(awake);
            if (getActiveChar().isStunned() && (Rnd.get(10) == 0))
            {
                getActiveChar().stopStunning(true);
            }
        }
        
        if (value > 0)
        {
            setCurrentHp(Math.max(getCurrentHp() - value, 0));
        }
        
        if ((getActiveChar().getCurrentHp() < 0.5) && getActiveChar().isMortal()) // Die
        {
            getActiveChar().abortAttack();
            getActiveChar().abortCast();
            
            if (Config.DEBUG)
            {
                _log.fine("char is dead.");
            }
            
            getActiveChar().doDie(attacker);
        }
    }

public void reduceHp(double value, L2Character attacker, boolean awake, boolean isDOT, boolean isHPConsumption)
    {
        _log.warning("wtf");
        if (getActiveChar().isDead())
        {
            return;
        }
        
        // invul handling
        if (getActiveChar().isInvul())
        {
            // other chars can't damage
            if (attacker != getActiveChar())
            {
                return;
            }
            
            // only DOT and HP consumption allowed for damage self
            if (!isDOT && !isHPConsumption)
            {
                return;
            }
        }
        
        if (attacker != null)
        {
            final L2PcInstance attackerPlayer = attacker.getActingPlayer();
            if ((attackerPlayer != null) && attackerPlayer.isGM() && !attackerPlayer.getAccessLevel().canGiveDamage())
            {
                return;
            }
        }
        
        if (!isDOT && !isHPConsumption)
        {
            getActiveChar().stopEffectsOnDamage(awake);
            if (getActiveChar().isStunned() && (Rnd.get(10) == 0))
            {
                getActiveChar().stopStunning(true);
            }
        }
        
        if (value > 0)
        {
            setCurrentHp(Math.max(getCurrentHp() - value, 0));
        }
        
        if ((getActiveChar().getCurrentHp() < 0.5) && getActiveChar().isMortal()) // Die
        {
            getActiveChar().abortAttack();
            getActiveChar().abortCast();
            
            if (Config.DEBUG)
            {
                _log.fine("char is dead.");
            }
            
            getActiveChar().doDie(attacker);
        }
    }

This worked for me

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Posts

    • ElmoreLab Harbor - Eternal C1 x1: ✅ https://harbor.elmorelab.com ElmoreLab Harbor - Eternal C1 x1 - is an exclusive server of the Eternal C1 chronicles from the top project ElmoreLab Harbor.   A unique server of its kind, on which everyone will have maximum pleasure, such as oldschool players who dream of nostalgia and to feel the warmest and classic C1 chronicles, as well as experienced players who are tired of thousands unbalanced servers of late chronicles. Due to the professional corrections of the balance system and the HONEST gameplay system - on this server, EVERY player will feel like in their own, warm and cozy Harbor C1. Let's return to the origins of L2 - back to 2004 in C1! ❤️   ⭐ Server characteristics:   STRICTLY 1 window, NO BOXES Bans for RMT and bots/cheats No donations with benefits Unique and high-quality PTS-build from Master Toma Professional corrections and full class-balance Reworked economy and closed all abuses Improved animations and all aspects of the game Exclusive HD-client with high-quality textures Experienced administration and management Fixed all bugs, geodata, exploits and holes Maximum sociality due to the 1-box system Discovering, exploring and researching Big online International server Nostalgia and oldschool-feelings   Rates: x1 Server start: 14.02.2025   The server is at the final stages of development and preparation for release. Information on the server will be updated, soon the patchnotes and changes/edits will be posted. Don't miss the legendary and epic experience on the best server in the last 20 years! ❤️ Join our C1-forum with a lot of information about server and active discussions.   ⭐ Website: https://harbor.elmorelab.com   ✅ Forum: https://forum-harbor.elmorelab.com   💥 Telegram: https://t.me/l2harbor https://t.me/l2harbor_chat   ⚡ Discord: https://discord.gg/harborelmorelab
    • yeah ok, if you say what is fuctional 100% i can't say something different 😛  but if someone find hard to compile it or get vs and all that things i have here one more simple way here to put overlay in your own server or to change your window name with few money.
    • I've been using this for 2 years now with no issues from Discord. I don't use ogg.dll either. This one works with any l2.exe too; I don’t see any difference between them.
    • hmm.. ok i just see that, is different code first of all. My sources is totally different based in other way, with else libraries.  I have access to modify everything even to make the clock to stop show how many time users play in server. 1) so maybe keep some personal info more hide. 2) i dont use ogg.dll 3) i create it and give it ready + support to install it. Plus what is mine can working with what ever .exe you want not just l2 with same simple method. And i am sure if you try this source to compile it, after 3 hours discord will like shadowban your API too thats my source
  • Topics

×
×
  • Create New...