Help Nobless Status After Killing Barakiel For All Party Members

[ton3]

Hi all, I added this code to my project and even if player is lvl 1 and without sub he is getting nobless status. Could anyone help me? I want to give nobless status only for players who have active subclass and is level 75+ and send a message to let them know if they are under lvl 75 and dont have sub. Any help is welcome.

 

Edit: this code is inside l2raidbossinstance

if (player.isInParty())
				{
					if (getNpcId() == 25325) // barakielId = 25325;
											{
												
											for(L2PcInstance newNoble : player.getParty().getPartyMembers())
											{
												if (!player.isSubClassActive() || player.getLevel() >= 75 || player.isNoble())																									
												 {
													 newNoble.setNoble(true, true);
													 newNoble.sendMessage("You Are Now a Noble, You Are Granted With Noblesse Status, And Noblesse Skills.");
													 
													 
														
													 	                } 
													 					}
											}
																		
					else 
					{
						if (!player.isSubClassActive() || player.getLevel() < 75);
						player.sendMessage("You don't have subclass level 75 or you are already nobless");	
					}

Edited April 28, 2015 by ton3

[Kelrzher]

Sorry sdw and sweets, no offense but i made it , so you dont need script or it isnt a fault of the loop, your code obviously hadnt the logic as you guys said.

 

 

 

int _barakielId = 25325;
if (getNpcId() == _barakielId  && player.getParty() != null) //check for party 
{
for (final L2PcInstance member : player.getParty().getPartyMembers())
{
if (member.isSubClassActive() && member.getLevel() >= 75 && !member.isNoble()) //replaced player with the new method 
  {
   member.setNoble(true);
member.broadcastPacket(new SocialAction( player.getObjectId(), 15));
member.sendMessage("You have received nobless status by killing Barakiel!");
  }
else 
if (!member.isSubClassActive() && member.getLevel() <= 75) //the message will appear to ppl that arent subclassed and also they are low leveled, only 
   {
member.sendMessage("You don't meet the required criteria. Your level is too low, you aren't on an active subclass."); 
}
}
}

[Kelrzher]

Theres no sub check , you gotta make a boolean for sub check registering it on pcinstance and then add the check , also you can make a restriction at least for level 

 

if(player.getLevel>=76 

 

also i guess if (!player.isSubClassActive() it should be if(player.isSubClassActive if this works at least  

Edited April 28, 2015 by Kelrzher

[Tryskell]

It's because your for loop internal checks should aim "newNoble", not "player". You currently only check a single player, probably the one who requested the ask.

if (!player.isSubClassActive() || player.getLevel() >= 75 || player.isNoble())

-> player != newNoble

[Kelrzher]

if (getNpcId() == _barakielId && !player.isNoble())
{
for(L2PcInstance newNoble : player.getParty().getPartyMembers())
{
   if (player != newNoble || player.isSubClassActive() || player.getLevel() >= 75()) 
   {
   player.setNoble(true);
player.broadcastPacket(new SocialAction( player.getObjectId(), 15));
player.sendMessage("You have received nobless status by killing Raid Boss Barakiel!");
}     
}
}
else 
{
if (!player.isSubClassActive() || player.getLevel() < 75);
player.sendMessage("You don't have subclass level 75 or you are already nobless"); 
}

correct me if i am wrong 

Edited April 28, 2015 by Kelrzher

[ton3]

if (getNpcId() == _barakielId && !player.isNoble())
{
for(L2PcInstance newNoble : player.getParty().getPartyMembers())
{
   if (player != newNoble || player.isSubClassActive() || player.getLevel() >= 75()) 
   {
   player.setNoble(true);
player.broadcastPacket(new SocialAction( player.getObjectId(), 15));
player.sendMessage("You have received nobless status by killing Raid Boss Barakiel!");
}     
}
}
else 
{
if (!player.isSubClassActive() || player.getLevel() < 75);
player.sendMessage("You don't have subclass level 75 or you are already nobless"); 
}

correct me if i am wrong 

 

 

this one worked but didnt send any message to player who was lvl 1 =(

[Kelrzher]

so the else doesnt work ... 

[Kelrzher]

if (!player.isSubClassActive() && player.getLevel() < 75);
player.sendMessage("You don't have subclass level 75 or you are already nobless");

[SweeTs]

It's plain wrong, the WHOLE code and it's logic. Still, your for loop doesn't consider party members. You create for loop for party members and you still focus on the player, in short, your actual for loop is useless, has no use.

 

Here you go the proper code.. Change the msg

       if (getNpcId() == _barakielId)
        {
            for (L2PcInstance newNoble : player.getParty().getPartyMembers())
            {
                if ((newNoble.isSubClassActive() || player.getLevel() >= 75) && !newNoble.isNoble())
                {
                    newNoble.setNoble(true, true);
                    newNoble.broadcastPacket(new SocialAction(player.getObjectId(), 15));
                    newNoble.sendMessage("You have received nobless status by killing Raid Boss Barakiel!");
                }
                else
                    newNoble.sendMessage("What a shame. You don't meet the required criteria (subclass is not active or lvl is not greater or equal 75 or you are simply already a noble.)");
            }
        }

Edited April 28, 2015 by SweeTs

[Kelrzher]

thanks sweets  :D i am in the first year doing the steps right now :D

if (getNpcId() == _barakielId)
        {
            for (L2PcInstance newNoble : player.getParty().getPartyMembers())
            {
                if ((newNoble.isSubClassActive() || player.getLevel() >= 75) && !newNoble.isNoble())
                {
-                   newNoble.setNoble(true, true);
+                  newNoble.setNoble(true);
                    newNoble.broadcastPacket(new SocialAction(player.getObjectId(), 15));
                    newNoble.sendMessage("You have received nobless status by killing Raid Boss Barakiel!");
                }
                else
                    newNoble.sendMessage("What a shame. You don't meet the required criteria (subclass is not active or lvl is not greater or equal 75 or you are simply already a noble.)");
            }
        }

 

and a small correction

Edited April 28, 2015 by Kelrzher

[ton3]

 

It's plain wrong, the WHOLE code and it's logic. Still, your for loop doesn't consider party members. You create for loop for party members and you still focus on the player, in short, your actual for loop is useless, has no use.

 

Here you go the proper code.. Change the msg

       if (getNpcId() == _barakielId)
        {
            for (L2PcInstance newNoble : player.getParty().getPartyMembers())
            {
                if ((newNoble.isSubClassActive() || player.getLevel() >= 75) && !newNoble.isNoble())
                {
                    newNoble.setNoble(true, true);
                    newNoble.broadcastPacket(new SocialAction(player.getObjectId(), 15));
                    newNoble.sendMessage("You have received nobless status by killing Raid Boss Barakiel!");
                }
                else
                    newNoble.sendMessage("What a shame. You don't meet the required criteria (subclass is not active or lvl is not greater or equal 75 or you are simply already a noble.)");
            }
        }

 

ur code gave nobless to level 1 char =(

[SweeTs]

Bcs you have subclass active? Or in short, you are not replacing the file / not restarting the server.. Ppl always claims that my code doesn't work while I have proofs it is working, anyway :D

[Sdw]

Don't put that there, make something in the quest right away or a new scripts or whatever.

[Kelrzher]

yes sweets its not working just tested

[Kelrzher]

You dont need a party check, this will work

int _barakielId = 25325;
if (getNpcId() == _barakielId && !player.isNoble())
{
  if (player.isSubClassActive() || player.getLevel() >= 75) 
  {
player.setNoble(true);
player.broadcastPacket(new SocialAction( player.getObjectId(), 15));
player.sendMessage("You have received nobless status by killing Raid Boss Barakiel!");
  }
else 
if (!player.isSubClassActive() || player.getLevel() <= 75)
   {
player.sendMessage("You don't have subclass level 75 or you are already nobless"); 
}
}

Edited April 28, 2015 by Kelrzher

[ton3]

 

You dont need a party check, this will work

int _barakielId = 25325;
if (getNpcId() == _barakielId && !player.isNoble())
{
  if (player.isSubClassActive() || player.getLevel() >= 75) 
  {
player.setNoble(true);
player.broadcastPacket(new SocialAction( player.getObjectId(), 15));
player.sendMessage("You have received nobless status by killing Raid Boss Barakiel!");
  }
else 
if (!player.isSubClassActive() || player.getLevel() <= 75)
   {
player.sendMessage("You don't have subclass level 75 or you are already nobless"); 
}
}

but this will give only to one player right? what if they make party with 9 players and only 1 of them last hit barakiel?