Help Have Some Problem With Adaptation Elfocrash's Menu For L2Jacis

[t4u2d]

I trying adapt elfocrash's menu for l2jacis (rev. 330), change for usercommand, all work fine exсept disabling soulshot's/spiritshots effect. Effect disabling only on weapon, but attack's on npc with effect (if u don't understand me can make video). Pls help, i attach code from handler/itemhandler/soulshots.java , maybe u find problem.  Sry for bad english.  ;)

			return;
		}
		
		final SkillHolder[] skills = item.getItem().getSkills();
		
		weaponInst.setChargedShot(ShotType.SOULSHOT, true);
		activeChar.sendPacket(SystemMessageId.ENABLED_SOULSHOT);
		if (!activeChar.isSSDisabled())
			Broadcast.toSelfAndKnownPlayersInRadiusSq(activeChar, new MagicSkillUse(activeChar, activeChar, skills[0].getSkillId(), 1, 0, 0), 360000);
	}
}

Edited March 11, 2015 by t4u2d

[t4u2d]

guys)) pls help someone)

[FirefoxAurora]

guys)) pls help someone)

Hello, t4u2d

 

Please be patience untill someone will help you but also take a look at this,

Bumping rules: You are allowed to BUMP (Bring up your topic/post) your topic only 24 hours after your last post.

You have just to press the following button:

 

VIPs & Donators can bump 3 topics per day. 

Members can bump 1 topic per day.

 

Note : All BUMP posts (any words like "bump", "up", etc.) are not allowed anymore and they will be DELETED(To avoid post hunting through this kind of topics). We will warn you & remove your bump replies except if they're referring on updates of your server.

If you continue bumping you might get punished by locking/junking your thread.

[Tryskell]

 but attack's on npc with effect

 

 

What is it supposed to mean ? If you mean NPC using soulshots, it's in another section of code.

[t4u2d]

Tryskell thx for answer, i'm waiting for it)) Chenk this video pls and u understand me http://youtu.be/5XM4xAKw4bU.

[Tryskell]

I can't check videos, i'm using phone 4G waiting for internet provider.

[vampir]

You need to modify Attack(0x33) packet. Set soulshot as not charged in there to disable the effect.

[t4u2d]

Hmm, you can explain in more detail? I'm not a professional in java.

[vampir]

In your first code, i can see if player disables Shots then Soulshots HE uses cannot be seen by himself or anybody else. 

To continue that practice you should modify parameter "useShots" in Attack constructor.

You can do it in 2 ways:

1. That i think is more dirty:

before

soulshot = useShots;

put

if(attacker.isPlayable() && attacker.getPlayer().isSSDisabled())
soulshot = false;
else

2. Find usages of that constructor and modify soulshot usage before constructor is used. I don't have acis sources on my PC(just using online SVN) so i cannot help you.

 

What i think would be a lot better, is making only player that doesn't want to see Shots to not see them all around. To do that you need to play with who the packet is sent to(take a look at getClient() in writeImpl())

[t4u2d]

Okay, vampir thx for answer, I'll try to do what you said (and I hope I can do it :D ) . I have one more question. On some interlude/gracia servers i have seen on/off skills animation function for bad computers etc. Maybe you know how to do it?

[vampir]

Okay, vampir thx for answer, I'll try to do what you said (and I hope I can do it :D ) . I have one more question. On some interlude/gracia servers i have seen on/off skills animation function for bad computers etc. Maybe you know how to do it?

You should skip sending Packet MagicSkillLaunched to person who disables it