Jump to content

Recommended Posts

Posted

 

As I said before, there is no need for equip part, since it's already there, few lines below :P

            if (item.isEquipable())
            {
                if (newChar.getActiveWeaponItem() == null || !(item.getItem().getType2() != Item.TYPE2_WEAPON))
                    newChar.getInventory().equipItemAndRecord(item);
            }

 

its not same at all 

(item,getItem().getType2() != Item,TYPE2_weapon)

 

 

(helm,getItem().getType2() != Item,TYPE2_HEAD)...

(chest,getItem().getType2() != Item,TYPE2_EHEST)...

etc....

Posted

its not same at all 

(item,getItem().getType2() != Item,TYPE2_weapon)

 

 

(helm,getItem().getType2() != Item,TYPE2_HEAD)...

(chest,getItem().getType2() != Item,TYPE2_EHEST)...

etc....

This is an example, and sweets tell you that there is already there.

Does not need to put lines for equip items.

If I understood correctly because English is not my forte. :P

Posted

Well...from what i remember there is already a table in database to config this things by classId/itemid, its similar, but don't automatic equip the items on creation

 

Just a question, this one, equip the items when the char enter in the world or already equip in the lobby room?

Too much configs is a bit complex, maybe you can do 2 versions of this

A basic one
+By Fighter/Mage Class

And a complex one with a lot of configs
+For All
+By Fighter/Mage Class

+By Race

+By Specific Class Id

And a tip, try to use arrays/maps like the others said,
If you don't know what this means, just do a little search and make some tutorials

You can simplify this code with a for loop and switch/cases based on a built array

My english is not my "forte" too so i hope you understand, i'm just trying to be nice :)

 

Posted (edited)

Well...from what i remember there is already a table in database to config this things by classId/itemid, its similar, but don't automatic equip the items on creation

 

Yes, there is actually and it's auto equipping - at least on aCis.. So, basically this share is kinda useless :)

 

But still a good practice for the author.

Edited by SweeTs
  • 2 weeks later...
Posted
<?xml version="1.0" encoding="UTF-8"?>
<list>
    <template race="-1" classId="-1">
        <equipment slot="rhand" item="12345"/>
        <equipment slot="lhand" item="12345"/>
        <inventory>
            <item id="1234" count="12313" />
            <item id="567" count="2222" />
        </inventory>
        <shortCut slot="1" page="1" type="1" id="5555" level="-1" charType="1">
    </template>
</list>

Is possible to change code to: When player success his 3rd class get his class items? Soultaker for example am,dc .. ?

Posted

 

<?xml version="1.0" encoding="UTF-8"?>
<list>
    <template race="-1" classId="-1">
        <equipment slot="rhand" item="12345"/>
        <equipment slot="lhand" item="12345"/>
        <inventory>
            <item id="1234" count="12313" />
            <item id="567" count="2222" />
        </inventory>
        <shortCut slot="1" page="1" type="1" id="5555" level="-1" charType="1">
    </template>
</list>

Is possible to change code to: When player success his 3rd class get his class items? Soultaker for example am,dc .. ?

 

This XML was an example and it's related to the character creation. You should edit the quest (Saga of the Soultaker in your case) or add them as a reward if you use the custom class master.

  • 1 month later...
Posted

I separated the class put even when one activates the two are receiving the items

 

# Human Fighter
EnableHumanFighterReward = True
HumanFighterHelmID = 43
HumanFighterChestID = 23
HumanFighterLegsID = 2386
HumanFighterBootsID = 39
HumanFighterGlovesID = 49
HumanFighterWeaponID = 2
# Human Mage
EnableHumanMageReward = False
HumanMageHelmID = 43
HumanMageChestID = 1101
HumanMageLegsID = 1104
HumanMageBootsID = 39
HumanMageGlovesID = 49
HumanMageWeaponID = 6

 

 

public static boolean ENABLE_HUMAN_FIGHTER_REWARD;
public static boolean ENABLE_HUMAN_MAGE_REWARD;

 

 

public static int HUMAN_M_HELM_ID;
public static int HUMAN_M_CHEST_ID;
 public static int HUMAN_M_LEGS_ID;
 public static int HUMAN_M_BOOTS_ID;
 public static int HUMAN_M_GLOVES_ID;
 public static int HUMAN_M_WEAPON_ID;
 public static int HUMAN_F_HELM_ID;
 public static int HUMAN_F_CHEST_ID;
 public static int HUMAN_F_LEGS_ID;
 public static int HUMAN_F_BOOTS_ID;
 public static int HUMAN_F_GLOVES_ID;
 public static int HUMAN_F_WEAPON_ID;

 

 

if (Config.ENABLE_HUMAN_MAGE_REWARD)
               {
                       if (newChar.getRace() == Race.Human || newChar.isMageClass())
                       {
                               final L2ItemInstance Helm = newChar.getInventory().addItem("Init", Config.HUMAN_M_HELM_ID, 1, newChar, null);
                               if (Helm.isEquipable())
                                       if (newChar.getActiveWeaponItem() == null || !(Helm.getItem().getType2() != L2Item.SLOT_HEAD))
                                               newChar.getInventory().equipItemAndRecord(Helm);
                               final L2ItemInstance Chest = newChar.getInventory().addItem("Init", Config.HUMAN_M_CHEST_ID, 1, newChar, null);
                               if (Chest.isEquipable())
                                       if (newChar.getActiveWeaponItem() == null || !(Chest.getItem().getType2() != L2Item.SLOT_CHEST))
                                               newChar.getInventory().equipItemAndRecord(Chest);
                               final L2ItemInstance Legs = newChar.getInventory().addItem("Init", Config.HUMAN_M_LEGS_ID, 1, newChar, null);
                               if (Legs.isEquipable())
                                       if (newChar.getActiveWeaponItem() == null || !(Legs.getItem().getType2() != L2Item.SLOT_LEGS))
                                               newChar.getInventory().equipItemAndRecord(Legs);
                               final L2ItemInstance Boots = newChar.getInventory().addItem("Init", Config.HUMAN_M_BOOTS_ID, 1, newChar, null);
                               if (Boots.isEquipable())
                                       if (newChar.getActiveWeaponItem() == null || !(Boots.getItem().getType2() != L2Item.SLOT_FEET))
                                               newChar.getInventory().equipItemAndRecord(Boots);
                               final L2ItemInstance Gloves = newChar.getInventory().addItem("Init", Config.HUMAN_M_GLOVES_ID, 1, newChar, null);
                              if (Gloves.isEquipable())
                                       if (newChar.getActiveWeaponItem() == null || !(Gloves.getItem().getType2() != L2Item.SLOT_GLOVES))
                                               newChar.getInventory().equipItemAndRecord(Gloves);
                               final L2ItemInstance Weap = newChar.getInventory().addItem("Init", Config.HUMAN_M_WEAPON_ID, 1, newChar, null);
                               if (Weap.isEquipable())
                                       if (newChar.getActiveWeaponItem() == null || !(Weap.getItem().getType2() != L2Item.TYPE2_WEAPON))
                                               newChar.getInventory().equipItemAndRecord(Weap);
                       }
                }       
                
        if (Config.ENABLE_HUMAN_FIGHTER_REWARD)
            {
                       if (newChar.getRace() == Race.Human)
                       {
                               final L2ItemInstance Helm = newChar.getInventory().addItem("Init", Config.HUMAN_F_HELM_ID, 1, newChar, null);
                               if (Helm.isEquipable())
                                       if (newChar.getActiveWeaponItem() == null || !(Helm.getItem().getType2() != L2Item.SLOT_HEAD))
                                               newChar.getInventory().equipItemAndRecord(Helm);
                               final L2ItemInstance Chest = newChar.getInventory().addItem("Init", Config.HUMAN_F_CHEST_ID, 1, newChar, null);
                               if (Chest.isEquipable())
                                       if (newChar.getActiveWeaponItem() == null || !(Chest.getItem().getType2() != L2Item.SLOT_CHEST))
                                               newChar.getInventory().equipItemAndRecord(Chest);
                               final L2ItemInstance Legs = newChar.getInventory().addItem("Init", Config.HUMAN_F_LEGS_ID, 1, newChar, null);
                               if (Legs.isEquipable())
                                       if (newChar.getActiveWeaponItem() == null || !(Legs.getItem().getType2() != L2Item.SLOT_LEGS))
                                               newChar.getInventory().equipItemAndRecord(Legs);
                               final L2ItemInstance Boots = newChar.getInventory().addItem("Init", Config.HUMAN_F_BOOTS_ID, 1, newChar, null);
                               if (Boots.isEquipable())
                                       if (newChar.getActiveWeaponItem() == null || !(Boots.getItem().getType2() != L2Item.SLOT_FEET))
                                               newChar.getInventory().equipItemAndRecord(Boots);
                               final L2ItemInstance Gloves = newChar.getInventory().addItem("Init", Config.HUMAN_F_GLOVES_ID, 1, newChar, null);
                               if (Gloves.isEquipable())
                                       if (newChar.getActiveWeaponItem() == null || !(Gloves.getItem().getType2() != L2Item.SLOT_GLOVES))
                                               newChar.getInventory().equipItemAndRecord(Gloves);
                               final L2ItemInstance Weap = newChar.getInventory().addItem("Init", Config.HUMAN_F_WEAPON_ID, 1, newChar, null);
                               if (Weap.isEquipable())
                                       if (newChar.getActiveWeaponItem() == null || !(Weap.getItem().getType2() != L2Item.TYPE2_WEAPON))
                                               newChar.getInventory().equipItemAndRecord(Weap);
                       }
            }

 

activated the fight but the magician is receiving also because it will be?

Posted (edited)
if (newChar.getRace() == Race.Human || newChar.isMageClass())

==>

if (newChar.getRace() == Race.Human && newChar.isMageClass())

It's kinda racist, free items only for humans :troll:

Edited by SweeTs
Posted
if (newChar.getRace() == Race.Human || newChar.isMageClass())

==>

if (newChar.getRace() == Race.Human && newChar.isMageClass())

It's kinda racist, free items only for humans :troll:

 

 

put so but the wizard still getting the items fighter

 

if (newChar.getRace() == Race.Human && newChar.isMageClass())
Posted (edited)

Bcs the fighter check is ONLY about race.. You can add && !newChar.isMageClass()

Edited by SweeTs
Posted (edited)

Bcs the fighter check is ONLY about race.. You can add && !newChar.isMageClass()

 

forgot to say that I'm adapting to H5

 

got worse I see thus enabling

# Human Fighter
# Default: False
EnableHumanFighterReward = False
HumanFighterHelmID = 43
HumanFighterChestID = 23
HumanFighterLegsID = 2386
HumanFighterBootsID = 39
HumanFighterGlovesID = 49
HumanFighterWeaponID = 2
# Human Mage
# Default: False
EnableHumanMageReward = True
HumanMageHelmID = 43
HumanMageChestID = 1101
HumanMageLegsID = 1104
HumanMageBootsID = 39
HumanMageGlovesID = 49
HumanMageWeaponID = 6

put to the wizard and get the fight not only in the fight game received the items of the two and the magician not received anything

if (newChar.getRace() == Race.Human && !newChar.isMageClass())
Edited by nery
Posted (edited)

Maybe you do not understand where you have to put " && !newChar.isMageClass() "

 

For mage:

if (Config.ENABLE_HUMAN_MAGE_REWARD)
               {
                       if (newChar.getRace() == Race.Human && newChar.isMageClass())
                       {

For fighter

        if (Config.ENABLE_HUMAN_FIGHTER_REWARD)
            {
                       if (newChar.getRace() == Race.Human && !newChar.isMageClass())
Edited by 'Baggos'

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now



  • Posts

    • L2Virus the one who buyed those files from me.
    • Hi ️ Are you a supplier or do you have your own modem and are looking for a place to sell numbers?  SMS.PRO - The best option for selling your numbers  You choose the selling price yourself  Sale option: public (to everyone) or private (you choose who you want to sell to)  Everything works automatically  The simplest possible connection  Visit the website SMS.PRO and start selling your numbers.  Support @alismsorg_bot
    • Good luck to anyone playing on this server . Kamael items are bugged ( stats are insane ) Commands not working properly ( .getreward for example  ... gives u free reward without voting ). When i had those files , i fixed most of the stuff .   Every 2-3 years , he closes the server because players report bugs to him about items , he dont know how to fix then he repeating the process again https://ibb.co/Fkv7y9hJ https://ibb.co/fdYP2bVQ https://ibb.co/sp1f8C61 https://ibb.co/CKZnCgL7 https://ibb.co/Z6GktJgP  
    • Hello and welcome Server started 2026-01-05 Web site: https://l2dragonlands.eu Discrod: https://discord.gg/ngQUY8FB8G Rates >Xp x500 >Sp x500 >Drop x25 >Spoil x25 Enchant rates: Safe/max enchant +500  Blessed and simple scrolls max enchant (+200)  Enchant maneger to make +500.  In server items are progresed in tiers. Weapons: Starter > Vesper > Vorpal > Elegia > Ferrum. Armors: Starter > Moirai > Vesper > Vesper Noble > Vorpal > Elegia > Scarlet. Jewels: Starter > Vesper > Vorpal > Elegia > Ferrum. Cloaks: Pearl White > Pitch Black > Frintezza > Class Cloka > Hero > Scarlet. Acessories: Goblin Circlet 1/2lvl > Half Mask Mage 1/2lvl > Half Mask Fighter 1/2lvl > Flame of valakas > Gem Mask > Ferrum Helmet. Belt: Mithril Belt > Vitality Belt. Badges: For fighter and mage from 1lvl to 6lvl upgraded in order. Bracelets: Mithril > Shiny Fighter/Mage > 1/2lvl custom talismans in bracelest. Agathion: 7 tiers upgrade in order eatch one. Clan item shop/ New weapon Spadona upgradeble from 1lvl till 85lvl. Farm zones in order: >Giran Harbor > WasteLand > Gateway > Valley of Saints > Chromatic > Ruins of Despair > Soul Harbor > Dragon Valley. >LvL up zone >PvP zone Custom instance zone. Custom buff maneger it will grand big boost in stats. Lotery maneger to gamble. Extra features ALT+B: >Events  >Rankings  >Clan  >RB Status  >Updates and other Auto Event system: >Team VS Team event - Auto event  >Capture The Flag - Auto event Olympiad: >Retail olympiad game  >Competition period [2] week  >Olympiad start time [18:00] end [00:00]  >Maximum enchant in the Olympiad is +10, not custom items in olympiada only normal ones from shop.
    • L2 VOID - ADVERTISING BANNER   L2 FURY - ANIMATED BANNER   L2 HEROIC - ANIMATED BANNER   L2 WEED - ANIMATED BANNER   L2 REFORGE - ANIMATED LOGO   L2 WARZONE - ANIMATED LOGO   L2 ACME - SPLASH SCREEN   L2 DRUGS - ANIMATED BANNER   L2 GOLD - ADVERTISING BANNER   L2 AARON - ADVERTISING BANNER  
  • Topics

×
×
  • Create New...

Important Information

This community uses essential cookies to function properly. Non-essential cookies and third-party services are used only with your consent. Read our Privacy Policy and We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue..

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock