L2PICK.com — Lineage 2 Private Server List

Help Core Buffer Close Html After Preset

Help

Followers

brett16

Members

OfflineStatus
MembersGroup
158Posts
0Solutions
0Reputation
2,862Member No
0Days Won
22/02/2006Joined
Offline Status
Members Group
158 posts
0 Badges
0 Reputation
2,862 Member No
0 Days Won
22/02/2006 Joined

N/A 0 0 0

January 20, 201511 yr

I am using this core buffer and I have it setup really nice, but there is only 1 thing bugging me with it. When you use 1 of the preset buffs it opens up a random html afterwards. Is there a line I can add some where in this code below that doesn't reopen the html for preset buffs? I don't want it to close after each single buff is picked tho if thats possible.

public class L2NpcBufferInstance extends L2Npc
{
	private static final Logger _log = Logger.getLogger(L2NpcBufferInstance.class.getName());
	
	private static final Map<Integer, Integer> pageVal = new HashMap<>();
	
	/**
	 * Instantiates a new l2 npc buffer instance.
	 * @param objectId the object id
	 * @param template the template
	 */
	public L2NpcBufferInstance(int objectId, L2NpcTemplate template)
	{
		super(objectId, template);
		setInstanceType(InstanceType.L2NpcBufferInstance);
	}
	
	@Override
	public void showChatWindow(L2PcInstance player, int val)
	{
		if (player == null)
		{
			return;
		}
		
		String htmContent = HtmCache.getInstance().getHtm(player.getHtmlPrefix(), "data/html/mods/NpcBuffer.htm");
		if (val > 0)
		{
			htmContent = HtmCache.getInstance().getHtm(player.getHtmlPrefix(), "data/html/mods/NpcBuffer-" + val + ".htm");
		}
		
		if (htmContent != null)
		{
			final NpcHtmlMessage npcHtmlMessage = new NpcHtmlMessage(getObjectId());
			npcHtmlMessage.setHtml(htmContent);
			npcHtmlMessage.replace("%objectId%", String.valueOf(getObjectId()));
			player.sendPacket(npcHtmlMessage);
		}
		player.sendPacket(ActionFailed.STATIC_PACKET);
	}
	
	@Override
	public void onBypassFeedback(L2PcInstance player, String command)
	{
		// BypassValidation Exploit plug.
		if ((player == null) || (player.getLastFolkNPC() == null) || (player.getLastFolkNPC().getObjectId() != getObjectId()))
		{
			return;
		}
		
		L2Character target = player;
		if (command.startsWith("Pet"))
		{
			if (!player.hasSummon()) // TODO: Should be hasPet() ?
			{
				player.sendPacket(SystemMessageId.DONT_HAVE_PET);
				showChatWindow(player, 0); // 0 = main window
				return;
			}
			target = player.getSummon();
		}
		
		int npcId = getId();
		if (command.startsWith("Chat"))
		{
			int val = Integer.parseInt(command.substring(5));
			
			pageVal.put(player.getObjectId(), val);
			
			showChatWindow(player, val);
		}
		else if (command.startsWith("Buff") || command.startsWith("PetBuff"))
		{
			String[] buffGroupArray = command.substring(command.indexOf("Buff") + 5).split(" ");
			
			for (String buffGroupList : buffGroupArray)
			{
				if (buffGroupList == null)
				{
					_log.warning("NPC Buffer Warning: npcId = " + npcId + " has no buffGroup set in the bypass for the buff selected.");
					return;
				}
				
				int buffGroup = Integer.parseInt(buffGroupList);
				
				final NpcBufferData npcBuffGroupInfo = NpcBufferTable.getInstance().getSkillInfo(npcId, buffGroup);
				if (npcBuffGroupInfo == null)
				{
					_log.warning("NPC Buffer Warning: npcId = " + npcId + " Location: " + getX() + ", " + getY() + ", " + getZ() + " Player: " + player.getName() + " has tried to use skill group (" + buffGroup + ") not assigned to the NPC Buffer!");
					return;
				}
				
				if (npcBuffGroupInfo.getFee().getId() != 0)
				{
					L2ItemInstance itemInstance = player.getInventory().getItemByItemId(npcBuffGroupInfo.getFee().getId());
					if ((itemInstance == null) || (!itemInstance.isStackable() && (player.getInventory().getInventoryItemCount(npcBuffGroupInfo.getFee().getId(), -1) < npcBuffGroupInfo.getFee().getCount())))
					{
						SystemMessage sm = SystemMessage.getSystemMessage(SystemMessageId.THERE_ARE_NOT_ENOUGH_NECESSARY_ITEMS_TO_USE_THE_SKILL);
						player.sendPacket(sm);
						continue;
					}
					
					if (itemInstance.isStackable())
					{
						if (!player.destroyItemByItemId("Npc Buffer", npcBuffGroupInfo.getFee().getId(), npcBuffGroupInfo.getFee().getCount(), player.getTarget(), true))
						{
							SystemMessage sm = SystemMessage.getSystemMessage(SystemMessageId.THERE_ARE_NOT_ENOUGH_NECESSARY_ITEMS_TO_USE_THE_SKILL);
							player.sendPacket(sm);
							continue;
						}
					}
					else
					{
						for (int i = 0; i < npcBuffGroupInfo.getFee().getCount(); ++i)
						{
							player.destroyItemByItemId("Npc Buffer", npcBuffGroupInfo.getFee().getId(), 1, player.getTarget(), true);
						}
					}
				}
				
				final Skill skill = SkillData.getInstance().getSkill(npcBuffGroupInfo.getSkill().getSkillId(), npcBuffGroupInfo.getSkill().getSkillLvl());
				if (skill != null)
				{
					skill.applyEffects(player, target);
				}
			}
			
			showChatWindow(player, pageVal.get(player.getObjectId()));
		}
		else if (command.startsWith("Heal") || command.startsWith("PetHeal"))
		{
			if (!target.isInCombat() && !AttackStanceTaskManager.getInstance().hasAttackStanceTask(target))
			{
				String[] healArray = command.substring(command.indexOf("Heal") + 5).split(" ");
				
				for (String healType : healArray)
				{
					if (healType.equalsIgnoreCase("HP"))
					{
						target.setCurrentHp(target.getMaxHp());
					}
					else if (healType.equalsIgnoreCase("MP"))
					{
						target.setCurrentMp(target.getMaxMp());
					}
					else if (healType.equalsIgnoreCase("CP"))
					{
						target.setCurrentCp(target.getMaxCp());
					}
				}
			}
			showChatWindow(player, pageVal.get(player.getObjectId()));
		}
		else if (command.startsWith("RemoveBuffs") || command.startsWith("PetRemoveBuffs"))
		{
			target.stopAllEffectsExceptThoseThatLastThroughDeath();
			showChatWindow(player, pageVal.get(player.getObjectId()));
		}
		else
		{
			super.onBypassFeedback(player, command);
		}
	}
}

Tessa

Members

OfflineStatus
MembersGroup
1,474Posts
20Solutions
6Reputation
150,788Member No
4Days Won
22/11/2014Joined
Offline Status
Members Group
1.5k posts
20 Solutions
7 Badges
6 Reputation
150,788 Member No
4 Days Won
22/11/2014 Joined

N/A 0 0 0

January 20, 201511 yr

Why this?

showChatWindow(player, pageVal.get(player.getObjectId()));

brett16

Members

OfflineStatus
MembersGroup
158Posts
0Solutions
0Reputation
2,862Member No
0Days Won
22/02/2006Joined
Offline Status
Members Group
158 posts
0 Badges
0 Reputation
2,862 Member No
0 Days Won
22/02/2006 Joined

N/A 0 0 0

January 20, 201511 yr

Author

So remove that line?

Tessa

Members

OfflineStatus
MembersGroup
1,474Posts
20Solutions
6Reputation
150,788Member No
4Days Won
22/11/2014Joined
Offline Status
Members Group
1.5k posts
20 Solutions
7 Badges
6 Reputation
150,788 Member No
4 Days Won
22/11/2014 Joined

N/A 0 0 0

January 20, 201511 yr

No, why you get the object id?

brett16

Members

OfflineStatus
MembersGroup
158Posts
0Solutions
0Reputation
2,862Member No
0Days Won
22/02/2006Joined
Offline Status
Members Group
158 posts
0 Badges
0 Reputation
2,862 Member No
0 Days Won
22/02/2006 Joined

N/A 0 0 0

January 20, 201511 yr

Author

Oh, I don't know this is the core buffer from L2jserver.com on their highfive beta. I didn't make this, I just want to fix the html reopening after I use a preset.

HaddWik

Members

OfflineStatus
MembersGroup
258Posts
0Solutions
0Reputation
81,346Member No
0Days Won
30/10/2010Joined
Offline Status
Members Group
258 posts
4 Badges
0 Reputation
81,346 Member No
0 Days Won
30/10/2010 Joined

N/A 0 0 0

January 20, 201511 yr

Do you have a main page on your buffer?

What I mean:

Hello im buffer bla bla bla.

Button Buff me and taking you to buff menus where are those presets?

Because if you do it like that with the main page you will not have problem with returning back to right html window.

brett16

Members

OfflineStatus
MembersGroup
158Posts
0Solutions
0Reputation
2,862Member No
0Days Won
22/02/2006Joined
Offline Status
Members Group
158 posts
0 Badges
0 Reputation
2,862 Member No
0 Days Won
22/02/2006 Joined

N/A 0 0 0

January 20, 201511 yr

Author

This is the new code that I think opens the main page 0 after using presets. But comes with another issue.

public class L2NpcBufferInstance extends L2Npc
{
	private static final Logger _log = Logger.getLogger(L2NpcBufferInstance.class.getName());
	
	private static final Map<Integer, Integer> pageVal = new HashMap<>();
	
	/**
	 * Instantiates a new l2 npc buffer instance.
	 * @param objectId the object id
	 * @param template the template
	 */
	public L2NpcBufferInstance(int objectId, L2NpcTemplate template)
	{
		super(objectId, template);
		setInstanceType(InstanceType.L2NpcBufferInstance);
	}
	
	@Override
	public void showChatWindow(L2PcInstance player, int val)
	{
		if (player == null)
		{
			return;
		}
		
		String htmContent = HtmCache.getInstance().getHtm(player.getHtmlPrefix(), "data/html/mods/NpcBuffer.htm");
		if (val > 0)
		{
			htmContent = HtmCache.getInstance().getHtm(player.getHtmlPrefix(), "data/html/mods/NpcBuffer-" + val + ".htm");
		}
		
		if (htmContent != null)
		{
			final NpcHtmlMessage npcHtmlMessage = new NpcHtmlMessage(getObjectId());
			npcHtmlMessage.setHtml(htmContent);
			npcHtmlMessage.replace("%objectId%", String.valueOf(getObjectId()));
			player.sendPacket(npcHtmlMessage);
		}
		player.sendPacket(ActionFailed.STATIC_PACKET);
	}
	
	@Override
	public void onBypassFeedback(L2PcInstance player, String command)
	{
		// BypassValidation Exploit plug.
		if ((player == null) || (player.getLastFolkNPC() == null) || (player.getLastFolkNPC().getObjectId() != getObjectId()))
		{
			return;
		}
		
		L2Character target = player;
		if (command.startsWith("Pet"))
		{
			if (!player.hasSummon()) // TODO: Should be hasPet() ?
			{
				player.sendPacket(SystemMessageId.DONT_HAVE_PET);
				showChatWindow(player, 0); // 0 = main window
				return;
			}
			target = player.getSummon();
		}
		
		int npcId = getId();
		if (command.startsWith("Chat"))
		{
			int val = Integer.parseInt(command.substring(5));
			
			pageVal.put(player.getObjectId(), val);
			
			showChatWindow(player, val);
		}
		else if (command.startsWith("Buff") || command.startsWith("PetBuff"))
		{
			String[] buffGroupArray = command.substring(command.indexOf("Buff") + 5).split(" ");
			
			for (String buffGroupList : buffGroupArray)
			{
				if (buffGroupList == null)
				{
					_log.warning("NPC Buffer Warning: npcId = " + npcId + " has no buffGroup set in the bypass for the buff selected.");
					return;
				}
				
				int buffGroup = Integer.parseInt(buffGroupList);
				
				final NpcBufferData npcBuffGroupInfo = NpcBufferTable.getInstance().getSkillInfo(npcId, buffGroup);
				if (npcBuffGroupInfo == null)
				{
					_log.warning("NPC Buffer Warning: npcId = " + npcId + " Location: " + getX() + ", " + getY() + ", " + getZ() + " Player: " + player.getName() + " has tried to use skill group (" + buffGroup + ") not assigned to the NPC Buffer!");
					return;
				}
				
				if (npcBuffGroupInfo.getFee().getId() != 0)
				{
					L2ItemInstance itemInstance = player.getInventory().getItemByItemId(npcBuffGroupInfo.getFee().getId());
					if ((itemInstance == null) || (!itemInstance.isStackable() && (player.getInventory().getInventoryItemCount(npcBuffGroupInfo.getFee().getId(), -1) < npcBuffGroupInfo.getFee().getCount())))
					{
						SystemMessage sm = SystemMessage.getSystemMessage(SystemMessageId.THERE_ARE_NOT_ENOUGH_NECESSARY_ITEMS_TO_USE_THE_SKILL);
						player.sendPacket(sm);
						continue;
					}
					
					if (itemInstance.isStackable())
					{
						if (!player.destroyItemByItemId("Npc Buffer", npcBuffGroupInfo.getFee().getId(), npcBuffGroupInfo.getFee().getCount(), player.getTarget(), true))
						{
							SystemMessage sm = SystemMessage.getSystemMessage(SystemMessageId.THERE_ARE_NOT_ENOUGH_NECESSARY_ITEMS_TO_USE_THE_SKILL);
							player.sendPacket(sm);
							continue;
						}
					}
					else
					{
						for (int i = 0; i < npcBuffGroupInfo.getFee().getCount(); ++i)
						{
							player.destroyItemByItemId("Npc Buffer", npcBuffGroupInfo.getFee().getId(), 1, player.getTarget(), true);
						}
					}
				}
				
				final Skill skill = SkillData.getInstance().getSkill(npcBuffGroupInfo.getSkill().getSkillId(), npcBuffGroupInfo.getSkill().getSkillLvl());
				if (skill != null)
				{
					skill.applyEffects(player, target);
				}
			}
			
			showChatWindow(player, pageVal.get(player.getObjectId()));
		}
		else if (command.startsWith("Heal") || command.startsWith("PetHeal"))
		{
			if (!target.isInCombat() && !AttackStanceTaskManager.getInstance().hasAttackStanceTask(target))
			{
				String[] healArray = command.substring(command.indexOf("Heal") + 5).split(" ");
				
				for (String healType : healArray)
				{
					if (healType.equalsIgnoreCase("HP"))
					{
						target.setCurrentHp(target.getMaxHp());
					}
					else if (healType.equalsIgnoreCase("MP"))
					{
						target.setCurrentMp(target.getMaxMp());
					}
					else if (healType.equalsIgnoreCase("CP"))
					{
						target.setCurrentCp(target.getMaxCp());
					}
				}
			}
			showChatWindow(player, pageVal.get(player.getObjectId()));
		}
		else if (command.startsWith("RemoveBuffs") || command.startsWith("PetRemoveBuffs"))
		{
			target.stopAllEffectsExceptThoseThatLastThroughDeath();
			showChatWindow(player, 0);
		}
		else
		{
			super.onBypassFeedback(player, command);
		}
	}
}

When I go to my buffer and select a preset fighter it buffs me, but this also pops up and sends the same message to my gameserver console. http://imgur.com/dgLhUZ1

I know how to stop to problem from happening again in game, If I select a normal buff first then use my preset it wont give me this message. But not every player will do this, they will all just use the presets. How can I fix or remove this message spam?

Edited January 20, 201511 yr by brett16

HaddWik

Members

OfflineStatus
MembersGroup
258Posts
0Solutions
0Reputation
81,346Member No
0Days Won
30/10/2010Joined
Offline Status
Members Group
258 posts
4 Badges
0 Reputation
81,346 Member No
0 Days Won
30/10/2010 Joined

N/A 0 0 0

January 20, 201511 yr

Now let me say you something the page returning function can be removed at all but this is not good because when player uses normal buffs except presets at every click the window will be closed.

My suggestion is to move the presets to page1. Not on page 0 because the buffer is remembering the pageVal only when the "Chat" function is used.

You can also try to add this code:

if (val == 0)
{
pageVal.put(player.getObjectId(), 0);
}

Bellow:

public void showChatWindow(L2PcInstance player, int val)
	{
		if (player == null)
		{
			return;
		}

I dont know if it will work that way but try.

brett16

Members

OfflineStatus
MembersGroup
158Posts
0Solutions
0Reputation
2,862Member No
0Days Won
22/02/2006Joined
Offline Status
Members Group
158 posts
0 Badges
0 Reputation
2,862 Member No
0 Days Won
22/02/2006 Joined

N/A 0 0 0

January 20, 201511 yr

Author

It stays on the first main page now, but no idea how to stop the bypass popups and spam on gameserver console.

Create an account or sign in to comment

Followers

Go to topic listing

NPC Temples Pack with Effects (Interlude).7z

Well i checked the NPC IDs as you suggested.

The server-side NPC IDs match the entries in npcgrp.dat and npcname-e.dat exactly (40040–40049), with no duplicates or display-ID substitutions. the rabbit appearance was occurring in a client that didn't contain those custom NPC records. However, the client crash is a separate issue.
i tested NPC 40042 using LineageNPCs6Script.effectnpc_a and the Kain_van_Holter_m00 mesh.

💥When that NPC came into view, my standard Interlude client crashed.

After inspecting the pack, i noticed that :

1. LineageNpcs6.ukx, LineageNPCs6Script.u and LineageNPCs6Effect.u use a non-standard package header (Lineage2Ver11 followed by 0xD839), rather than the standard Interlude Lineage2Ver111 format.

The included L2Mid packages use Lineage2Ver821.
Several NPC entries reference additional packages that aren't included in the archive.
my environment is Lucera2 Interlude with a standard Interlude client.
if you could you please clarify:

1.Were the LineageNpcs6 files made for a protected or modified Interlude client?
2.Do they require a specific encryption key, DLL or client patch?
3.Are standard Interlude-compatible versions of these files available?
4.Are the missing model packages supposed to be included separately?

i would like to use the actual custom NPC models, rather than replacing them with retail models.
Thanks for your help!

By d1ctatorTV · 28 minutes ago28 min
WTS / WTB L2REBORN

⚔️ ADENAVIP — L2 GAME SHOP ⚔️
🔥 BUY & SELL ADENA ON L2REBORN! 🔥
Looking to buy or sell Adena? You've come to the right place!
💰 WE BUY & SELL:
Adena
In-game currency
Valuable items
Epic items & equipment
⚡ Fast transactions
🛡️ Safe and reliable deals
🤝 Friendly support
💎 Competitive prices
🌍 SERVER: L2REBORN
📩 CONTACT US ON DISCORD:
ADENAVIP
🔥 Your trusted partner in Lineage 2 trading!
BUY SMART. SELL FAST. PLAY STRONG! ⚔️

By addelka · 1 hour ago1 hr
Buy Chatgpt | Gemini | Any Premium Subscription at Klouditem

🛠️ The ultimate digital toolkit: Cursor AI for coding, Claude & ChatGPT for reasoning, and Canva Pro for graphics. Instant automated delivery!

By klouditem · 1 hour ago1 hr
Is L2J's gameserver security indefinitelly compromised ?

It's very easy to call everyone an AI slop vibe coder nowadays when they disagree with you. Let me educate you a bit on the history of Java emulation of Lineage 2 to make my point clearer.

L2J took a very bad turn around 2010.

Around that date, most of people people who were capable programmers that created L2J and L2JFree simply for fun, were starting to get replaced by people who were primarily server-owners or paid-developers who simply wanted either recognition or to steer the project towards personal agendas.

A lot of the L2JServer code got rewritten back then, by so called "senior developers" who decided to "move things to the Datapack" and other niche ideas. This "rewrite" of older code lead to the introduction of most exploits that work today and that AI keeps finding.

For example, around that time, Zoey76 who was leading L2JServer decided to rewrite the favourites module of the community board. That code was perfectly fine, and he rewrote it in a very bad way that introduced a memory leak that can be triggered by a malicious user that can lead to OOM on the server. A lot of packs who forked from L2JServer both private and public have this issue nowadays.

Generally the quality of the developers after 2010 went down because most of these people were qualified asslickers and not qualified developers.

The same rewrite era led to the introduction of a nasty adena dupe exploit that is currently working in many servers using re-bidding from a clan leader that changed a clan and then cancelling the bit. This was fixed, new developers regressed it.

And it's not just the era of L2JServer's 2010+ years. Later on Mobius took control of the scene and he has done a lot of such mistakes too. And it's not just open source. L2Scripts, check the 2020 leak, you can craft manor packets to plant baium rings instead of crops. aCis has messed up zone system, you can become invulnerable in multiple ways and nobody can kill you too. I can go on and on about how insecure ALL the packs are.

"But if you point an AI to the code it will tell you the security issues". Note quietly. AI is a reflection of your skills, if you dont know where to look, how to look, how the mechanics of the code work it wont find anything. There are people who use AI and people who CAN USE AI. It's different.

The reality is for someone who knows what he is doing and an AI agent, it's easy to "demote" the security of all these decent packs to "mediocre".

In some months I'm planning to open a server of my own. I'm terrified to the idea of not knowing all my security vulnerabilities and of a hacker who can come and TRASH it for fun ...

These are existing risks for all of us, that a lot of you dont seem to be taking under consideration ...

By aguy · 2 hours ago2 hr
Is L2J's gameserver security indefinitelly compromised ?

It couldn't have been explained better.
People who consider themselves senior developers because they know how to write text to an AI, whose QA is simply to jump in and see if it works without understanding the actual mechanics or what they entail, is frustrating.
Furthermore, treating developers as if they're nothing because AI can do the same things we do is simply ridiculous.
Imagine you have to create a recipe for a contest and you have zero cooking experience, and your opponent is a professional chef. Even using AI, the odds of winning are low. The same applies here.

By rexen · 3 hours ago3 hr

Help Core Buffer Close Html After Preset

Featured Replies

Create an account or sign in to comment

Posts

NPC Temples Pack with Effects (Interlude).7z

WTS / WTB L2REBORN

Buy Chatgpt | Gemini | Any Premium Subscription at Klouditem

Is L2J's gameserver security indefinitelly compromised ?

Is L2J's gameserver security indefinitelly compromised ?

Topics

Lagacy L2REBORN

Black Chaotic Weapons

🤖 HeistBot

NPC Temples Pack with Effects (Interlude).7z

L2 Good Vs Evil !

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)