Jump to content

Recommended Posts

Posted

Hello guys. I made a clan manager for a guy. I decided to share it with you.


 


What that manager does? You can change your clan's level, your clan's reputation score and add clan skills.


 


Code is untested, I would be greatful if someone test it.


 


The code: http://pastebin.com/n4kY3kbJ


 


Thanks in advance. All credits are mine.


Posted (edited)
 




+       public int itemId = 57;
+       public int itemCountLevelUp = 10000;
+       public int itemCountReputationPoints = 100000;
+       public int itemCountClanSkills = 100000000;
+       public int clanLevel = 1;
+       public int clanReputationScore = 1000;
+       public int[] clanSkills = {
+       {
+               370,
+               371,


+               372,


+               373,
+               374,
+               375,
+               376,
+               377,
+               378,
+               379,
+               380,
+               381,
+               382,
+               383,
+               384,
+               385,
+               386,
+               387,
+               388,
+               389,
+               390,
+               391
+       


 

all these should be private static final

 




+                       if (player.getClan() != null)
+                       {
+                               player.sendMessage("You don't have a clan.");
+                               return;
+                       }



 

this is wrong



+                       for (int s : clanSkills)
+                       {
+                               L2Skill clanSkill = SkillTable.getInstance().getInfo(s, SkillTable.getInstance().getMaxLevel(s));
+                               player.getClan().addNewSkill(clanSkill);
+                               player.getClan().broadcastClanStatus();
+                               player.getInventory().destroyItemByItemId("Init.", itemId, itemCountClanSkills, player, player);
+                               player.sendMessage("Your clan has learned all clan skills.");
+                       }


 

this should be



+                       for (int s : clanSkills)
+                       {
+                               L2Skill clanSkill = SkillTable.getInstance().getInfo(s, SkillTable.getInstance().getMaxLevel(s));


+                               player.getClan().addNewSkill(clanSkill);
+                               //if clan already owns this skill; continue;

+                               if (!player.getInventory().destroyItemByItemId("ClanSkill", itemId, itemCountClanSkills, player, player))
+                               {
+                                       player.sendMessage("you dont have enough materials for this clan skill);
+                                       break;
+                               }
+                               player.sendMessage("Your clan has learned all clan skills.");
+                       }
+                      player.getClan().broadcastClanStatus();



Edited by xdem
Posted (edited)

Haha this one is the best :happyforever:  Surely you wanted to write == :P

    +                       if (player.getClan() != null)
    +                       {
    +                               player.sendMessage("You don't have a clan.");
    +                               return;
    +                       }
Edited by SweeTs
Posted

There's a lot of improvements to do :

* all commands use the same checks so you can reduce amount of produced code (using for example if (command.startsWith("clan"))

* the skills array is from 370 to 391 so you can use old school for loop to avoid to store anything (not needed to store stuff which can be easily guessed).

* as said SweeTs the clan check makes the whole code broken.

* as said xdem you should check if you can destroy the item before trying to "reward" for the given action, otherwise it's a big exploit. xdem code got also a problem btw.

Posted

There's a lot of improvements to do :

* all commands use the same checks so you can reduce amount of produced code (using for example if (command.startsWith("clan"))

* the skills array is from 370 to 391 so you can use old school for loop to avoid to store anything (not needed to store stuff which can be easily guessed).

* as said SweeTs the clan check makes the whole code broken.

* as said xdem you should check if you can destroy the item before trying to "reward" for the given action, otherwise it's a big exploit. xdem code got also a problem btw.

Yeah thanks for that suggestions. I was in hurry about posting the code so I didn't notice that kind of typos.

Posted

There's a lot of improvements to do :

* all commands use the same checks so you can reduce amount of produced code (using for example if (command.startsWith("clan"))

* the skills array is from 370 to 391 so you can use old school for loop to avoid to store anything (not needed to store stuff which can be easily guessed).

* as said SweeTs the clan check makes the whole code broken.

* as said xdem you should check if you can destroy the item before trying to "reward" for the given action, otherwise it's a big exploit. xdem code got also a problem btw.

 

yes, I made that mistake cause I used his code, I gave the skill and then I asked for the price, what a dumb

  • 2 months later...
Posted

327Rev>

 

not tested ( i just fix the build error about 

  1. -import net.sf.l2j.gameserver.templates.chars.L2NpcTemplate;

 

with that

  1. +import net.sf.l2j.gameserver.model.actor.template.NpcTemplate;

 

and that 

  1. -       public L2ClanManagerInstance(int objectId, L2NpcTemplate template)

 

with that

  1. +       public L2ClanManagerInstance(int objectId, NpcTemplate template)

 

 

/*
 * This program is free software: you can redistribute it and/or modify it under
 * the terms of the GNU General Public License as published by the Free Software
 * Foundation, either version 3 of the License, or (at your option) any later
 * version.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
 * details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program. If not, see <http://www.gnu.org/licenses/>.
 */
package net.sf.l2j.gameserver.model.actor.instance;
 
import net.sf.l2j.gameserver.datatables.SkillTable;
import net.sf.l2j.gameserver.model.L2Skill;
import net.sf.l2j.gameserver.network.serverpackets.ActionFailed;
import net.sf.l2j.gameserver.network.serverpackets.NpcHtmlMessage;
import net.sf.l2j.gameserver.model.actor.template.NpcTemplate;
 
/**
 * @author Devlin
 *
 */
public class L2ClanManagerInstance extends L2NpcInstance
{
       public L2ClanManagerInstance(int objectId, NpcTemplate template)
       {
               super(objectId, template);
       }
      
    @Override
    public void showChatWindow(L2PcInstance player, int val)
    {
        player.sendPacket(ActionFailed.STATIC_PACKET);
        String filename = "data/html/mods/clanManager.htm";
        NpcHtmlMessage html = new NpcHtmlMessage(getObjectId());
        html.setFile(filename);
        html.replace("%objectId%", String.valueOf(getObjectId()));
        player.sendPacket(html);
    }
      
       public int itemId = 57;
       public int itemCountLevelUp = 15;
       public int itemCountReputationPoints = 15;
       public int itemCountClanSkills = 20;
       public int clanLevel = 8;
       public int clanReputationScore = 30000;
      
       public int[] clanSkills =
       {
               370,
               371,
               372,
               373,
               374,
               375,
               376,
               377,
               378,
               379,
               380,
               381,
               382,
               383,
               384,
               385,
               386,
               387,
               388,
               389,
               390,
               391
       };
      
       @Override
       public void onBypassFeedback(L2PcInstance player, String command)
       {
               if (command.equals("clanLevelUp"))
               {
                       if (player.getClan() != null)
                       {
                               player.sendMessage("You don't have a clan.");
                               return;
                       }
                      
                       if (!player.isClanLeader())
                       {
                               player.sendMessage("You aren't the leader of your clan.");
                               return;
                       }
                      
                       if (player.getInventory().getItemByItemId(itemId).getCount() > itemCountLevelUp)
                       {
                               player.sendMessage("You don't have enough items.");
                               return;
                       }
                      
                       player.getClan().changeLevel(player.getClan().getLevel() + clanLevel);
                       player.getClan().broadcastClanStatus();
                       player.getInventory().destroyItemByItemId("Init.", itemId, itemCountLevelUp, player, player);
                       player.sendMessage("Your clan's level has been changed to "+player.getClan().getLevel());
               }
              
               else if (command.equals("clanReputationPoints"))
               {
                       if (player.getClan() != null)
                       {
                               player.sendMessage("You don't have a clan.");
                               return;
                       }
                      
                       if (!player.isClanLeader())
                       {
                               player.sendMessage("You aren't the leader of your clan.");
                               return;
                       }
                      
                       if (player.getInventory().getItemByItemId(itemId).getCount() > itemCountReputationPoints)
                       {
                               player.sendMessage("You don't have enough items.");
                               return;
                       }
                      
                       player.getClan().addReputationScore(clanReputationScore);
                       player.getClan().broadcastClanStatus();
                       player.getInventory().destroyItemByItemId("Init.", itemId, itemCountReputationPoints, player, player);
                       player.sendMessage("Your clan's reputation score has been changed to "+player.getClan().getReputationScore());
               }
              
               else if (command.equals("clanSkills"))
               {
                       if (player.getClan() != null)
                       {
                               player.sendMessage("You don't have a clan.");
                               return;
                       }
                      
                       if (!player.isClanLeader())
                       {
                               player.sendMessage("You aren't the leader of your clan.");
                               return;
                       }
                      
                       if (player.getInventory().getItemByItemId(itemId).getCount() > itemCountClanSkills)
                       {
                               player.sendMessage("You don't have enough items.");
                               return;
                       }
                      
                       for (int s : clanSkills)
                       {
                               L2Skill clanSkill = SkillTable.getInstance().getInfo(s, SkillTable.getInstance().getMaxLevel(s));
                               player.getClan().addNewSkill(clanSkill);
                               player.getClan().broadcastClanStatus();
                               player.getInventory().destroyItemByItemId("Init.", itemId, itemCountClanSkills, player, player);
                               player.sendMessage("Your clan has learned all clan skills.");
                       }
               }
       }
}
Posted (edited)

 

Haha this one is the best :happyforever:  Surely you wanted to write == :P

    +                       if (player.getClan() != null)
    +                       {
    +                               player.sendMessage("You don't have a clan.");
    +                               return;
    +                       }

he want to say if clan is different than Nothing then you don't have a clan he is right <3 xD

Edited by WolfGiaS3na
Guest
This topic is now closed to further replies.


  • Posts

    • Update M54: Global HP/MP/CP consumable handling expanded beyond combat-only usage. Offensive mage idle recovery with learned skill Battle Heal. Spellhowler/Storm Screamer prioritizes Hurricane, using Vampiric Claw mostly below 90% HP. Major structural refactor initialized: Added category/class organization such as Archer, Dagger, Tank, Mage, Healer, Support and Specialized class files. Further structural cleanup. Extracted combat memory/state and more class-policy logic from the main controller. Added global stuck/inactivity watchdog for bots blocked by terrain/geodata. Added unreachable dropped ground-item timeout/temporary blacklist. Reworked Necromancer/Soultaker PvP: Dominator level 78+ maintains learned Arcane Power toggle on. Overlord/Dominator level 44+ maintains learned Soul Guard toggle automatically. Stability/scalability update: Bot controller ticks staggered instead of all starting in the same phase: Same 350 ms update rate retained Reduces simultaneous AI workload bursts. Removed the old manual aggressive-monster EVT_AGGRESSION bridge. Phantoms now use native Lucera setActive() behavior so monsters aggro them naturally. Reduced unnecessary NPC scans and native AI event pressure. Added saved-bot equipment overrides using a separate database table:         lucera_autobots_items Existing lucera_autobots remains the main saved-bot identity/state table. Equipment rows are linked to saved bots through bot_id. Added optional convenience view to show bot name together with equipment overrides:         lucera_autobots_items_view Added editable equipment slots in columns: Weapon Shield Helmet Chest Legs Gloves Boots Necklace Left/Right Earrings Left/Right Rings Equipment override values: 0 = use normal class/level profile item -1 = force slot empty >0 = equip that Item ID Custom equipment works only for saved database bots. Default class/level equipment profiles remain unchanged. Supports custom equipment from No Grade to S Grade, regardless of the bot's current level. Added validation for invalid item IDs and incompatible equipment slots. Added handling for: Two-handed weapons vs shields Full-body armor vs separate leggings Added all-grade Soulshots and Spiritshots to bot inventory/replenishment so custom lower-grade weapons still use the correct shots. Mage profiles that already use Blessed Spiritshots keep that behavior with all relevant grades available. First save the bot normally so it exists in table:         lucera_autobots Then open:         lucera_autobots_items Find the row with the same bot_id and edit only the equipment slots you want. Example: weapon_id = 6608 shield_id = -1 helmet_id = 0 chest_id = 0 legs_id = 0 gloves_id = 0 boots_id = 0 This means: weapon_id 6608 → custom weapon shield_id -1 → no shield all 0 values → keep normal default profile equipment After editing the DB, despawn and respawn the saved bot so M54 reloads its equipment overrides. Do not edit bot_id. Use it only to identify which saved bot the equipment row belongs to.   DOWNLOAD
    • It will be multi client so it will detect the client from the files and adapt the packets and asset loading. I am aiming for C4 and H5 after IL
    • this is just to simplify your life, time, and can be done for free by yourself just watch some tutorials, in case you don't wanna waste time check it out!   https://l2getwork.art   https://l2getwork.art/showcase.html  
    • Good job! Any chance for it to be downgradeable or at least compatible with older chronicles?
    • Fermata now runs in a web browser too. Try it here: https://web.fermata.gg/    
  • Topics

×
×
  • Create New...

Important Information

This community uses essential cookies to function properly. Non-essential cookies and third-party services are used only with your consent. Read our Privacy Policy and We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue..