No Heal and Buffs at Monsters and Raids

[xdem]

This simple code will stop players from healing or buffing monsters and raids

Go at network/clientpackets/RequestMagicSkillUse

	// Check the validity of the skill
	if (skill != null)
	{
		+if (activeChar.getTarget() instanceof L2MonsterInstance)
		+{
		+	switch (skill.getSkillType())
		+	{
		+		case HEAL:
		+		case HEAL_PERCENT:
		+		case BUFF:
		+		{
		+			if (skill.getTargetType()==L2TargetType.TARGET_ONE)
		+			{
		+				return;
		+			}
		+		}
		+	}
		+}
		if ((activeChar.isTransformed() || activeChar.isInStance()) && !activeChar.containsAllowedTransformSkill(skill.getId()))

 

Credits me, thanks for your reports guys, all fixed!

for those with the previus version I recomend change asap

[Napster321]

thanks ;)

[xdem]

thanks ;)

:$

[lame69]

thanks ;)

its very usefull

but ,  case CHAIN_HEAL: is not necessary i think, becouse it cant be cast on target!

 

[Setekh]

small note.

 

You don't do this:

		+		case HEAL:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case HEAL_PERCENT:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case CHAIN_HEAL:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case BUFF:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;

 

You do

		+		case HEAL:
		+		case HEAL_PERCENT:
		+		case CHAIN_HEAL:
		+		case BUFF:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;

Cases collapse and run till u tell them to break;

Also it would of been best/safer, if you did it in the Heal skill handler.

[xdem]

small note.

 

You don't do this:

		+		case HEAL:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case HEAL_PERCENT:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case CHAIN_HEAL:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case BUFF:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;

 

You do

		+		case HEAL:
		+		case HEAL_PERCENT:
		+		case CHAIN_HEAL:
		+		case BUFF:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;

Cases collapse and run till u tell them to break;

Also it would of been best/safer, if you did it in the Heal skill handler.

thanks for the info, updated

[Setekh]

Np dude, thanks for the share + 1.

[xdem]

Np dude, thanks for the share + 1.

thanks!!!

[Napster321]

small note.

 

You don't do this:

		+		case HEAL:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case HEAL_PERCENT:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case CHAIN_HEAL:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case BUFF:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;

 

You do

		+		case HEAL:
		+		case HEAL_PERCENT:
		+		case CHAIN_HEAL:
		+		case BUFF:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;

Cases collapse and run till u tell them to break;

Also it would of been best/safer, if you did it in the Heal skill handler.

as you had told me to add these exceptions in skillhandlers didn't work...so it's pointless to add that to skillhandlers :)

[vampir]

also

from this:

if (activeChar.getTarget() instanceof L2RaidBossInstance || activeChar.getTarget() instanceof L2GrandBossInstance || activeChar.getTarget() instanceof L2MonsterInstance)

you can do this:

if (activeChar.getTarget() instanceof L2MonsterInstance)

because as far as i know, L2RaidBossInstance and L2GrandBossInstance are extending L2MonsterInstance

[xdem]

also

from this:

if (activeChar.getTarget() instanceof L2RaidBossInstance || activeChar.getTarget() instanceof L2GrandBossInstance || activeChar.getTarget() instanceof L2MonsterInstance)

you can do this:

if (activeChar.getTarget() instanceof L2MonsterInstance)

because as far as i know, L2RaidBossInstance and L2GrandBossInstance are extending L2MonsterInstance

 

I thougth it too, but never tested it, because L2MonsterInstance Extends L2Npc I think, its a little complicated, I will test

[lame69]

I thougth it too, but never tested it, because L2MonsterInstance Extends L2Npc I think, its a little complicated, I will test

After alot of tests today(becouse i like your idea)

When u get target raidboss/grandraid/monster:

u cant use group heal/chain heal/prayer/servitor heal/AI and alot of buffs which are self...

if you drop chain heal/Buff and MonsterInstance this system will be perfect for raids/epics,big deal that someone will buff him with might or shield,and only group heal and few other skills on target will not work normal.(this is my opinion ofc)

[xdem]

After alot of tests today(becouse i like your idea)

When u get target raidboss/grandraid/monster:

u cant use group heal/chain heal/prayer/servitor heal/AI and alot of buffs which are self...

if you drop chain heal/Buff and MonsterInstance this system will be perfect for raids/epics,big deal that someone will buff him with might or shield,and only group heal and few other skills on target will not work normal.(this is my opinion ofc)

 

Your report is usefull for me and now I will go fix it, im pretty sure I will solve this bug too, the servitor heal yes its a bug on witch im gonna work on now, but the healer(who is there to use heal and mass heals) is not the one who is supposed to target the monster, but still yes this makes the code faulty and buggy so Im gonna spend more time on this

 

PS I will only fix: SelfBuffs, SelfHeals and any other skill that casts without target

[Trance]

After alot of tests today(becouse i like your idea)

When u get target raidboss/grandraid/monster:

u cant use group heal/chain heal/prayer/servitor heal/AI and alot of buffs which are self...

if you drop chain heal/Buff and MonsterInstance this system will be perfect for raids/epics,big deal that someone will buff him with might or shield,and only group heal and few other skills on target will not work normal.(this is my opinion ofc)

 

Index: java/net/sf/l2j/gameserver/network/clientpackets/RequestMagicSkillUse.java
===================================================================
--- java/net/sf/l2j/gameserver/network/clientpackets/RequestMagicSkillUse.java	(revision 2)
+++ java/net/sf/l2j/gameserver/network/clientpackets/RequestMagicSkillUse.java	(working copy)
@@ -17,7 +17,10 @@
import net.sf.l2j.gameserver.datatables.SkillTable;
import net.sf.l2j.gameserver.model.L2Skill;
+import net.sf.l2j.gameserver.model.actor.instance.L2MonsterInstance;
import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
import net.sf.l2j.gameserver.network.serverpackets.ActionFailed;
@@ -69,6 +72,19 @@
			if (skill.isToggle() && activeChar.isMounted())
				return;

+			if (activeChar.getTarget() instanceof L2MonsterInstance)
+			{
+				switch (skill.getSkillType())
+				{
+					case BUFF:
+						return;
+					case HEAL:
+						return;
+					case HEAL_PERCENT:
+						return;
+				}
+			}
+			
			activeChar.useMagic(skill, _ctrlPressed, _shiftPressed);
		}
		else

[xdem]

Index: java/net/sf/l2j/gameserver/network/clientpackets/RequestMagicSkillUse.java
===================================================================
--- java/net/sf/l2j/gameserver/network/clientpackets/RequestMagicSkillUse.java	(revision 2)
+++ java/net/sf/l2j/gameserver/network/clientpackets/RequestMagicSkillUse.java	(working copy)
@@ -17,7 +17,10 @@
import net.sf.l2j.gameserver.datatables.SkillTable;
import net.sf.l2j.gameserver.model.L2Skill;
+import net.sf.l2j.gameserver.model.actor.instance.L2MonsterInstance;
import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
import net.sf.l2j.gameserver.network.serverpackets.ActionFailed;
@@ -69,6 +72,19 @@
			if (skill.isToggle() && activeChar.is-beep-ted())
				return;

+			if (activeChar.getTarget() instanceof L2MonsterInstance)
+			{
+				switch (skill.getSkillType())
+				{
+					case BUFF:
+						return;
+					case HEAL:
+						return;
+					case HEAL_PERCENT:
+						return;
+				}
+			}
+			
			activeChar.useMagic(skill, _ctrlPressed, _shiftPressed);
		}
		else

I cant see any diffrence tho