Famous Player engine.

[^Wyatt]

if (target.getAccessLevel() > 100)

Shouldn't it be

if (target.getAccessLevel() != 0)

?

 

And you should change it

+if (Config.ANNOUNCE_FAMOUS_PLAYER)
+            Announcements.getInstance().announceToAll("Famous player "+activeChar.getName()+" is currently online");

And check if activechar is famous player, not? (inside the "if" already done)

 

And...

if (player.isFamous())
+			    		{
+			    			player.sendMessage("This guy is already famous player");
+			    			return;
+			    		}

The message shouldn't be... "You are a famous player, you can't vote" ? Coz you're checking "player." not "target." (or change player. for target. and move it down some lines)

 

pd: not tested

[Fanky]

True,thanks.

 

About accesslevel,they can change it depens on their pack ;p

 

[^Wyatt]

Np, the rest seems to be fine, good share.

 

[Fanky]

Np, the rest seems to be fine, good share.

 

thanks.

[lowrider88]

Hi i am trying to make this work for my server i am using Hi Five L2J and every thing i added i had no errors, but when i made the L2FamousPlayerInstance.java i pasted the codes and made it to work for my server, but i still have 26 errors:

 

 

/*
* This program is free software: you can redistribute it and/or modify it under
* the terms of the GNU General Public License as published by the Free Software
* Foundation, either version 3 of the License, or (at your option) any later
* version.
* 
* This program is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
* FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
* details.
* 
* You should have received a copy of the GNU General Public License along with
* this program. If not, see <http://www.gnu.org/licenses/>.
*/
package com.l2jserver.gameserver.model.actor.instance;

import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.SQLException;
import java.util.List;
import java.util.StringTokenizer;

import javolution.util.FastList;

import com.l2jserver.Config;
import com.l2jserver.L2DatabaseFactory;
import com.l2jserver.gameserver.Announcements;
import com.l2jserver.gameserver.model.L2World;
import com.l2jserver.gameserver.model.actor.templates.L2NpcTemplate;

/**
* @author fanky
*
*/
public class L2FamousPlayerInstance extends L2NpcInstance
{


/**
* @param objectId
* @param template
*/
public L2FamousPlayerInstance(int objectId, L2NpcTemplate template)
{
	super(objectId, template);
}

public void onByPassFeedBack(L2PcInstance player,String command)
{
	if (command.startsWith("voteFamousPlayer"))
		    	{
		    		String val = command.substring(14);
		    		StringTokenizer st = new StringTokenizer(val);
		    		
		    		if(st.countTokens() != 1)
		    		{
		    			return;
		    		}
		    		
		    		if (player.getFamousPlayer() != null)
		    		{
		    			player.sendMessage("You have already voted for a player, "player.getFamousPlayer()".");
		    			return;
		    		}
		    		if (player.isFamous())
		    		{
		    			player.sendMessage("You are famous player,u cant vote");
		    			return;
		    		}
		    		L2PcInstance target = L2World.getInstance().getPlayer(st.nextToken());
		    		
		    		if (target == null)
		    		{
		    			player.sendMessage("There isn't such character");
		    			return;
		    		}
		    		if (target.getAccessLevel() > 100)
		    		{
		    			player.sendMessage("Admins and gms don't need to become famous,they already are :P");
		    			return;
		    		}			    		
		    		if (target.getPvpKills() > Config.PVP_REQUIRED_TO_VOTE)
		    		{
		    						
		    		target.setFamousPlayerVotes(target.getFamousPlayerVotes()1);
		    		player.sendMessage("You have successfully voted for "target.getName()".");
		    		target.sendMessage(player.getName()" has voted for you to be a famous player,you currently have "target.getFamousPlayerVotes()" votes");
		    		if (target.getFamousPlayerVotes() == Config.VOTES_REQUIRED_TO_BECOME_FAMOUS)
		    		{
		    			target.setFamous(true);
		    			Announcements.getInstance().announceToAll(target.getName()" has become Famous Player because he reached "Config.VOTES_REQUIRED_TO_BECOME_FAMOUS" vote");
		    			target.setFamousPlayerVotes(0);
		    			cleanDatabase(target.getName());
		    			target.sendMessage("You've become Famous player.");
		    		}
		    		else
		    		{
		    			target.sendMessage("You need at least "Config.PVP_REQUIRED_TO_VOTE" pvp(s) in order to vote");
		    		}
		    	}
		    }
		}
		    
		    private void cleanDatabase(String pname)
		    {
		    	Connection con = null;
		    	try
		    	{
		    		con = L2DatabaseFactory.getInstance().getConnection();
		    		PreparedStatement st = con.prepareStatement("UPDATE characters SET famousplayer=null WHERE famousplayer="pname);
		    		st.execute();
		    		st.close();
		    	}
		    	catch (SQLException sqle)
		    	{
		    		for (L2PcInstance gmchat : L2World.getInstance().getAllGMs())
		    		{
		    			gmchat.sendMessage("There was a problem while updating database on famousplayer column,Noobs!");
		    		}
		    	}
		    	finally
		    	{
		    		try
		    		{
		    			con.close();
		    		}
		    		catch (SQLException sqle2)
		    		{ 
		    			
		    		}
		    	}
		    }
		    
		    @Override
			public String getHtmlPath(int npcId, int val)
		    {
		        String pom = "";
		        if (val == 0)
		        {
		            pom = ""  npcId;
		        }
		        else
		        {
		            pom = npcId  "-"  val;
		        }

		        return "data/html/famousplayer/"  pom  ".htm";
		    }	
}

 

 

Here are the errors, what can i do to fix this thanks so much

 

 

Description	Resource	Path	Location	Type
Syntax error, insert ")" to complete MethodInvocation	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 62	Java Problem
Syntax error, insert ";" to complete BlockStatements	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 62	Java Problem
The operator > is undefined for the argument type(s) L2AccessLevel, int	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 77	Java Problem
Syntax error on token "1", delete this token	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 85	Java Problem
The method getFamousPlayer() in the type L2PcInstance is not applicable for the arguments (String)	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 62	Java Problem
Syntax error on token ")", delete this token	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 62	Java Problem
Syntax error on token "PVP_REQUIRED_TO_VOTE", ( expected after this token	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 98	Java Problem
The method PVP_REQUIRED_TO_VOTE(String) is undefined for the type Config	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 98	Java Problem
Syntax error on token "pname", delete this token	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 110	Java Problem
Syntax error on token "npcId", delete this token	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 140	Java Problem
Syntax error on token "" has become Famous Player because he reached "", [ expected	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 91	Java Problem
Syntax error on token "" vote"", ] expected	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 91	Java Problem
Syntax error, insert ")" to complete MethodInvocation	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 98	Java Problem
Syntax error, insert ";" to complete BlockStatements	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 98	Java Problem
The type of the expression must be an array type but it resolved to String	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 87	Java Problem
Syntax error on token "" has voted for you to be a famous player,you currently have "", [ expected	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 87	Java Problem
Syntax error on token "" votes"", ] expected	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 87	Java Problem
The type of the expression must be an array type but it resolved to String	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 91	Java Problem
Syntax error, insert ")" to complete MethodInvocation	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 86	Java Problem
Syntax error, insert ";" to complete Statement	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 86	Java Problem
The method getName() in the type L2Object is not applicable for the arguments (String)	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 86	Java Problem
Syntax error on token ")", delete this token	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 86	Java Problem
Syntax error on token ""-"", . expected	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 144	Java Problem
The primitive type int of npcId does not have a field val	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 144	Java Problem
Syntax error on token "pom", invalid AssignmentOperator	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 147	Java Problem
The left-hand side of an assignment must be a variable	L2FamousPlayerInstance.java	/L2J_Server/java/com/l2jserver/gameserver/model/actor/instance	line 147	Java Problem

[Fanky]

You haven't add most of the tokens,check it.

[Absolute®]

cool share mate

keep up :)

[~~Darius~~]

i try making it on H5 server (clean Pack) in code i dont have any errors  but in gs i have that error:

http://s6.ifotos.pl/img/Przechwyt_xhqaqhw.PNG

and here is code :

http://pastebin.com/FRwyBYdY [DP]

http://pastebin.com/mzKMjJGg [GS]

[DescJa]

It should work.

I coded from scrath,dunno if i miss something >.> but seems that I didnt.

whatever,just report it here if it doesn't workin' properly.

Check again your code....

nice idea ;)

[JaharakaL]

can u remake the code for l2jfrozen? :D please T.T

Well fanky cant code it for L2JFrozen cause he study for university if i remember well.

[xdem]

Well fanky cant code it for L2JFrozen cause he study for university if i remember well.

 

why u spam? u could send that via PM

[Fanky]

bump to this.I want to know if someone tested this..

 

can someone give me a feedback..?

[marwan]

bump to this.I want to know if someone tested this..

 

can someone give me a feedback..?

why you put this method in PcInstance ?

 

+	public String getFamousPlayer()
+	{
+		    return famousplayer;
+	}

[Fanky]

why you put this method in PcInstance ?

 

+	public String getFamousPlayer()
+	{
+		    return famousplayer;
+	}

so it can be safely accessed, if anyone wanted so

[Fanky]

i will test :)  thx for the share

Thank you,and if you want,feedback me please.