[HELP] Castle Control Announce During Siege

[Revolver]

Hello Devs of Maxcheaters,

 

I've came to this topic after a long-term period of trying to solve this problem.

I want when a Clan takes a Castle during siege,to be announced to all players.

Using the method that i've already used to announce when Siege starts,stops & when clan registers for Attack / Defend,i've tryed to use the same code.

 

This is the code:

Announcements.getInstance().announceToAll(""+player.getClan().getName()+" has taken "+getCastle().getName()+" Castle.");

 

This is the error:

 

But when using the same code for the other lines,it works perfect.

 

Any ideas?

 

Thanks in advance,

 

- Revo

[Revolver]

I am still at the first steps of Java...

Could you give me a hand? I don't know how to place a loop.

[Intrepid]

I am still at the first steps of Java...

Could you give me a hand? I don't know how to place a loop.

 

for (L2PcInstance player : L2World.getInstance().getAllPlayers().values())

{

your code aka the announcement

}

[Revolver]

Thanks for the code,but check this error out:

 

 

Any help?

 

Thanks

[Intrepid]

Thanks for the code,but check this error out:

 

 

Any help?

 

Thanks

 

import L2World check the quick fix menu on hover of the text

[Revolver]

Intrepid,

 

Thanks for all of your help.

I was trying to fix this here and 5 days but i couldn't.

This is the result of your help.

 

 

But why is it announced 3 times?

 

This is the code:

 

Thanks very much,

 

- Rev

 

[Intrepid]

Intrepid,

 

Thanks for all of your help.

I was trying to fix this here and 5 days but i couldn't.

This is the result of your help.

 

 

But why is it announced 3 times?

 

This is the code:

 

Thanks very much,

 

- Rev

 

 

prolly its called 3 times in different methods but i dont know i dont use l2j i dont know their siege system :S

[Revolver]

I've moved the code to the bottom of this code and now it shows it twice.

 

 

The 1st announcement,is for the clan that takes the Castle.

The 2nd announcement,is for the clan that loses the Castle.

 

But there is only 1 line that triggers the announcement.

 

 

[Revolver]

Bump

[Tryskell]

When you did your tests there were 3 ppls online, then 2 in second test.

 

Spoiler of this awesome logic : Why I can say that ? Basically, for each online player, it sends an announce. You know the next...

 

-------

 

You didn't say you had error - well I didn't check well the image - but what I said was true :P.

 

You have to make the player/clan variable "fly" from one method to another.

 

 

   public void midVictory(String clanName)
   {
       if (getIsInProgress()) // Siege still in progress
       {
           // Announce
           Announcements.getInstance().announceToAll(clanName+" has taken "+getCastle().getName()+" Castle.");

           if (getCastle().getOwnerId() > 0) 
           	_siegeGuardManager.removeMercs(); // Remove all merc entry from db

           // If defender doesn't exist (Pc vs Npc) and only 1 attacker

 

And considering the use of this method (only 2) :

 

getSiege().midVictory(clan.getName());

 

Dunno if it's the best solution, but it's the easiest for sure, considering what you want to do.

[Revolver]

I have no problem to work, but as i said i am really newbie with Java.

Here and a few weeks i am studying with a teacher Java,i am testing things with Eclipse but i'm not there yet.

Could you please help me a bit with coding?

 

Thanks in advance

- Rev

[Tryskell]

I have no problem to work, but as i said i am really newbie with Java.

Here and a few weeks i am studying with a teacher Java,i am testing things with Eclipse but i'm not there yet.

Could you please help me a bit with coding?

 

Thanks in advance

- Rev

 

I gave you the whole solution, the only thing I was talking about being lazy was the diff patch.As I like to say, giving you a fish won't help you, when a fishrod could stop your hungry :).

 

All is supposed to work, just use CTRL+H (search function) in order to find good places. You know already 1 place, you have to search for the 2 last (must be siegemanager, siege and castle).

 

You can c/p the code I make, it works whatever is your chronicle/pack normally.

 

I removed sentence in last post which could make think it wasn't complete code.

 

Regards, Tk.