[Help] Action Shift for L2PcInstance

[Howl3r]

Well i am trying to make an action Shift to get stats from Characters for non Gm Char.

What i mean a normal char press shift and click on other or himself

but is not working (with gm is working).

This is my Code:

/**
* 
*/
package handlers.actionhandlers;

import com.l2jserver.gameserver.handler.IActionHandler;
import com.l2jserver.gameserver.model.L2Object;
import com.l2jserver.gameserver.model.L2Object.InstanceType;
import com.l2jserver.gameserver.model.actor.L2Character;
import com.l2jserver.gameserver.model.actor.instance.L2PcInstance;
import com.l2jserver.gameserver.network.serverpackets.MyTargetSelected;
import com.l2jserver.gameserver.network.serverpackets.NpcHtmlMessage;
import com.l2jserver.gameserver.network.serverpackets.StatusUpdate;
import com.l2jserver.gameserver.skills.BaseStats;
import com.l2jserver.gameserver.skills.Stats;
import com.l2jserver.util.StringUtil;

/**
* @author Howler
*
*/
public class L2FactionActionShift implements IActionHandler
{
@Override
public boolean action(L2PcInstance activeChar, L2Object target, boolean interact)
{
	// Set the target of the L2PcInstance activeChar
	activeChar.setTarget(target);

	// Send a Server->Client packet MyTargetSelected to the L2PcInstance activeChar
	// The activeChar.getLevel() - getLevel() permit to display the correct color in the select window
	MyTargetSelected my = new MyTargetSelected(target.getObjectId(), 0);
	activeChar.sendPacket(my);

	L2PcInstance target = (L2PcInstance) activeChar.getTarget();
		String htmFile = "data/html/mods/Faction/userinfo.htm";
		String htmContent = HtmCache.getInstance().getHtm(htmFile);
		if (htmContent != null)
		{
			NpcHtmlMessage showHtml = new NpcHtmlMessage(1);
			showHtml.setHtml(htmContent);
			showHtml.replace("%name%", target.getName());
			if (target.isTeam1Member())
				showHtml.replace("%faction%", "<font color=\""+Config.FACTION_TEAM1_NAME_COLOR+"\">"+Config.FACTION_TEAM1_NAME+"</font>");
			else if (target.isTeam2Member())
				showHtml.replace("%faction%", "<font color=\""+Config.FACTION_TEAM2_NAME_COLOR+"\">"+Config.FACTION_TEAM2_NAME+"</font>");
			else
				showHtml.replace("%faction%", "None");
			showHtml.replace("%spree%", Integer.toString(target.getTopKillRow()));
			showHtml.replace("%facpot%", Integer.toString(target.getFactionPoints()));
			showHtml.replace("%pvp%", Integer.toString(target.getPvpKills()));
			activeChar.sendPacket(showHtml);
		}
	return true;
}

/* (non-Javadoc)
 * @see com.l2jserver.gameserver.handler.IActionHandler#getInstanceType()
 */
@Override
public InstanceType getInstanceType()
{
	return InstanceType.L2Playable;
}

}

[Tryskell]

I don't get why you delete the GM stuff, because it will make your code FAR simplier.

 

if GM
   GM code
else
   others guys

 

After that, you recopy in the "other guys" this part of code about target check

			// Check if the guy already target this l2pcinstance
		if (activeChar.getTarget() != target)
		{
			// Set the target of the L2PcInstance activeChar
			activeChar.setTarget(target);

			// Send a Server->Client packet MyTargetSelected to the L2PcInstance activeChar
			activeChar.sendPacket(new MyTargetSelected(target.getObjectId(), 0));
		}

		// Send a Server->Client packet ValidateLocation to correct the L2PcInstance position and heading on the client
		if (activeChar != target)
			activeChar.sendPacket(new ValidateLocation((L2Character)target));

And you complete with your code below...

[Howl3r]

You didn't understand i try it in the L2PcInstanceActionShift but only the gm part was working.

	public boolean action(L2PcInstance activeChar, L2Object target, boolean interact)
{
	if (activeChar.isGM())
	{
		// Check if the gm already target this l2pcinstance
		if (activeChar.getTarget() != target)
		{
			// Set the target of the L2PcInstance activeChar
			activeChar.setTarget(target);

			// Send a Server->Client packet MyTargetSelected to the L2PcInstance activeChar
			activeChar.sendPacket(new MyTargetSelected(target.getObjectId(), 0));
		}

		// Send a Server->Client packet ValidateLocation to correct the L2PcInstance position and heading on the client
		if (activeChar != target)
			activeChar.sendPacket(new ValidateLocation((L2Character)target));

		IAdminCommandHandler ach = AdminCommandHandler.getInstance().getAdminCommandHandler("admin_character_info");
		if (ach != null)
			ach.useAdminCommand("admin_character_info " + target.getName(), activeChar);
	}
	else
	{
		activeChar.setTarget(target);

		activeChar.sendPacket(new MyTargetSelected(target.getObjectId(), 0));

		String htmFile = "data/html/mods/Faction/userinfo.htm";
		String htmContent = HtmCache.getInstance().getHtm(htmFile);
		if (htmContent != null)
		{
			NpcHtmlMessage showHtml = new NpcHtmlMessage(1);
			showHtml.setHtml(htmContent);
			showHtml.replace("%name%", target.getName());
			if (((L2PcInstance)target).isTeam1Member())
				showHtml.replace("%faction%", "<font color=\""+Config.FACTION_TEAM1_NAME_COLOR+"\">"+Config.FACTION_TEAM1_NAME+"</font>");
			else if (((L2PcInstance)target).isTeam2Member())
				showHtml.replace("%faction%", "<font color=\""+Config.FACTION_TEAM2_NAME_COLOR+"\">"+Config.FACTION_TEAM2_NAME+"</font>");
			else
				showHtml.replace("%faction%", "None");
			showHtml.replace("%spree%", Integer.toString(((L2PcInstance)target).getTopKillRow()));
			showHtml.replace("%facpot%", Integer.toString(((L2PcInstance)target).getFactionPoints()));
			showHtml.replace("%pvp%", Integer.toString(((L2PcInstance)target).getPvpKills()));
			activeChar.sendPacket(showHtml);
		}
	}
	return true;
}

Still not working.

[Tryskell]

I have misread factionholder, my bad.

 

Try replace the gm stuff in L2PcInstance for your html part. As Gm is working you will know if it comes form the structure of handler itself OR about what you try to call.

 

So basically try as a GM to call the faction window. If it works, it's because of missing "targetting stuff" in your factionholder.

[Howl3r]

I put a test message to say when i use shift and player i change the InstanceType to L2Npc and i targeted a npc and the test message appear. But when is L2PcInstance only gm can do it.

[Tryskell]

On L2PcInstanceActionShift :

 

public boolean action(L2PcInstance activeChar, L2Object target, boolean interact)
{
	// Check if the player already target this l2pcinstance
	if (activeChar.getTarget() != target)
	{
		// Set the target of the L2PcInstance activeChar
		activeChar.setTarget(target);

		// Send a Server->Client packet MyTargetSelected to the L2PcInstance activeChar
		activeChar.sendPacket(new MyTargetSelected(target.getObjectId(), 0));
	}

	// Send a Server->Client packet ValidateLocation to correct the L2PcInstance position and heading on the client
	if (activeChar != target)
		activeChar.sendPacket(new ValidateLocation((L2Character)target));

	if (activeChar.isGM())
	{
		IAdminCommandHandler ach = AdminCommandHandler.getInstance().getAdminCommandHandler("admin_character_info");
		if (ach != null)
			ach.useAdminCommand("admin_character_info " + target.getName(), activeChar);
	}
	else
		activeChar.sendMessage(target.getName() + " is a noob.");

	return true;
}

 

If that compile fine but don't work, consider there are somewhere restrictions.

 

I moved the target check out of the GM one, because shift is both for players and GMs now. So keeping old structure will be redundant (must add x2 the same check both for players and GMs).

 

If you can see a message with the target name, replace the message by your html. Btw, your html format is really strange. Check the NPC action shift one to see how they form it. Wel it's fine it if works like you did, but just use conventions they use :p.

[Howl3r]

Compile fine but don't work ither. i search for restriction but i didn't find anything.

[Tryskell]

I learnt the existence of actionShift with your thread (I dev only on IL), so I miss of study :).

 

Anyway, it can only be some sort of restrictions. I don't know what is the actual accesslevel system in L2J, but in IL there was something like that. As you got only this problem with GMs, it can be related to "basic" accesslevel system.

 

We eliminated all eventual problems :

- the target check is the GM one, so normally works.

- the html part have been replaced by a simple sendMessage.

 

So basically, it can only be a shift restriction :).