[HELP] NPE Error With Hitman Event of Setekh

[Stefoulis15]

Well , I've tried to adapt Hitman Event From Gracia Final to Interlude without any problem.

i compiled my serverpack and then i logged in to test it, i set the bounty to my 2nd char successfully , but when i tried to kill my 2nd char with my 1st char i get an NPE Error on my gs console, and IG i get no adena reward and no msg that my target was assasinated or sth.

i tried a lot of things but nothing worked.

 

something that might help :

 

NPE error on gs ( ffs ) : java.lang.NullPointerException

 

Error on .log file : 2010.06.29 13:14:44,390 SEVERE 13 net.sf.l2j.gameserver.model.L2Character java.lang.NullPointerException

 

[Intrepid]

i got errors when i do it like this ..

 

 

but still you never cast something to itself...if you have errors its because of the whole onDeath metho in the hitman is wrong and need to be changed

[Stefoulis15]

but still you never cast something to itself...if you have errors its because of the whole onDeath metho in the hitman is wrong and need to be changed

 

thats what i said before, that i got errors in onDeath method with ur way and u just came like oh i will rape you! chillout. i just need freaking help

[Intrepid]

thats what i said before, that i got errors in onDeath method with ur way and u just came like oh i will rape you! chillout. i just need freaking help

 

well than change the method and make the killer L2Character

[Stefoulis15]

well than change the method and make the killer L2Character

 

yes i did it..and i got errors

on killer.addadena

and also killer.sendMessage

 

[Intrepid]

yes i did it..and i got errors

on killer.addadena

and also killer.sendMessage

 

 

ok but whats the error

[Stefoulis15]

The method sendMessage(String) is undefined for the type L2Character

 

The method addAdena(String, int, L2PcInstance, boolean) is undefined for the type L2Character

 

 

[Intrepid]

instead of addAdena use addItem for killer and cast it to L2PcInstance for sendMessage its defined for both l2PcInstance and L2Character so i dont know about that

[Coyote™]

c/p onDeath, in the way you've made it.

[Tryskell]

I adapted it on L2J archid (the old free one), and all is working fine, except some errors than I didn't agree with (guards kill you, you're still under bounty but the guy receive a msg like you are dead and there is no more bounty on you), but I corrected it.

 

All is working fine, I suppose you missed something.

 

			if(Config.ALLOW_HITMAN_GDE)
			Hitman.getInstance().onDeath(pk, this);

 

got it on the doDie of L2PcInstance. L2Character doDie isn't used.

 

onDeath isn't supposed to be changed, it's called from hitman.java (model/entity/...). Here it is (modded) :

 

	public void onDeath(L2PcInstance assassin, L2PcInstance target)
{
	if(_targets.containsKey(target.getObjectId()))
	{
		PlayerToAssasinate pta = _targets.get(target.getObjectId());
		String name= getOfflineData(null, pta.getClientId())[1];
		L2PcInstance client = L2World.getInstance().getPlayer(name);

		target.sendMessage("You have been assassinated. You haven't any bounties on your head now.");

		if(client != null)
		{
			client.sendMessage("Your request to kill "+target.getName()+" has been fulfilled.");
			client.setHitmanTarget(0);
		}

		assassin.sendMessage("You assassinated "+target.getName()+", his bounty will be converted in adena !");
		assassin.addAdena("Hitman", pta.getBounty(), target, true);
		removeTarget(pta.getObjectId(), true);
	}
}

 

addAdena is used on many others .java (under IL anyway), and written in L2PcInstance. It's why you got addAdena erros, when you try to change to L2Character.

 

Btw, why to change on L2Character ? The finality is to kill a player, so... L2PcInstance. I agree the killer haven't to be a L2PcInstance, as there is summons too.

 

Just give a decent error ^_^", with non modified code.

[Nilinking]

Can someone please post the code? the link from the setekh's post is broken!, tnx in advance