Jump to content

Recommended Posts

Posted

You can understand what is this from the title. I need some feedback.

Index: java/net/sf/l2j/Config.java
===================================================================
--- java/net/sf/l2j/Config.java	(revision 4092)
+++ java/net/sf/l2j/Config.java	(working copy)
@@ -881,6 +881,17 @@
     public static boolean L2JMOD_WEDDING_SAMESEX;
     public static boolean L2JMOD_WEDDING_FORMALWEAR;
     public static int L2JMOD_WEDDING_DIVORCE_COSTS;
+    
+    public static boolean PVP_TITLE_COLOUR_SYSTEM;
+    public static int TITLE_COLOUR_FOR_100_PVP;
+    public static int TITLE_COLOUR_FOR_200_PVP;
+    public static int TITLE_COLOUR_FOR_300_PVP;
+    public static int TITLE_COLOUR_FOR_400_PVP;
+    public static int TITLE_COLOUR_FOR_500_PVP;
+    public static boolean PK_TITLE_COLOUR_SYSTEM;
+    public static int TITLE_COLOUR_FOR_100_PK;
+    public static int TITLE_COLOUR_FOR_200_PK;
+    public static int TITLE_COLOUR_FOR_300_PK;
+    public static int TITLE_COLOUR_FOR_400_PK;
+    public static int TITLE_COLOUR_FOR_500_PK;

     // Packet information
     /** Count the amount of packets per minute ? */
@@ -1858,6 +1869,17 @@
                 L2JMOD_WEDDING_SAMESEX                  = Boolean.parseBoolean(L2JModSettings.getProperty("WeddingAllowSameSex", "False"));
                 L2JMOD_WEDDING_FORMALWEAR               = Boolean.parseBoolean(L2JModSettings.getProperty("WeddingFormalWear", "True"));
                 L2JMOD_WEDDING_DIVORCE_COSTS            = Integer.parseInt(L2JModSettings.getProperty("WeddingDivorceCosts", "20"));
+                
+                PVP_TITLE_COLOUR_SYSTEM = Boolean.parseBoolean(L2JModSettings.getProperty("Enable= True, Disable= False", "False"));
+                TITLE_COLOUR_FOR_100_PVP = Integer.decode("0x" + L2JModSettings.getProperty("TitleColourFor100PvP", "FFFFFF"));
+                TITLE_COLOUR_FOR_200_PVP = Integer.decode("0x" + L2JModSettings.getProperty("TitleColourFor200PvP", "FFFFFF"));
+                TITLE_COLOUR_FOR_300_PVP = Integer.decode("0x" + L2JModSettings.getProperty("TitleColourFor300PvP", "FFFFFF"));
+                TITLE_COLOUR_FOR_400_PVP = Integer.decode("0x" + L2JModSettings.getProperty("TitleColourFor400PvP", "FFFFFF"));
+                TITLE_COLOUR_FOR_500_PVP = Integer.decode("0x" + L2JModSettings.getProperty("TitleColourFor500PvP", "FFFFFF"));
+                PK_TITLE_COLOUR_SYSTEM = Boolean.parseBoolean(L2JModSettings.getProperty("Enable= True, Disable= False", "False"));
+                TITLE_COLOUR_FOR_100_PK = Integer.decode("0x" + L2JModSettings.getProperty("TitleColourFor100PK", "FFFFFF"));
+                TITLE_COLOUR_FOR_200_PK = Integer.decode("0x" + L2JModSettings.getProperty("TitleColourFor200PK", "FFFFFF"));
+                TITLE_COLOUR_FOR_300_PK = Integer.decode("0x" + L2JModSettings.getProperty("TitleColourFor300PK", "FFFFFF"));
+                TITLE_COLOUR_FOR_400_PK = Integer.decode("0x" + L2JModSettings.getProperty("TitleColourFor400PK", "FFFFFF"));
+                TITLE_COLOUR_FOR_500_PK = Integer.decode("0x" + L2JModSettings.getProperty("TitleColourFor500PK", "FFFFFF"));

                 if (TVT_EVENT_PARTICIPATION_NPC_ID == 0)
                 {
Index: java/config/l2jmods.properties
===================================================================
--- java/config/l2jmods.properties	(revision 4092)
+++ java/config/l2jmods.properties	(working copy)
@@ -132,3 +132,40 @@
# ex.: 1;2;3;4;5;6
# no ";" at the start or end
TvTEventDoorsCloseOpenOnStartEnd =
+
+#<----------------------------->
+# PvP/PK Title Colour System                                                 
+#<----------------------------->
+# Enable= True, Disable= False
+# Default: False
+PvPTitleColourSystem = False
+
+# @ 100 PvP
+TitleColourFor100PvP = FFFFFF
+
+# @ 200 PvP
+TitleColourFor200PvP = FFFFFF
+
+# @ 300 PvP
+TitleColourFor300PvP = FFFFFF
+
+# @ 400 PvP
+TitleColourFor400PvP = FFFFFF
+
+# @ 500 PvP
+TitleColourFor500PvP = FFFFFF
+
+# Enable= True, Disable= False
+# Default: False
+PKTitleColourSystem = False
+
+# @ 100 PK
+TitleColourFor100PK = FFFFFF
+
+# @ 200 PK
+TitleColourFor200PK = FFFFFF
+
+# @ 300 PK
+TitleColourFor300PK = FFFFFF
+
+# @ 400 PK
+TitleColourFor400PK = FFFFFF
+
+# @ 500 PK
+TitleColourFor500PK = FFFFFF
Index: java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java
===================================================================
--- java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java	(revision 4092)
+++ java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java	(working copy)
@@ -174,6 +174,51 @@
             engage(activeChar);
             notifyPartner(activeChar,activeChar.getPartnerId());
         }
+        
+        // PvP Title Colour System - By Rozdex
+        
+        if (Config.PVP_TITLE_COLOUR_SYSTEM)
+        {
+        	if (activeChar.getPvpKills()>= 100)
+        	{
+        		activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_100_PVP);
+        	}
+        	else if (activeChar.getPvpKills()>= 200)
+        	{
+        		activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_200_PVP);
+        	}
+        	else if (activeChar.getPvpKills()>= 300)
+        	{
+        		activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_300_PVP);
+        	}
+        	else if (activeChar.getPvpKills()>= 400)
+        	{
+        		activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_400_PVP);
+        	}
+               else if (activeChar.getPvpKills()>= 500)
+        	{
+        		activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_500_PVP);
+        	}
+        }
+        	
+        // PK Title Colour System - By Rozdex
+        	
+        if (Config.PK_TITLE_COLOUR_SYSTEM)
+        {
+        	if (activeChar.getPkKills()>= 100)
+        	{
+        		activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_100_PK);
+        	}
+        	else if (activeChar.getPkKills()>= 200)
+        	{
+        		activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_200_PK);
+        	}
+        	else if (activeChar.getPkKills()>= 300)
+        	{
+        		activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_300_PK);
+        	}
+        	else if (activeChar.getPkKills()>= 400)
+        	{
+        		activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_400_PK);
+        	}
+        	else if (activeChar.getPkKills()>= 500)
+        	{
+        		activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_500_PK);
+        	}
+        }
+        

         if (activeChar.getAllEffects() != null)
         {

Credits: Me

Posted

LOL :) And the funny part is that this script is wrong. Check this for example:

 

Say you have 500 PVP.

 

if (activeChar.getPvpKills()>= 100) // 500 >= 100 so it will give the title color for 100 pvp.

+         {

+         activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_100_PVP);

+         }

+         else if (activeChar.getPvpKills()>= 200)

+         {

+         activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_200_PVP);

+         }

Posted

1) Should be made on PcInstance too. Like that, you need to rr every time you make the record.

2) It is sooooooooooooo badly coded. In this way, the colours will be screwed up. Because the checks you have set are not enough.

What do I mean? Look.

 

if (activeChar.getPkKills()>= 100)
+        	{
+        		activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_100_PK);
+        	}
+        	else if (activeChar.getPkKills()>= 200)
+        	{
+        		activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_200_PK);
+        	}

 

Let's take number 300. It is higher than both: 200 and 100.

So, the player should somehow get both colours. But since this can't happen there will be a huge mess.

How to fix it?

 

if (activeChar.getPkKills()>= 100 && activeChar.getPkKills() < 200)
+        	{
+        		activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_100_PK);
+        	}
+        	else if (activeChar.getPkKills()>= 200 && activeChar.getPkKills() < 300)
+        	{
+        		activeChar.getAppearance().setTitleColor(Config.TITLE_COLOUR_FOR_200_PK);
+        	}

 

and so on.

 

3) Already shared, from VaGo (Credits to sauron).

http://www.maxcheaters.com/forum/index.php?topic=25237.0

Guest
This topic is now closed to further replies.


×
×
  • Create New...