Help Acis Casting Speed caltulation.

[devil12pl]

Hi, I'm learning java and trying to edit things, add things etc. I can't manage one problem. I'm editing public int getMAtkSpd() in CharStat.java but it doesn't change antything.

public int getMAtk(L2Character target, L2Skill skill)
	{
		return 500;
	}


public int getMAtkSpd()
	{
		return 500;
	}

I works for m atack, but doesn't work for casting speed. Any ideas?

[Tryskell]

Not sure if you know, but

getMAtkSpd()

 is currently overriden numerous time, depending about the actor. PlayerStat refers to player stats, PetStat refers to pets, etc. If you edit the value on, let's say, CreatureStat, then you have to be sure PlayerStat isn't completely overriding it.

 

It's called inheritance, even if CreatureStat is the mother class of PlayerStat, PlayerStat must be edited OR must refer to mother class using :

 

super.getMatkSpd();

PS : CreatureStat is the new name of CharStat.

 

Correctly used, override is a strong tool, allowing some classes to do specific things compared to others. If you see a lot of instanceof checks, it's generally a "bad" use of overriding and inheritance.

Edited July 8, 2018 by Tryskell

[Rootware]

/aCis_gameserver/java/net/sf/l2j/gameserver/skills/Formulas.java

 

[devil12pl]

Found this:

	public static final int calcAtkSpd(L2Character attacker, L2Skill skill, double skillTime)
	{
		if (skill.isMagic())
			return (int) (skillTime * 333 / attacker.getMAtkSpd());
		
		return (int) (skillTime * 333 / attacker.getPAtkSpd());
	}

But it refers to CharStat.java to getMatkSpd. But when I changed getMatkSpd to always return 500 there was no effect. Can you explain it to me like to a child please? :D

I don't get it. Magic attack is fixed at 500 but casting speed isn't.

Edited July 8, 2018 by devil12pl

[devil12pl]

Thanks Tryskell, you explained it to me. Always wanted to learn Java. Java itself isnt that hard. Harder for me is getting to know all the Acis/lineage2 way of coding. Ill be greatful for any tips :D

Edited July 9, 2018 by devil12pl

[Syrus]

its hard to give any tips, you need to learn the structure yourself by reviewing the code and what it refers to, taking in mind name of the file which usually suggests what it belongs to

to write a full manual on what belongs where or whats responsible for what in acis, or any other pack, would be too time consuming

 

btw, what exactly did you change to 500? whole formula? or just getmatkspd

 

and also, it needs to have an effect unless you didn't update your server, note how that function works and where it is used

 

creature.java:

private void beginCast(L2Skill skill, boolean simultaneously, Creature target, WorldObject[] targets)
(...)
		// Calculate the casting time of the skill (base + modifier of MAtkSpd)
		// Don't modify the skill time for FUSION skills. The skill time for those skills represent the buff time.
		if (!effectWhileCasting)
		{
			hitTime = Formulas.calcAtkSpd(this, skill, hitTime);
			if (coolTime > 0)
				coolTime = Formulas.calcAtkSpd(this, skill, coolTime);
		}

so, when creature (including players) begin cast, and as the guide says, hitTime of a skill refers to formulas.java to calcAtkSpd, so if you modify it, it has to return a value of your choosing

 

 

[devil12pl]

Already managed the problem And it works like a charm. And about learning Java for acis I really dont know how to start. There Are soooooo many things :P