Jump to content

Question

Posted (edited)

Hi Developers...i add buffer in my server..and i get some error at line 

st.setState(STARTED)

(i use l2jserver - High Five)

here it`s error

http://DqTXjfN.jpg

And here it`s java code for buffer

def onTalk (self,npc,player):
	   st = player.getQuestState(qn)
	   htmltext = "<html><head><body>I have nothing to say to you</body></html>"
	   st.setState(STARTED)
	   return InitialHtml

Thank's.

Edited by criss22

Recommended Posts

  • 0
Posted

It's not Java, just python :p

 

If you have other .py files in you pack, check the line, it could be different, like setState(State.STARTED) for example. 

  • 0
Posted (edited)

Solomun, I appreciate your help...but i get some errors in GameServer. Check this.

1. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 32)
        import com.l2jserver.L2DatabaseFactory;
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The import com.l2jserver.L2DatabaseFactory cannot be resolved
----------
2. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 286)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
3. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 362)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
4. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 382)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
5. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 402)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
6. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 426)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
7. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 448)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
8. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 474)
        st.playSound("ItemSound3.sys_shortage");
           ^^^^^^^^^
The method playSound(IAudio) in the type QuestState is not applicable for the ar
guments (String)
----------
9. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 520)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
10. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 541)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
11. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 582)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
12. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 729)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
13. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 764)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
14. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 934)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
15. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1065)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
16. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1085)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
17. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1150)
        System.out.println(getScriptName() + "#onAdvEvent('" + event + "'," + (n
pc == null ? "NULL" : npc.getId() + npc.getName()) + "," + (player == null ? "NU
LL" : player.getName()) + ")");
                           ^^^^^^^^^^^^^
The method getScriptName() is undefined for the type NpcBuffer
----------
18. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1229)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
19. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1245)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
20. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1285)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
21. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1317)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
22. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1496)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
23. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1676)
        if (st.getQuestItemsCount(skill.getItemConsumeId()) < skill.getItemConsu
me())
                                                                    ^^^^^^^^^^^^
^^
The method getItemConsume() is undefined for the type Skill
----------
24. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1678)
        return showText(st, "Sorry", "You don't have the enough items:<br>You ne
ed: <font color=LEVEL>" + skill.getItemConsume() + " " + getItemNameHtml(st, ski
ll.getItemConsumeId()) + "!", false, "0", "0");

                                ^^^^^^^^^^^^^^
The method getItemConsume() is undefined for the type Skill
----------
25. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1763)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
26. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1794)
        try (Connection con = L2DatabaseFactory.getInstance().getConnection())
                              ^^^^^^^^^^^^^^^^^
L2DatabaseFactory cannot be resolved
----------
26 problems (26 errors)
The import com.l2jserver.L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
The method playSound(com.l2jserver.gameserver.enums.audio.IAudio) in the type co
m.l2jserver.gameserver.model.quest.QuestState is not applicable for the argument
s (java.lang.String)
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
The method getScriptName() is undefined for the type custom.NpcBuffer.NpcBuffer
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
The method getItemConsume() is undefined for the type com.l2jserver.gameserver.m
odel.skills.Skill
The method getItemConsume() is undefined for the type com.l2jserver.gameserver.m
odel.skills.Skill
L2DatabaseFactory cannot be resolved
L2DatabaseFactory cannot be resolved
[15/09 19:42:01] Failed executing script: C:\Users\Acer\Desktop\L2Aris\game\data
\scripts\custom\NpcBuffer\NpcBuffer.java. See NpcBuffer.java.error.log for detai

 

Edited by criss22
  • 0
Posted

Open notepad++, press ctrl+f and replace all L2DatabaseFactory to ConnectionFactory.

 

Also, add the  import com.l2jserver.commons.database.pool.impl.ConnectionFactory; at the top of your code...

  • 0
Posted

all done..you read my mind..i get another errors ..

1. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 456)
        st.playSound(IAudio audio)
                     ^^^^^^
Syntax error on token(s), misplaced construct(s)
----------
2. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 456)
        st.playSound(IAudio audio)
                                 ^
Syntax error, insert ";" to complete Statement
----------
3. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1132)
        System.out.println(getScriptName() + "#onAdvEvent('" + event + "'," + (n
pc == null ? "NULL" : npc.getId() + npc.getName()) + "," + (player == null ? "NU
LL" : player.getName()) + ")");
                           ^^^^^^^^^^^^^
The method getScriptName() is undefined for the type NpcBuffer
----------
4. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1658)
        if (st.getQuestItemsCount(skill.getItemConsumeId()) < skill.getItemConsu
me())
                                                                    ^^^^^^^^^^^^
^^
The method getItemConsume() is undefined for the type Skill
----------
5. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1660)
        return showText(st, "Sorry", "You don't have the enough items:<br>You ne
ed: <font color=LEVEL>" + skill.getItemConsume() + " " + getItemNameHtml(st, ski
ll.getItemConsumeId()) + "!", false, "0", "0");

                                ^^^^^^^^^^^^^^
The method getItemConsume() is undefined for the type Skill
----------
5 problems (5 errors)
Syntax error on token(s), misplaced construct(s)
Syntax error, insert ";" to complete Statement
The method getScriptName() is undefined for the type custom.NpcBuffer.NpcBuffer
The method getItemConsume() is undefined for the type com.l2jserver.gameserver.m
odel.skills.Skill
The method getItemConsume() is undefined for the type com.l2jserver.gameserver.m
odel.skills.Skill
Dead code
Dead code
[15/09 20:32:26] Failed executing script: C:\Users\Acer\Desktop\L2Aris\game\data
\scripts\custom\NpcBuffer\NpcBuffer.java. See NpcBuffer.java.error.log for detai
ls.

 

  • 0
Posted

To solve Error #1 & #2: remove this line: st.playSound("ItemSound3.sys_shortage"); wherever it exists (use search to find it). You don't need sounds at all...

To solve Error #3:  Delete line 1132 (starts with System.out.println)

To solve Error #4 & #5: In line 1658 (or somewhere near) and 2 lines after this replace getItemConsume() with getItemConsumeCount() (you can use control f and replace getItemConsume() with getItemConsumeCount())

 

  • 0
Posted

only 1 error and it`s done...i make all what did you say Solomun, and i get a little error.

1. ERROR in \custom\NpcBuffer\NpcBuffer.java (at line 1656)
        if (st.getQuestItemsCount(skill.getItemConsumeId()) < skill.getItemConsu
meCount()>)

         ^
Syntax error on token ">", Expression expected after this token
----------
1 problem (1 error)
Syntax error on token ">", Expression expected after this token
Dead code
Dead code
[15/09 21:18:18] Failed executing script: C:\Users\Acer\Desktop\L2Aris\game\data
\scripts\custom\NpcBuffer\NpcBuffer.java. See NpcBuffer.java.error.log for detai
ls.

 

  • 0
Posted

ok..no one error in GameServer...in game work Buffer spawn and 2nd click...(i see schemes)

but when i press any button..nothing happend...where i`ts wrong?

  • 0
Posted (edited)

i have 2 sql's with buffer: npc_buffer.sql and

npcbuffer_buff_list.sql

.

i have to delete npc_buffer.sql?

Edited by criss22
  • 0
Posted (edited)

You should have npcbuffer_buff_list , npcbuffer_scheme_list and npcbuffer_scheme_content into your database.

 

Also can you tell me where exactly is the problem?

Edited by Solomun

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now


  • Posts

    • First, don't really follow the "main voice", moreover if you consider it an hobby. Simply do what you want, you got only one life so use it as you want. If you make it an hobby, it's exactly like piano, or velo - only practice makes you better.   Secondly, how do you learn things ? It's actually a really important question, since some can simply be scholar, read books (theory) then practice ; and some simply can't read books. I'm the second type, I hated school, I find it boring - my knowledge in Java comes from try-and-fail. You improve your coding style every year or so, I can myself rewrite my own code (which I already considered top-notched) after a while. You always learn something new - even if Java barely evolves. L2J is a fun way to learn programming, it's a giant sandbox where you can edit anything, and I believe it should be taken as it.   My own way of learning was as follow : Add existing customs, no matter what they are : the point is to know main classes used by L2J / customs. L2J is barely Java knowledge ; the true knowledge is to know WHAT to search in WHICH location (what I call, organization). You have to understand than EVERYTHING you think already exists, in a form on another, in the source code. A custom is only the association of the different mechanisms you found "here and there", glued together in a proper goal. Once you know main classes to edit, and the customs you added are compiling fine, the main point is to know WHAT exactly you DID. Try to understand WHY and WHERE you actually copied the code. Third point would be to MANIPULATE the customs you added in order to fit your wish. First edit little values, then logic conditions ; eventually add a new Config, or a new functionality to the custom. Fourth point would be to begin to craft your own ideas. Once again, EVERYTHING already exists, in a form or another. You want a cycled event ? You got Seven Signs main task as exemple. Npc ? Search any type of Npc and figure out what it does. Fifth point would be to understand Java - mostly containers (WHAT and WHERE to use them), variables types and main Java mechanisms (inheritance, static modifier, etc). You should also begin to cut your code into maintainable classes or methods. Java can actually run without optimization, but bigger your ideas, more optimized and well-thought it should be. It's direct saved time in the future, and you would thank yourself doing so. Main tips : ALWAYS use any type of versioning system - GIT or SVN. It allows to save your work, step by step and eventually revert back anytime you want if you terribly messed up. L2J is 80% organization knowledge, and 20% Java knowledge. Basically, if you know WHAT and WHERE to search, if you aren't dumb, it's easy to replicate and re-use things. Cherry on top is to use a already good coded pack to avoid copy-paste crap and get bad habits. Avoid any type of russian or brazilian packs, for exemple - their best ability is to leak someone's else code. Obviously you need some default sense of logic, but Java and programming in general help you to improve it.   Finally, most of your questions could be solved joining related Discord (at least for aCis, I can't speak for others) - from the moment your question was correctly asked (and you seemed to search for the answer). My community (and myself) welcomes newbies, but got some issues with noobies.   The simpliest is to try, fail and repeat until you succeed - it sounds stupid, but that's basically how life works.   PS : about Java ressources, before ChatGPT, it was mostly about stackoverflow website, and site like Baeldung's one. With ChatGPT and alike, you generally double-cross AI output to avoid fucked up answers. Also, care about AI, they are often hallucinating really hard, even today. They can give you complete wrong answer, you tell them they are wrong, and they say "indeed, I suck, sorry - here's a new fucked up answer". You shouldn't 100% rely over AI answer, even if that can give sometimes legit answers, full code or just skeletons of ideas.   PPS : I don't think there are reliable ressources regarding L2J itself, also most of the proposed code decays pretty fast if the source code is actually maintained (at least for aCis). Still, old coded customs for old aCis sources are actually a good beginner challenge to apply on latest source.
    • Add prices please.
    • WTS: - AQ - Baium - Zaken  - Frintezza - Vesper Fighter Focus Fire Element   pm for detalis
    • We have the best price! L2Reborn.org Signature x1 Franz NEW!! 1KK = $20 HURRY TO BUY AT THE TOP PRICE discord - adver745645
  • Topics

×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock