Help All private stores in one npc

[admirolas3]

Hey, i am working on custom npc, that will show private store list of players, by selected category. Example if i select category dagger weapons, npc will show list of available shops with dagger type weapons. I have a little problem, when there is no shops in world, the "No items to show" msg is not shown in npc htm. Maybe someone would know what is bad? For me it's pretty hard. 
 

else if (currentCommand.startsWith("category"))
        {
            String categoryName = st.nextToken();
            final StringBuilder sb = new StringBuilder(200);
            for (Player storeChar : World.getInstance().getPlayers())
            {
                if (storeChar.isInStoreMode() && storeChar.getStoreType() == StoreType.SELL)
                {
                    for (TradeItem i : storeChar.getSellList().getItems())
                    {
                        if (categoryName.startsWith("dagger"))
                        {
                            if(i.getItem().getItemType() == WeaponType.DAGGER){
                                sb.append("<table width=240 height=42><tr>");
                                sb.append("<td width=32 height=32 align=center><img src=Icon.item"+i.getItem().getItemId()+" width=32 height=32></td>");
                                sb.append("<td>" + i.getItem().getName() + "</td>");
                                sb.append("</tr><tr><td height=7></td></tr></table>");
                            }
                            else{
                                sb.append("No items to show");
                            }
                        }
                }
            }
            final NpcHtmlMessage html = new NpcHtmlMessage(getObjectId());
            html.setFile("data/html/auctioneerManager/categoryView.htm");
            html.replace("%objectId%", getObjectId());
            html.replace("%items%", sb.toString());
            player.sendPacket(html);

}

 

Edited August 26, 2017 by admirolas3

[admirolas3]

Any ideas? Maybe i should youse other method?

 

[wongerlt]

its simple:

else if (currentCommand.startsWith("category"))
        {
            String categoryName = st.nextToken();
            final StringBuilder sb = new StringBuilder(200);
            for (Player storeChar : World.getInstance().getPlayers())
            {
                if (storeChar.isInStoreMode() && storeChar.getStoreType() == StoreType.SELL)
                {
                    for (TradeItem i : storeChar.getSellList().getItems())
                    {
                        if (categoryName.startsWith("dagger"))
                        {
                            if(i.getItem().getItemType() == WeaponType.DAGGER){
                                sb.append("<table width=240 height=42><tr>");
                                sb.append("<td width=32 height=32 align=center><img src=Icon.item"+i.getItem().getItemId()+" width=32 height=32></td>");
                                sb.append("<td>" + i.getItem().getName() + "</td>");
                                sb.append("</tr><tr><td height=7></td></tr></table>");
                            }
                        }
                }
            }
			if(sb == null || sb.toString().equals("")) {
			sb.append("No items to show");
			}
            final NpcHtmlMessage html = new NpcHtmlMessage(getObjectId());
            html.setFile("data/html/auctioneerManager/categoryView.htm");
            html.replace("%objectId%", getObjectId());
            html.replace("%items%", sb.toString());
            player.sendPacket(html);

}

and change table, u dont need to create new table on every found item. use <tr> tag.

Edited August 29, 2017 by wongerlt

[admirolas3]

Ahh, not working,  this line checks :

if (storeChar.isInStoreMode() && storeChar.getStoreType() == StoreType.SELL)

The player who is reading a code is not in a shop, and it cant be shown. What i could edit? Dont know how to get info from all characters that is in world with shops.

 

[wongerlt]

what pack u using?

[admirolas3]

5 hours ago, wongerlt said:

what pack u using?

Acis. Last rev shared source

[wongerlt]

storeChar.getStoreType() == StoreType.SELL || storeChar.getStoreType() == StoreType.PACKAGE_SELL

 

Edited September 6, 2017 by wongerlt

[admirolas3]

53 minutes ago, wongerlt said:

storeChar.getStoreType() == StoreType.SELL || storeChar.getStoreType() == StoreType.PACKAGE_SELL

 

Still that did not fix the problem. When there is no private stores npc does not show those words. But when i make a shop with character it appears. Maybe it could be a problem with all world players filtrate. When script goes throw all players and dont found at least one with a shop it stops. 

[Tryskell]

I hope you don't count to write every single type of item in that for loop.

For your stuff, replace given solution

if(sb == null || sb.toString().equals(""))

by

if (sb.length() == 0)

 

PS : you must care about implementing a paging system, otherwise with a lot of shops your system will be unusable due to html character limit. And avoid to use <table></table> on every entry, that's already that saved on your total count of allowed characters. See Bookmark system for a live exemple of paging system.

Edited September 6, 2017 by Tryskell