Jump to content

Question

Posted

Hello guys,

 

I have an problem. It's about Inventory. For example when it gets full 80/80 I can't pick anything anymore, even the items that i already have, for example adena.
It is ok that i can't pick up new items, but i would like to know is it possible to make stacks out of it ?  For example when my Inventory is full that I still can pick up adena and the items that i already have inside.

Recommended Posts

  • 0
Posted (edited)

unless you have the source code, you won't be able to fix that...

on your next post write " if you have program for edit the code "

 

op L2j Dev "lol"

 

OnTopic

 

L2PcInstance.java

 

find

@Override
public void doPickupItem(L2Object object)

find

	sendPacket(SystemMessageId.SLOTS_FULL);
	return;

make it 

if (!item.isStackable() || _inventory.getItemByItemId(item.getItemId()) == null)
{
	sendPacket(SystemMessageId.SLOTS_FULL);
	return;
}
Edited by pirama
  • 0
Posted

Ok. Here it is this is all i've got:

https://i.imgsafe.org/48/48d8ed97be.jpeg

 

48d8ed97be.jpeg

 

 

and here are the codes from both inside:

L2PcInstanceAction.java:


package handlers.actionhandlers;

import com.l2jserver.gameserver.GeoData;
import com.l2jserver.gameserver.ai.CtrlIntention;
import com.l2jserver.gameserver.enums.InstanceType;
import com.l2jserver.gameserver.enums.PrivateStoreType;
import com.l2jserver.gameserver.handler.IActionHandler;
import com.l2jserver.gameserver.model.L2Object;
import com.l2jserver.gameserver.model.Location;
import com.l2jserver.gameserver.model.actor.instance.L2PcInstance;
import com.l2jserver.gameserver.model.entity.TvTEvent;
import com.l2jserver.gameserver.network.SystemMessageId;
import com.l2jserver.gameserver.network.serverpackets.ActionFailed;

public class L2PcInstanceAction implements IActionHandler
{
	private static final int CURSED_WEAPON_VICTIM_MIN_LEVEL = 21;
	
	/**
	 * Manage actions when a player click on this L2PcInstance.<BR>
	 * <BR>
	 * <B><U> Actions on first click on the L2PcInstance (Select it)</U> :</B><BR>
	 * <BR>
	 * <li>Set the target of the player</li> <li>Send a Server->Client packet MyTargetSelected to the player (display the select window)</li><BR>
	 * <BR>
	 * <B><U> Actions on second click on the L2PcInstance (Follow it/Attack it/Intercat with it)</U> :</B><BR>
	 * <BR>
	 * <li>Send a Server->Client packet MyTargetSelected to the player (display the select window)</li> <li>If target L2PcInstance has a Private Store, notify the player AI with AI_INTENTION_INTERACT</li> <li>If target L2PcInstance is autoAttackable, notify the player AI with AI_INTENTION_ATTACK</li>
	 * <BR>
	 * <BR>
	 * <li>If target L2PcInstance is NOT autoAttackable, notify the player AI with AI_INTENTION_FOLLOW</li><BR>
	 * <BR>
	 * <B><U> Example of use </U> :</B><BR>
	 * <BR>
	 * <li>Client packet : Action, AttackRequest</li><BR>
	 * <BR>
	 * @param activeChar The player that start an action on target L2PcInstance
	 */
	@Override
	public boolean action(L2PcInstance activeChar, L2Object target, boolean interact)
	{
		// See description in TvTEvent.java
		if (!TvTEvent.onAction(activeChar, target.getObjectId()))
		{
			return false;
		}
		
		// Check if the L2PcInstance is confused
		if (activeChar.isOutOfControl())
		{
			return false;
		}
		
		// Aggression target lock effect
		if (activeChar.isLockedTarget() && (activeChar.getLockedTarget() != target))
		{
			activeChar.sendPacket(SystemMessageId.FAILED_CHANGE_TARGET);
			return false;
		}
		
		// Check if the activeChar already target this L2PcInstance
		if (activeChar.getTarget() != target)
		{
			// Set the target of the activeChar
			activeChar.setTarget(target);
		}
		else if (interact)
		{
			final L2PcInstance player = target.getActingPlayer();
			// Check if this L2PcInstance has a Private Store
			if (player.getPrivateStoreType() != PrivateStoreType.NONE)
			{
				activeChar.getAI().setIntention(CtrlIntention.AI_INTENTION_INTERACT, player);
			}
			else
			{
				// Check if this L2PcInstance is autoAttackable
				if (player.isAutoAttackable(activeChar))
				{
					if ((player.isCursedWeaponEquipped() && (activeChar.getLevel() < CURSED_WEAPON_VICTIM_MIN_LEVEL)) //
						|| (activeChar.isCursedWeaponEquipped() && (player.getLevel() < CURSED_WEAPON_VICTIM_MIN_LEVEL)))
					{
						activeChar.sendPacket(ActionFailed.STATIC_PACKET);
					}
					else
					{
						if (GeoData.getInstance().canSeeTarget(activeChar, player))
						{
							activeChar.getAI().setIntention(CtrlIntention.AI_INTENTION_ATTACK, player);
						}
						else
						{
							final Location destination = GeoData.getInstance().moveCheck(activeChar, player);
							activeChar.getAI().setIntention(CtrlIntention.AI_INTENTION_MOVE_TO, destination);
						}
						activeChar.onActionRequest();
					}
				}
				else
				{
					// This Action Failed packet avoids activeChar getting stuck when clicking three or more times
					activeChar.sendPacket(ActionFailed.STATIC_PACKET);
					if (GeoData.getInstance().canSeeTarget(activeChar, player))
					{
						activeChar.getAI().setIntention(CtrlIntention.AI_INTENTION_FOLLOW, player);
					}
					else
					{
						final Location destination = GeoData.getInstance().moveCheck(activeChar, player);
						activeChar.getAI().setIntention(CtrlIntention.AI_INTENTION_MOVE_TO, destination);
					}
				}
			}
		}
		return true;
	}
	
	@Override
	public InstanceType getInstanceType()
	{
		return InstanceType.L2PcInstance;
	}
}

and the L2PcInstanceActionShift.java :


package handlers.actionshifthandlers;

import com.l2jserver.gameserver.enums.InstanceType;
import com.l2jserver.gameserver.handler.AdminCommandHandler;
import com.l2jserver.gameserver.handler.IActionShiftHandler;
import com.l2jserver.gameserver.handler.IAdminCommandHandler;
import com.l2jserver.gameserver.model.L2Object;
import com.l2jserver.gameserver.model.actor.instance.L2PcInstance;

public class L2PcInstanceActionShift implements IActionShiftHandler
{
	@Override
	public boolean action(L2PcInstance activeChar, L2Object target, boolean interact)
	{
		if (activeChar.isGM())
		{
			// Check if the gm already target this l2pcinstance
			if (activeChar.getTarget() != target)
			{
				// Set the target of the L2PcInstance activeChar
				activeChar.setTarget(target);
			}
			
			IAdminCommandHandler ach = AdminCommandHandler.getInstance().getHandler("admin_character_info");
			if (ach != null)
			{
				ach.useAdminCommand("admin_character_info " + target.getName(), activeChar);
			}
		}
		return true;
	}
	
	@Override
	public InstanceType getInstanceType()
	{
		return InstanceType.L2PcInstance;
	}
}
 
  • 0
Posted (edited)

Oh man go to model.actor.instance

L2PcInstance.java..read the piramas reply..

Into your eclipse not via folder search..

Edited by Reborn12
  • 0
Posted

I am sorry but i don't have it here....

 

https://i.imgsafe.org/4a/4a96d57769.jpeg

 

4a96d57769.jpeg

 

:alone:

Sad story but let's bypass your problem. Let's focus on something else.

Try build the project :-[  i want see what will happen  :-[

  • 0
Posted

:alone:

Sad story but let's bypass your problem. Let's focus on something else.

Try build the project :-[  i want see what will happen  :-[

Idk.... this happens ...

 

4add6affd2.jpeg

 

is it a good sign ?

  • 0
Posted (edited)

L2jServer

 

src/main/java

 

after open the package

 

com.l2jserver.gameserver.model.actor.instance

 

find

L2PcInstance.java

@Override
public void doPickupItem(L2Object object)
{
.....

find


sendPacket(SystemMessageId.SLOTS_FULL);
return;

edit

if (!item.isStackable() || _inventory.getItemByItemId(item.getItemId()) == null)
{
	sendPacket(SystemMessageId.SLOTS_FULL);
	return;
}
Edited by pirama
  • 0
Posted (edited)

Thank you pirama but i am having problems...

 

1) Problem location

 

4df234ec22.jpeg

 

2) Problem Overview

 

4df5c4829b.jpeg

 

3) Solution from Eclipse ( EDIT: I tried all of these solutions...they all didn't fix anything...)

4df929508d.jpeg

 

 

What should i do :/ ?

Edited by milosvamp
  • 0
Posted

 

A few lines before

public void doPickupItem(L2Object object)
L2ItemInstance target = (L2ItemInstance) object;

I've found the line, but what to do with it? Where to insert this code that the guy gave me ? :X 

  • 0
Posted

He gave you the place(pirama)

Just change the item to target....

I did that, and i showed you the problem that is eclipse showing. 

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now



  • Posts

    • I'll give you my wallet if you want, haha
    • To make up for some of the waiting time we’re hosting a 3v3 Tournament on open Beta, and this time we’re raising the stakes with a $1,300 prize pool 💰   🏆 PRIZE POOL BREAKDOWN (Over 2000$ Worth of prices total)   🥇 1st Place — $700 🥈 2nd Place —$300 🥉 3rd Place — $200 🏅 4th Place — $100  5th -6th Place - $100 in Gold Coins each    All Participating Teams: $50 in Gold!   All Prices will be Paid out instantly after the tour, no waiting time and conditions. This is not simply a marketing move, we want to give back to the community.   📅 Date: Wednesday 06.05.2026 ⏰ Time: 20:00 Central European Timezone (Berlin) 📍Format: 3v3   ⚔️Why join? Cash Prices for top 4 and rewards for all participants Payments to winners sent out straight after the tournament - No waiting time or rules that you have to play live server to obtain the reward. Clean format, smooth matches, and solid prize pool and a chance to experience our brand new files   📝How to join: Form your 3-player team Group Leader Sign up here: ⁠📍・3v3-tour-registration (Include Name of Group, Name of Group Leader)   Be ready on match day!     A separate post with rules for the tournament and class setups will follow shortly.   Tag your teammates, lock in your roster, and get ready to compete. We'll be happy to see you on the OBT!   💬 Questions? Ask in ⁠🎫・ticket or send us a message   See you on L2Dark! 😏   Discord: https://discord.gg/FAJwnFpb8M
    • You should check if that condition is supported by your current sources. You can find this in  DocumentBase#parsePlayerCondition If it isnt there and you want to follow the same pattern of the other item conditions, create a custom condition to parse the classId (or multiple class ids) (there are examples to copy the code). Alternatively, you can create your own condition handler. Your condition should look like this: <cond msgId="1518"> <player classId="ADVENTURER,PALADIN" /> </cond> or <cond msgId="1518"> <player classId="93,5" /> </cond>  
    • it's Interlude client forgot to mention
    • idk if acis have this option, but you can put inside item smth like that atleast on H5         <cond msgId="1518">             <player class_id_restriction="93, 101, 108, 117" /> <!-- Dagger Masters -->         </cond>
  • Topics

×
×
  • Create New...

Important Information

This community uses essential cookies to function properly. Non-essential cookies and third-party services are used only with your consent. Read our Privacy Policy and We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue..