Help Some Skills Don't Finish Cast Animation

[Ikeryn]

Hi MxC! I have a very irritating problem with my test server, and I don't understand where this problem comes from. Some skills don't finish their cast animation, resulting in causing effect before it should. Here I post a video capturing the problem. The skill Shield Strike works properly, but Power Strike and Shield Stun don't. This problem also occurs with a lot of other skills that involves debuff or applying damage, all of them melee. I think it's related to Formulas.java or L2Character.java, but i'm not sure since I'm not a proper server developer. Also, I'm using the latest revision of l2jserver H5 master branch (https://bitbucket.org/l2jserver/l2j_server)

 

Edited July 12, 2017 by Ikeryn

[etherian]

i know about this, it also happens in extender bassed

 

so you have to check  skill hit time &  skill cool time
shield stun
<set name="hitTime" val="1200"/>
<set name="coolTime" val="300" />

and disable next action attack -very important this one

add this
<set name="nextActionAttack" val="true" />

but it goes false
<set name="nextActionAttack" val="false" />

hope this helps
it solved for me back in 2012 when i had freya modded to H5  java srv

laters!

Edited July 12, 2017 by etherian

[Ikeryn]

That could be a workaround, but then the character won't auto-attack again when the skill is casted. Is that a retail behaviour?

 

Also, I found the place where the delay before next attack is calculated in Formulas.java (gameserver/model/stats), maybe some values need to be changed?

	/**
	 * Calculate delay (in milliseconds) before next ATTACK
	 * @param attacker
	 * @param target
	 * @param rate
	 * @return
	 */
	public static final int calcPAtkSpd(L2Character attacker, L2Character target, double rate)
	{
		// measured Oct 2006 by Tank6585, formula by Sami
		// attack speed 312 equals 1500 ms delay... (or 300 + 40 ms delay?)
		if (rate < 2)
		{
			return 2700;
		}
		return (int) (470000 / rate);
	}
	
	public static double calcCastTime(L2Character character, Skill skill)
	{
		double skillAnimTime = skill.getHitTime();
		if (!skill.isChanneling() || (skill.getChannelingSkillId() == 0))
		{
			// Calculate the Casting Time of the "Non-Static" Skills (with caster PAtk/MAtkSpd).
			if (!skill.isStatic())
			{
				final double speed = skill.isMagic() ? character.getMAtkSpd() : character.getPAtkSpd();
				skillAnimTime = (skillAnimTime / speed) * 333;
			}
			
			// Calculate the Casting Time of Magic Skills (reduced in 40% if using SPS/BSPS)
			if (skill.isMagic() && (character.isChargedShot(ShotType.SPIRITSHOTS) || character.isChargedShot(ShotType.BLESSED_SPIRITSHOTS)))
			{
				skillAnimTime = (int) (skillAnimTime / 1.4);
			}
			
			if ((skillAnimTime < 500) && (skill.getHitTime() > 500))
			{
				skillAnimTime = 500.0;
			}
		}
		return skillAnimTime;
	}
	

[melron]

its clearly coolTime problem.

 

edit your xmls and set new cool time there

example:

<set name="coolTime" val="720" />

P.s if doesnt exists , add it

Edited July 12, 2017 by melron

[Sdw]

Zealar made a huge less modifying hit time, most formula are wrong, but server to match client animation, hit time should be hitTime + cancelTime with a 500ms cap going down

 

Also indeed coolTime for last casting phase

Edited July 12, 2017 by Sdw

[Ikeryn]

I have tried increasing coolTime for Shield Stun from 300 to 800 even 3000, and it did nothing :/

 

hitTime of Shield Stun is the same either in client and server (XML 1200 hitTime; SKILLGRP 1.2 hitTime). It's very strange that Shield Strike works properly, and a bunch of other skills not.

[Sdw]

Because the whole formula is wrong mostly, time is not calculated correctly :/

[etherian]

try as i said

 

<set name="nextActionAttack" val="false" />


what is the most you want for your server

retail behaviour  or complete skill animation
anyway if you press attack  will cut off animation 
happens since all lineage servers there is no much to do about 

 

its clearly coolTime problem.

 

edit your xmls and set new cool time there

example:

<set name="coolTime" val="720" />

P.s if doesnt exists , add it

 

yes  cooltime 720  i used that long time ago is good solution
but since last changes in H5 jserver im not sure about, it worked in past, lately seems not at all

 

 

Edited July 12, 2017 by etherian

[marcoviny]

TO Fix This In My Source but no Know in Your ....
L2Character.java

_skillCast2 = ThreadPoolManager.getInstance().scheduleEffect(mut, 0);
to this
_skillCast2 = ThreadPoolManager.getInstance().scheduleEffect(mut, 33);

 

 

and

 

 

_skillCast = ThreadPoolManager.getInstance().scheduleEffect(mut, 0);
to this
_skillCast = ThreadPoolManager.getInstance().scheduleEffect(mut, 33);

 

[maugs47]

Hi, just fixed it on my windows personal server: (im using the build from http://l2jserver.com) I'm not a dev so I will reproduce how I fixed it step-by-step:

 

1. Navigate to dir "C:\opt\l2j\git\l2j-game-server\scr\main\java\com\l2jserver\gameserver\model\actor"

 

2. Edit "L2Character.java" with text editor like Notepad++.

 

3. Change it

FROM:

        _{mut.setPhase(3);
        if (mut.getSkillTime() == 0) {
            onMagicFinalizer(mut);
        } else {
            if (mut.isSimultaneous()) {
                _skillCast2 = ThreadPoolManager.getInstance().scheduleEffect(mut, 0);
            } else {
                _skillCast = ThreadPoolManager.getInstance().scheduleEffect(mut, 0);
            }
        }}

TO:

        _{mut.setPhase(3);
        if (mut.getSkillTime() == 0) {
            onMagicFinalizer(mut);
        } else {
            if (mut.isSimultaneous()) {
                _skillCast2 = ThreadPoolManager.getInstance().scheduleEffect(mut, 333);
            } else {
                _skillCast = ThreadPoolManager.getInstance().scheduleEffect(mut, 333);
            }
        }}

 

4. Save file.

 

5. Compile by navigating using Windows Power Shell or Command Prompt to "C:\opt\l2j\git\l2j-game-server" and running the command:

 

mvn install

 

(I assume you installed maven in order to compile the server in l2jserver.com, if you created your server using other method use your compiler instead)

 

6. Extract the "C:\opt\l2j\git\l2j-server-game\target\l2j-server-game-2.6.1.0-SNAPSHOT" to your "C:\opt\l2j\server\game\" FOLDER.

 

(again this is for maven compiler)

 

7. Done. Hope it helps anyone else looking for a solution.

 

 

Edited December 23, 2019 by maugs47
Formating for better reading