Jump to content
  • 0

Idk How...help Me On That Please


Question

Posted (edited)

  1. I want to put if Human , Elf , Dwarf female setGood(true)  and if Orc , delf, male dwarf setEvil(true) i made the code but doesnt work correctly , thinking to delete setevil and change the setGood retail code here:http://pastebin.com/0wdWBjT5
  2.  generally i deleted the setevil and changed the setgood to setdestiny i want just to press the button and check if race suits then go to the faction.. Goods : human , elf , female dwarf 

    evil : orc, d.elf , male dwarf

  3. package net.sf.l2j;
    	
    	
    	 
    	
    	
    	import java.sql.Connection;
    	
    	
    	import java.sql.PreparedStatement;
    	
    	
    	import java.sql.ResultSet;
    	
    	
    	import java.util.StringTokenizer;
    	
    	
    	import java.util.logging.Logger;
    	
    	
    	 
    	
    	
    	import net.sf.l2j.commons.random.Rnd;
    	
    	
    	import net.sf.l2j.gameserver.ai.CtrlIntention;
    	
    	
    	import net.sf.l2j.gameserver.model.L2World;
    	
    	
    	import net.sf.l2j.gameserver.model.actor.instance.L2NpcInstance;
    	
    	
    	import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
    	
    	
    	import net.sf.l2j.gameserver.model.actor.template.NpcTemplate;
    	
    	
    	import net.sf.l2j.gameserver.network.serverpackets.ActionFailed;
    	
    	
    	import net.sf.l2j.gameserver.network.serverpackets.MyTargetSelected;
    	
    	
    	import net.sf.l2j.gameserver.network.serverpackets.NpcHtmlMessage;
    	
    	
    	import net.sf.l2j.gameserver.network.serverpackets.SocialAction;
    	
    	
    	import net.sf.l2j.gameserver.network.serverpackets.ValidateLocation;
    	
    	
    	 
    	
    	
    	 
    	
    	
    	 
    	
    	
    	public class L2FactionInstance extends L2NpcInstance
    	
    	
    	{
    	
    	
    	 
    	
    	
    	    public L2FactionInstance(int objectId, NpcTemplate template)
    	
    	
    	    {
    	
    	
    	        super(objectId, template);
    	
    	
    	    }
    	
    	
    	 
    	
    	
    	    private final static Logger _log = Logger.getLogger(L2FactionInstance.class.getName());
    	
    	
    	 
    	
    	
    	    @Override
    	
    	
    	    public void onBypassFeedback(L2PcInstance player, String command)
    	
    	
    	    {
    	
    	
    	        player.sendPacket(ActionFailed.STATIC_PACKET);
    	
    	
    	        StringTokenizer st = new StringTokenizer(command, " ");
    	
    	
    	        String actualCommand = st.nextToken();
    	
    	
    	        @SuppressWarnings("unused")
    	
    	
    	        String val = "";
    	
    	
    	        if (st.countTokens() >= 1)
    	
    	
    	        {
    	
    	
    	            val = st.nextToken();
    	
    	
    	    }
    	
    	
    	 
    	
    	
    	        else if (actualCommand.equalsIgnoreCase("setdestiny"))
    	
    	
    	        {
    	
    	
    	           
    	
    	
    	        setTarget(player);
    	
    	
    	       
    	
    	
    	            if (player.isGood())
    	
    	
    	            {
    	
    	
    	                player.sendMessage("You already are in " + Config.FACTION_NAME_TEAM_GOOD + " faction ");
    	
    	
    	                player.sendPacket(new ActionFailed());
    	
    	
    	            }
    	
    	
    	           if(player.getRace blabla bla 
    	
    	
    	                    {
    	
    	
    	                    player.setGood(true);
    	
    	
    	                    Connection connection = null;
    	
    	
    	                        try
    	
    	
    	                        {
    	
    	
    	                            connection = L2DatabaseFactory.getInstance().getConnection();
    	
    	
    	                            PreparedStatement statement = connection.prepareStatement("SELECT obj_Id FROM characters where char_name=?");
    	
    	
    	                            statement.setString(1, player.getName());
    	
    	
    	                            ResultSet rset = statement.executeQuery();
    	
    	
    	                            int objId = 0;
    	
    	
    	                        if (rset.next())
    	
    	
    	                            {
    	
    	
    	                                objId = rset.getInt(1);
    	
    	
    	                            }
    	
    	
    	                            rset.close();
    	
    	
    	                            statement.close();
    	
    	
    	                            if (objId == 0)
    	
    	
    	                            {
    	
    	
    	                                connection.close();
    	
    	
    	                                return;
    	
    	
    	                            }
    	
    	
    	                            statement = connection.prepareStatement("UPDATE characters SET good=1 WHERE obj_Id=?");
    	
    	
    	                        statement.setInt(1, objId);
    	
    	
    	                            statement.execute();
    	
    	
    	                            statement.close();
    	
    	
    	                            connection.close();
    	
    	
    	                        }
    	
    	
    	                        catch (Exception e)
    	
    	
    	                        {
    	
    	
    	                            _log.info("could not set good status of char:");
    	
    	
    	                        }
    	
    	
    	                        finally
    	
    	
    	                        {
    	
    	
    	                            try
    	
    	
    	                            {
    	
    	
    	                                connection.close();
    	
    	
    	                            }
    	
    	
    	                            catch (Exception e)
    	
    	
    	                            {
    	
    	
    	                            }
    	
    	
    	                        }
    	
    	
    	                   
    	
    	
    	                        if (player.isGood())
    	
    	
    	                        {
    	
    	
    	                            player.broadcastUserInfo();
    	
    	
    	                            player.sendMessage("You Are fighiting Now for" + Config.FACTION_NAME_TEAM_GOOD + " Faction ");
    	
    	
    	                            player.getAppearance().setNameColor(Config.FACTION_COLOR_NAME_GOOD);
    	
    	
    	                            player.teleToLocation(Config.GOODX, Config.GOODY, Config.GOODZ);
    	
    	
    	                            player.setTitle(Config.FACTION_NAME_TEAM_GOOD);
    	
    	
    	                        }
    	
    	
    	                    }
    	
    	
    	                }
    	
    	
    	        }
    	
    	
    	        }
    	
    	
    	           
    	
    	
    	                    else if(player.getRace() == Race.Orc() bla bla bla
    	
    	
    	                    {
    	
    	
    	                        player.setEvil(true);
    	
    	
    	                        Connection connection = null;
    	
    	
    	                        try
    	
    	
    	                        {
    	
    	
    	                            connection = L2DatabaseFactory.getInstance().getConnection();
    	
    	
    	                            PreparedStatement statement = connection.prepareStatement("SELECT obj_Id FROM characters where char_name=?");
    	
    	
    	                            statement.setString(1, player.getName());
    	
    	
    	                            ResultSet rset = statement.executeQuery();
    	
    	
    	                            int objId = 0;
    	
    	
    	                            if (rset.next())
    	
    	
    	                        {
    	
    	
    	                                objId = rset.getInt(1);
    	
    	
    	                        }
    	
    	
    	                            rset.close();
    	
    	
    	                            statement.close();
    	
    	
    	                            if (objId == 0)
    	
    	
    	                            {
    	
    	
    	                                connection.close();
    	
    	
    	                                return;
    	
    	
    	                            }
    	
    	
    	                            statement = connection.prepareStatement("UPDATE characters SET evil=1 WHERE obj_Id=?");
    	
    	
    	                            statement.setInt(1, objId);
    	
    	
    	                            statement.execute();
    	
    	
    	                            statement.close();
    	
    	
    	                            connection.close();
    	
    	
    	                        }
    	
    	
    	                        catch (Exception e)
    	
    	
    	                        {
    	
    	
    	                            _log.info("could not set evil status of char:");
    	
    	
    	                        }
    	
    	
    	                        finally
    	
    	
    	                        {
    	
    	
    	                            try
    	
    	
    	                            {
    	
    	
    	                                connection.close();
    	
    	
    	                            }
    	
    	
    	                            catch (Exception e)
    	
    	
    	                            {
    	
    	
    	                            }
    	
    	
    	                        }
    	
    	
    	                   
    	
    	
    	                        if (player.isEvil())
    	
    	
    	                        {
    	
    	
    	                            player.broadcastUserInfo();
    	
    	
    	                            player.sendMessage("You Are fighiting Now for " + Config.FACTION_NAME_TEAM_EVIL + " Faction ");
    	
    	
    	                            player.getAppearance().setNameColor(Config.FACTION_COLOR_NAME_EVIL);
    	
    	
    	                            player.teleToLocation(Config.EVILX, Config.EVILY, Config.EVILZ);
    	
    	
    	                            player.setTitle(Config.FACTION_NAME_TEAM_EVIL);
    	
    	
    	                        }
    	
    	
    	                    }
    	
    	
    	                }
    	
    	
    	            
    	
    	
    	        else if (actualCommand.equalsIgnoreCase("setnobless"))
    	
    	
    	        {
    	
    	
    	       
    	
    	
    	            L2PcInstance activeChar = player;
    	
    	
    	            if (activeChar.isNoble())
    	
    	
    	                activeChar.sendMessage("You Are Already A Noblesse!.");
    	
    	
    	            else
    	
    	
    	            {
    	
    	
    	                activeChar.setNoble(true, true);
    	
    	
    	                activeChar.sendMessage("You Are Now a Noble,You Are Granted With Noblesse Status , And Noblesse Skills.");
    	
    	
    	                activeChar.broadcastUserInfo();
    	
    	
    	                activeChar.getInventory().addItem("Tiara", 7694, 1, activeChar, null);
    	
    	
    	            }
    	
    	
    	        }
    	
    	
    	        else
    	
    	
    	        {
    	
    	
    	            super.onBypassFeedback(player, command);
    	
    	
    	        }
    	
    	
    	    }
    	
    	
    	   
    	
    	
    	    @Override
    	
    	
    	    public String getHtmlPath(int npcId, int val)
    	
    	
    	    {
    	
    	
    	        return "data/html/mods/faction/main.htm";
    	
    	
    	    }
    	
    	
    	 
    	
    	
    	}
Edited by Kelrzher

Recommended Posts

  • 0
Posted

Tessa, what does this return ?

 

faction == Faction.GOOD

 

I never went to see such method ever again.

  • 0
Posted

Tessa, what does this return ?

 

faction == Faction.GOOD

 

I never went to see such method ever again.

You mean if it's not initialized? :lol:

  • 0
Posted

public boolean isGood() {

if (faction == Faction.GOOD) {

return true;

}

 

return false;

}

Still can't get it... what you mean? :lol:

  • 0
Posted

Still can't get it... what you mean? :lol:

 

boolean bool = false;

 

if (bool == true)

    return true;

else if (bool == false)

   return false;

else

    // bug

  • 0
Posted (edited)

You compare a wrong var with an enum ? Rofl xD

Why wrong var? :lol:

 

boolean bool = false;

 

if (bool == true)

    return true;

else if (bool == false)

   return false;

else

    // bug

It should be properly initialized at EnterWorld... no?

Edited by Tessa
  • 0
Posted (edited)

boolean bool = false;

 

if (bool == true)

    return true;

else if (bool == false)

   return false;

else

    // bug

What bug can happen if u make a check in a if else without else if 

Edited by AccessDenied
  • 0
Posted (edited)

Edit:

 

Can someone explain me how u will get "else" with this code or i have to categorize it into my sh1tcode of the day? :dat:

Edited by bravetobe
  • 0
Posted (edited)

Relax he's kidding... :lol:

trolling ... not just kidding lul."Everything coded by others can be done better ,so lets troll a bit .. "

 

I've never used this style tbh...  :lol:

if(....){
...
return true;
}
return false;
 
ftw style
Edited by bravetobe
Guest
This topic is now closed to further replies.



  • Posts

    • Lineage 2 Interlude Developer – Cliente + Datapack Hola, soy developer especializado en Lineage 2 Interlude con experiencia tanto en cliente como datapack/core. ✔ Desarrollo datapack (Java, scripts, quests, balance PvP/PvE) ✔ Fixes core / geodata / exploits ✔ Sistemas custom (events, Olympiad, instancias, mods PvP) ✔ Cliente: interface mods, system patches, .dat edits, UI personalizada ✔ Optimización y estabilidad de servidor ✔ Trabajo freelance o colaboración fija Si necesitáis soporte dev o mejoras para vuestro servidor Interlude, podéis contactarme por DM. Portfolio y ejemplos disponibles bajo petición.
    • THEY DON’T COME BACK FOR NO REASON. HERE’S WHY Our clients come from different countries and with very different tasks. But the strongest indicator of quality is simple — when a client comes back **for a second time**. This case is exactly that. The client returned with a request for a **German ID**. The requirement was clear: a document **in a male hand**, with a natural live scene and correct geographic context. What we did: ▪ accepted source files and data without unnecessary bureaucracy ▪ selected a **real street**, not a generic background ▪ built a print-ready mockup with correct scene logic ▪ sent it for approval ▪ after confirmation, delivered the **final file for printing** No templates. No “good enough”. Only solutions tailored to a specific task. Result: ▪ mockup approved on the first try ▪ client fully satisfied ▪ stays in touch We work **worldwide** — and that’s exactly why clients return. Contact us › TG: @mustang_service ( https:// t.me/ mustang_service ) › Channel: Mustang Service ( https:// t.me/ +6RAKokIn5ItmYjEx ) *All data is published with the client’s consent.* #redraw #verification #documents #case #ID
    • Lineage 2 Interlude Developer – Cliente + Datapack Hola, soy developer especializado en Lineage 2 Interlude con experiencia tanto en cliente como datapack/core. ✔ Desarrollo datapack (Java, scripts, quests, balance PvP/PvE) ✔ Fixes core / geodata / exploits ✔ Sistemas custom (events, Olympiad, instancias, mods PvP) ✔ Cliente: interface mods, system patches, .dat edits, UI personalizada ✔ Optimización y estabilidad de servidor ✔ Trabajo freelance o colaboración fija Si necesitáis soporte dev o mejoras para vuestro servidor Interlude, podéis contactarme por DM. Portfolio y ejemplos disponibles bajo petición.
  • Topics

×
×
  • Create New...

Important Information

This community uses essential cookies to function properly. Non-essential cookies and third-party services are used only with your consent. Read our Privacy Policy and We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue..