'Baggos' Posted February 2, 2015 Author Posted February 2, 2015 Wrong.. :D Try to understand the code, let me explain if (Config.FIGHTER_TATTOO_ENABLE && Config.MAGE_TATTOO_ENABLE && !isMageClass()) If fighter and mage tatto enabled and the char is not mage. Also rest of the code is logically wrong as well. Well, it's kinda stupid to have 2 options for fighter and mage tattoo, since why you would reward only one class, so you can make it only with one config and use Fanky version if (Config.CUSTOM_TATTOO_ENABLE) { if (getPvpKills() == 100) { if (!isMageClass()) { addItem("PvP Reward", Config.REWARD_FIGHTER_ID, Config.REWARD_FIGHTER_COUNT, this, true); sendMessage("You've been rewarded with a fighter tattoo"); } else { addItem("PvP Reward", Config.REWARD_MAGE_ID, Config.REWARD_MAGE_COUNT, this, true); sendMessage("You've been rewarded with a mage tatoo"); } } } Otherwise, you have to check 2 times the pvp count (if for example you enable fighter, and disable mage), one check for fighter and then the same shit for mage. :) take a look in my last post. i have edit with this. :P Quote
SweeTs Posted February 2, 2015 Posted February 2, 2015 (edited) Still wrong.. You will give reward ONLY for fighter class. At 100 pvp fighter tattoo, and for each kill mage. Look my previous post, Fanky's code. Debug it and don't mess :) Edited February 2, 2015 by SweeTs Quote
'Baggos' Posted February 2, 2015 Author Posted February 2, 2015 (edited) Still wrong.. You will give reward ONLY for fighter class. At 100 pvp fighter tattoo, and for each kill mage. Look my previous post, Fanky's code. Debug it and don't mess :) // Add Fighter or Mage Tattoos if (Config.REWARD_TATTOOS_ENABLE) { if (getPvpKills() == Config.PVP_COUNT) { if (!isMageClass()) { addItem("Tattoo", Config.TATTOO_FIGHTER_ID, Config.FIGHTER_TATTOO_COUNT, this, true); sendMessage("Congratulations! " + Config.PVP_COUNT + " PvP Kills! You won Fighter Tattoo."); } else { addItem("Tattoo", Config.TATTOO_MAGE_ID, Config.MAGE_TATTOO_COUNT, this, true); sendMessage("Congratulations! " + Config.PVP_COUNT + " PvP Kills! You won Mage Tattoo."); } } } } On eclipse i use this. :P I give wrong check here on quote. :lol: I put the wrong copy / paste lines one by one. Now is ok? Edited February 2, 2015 by 'Baggos' Quote
SweeTs Posted February 2, 2015 Posted February 2, 2015 (edited) Yeah, that's it :) Offtopic: I'm thinking about new section for "such" codes. :D Edited February 2, 2015 by SweeTs Quote
Tessa Posted February 2, 2015 Posted February 2, 2015 (edited) Yeah, that's it :) Offtopic: I'm thinking about new section for "such" codes. :D try/catch? :lol: Edited February 2, 2015 by Tessa Quote
'Baggos' Posted February 2, 2015 Author Posted February 2, 2015 (edited) Yeah, that's it :) Offtopic: I'm thinking about new section for "such" codes. :D Sorry, my English is shit . What do you mean ? :P hahahaha now i understand... yes it is a idea.. :lol: You've right... :( for people who do not have good computer to test. Edited February 2, 2015 by 'Baggos' Quote
SweeTs Posted February 2, 2015 Posted February 2, 2015 try/catch? :lol: Hehe, sort of :D Try to code and catch mistakes :D Quote
Wolf Bitch Posted February 14, 2015 Posted February 14, 2015 nice share mate, btw you need to remove the last " } " at the l2pcinstance part otherwise it's wrong to be like this one + + // Add Fighter or Mage Tattoos + if (Config.REWARD_TATTOOS_ENABLE) + { + if (getPvpKills() == Config.PVP_COUNT) + { + if (!isMageClass()) + { + addItem("Tattoo", Config.TATTOO_FIGHTER_ID, Config.FIGHTER_TATTOO_COUNT, this, true); + sendMessage("Congratulations! " + Config.PVP_COUNT + " PvP Kills! You won Fighter Tattoo."); + } + else + { + addItem("Tattoo", Config.TATTOO_MAGE_ID, Config.MAGE_TATTOO_COUNT, this, true); + sendMessage("Congratulations! " + Config.PVP_COUNT + " PvP Kills! You won Mage Tattoo."); + } + } + } + Quote
Red-Hair-Shanks Posted February 25, 2015 Posted February 25, 2015 nice idea bro :D i will update this code soon with more features :D Quote
SweeTs Posted February 25, 2015 Posted February 25, 2015 This logic is kinda meh, should be opposite (remove ! and switch mage <-> fighter code place) :D + if (!isMageClass()) + { + addItem("Tattoo", Config.TATTOO_FIGHTER_ID, Config.FIGHTER_TATTOO_COUNT, this, true); + sendMessage("Congratulations! " + Config.PVP_COUNT + " PvP Kills! You won Fighter Tattoo."); + } + else + { + addItem("Tattoo", Config.TATTOO_MAGE_ID, Config.MAGE_TATTOO_COUNT, this, true); + sendMessage("Congratulations! " + Config.PVP_COUNT + " PvP Kills! You won Mage Tattoo."); + } Quote
'Baggos' Posted February 25, 2015 Author Posted February 25, 2015 (edited) The same shit-Item will get again . :P What does it matter if the first is mage or fighter. It has to do with "image" yes. I agree. Edited February 25, 2015 by 'Baggos' Quote
SweeTs Posted February 25, 2015 Posted February 25, 2015 (edited) The check name speak for itself :D It's like you would check for AIO and non AIO char.. if (!player.isAio()) //if not aio, loled //blabla else //if aio, loled //blabla Which is plain stupid. The check is made to check if is aio, so use it like it's desired. I guess, now you get the point. Edited February 25, 2015 by SweeTs Quote
'Baggos' Posted February 25, 2015 Author Posted February 25, 2015 (edited) The check name speak for itself :D It's like you would check for AIO and non AIO char.. if (!player.isAio()) //if not aio, loled //blabla else //if aio, loled //blabla Which is plain stupid. The check is made to check if is aio, so use it like it's desired. I guess, now you get the point. Of course. is the same thing.. It is somewhat "stupidity" in this case use "!" I knew the meaning from that day. In this case have to be like if (isMageClass()) get this else get this. But now... if a woman kiss the your upper lip, the same would you feel with a kiss on the bottom lip.. Edited February 25, 2015 by 'Baggos' Quote
SweeTs Posted February 25, 2015 Posted February 25, 2015 (edited) But now... if a woman kiss the your upper lip, the same would you feel with a kiss on the bottom lip.. False statement, I can feel the difference. Stop kissing with a goat* :troll: * - just kidding Edited February 25, 2015 by SweeTs Quote
'Baggos' Posted February 25, 2015 Author Posted February 25, 2015 (edited) False statement, I can feel the difference. Stop kissing with a goat* :troll: * - just kidding hahaha You're a crazy guy... :happyforever: Be careful after 5 drinks... Never you go near on goats.. Edited February 25, 2015 by 'Baggos' Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.