Jump to content
  • 0

I Guess It's "simple" To Create...


R3spawn

Question

Hello fellas...

 

I came to an idea and I hope it's not hard to to and if you have the time, could you please give me a suggestions how to do the following...

 

I'm not asking to write the whole code for me. I just want to give it try and do it by myself so I can continue practicing my basic knowledge.

 

The thing is: When every player, comes up to XX amount of PvP points, he gets a YY item with ZZ id spawned in his inventory (quests) item, automatically.

 

If you can, tell me where should I start.

 

Peace!

Link to comment
Share on other sites

Recommended Posts

  • 0

check the void,

+        if(activeChar.getPvpKills() == Config.PVP_AMOUNTPVP1)
+        {
+            activeChar.getInventory().addItem("PvP Reward", Config.PVP_REWARD1, Config.PVP_AMOUNT1, activeChar, activeChar);
+            activeChar.sendMessage("You've been rewarded for your pvp amounts!");
+        }
+        
+        else if(activeChar.getPvpKills() == Config.PVP_AMOUNTPVP2)
+        {
+            activeChar.getInventory().addItem("PvP Reward", Config.PVP_REWARD2, Config.PVP_AMOUNT2, activeChar, activeChar);
+            activeChar.sendMessage("You've been rewarded for your pvp amounts!");
+        }
+        
+        else if(activeChar.getPvpKills() == Config.PVP_AMOUNTPVP3)
+        {
+            activeChar.getInventory().addItem("PvP Reward", Config.PVP_REWARD3, Config.PVP_AMOUNT3, activeChar, activeChar);
+            activeChar.sendMessage("You've been rewarded for your pvp amounts!");
+        }

 

 

before it was >= at every check now its == so player will be rewarded only at XX pvp

Edited by Fanky
Link to comment
Share on other sites

  • 0

by pvp points you mean pvp amount or a completely new system called 'pvp points'?

 

if its the second,you have to provide more informations about this system

Link to comment
Share on other sites

  • 0

by pvp points you mean pvp amount or a completely new system called 'pvp points'?

 

if its the second,you have to provide more informations about this system

Not a new pvp system ofcourse. The one that's already existing, but only when the player reaches the XX amount. The item is automatically spawned in his inventory.

Link to comment
Share on other sites

  • 0

I wrote something for you

### Eclipse Workspace Patch 1.0
#P gameserver
Index: java/net/sf/l2j/gameserver/customs/PvPRewards.java
===================================================================
--- java/net/sf/l2j/gameserver/customs/PvPRewards.java	(revision 0)
+++ java/net/sf/l2j/gameserver/customs/PvPRewards.java	(working copy)
@@ -0,0 +1,57 @@
+/* This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2, or (at your option)
+ * any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
+ * 02111-1307, USA.
+ *
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+package net.sf.l2j.gameserver.customs;
+
+import net.sf.l2j.Config;
+import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
+
+
+public class PvPRewards
+{
+	public static PvPRewards getInstance()
+	{
+		PvPRewards _instance = null;
+		if (_instance == null)
+		{
+			_instance = new PvPRewards();
+		}
+		
+		return _instance;
+	}
+	
+	public void addRewardPvP(L2PcInstance activeChar)
+	{
+		if(activeChar.getPvpKills() == Config.PVP_AMOUNTPVP1)
+		{
+			activeChar.getInventory().addItem("PvP Reward", Config.PVP_REWARD1, Config.PVP_AMOUNT1, activeChar, activeChar);
+			activeChar.sendMessage("You've been rewarded for your pvp amounts!");
+		}
+		
+		else if(activeChar.getPvpKills() == Config.PVP_AMOUNTPVP2)
+		{
+			activeChar.getInventory().addItem("PvP Reward", Config.PVP_REWARD2, Config.PVP_AMOUNT2, activeChar, activeChar);
+			activeChar.sendMessage("You've been rewarded for your pvp amounts!");
+		}
+		
+		else if(activeChar.getPvpKills() == Config.PVP_AMOUNTPVP3)
+		{
+			activeChar.getInventory().addItem("PvP Reward", Config.PVP_REWARD3, Config.PVP_AMOUNT3, activeChar, activeChar);
+			activeChar.sendMessage("You've been rewarded for your pvp amounts!");
+		}
+	}
+}
\ No newline at end of file
Index: java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java
===================================================================
--- java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java	(revision 42)
+++ java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java	(working copy)
@@ -56,6 +56,7 @@
 import net.sf.l2j.gameserver.communitybbs.BB.Forum;
 import net.sf.l2j.gameserver.communitybbs.Manager.ForumsBBSManager;
 import net.sf.l2j.gameserver.communitybbs.Manager.RegionBBSManager;
+import net.sf.l2j.gameserver.customs.PvPRewards;
 import net.sf.l2j.gameserver.datatables.AccessLevels;
 import net.sf.l2j.gameserver.datatables.AdminCommandAccessRights;
 import net.sf.l2j.gameserver.datatables.CharNameTable;
@@ -4810,7 +4811,10 @@
     {
         // Add karma to attacker and increase its PK counter
         setPvpKills(getPvpKills() + 1);
+        PvPRewards.getInstance().addRewardPvP(this);
         
+        
+        
         PvpPkColorSystem.getInstance().checkPvpColors(this);
 
         // Send a Server->Client UserInfo packet to attacker with its Karma and PK Counter
Index: java/net/sf/l2j/Config.java
===================================================================
--- java/net/sf/l2j/Config.java	(revision 41)
+++ java/net/sf/l2j/Config.java	(working copy)
@@ -686,6 +686,16 @@
 	public static Map<Integer, Integer> PK_COLORS_LIST;
 	public static boolean ALLOW_PVP_COLOR_SYSTEM;
 	public static boolean ALLOW_PK_COLOR_SYSTEM;
+	
+	public static int PVP_AMOUNTPVP1;
+	public static int PVP_AMOUNT1;
+	public static int PVP_REWARD1;
+	public static int PVP_AMOUNTPVP2;
+	public static int PVP_AMOUNT2;
+	public static int PVP_REWARD2;
+	public static int PVP_AMOUNTPVP3;
+	public static int PVP_AMOUNT3;
+	public static int PVP_REWARD3;
     //--------------------------------------------------
 
     /**
@@ -810,6 +820,16 @@
             	String[] more_splitted_pks = i.split(",");
             	PVP_COLORS_LIST.put(Integer.parseInt(more_splitted_pks[0]), Integer.decode("0x" + more_splitted_pks[1]));
             	}
+            	
+            	PVP_AMOUNTPVP1 = Integer.parseInt(pvpmods.getProperty("PvpsRequiredFor1stReward","100"));
+            	PVP_REWARD1 = Integer.parseInt(pvpmods.getProperty("Reward1ID","57"));
+            	PVP_AMOUNT1 = Integer.parseInt(pvpmods.getProperty("Amount1","10000"));
+            	PVP_AMOUNTPVP2 = Integer.parseInt(pvpmods.getProperty("PvpsRequiredFor2ndReward","100"));
+            	PVP_REWARD2 = Integer.parseInt(pvpmods.getProperty("Reward2ID","57"));
+            	PVP_AMOUNT2 = Integer.parseInt(pvpmods.getProperty("Amount2","10000"));
+            	PVP_AMOUNTPVP3 = Integer.parseInt(pvpmods.getProperty("PvpsRequiredFor3rdReward","100"));
+            	PVP_REWARD3 = Integer.parseInt(pvpmods.getProperty("Reward3ID","57"));
+            	PVP_AMOUNT3 = Integer.parseInt(pvpmods.getProperty("Amount3","10000"));
             }
             catch (Exception e)
             {

Edited by Fanky
Link to comment
Share on other sites

  • 0

I was looking for something like this for items and custom skills. But I'm getting a few errors and warnings, but it could be because I am on Highfive beta. 

PvPRewards _instance = null;
		if (_instance == null)
		{
			_instance = new PvPRewards();
		}
		

Warning says: Redundant null check: The variable_instance can only be null at this location.

And errors for 

			PVP_AMOUNTPVP1 = Integer.parseInt(pvpmods.getProperty("PvpsRequiredFor1stReward","100"));
			PVP_REWARD1 = Integer.parseInt(pvpmods.getProperty("Reward1ID","57"));
			PVP_AMOUNT1 = Integer.parseInt(pvpmods.getProperty("Amount1","10000"));
			PVP_AMOUNTPVP2 = Integer.parseInt(pvpmods.getProperty("PvpsRequiredFor2ndReward","100"));
			PVP_REWARD2 = Integer.parseInt(pvpmods.getProperty("Reward2ID","57"));
			PVP_AMOUNT2 = Integer.parseInt(pvpmods.getProperty("Amount2","10000"));
			PVP_AMOUNTPVP3 = Integer.parseInt(pvpmods.getProperty("PvpsRequiredFor3rdReward","100"));
			PVP_REWARD3 = Integer.parseInt(pvpmods.getProperty("Reward3ID","57"));
			PVP_AMOUNT3 = Integer.parseInt(pvpmods.getProperty("Amount3","10000"));

pvpmods cannot be resolved.
Link to comment
Share on other sites

  • 0

That's what I figured, I am currently trying to mess around with it and add it to the PVP_CONFIG_FILE section like the rest of all the pvp settings here like PVP_AMOUNTPVP1 = PVPSettings.getInt("PvpsRequiredFor1stReward", "100"); but no luck so far.

Edited by brett16
Link to comment
Share on other sites

  • 0

you have to place thse config files in the place that your pvp configs are stored

 

 

PVP_AMOUNTPVP1 = Integer.parseInt(pvpmods.getProperty("PvpsRequiredFor1stReward","100"));
            PVP_REWARD1 = Integer.parseInt(pvpmods.getProperty("Reward1ID","57"));
            PVP_AMOUNT1 = Integer.parseInt(pvpmods.getProperty("Amount1","10000"));
            PVP_AMOUNTPVP2 = Integer.parseInt(pvpmods.getProperty("PvpsRequiredFor2ndReward","100"));
            PVP_REWARD2 = Integer.parseInt(pvpmods.getProperty("Reward2ID","57"));
            PVP_AMOUNT2 = Integer.parseInt(pvpmods.getProperty("Amount2","10000"));
            PVP_AMOUNTPVP3 = Integer.parseInt(pvpmods.getProperty("PvpsRequiredFor3rdReward","100"));
            PVP_REWARD3 = Integer.parseInt(pvpmods.getProperty("Reward3ID","57"));
            PVP_AMOUNT3 = Integer.parseInt(pvpmods.getProperty("Amount3","10000"));
Link to comment
Share on other sites

  • 0
// Load PvP L2Properties file (if exists)
			final PropertiesParser PVPSettings = new PropertiesParser(PVP_CONFIG_FILE);
			
			KARMA_DROP_GM = PVPSettings.getBoolean("CanGMDropEquipment", false);
			KARMA_AWARD_PK_KILL = PVPSettings.getBoolean("AwardPKKillPVPPoint", false);
			KARMA_PK_LIMIT = PVPSettings.getInt("MinimumPKRequiredToDrop", 5);
			KARMA_NONDROPPABLE_PET_ITEMS = PVPSettings.getString("ListOfPetItems", "2375,3500,3501,3502,4422,4423,4424,4425,6648,6649,6650,9882");
			KARMA_NONDROPPABLE_ITEMS = PVPSettings.getString("ListOfNonDroppableItems", "57,1147,425,1146,461,10,2368,7,6,2370,2369,6842,6611,6612,6613,6614,6615,6616,6617,6618,6619,6620,6621,7694,8181,5575,7694,9388,9389,9390");
			PVP_AMOUNTPVP1 = PVPSettings.getInt("PvpsRequiredFor1stReward", 100);
			PVP_REWARD1 = PVPSettings.getInt("Reward1ID", 57);
			PVP_AMOUNT1 = PVPSettings.getInt("Amount1", 10000);
			PVP_AMOUNTPVP2 = PVPSettings.getInt("PvpsRequiredFor2ndReward", 100);
			PVP_REWARD2 = PVPSettings.getInt("Reward2ID", 57);
			PVP_AMOUNT2 = PVPSettings.getInt("Amount2", 10000);
			PVP_AMOUNTPVP3 = PVPSettings.getInt("PvpsRequiredFor3rdReward", 100);
			PVP_REWARD3 = PVPSettings.getInt("Reward3ID", 57);
			PVP_AMOUNT3 = PVPSettings.getInt("Amount3", 10000);

I have no errors so I am going to test it now see if this works.

Link to comment
Share on other sites

  • 0

It works if you want the reward for every pvp kill, doesn't just give the reward at the 100th pvp count. I gave myself 99 pvps and killed a test character for 100 and got the reward, and kept killing it a few more times and kept getting the reward.

Link to comment
Share on other sites

  • 0

i'm sry,it was fast.

just do it like this and its gonna be okey

### Eclipse Workspace Patch 1.0
#P gameserver
Index: java/net/sf/l2j/gameserver/customs/PvPRewards.java
===================================================================
--- java/net/sf/l2j/gameserver/customs/PvPRewards.java    (revision 0)
+++ java/net/sf/l2j/gameserver/customs/PvPRewards.java    (working copy)
@@ -0,0 +1,57 @@
+/* This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2, or (at your option)
+ * any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
+ * 02111-1307, USA.
+ *
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+package net.sf.l2j.gameserver.customs;
+
+import net.sf.l2j.Config;
+import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
+
+
+public class PvPRewards
+{
+    public static PvPRewards getInstance()
+    {
+        PvPRewards _instance = null;
+        if (_instance == null)
+        {
+            _instance = new PvPRewards();
+        }
+        
+        return _instance;
+    }
+    
+    public void addRewardPvP(L2PcInstance activeChar)
+    {
+        if(activeChar.getPvpKills() == Config.PVP_AMOUNTPVP1)
+        {
+            activeChar.getInventory().addItem("PvP Reward", Config.PVP_REWARD1, Config.PVP_AMOUNT1, activeChar, activeChar);
+            activeChar.sendMessage("You've been rewarded for your pvp amounts!");
+        }
+        
+        else if(activeChar.getPvpKills() == Config.PVP_AMOUNTPVP2)
+        {
+            activeChar.getInventory().addItem("PvP Reward", Config.PVP_REWARD2, Config.PVP_AMOUNT2, activeChar, activeChar);
+            activeChar.sendMessage("You've been rewarded for your pvp amounts!");
+        }
+        
+        else if(activeChar.getPvpKills() == Config.PVP_AMOUNTPVP3)
+        {
+            activeChar.getInventory().addItem("PvP Reward", Config.PVP_REWARD3, Config.PVP_AMOUNT3, activeChar, activeChar);
+            activeChar.sendMessage("You've been rewarded for your pvp amounts!");
+        }
+    }
+}
\ No newline at end of file
Index: java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java
===================================================================
--- java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java    (revision 42)
+++ java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java    (working copy)
@@ -56,6 +56,7 @@
import net.sf.l2j.gameserver.communitybbs.BB.Forum;
import net.sf.l2j.gameserver.communitybbs.Manager.ForumsBBSManager;
import net.sf.l2j.gameserver.communitybbs.Manager.RegionBBSManager;
+import net.sf.l2j.gameserver.customs.PvPRewards;
import net.sf.l2j.gameserver.datatables.AccessLevels;
import net.sf.l2j.gameserver.datatables.AdminCommandAccessRights;
import net.sf.l2j.gameserver.datatables.CharNameTable;
@@ -4810,7 +4811,10 @@
{
// Add karma to attacker and increase its PK counter
setPvpKills(getPvpKills() + 1);
+ PvPRewards.getInstance().addRewardPvP(this);

+ 
+ 
PvpPkColorSystem.getInstance().checkPvpColors(this);

// Send a Server->Client UserInfo packet to attacker with its Karma and PK Counter
Index: java/net/sf/l2j/Config.java
===================================================================
--- java/net/sf/l2j/Config.java    (revision 41)
+++ java/net/sf/l2j/Config.java    (working copy)
@@ -686,6 +686,16 @@
    public static Map<Integer, Integer> PK_COLORS_LIST;
    public static boolean ALLOW_PVP_COLOR_SYSTEM;
    public static boolean ALLOW_PK_COLOR_SYSTEM;
+    
+    public static int PVP_AMOUNTPVP1;
+    public static int PVP_AMOUNT1;
+    public static int PVP_REWARD1;
+    public static int PVP_AMOUNTPVP2;
+    public static int PVP_AMOUNT2;
+    public static int PVP_REWARD2;
+    public static int PVP_AMOUNTPVP3;
+    public static int PVP_AMOUNT3;
+    public static int PVP_REWARD3;
//--------------------------------------------------

/**
@@ -810,6 +820,16 @@
    String[] more_splitted_pks = i.split(",");
    PVP_COLORS_LIST.put(Integer.parseInt(more_splitted_pks[0]), Integer.decode("0x" + more_splitted_pks[1]));
    }
+     
+     PVP_AMOUNTPVP1 = Integer.parseInt(pvpmods.getProperty("PvpsRequiredFor1stReward","100"));
+     PVP_REWARD1 = Integer.parseInt(pvpmods.getProperty("Reward1ID","57"));
+     PVP_AMOUNT1 = Integer.parseInt(pvpmods.getProperty("Amount1","10000"));
+     PVP_AMOUNTPVP2 = Integer.parseInt(pvpmods.getProperty("PvpsRequiredFor2ndReward","100"));
+     PVP_REWARD2 = Integer.parseInt(pvpmods.getProperty("Reward2ID","57"));
+     PVP_AMOUNT2 = Integer.parseInt(pvpmods.getProperty("Amount2","10000"));
+     PVP_AMOUNTPVP3 = Integer.parseInt(pvpmods.getProperty("PvpsRequiredFor3rdReward","100"));
+     PVP_REWARD3 = Integer.parseInt(pvpmods.getProperty("Reward3ID","57"));
+     PVP_AMOUNT3 = Integer.parseInt(pvpmods.getProperty("Amount3","10000"));
}
catch (Exception e)
{
Edited by Fanky
Link to comment
Share on other sites

Guest
This topic is now closed to further replies.


  • Posts

    • So excited to announce 3x Telegram Premium (6 months)   Join our official TG and participate to win!   Asocks.com - trusted proxy service providing mobile and residential proxies with a single price of $3 per 1GB   A huge locations pool and high speed will help complete all tasks    
    • Well, sorry not sorry for resurrecting old topic, but I believe it's ultimately stupid to implement license checks like Vilmis did 🙂   private static String url = "jdbc:mysql://185.80.128.233/" + getData("Zm9ydW1fZGI="); private static String username = getData("bXJjb3B5cmlnaHQ="); private static String password = getData("Y29weXJpZ2h0XzEyMw=="); con = GlobalDB.getInstance().getConnection(); PreparedStatement statement; statement = con.prepareStatement("SELECT field_6 from core_pfields_content WHERE member_id = ?"); statement.setInt(1, Config.FORUM_USER_ID); ResultSet rset = statement.executeQuery();   This awesome way of coding things leaves us with base64-encoded credentials and DB exposed and accessible globally 😉 Btw he checks his licensing data from some plugin generated table his forum uses. Vilmis took action and ensured that mrcopyright user would have only needed accesses and rights for this operation. But he forgot to ensure that his INFORMATION_SCHEMA database would not be exposed and readable... That leads us to fully readable server variables like version used (10.1.26-MariaDB-0+deb9u1 - pretty ancient DB and OS, I'd assume). From here you can go south and do some kinky stuff, if you want and have knowledge for that. But who cares, right?   Ooh, table core_pfields_content field_6 is IP address which is checked by FORUM_USER_ID. Yep, you can query all IP addresses there (124 of them right now) and also do whatever you want with them! 🙂  The most fun part? Files source has been shared what, more than 2 years ago?  Vilmis still uses very same credentials and never changed it after sources exposure - who cares. Although, "sources" may be way too strong word here. If anyone still use paid Orion versions, I'd suggest packing your shit and leaving immediately, or at least fix this incompetent fool caused problems. It's obvious Vilmis don't care or maybe doesn't even know from the first place how to solve this problem (hint hint - tiny PHP Rest API microservice which would do absolutely the same but without exposing sensitive data?). By doing that, he exposes his infrastructure and YOUR data, and he does that for more than 2 years now 🙂 Developer of century!    
    • rename the l2.bin into l2.exe
    • L2LIVE.PRO- Dynamic Mid-rates Essence Seven Signs GRAND OPENING - July 5, 20:00 GMT+3 (EEST) TEST SERVER IS OPEN - COME AND CHECK IT OUT TODAY! Join our community and be part of it at: https://www.l2live.pro https://discord.gg/k3NMgR4Dmu   Server description * EXP/SP: Dynamic (x1- x100 based on your level, *before* Sayha and EXP buffs * Adena: x50 / Item Drop: x10 / Fishing EXP increased / Attribute EXP increased * Simplified gameplay to stay in the loop while not spending hours and hours farming * Starter Pack containing very useful items for beginners * MP replenishing potions with auto-consumption * No overpowered donations L2LIVE shop * All spellbook coupons, pet spellbook coupons and master books are sold via Game Assistant * Additionally you can buy SP pouches, enchanted talismans, pet training guides and various other consumables for Adena and L-Coin * More items such as cloaks, more talismans, agathions, belts, pendants, enchantment scrolls of various grades, evolution stones, etc will be added! Shop server as a shortcut, and all retail-like ways of earning items are still here! L-Coins * Drops with small change and in random amounts from Lv60+ monsters  * All raidbosses drop random amount of L-Coin Pouches generating up to 420 Lcoin per unit. **Grand Olympiad and Events** * Grand Olympiad is held week day * Format is 1v1, unlimited weekly fights  * Heroes are declared weekly at Sunday * There are three automated events - TvT, CTF and Deathmatch, running at evenings * Orc Fortress, Battle with Balok, Keber Hunter, Archievements Box, Daily Gift Calendar provisional events are active too Custom user commands * .offlineplay command, your character will keep playing till death or server restart * .offlineshop command, keeps your shop sitting until all items are purchased * .apon / .apoff - enable/disable HP/MP autoconsume And lots of other small improvements are waiting for you!   Join our community and be part of it at: https://www.l2live.pro https://discord.gg/k3NMgR4Dmu
  • Topics

×
×
  • Create New...