Help Double Login Session Bug.

[kenzoR]

Does anyone have a .diff patch for l2jfrozen rev. 1004 that fixes the double login session bugg? please

[Devlin]

http://pastebin.com/tpHMn9hd

 

I found it shared.

[LNG]

http://pastebin.com/tpHMn9hd

 

I found it shared.

 

Notice that credits goes to L2J Team, especially to Nos.

 

Cheers,

[kenzoR]

Thanks guys, altough I dont know how to apply that bugg i must find some1 to check it . 

I will post feedback soon

/THanks :D

[koksas]

After reconnect to server character cant be load... Bad fix... Please give someone normal fix of this bug..

[Devlin]

It wasn't my fix, I just found it.

[SweeTs]

Please give someone normal fix of this bug..

http://trac.l2jserver.com/changeset/6477/

[koksas]

SweeTs with this fix, after one login in your char ,and logout you cant login again in your char... Something bad in this code..  I cant find good fix... Im added this... Its good with login, logout... But bugg is still working. Maybe someone know where in there can be mistake ? :(

    public boolean addGameServerLogin(String account, L2GameClient client)  {
        
           L2GameClient savedClient = _accountsInGameServer.get(account);
          
                   if (savedClient != null) {
                   if (savedClient.isDetached()) {
                   if (Config.DEBUG)
                   _log.info("Old Client was disconnected: Offline or OfflineMode --> Login Again");
                   ((FastMap<String, L2GameClient>) _accountsInGameServer).put(account, client);
                   return true;
                   }
                   if (Config.DEBUG)
                   _log.info("Old Client was online --> Close Old Client Connection");
                   savedClient.closeNow();
                   _accountsInGameServer.remove(account);
                   return false;
                   }
                   if (Config.DEBUG)
                   _log.info("Client was not online --> New Client Connection");
                   ((FastMap<String, L2GameClient>) _accountsInGameServer).put(account, client);
                   return true;
                   }
}





    L2GameClient savedClient = _accountsInGameServer.get(account);

    if (savedClient != null) {
        if (savedClient.isDetached()) {
            _log.info("Old Client was disconnected: Offline or OfflineMode --> Login Again [Account: " + account + "]");
            ((FastMap<String, L2GameClient>) _accountsInGameServer).put(
                    account, client);
            return true;
        } else {
            _log.info("Old Client was online --> Close Old Client Connection [Account: " + account + "]");
            savedClient.closeNow();
            _accountsInGameServer.remove(account);
            return false;
        }
    } else {
        _log.info("Client was not online --> New Client Connection [Account: " + account + "]");
        ((FastMap<String, L2GameClient>) _accountsInGameServer).put(
                account, client);
        return true;
    }
} 




IN THIS CODE "ELSE" anything mean or no ? Becouse with else i get yellow code... ???

Edited June 11, 2014 by koksas

[koksas]

bump

Edited June 11, 2014 by koksas

[koksas]

bu,p

[te0x]

authlogin founded in l2jserver

// avoid potential exploits
if (client.getAccountName() == null)
{
 // Preventing duplicate login in case client login server socket was disconnected or this packet was not sent yet
if (LoginServerThread.getInstance().addGameServerLogin(_loginName, client))
{
 client.setAccountName(_loginName);
 LoginServerThread.getInstance().addWaitingClientAndSendRequest(_loginName, client, key);
}
else
{
 client.close((L2GameServerPacket) null);
 }

+    public boolean addGameServerLogin(String account, L2GameClient client) {
+
+        L2GameClient savedClient = _accountsInGameServer.get(account);
+
+        if (savedClient != null) {
+            if (savedClient.isDetached()) {
+                LOGGER.debug("Old Client was disconnected: Offline or OfflineMode --> Login Again [Account: " + account + "]");
+                ((FastMap<String, L2GameClient>) _accountsInGameServer).put(
+                        account, client);
+                return true;
+            } else {
+                LOGGER.debug("Old Client was online --> Close Old Client Connection [Account: " + account + "]");
+                savedClient.closeNow();
+                _accountsInGameServer.remove(account);
+                return false;
+            }
+        } else {
+            LOGGER.debug("Client was not online --> New Client Connection [Account: " + account + "]");
+            ((FastMap<String, L2GameClient>) _accountsInGameServer).put(
+                    account, client);
+            return true;
+        }
+    }

well i found this in the gta version of frozen.. i dont have idea if this works

 

 

also this 

public boolean addGameServerLogin(String account, L2GameClient client) 
 { 
 return _accountsInGameServer.putIfAbsent(account, client) == null; 
}

Edited June 11, 2014 by te0x