[Share] H5 Npc Enchant Manager V2 /java/

SweeTs · November 2, 2013

dude

imports... -.-'

I know that, but others don't as you see.. :P You ask them to show the error, given line where is error and they don't get it and they give you random shit.. It's really frustrating sometimes.. :D

fissban · November 9, 2013

this code is hardcode.

the html is better to define them as such and not within the code.

execution times is better to write this as follows

        String html = "<html>"+                        "<title>L2Mondial Enchanter</title>"+
                        "<body>"+
                            "<center><img src=\"L2UI_CH3.herotower_deco\" width=256 height=32><br>"+
                            "<font color=\"FF9900\">" + title + "</font></center><br>"+
                            content +
                            "<br><br>"+
                            "<center><a action=\"bypass -h Quest Enchant " + enchantType + "\">Go Back</a></center>"+
                        "</body>"+
                        "</html>";


        return html;

TextBuilder _td = new TextBuilder();
_td.append("<html>");
        _td.append("<title>L2Mondial Enchanter</title>");
        _td.append("<body>");
        _td.append("<center><img src=\"L2UI_CH3.herotower_deco\" width=256 height=32><br>");
        _td.append("<font color=\"FF9900\">" + title + "</font></center><br>" + content + "<br><br>");
        _td.append("<center><a action=\"bypass -h Quest Enchant " + enchantType + "\">Go Back</a></center>");
        _td.append("</body>");
        _td.append("</html>");


        return _td.toString();

MlDNlGHT · November 9, 2013

int npcId = 9994;

// Item required to enchant armor +1

int itemRequiredArmor = 6393;

int itemRequiredArmorCount = 50;

// Item required to enchant jewels +1

int itemRequiredJewels = 6393;

int itemRequiredJewelsCount = 50;

// Item required to enchant weapon +1

int itemRequiredWeapon = 6393;

int itemRequiredWeaponCount = 150;

// Item required to enchant belt/shirt +1

int itemRequiredBeltShirt = 6393;

int itemRequiredBeltShirtCount = 100;

all should be private final static

Overall a cool code, but imo its very poor

Disagree, the variables in this class are only being accessed by it's own class/itself. It is not being called by any other outside class or instance.

Why would you want to make all the variables global? This will keep them in memory even when this instance/class is unloaded/not in use.

Having them as non static, dynamic, will only access them and keep them in memory while the instance of that class is still being used/in memory.

You should only use static methods/variables etc when you need to access them from other classes/instances, and dont need to initiate a new instance of the class holding the needed variables/methods. Hope I explained it well, try the example program and you should see.

They Should be -> private final int

Example:

void main(){
{
dynamic int a = 1;
static int b = 1;
}
// a deleted from memory but b still is there
cout << b;
cout << a; // error occured because a deleted
}

Edited November 9, 2013 by MlDNlGHT

HappyLDE · November 9, 2013

Disagree, the variables in this class are only being accessed by it's own class/itself. It is not being called by any other outside class or instance.

Why would you want to make all the variables global? This will keep them in memory even when this instance/class is unloaded/not in use.

Having them as non static, dynamic, will only access them and keep them in memory while the instance of that class is still being used/in memory.

You should only use static methods/variables etc when you need to access them from other classes/instances, and dont need to initiate a new instance of the class holding the needed variables/methods. Hope I explained it well, try the example program and you should see.

They Should be -> private final int

Example:
void main(){
{
dynamic int a = 1;
static int b = 1;
}
// a deleted from memory but b still is there
cout << b;
cout << a; // error occured because a deleted
}

Good explanation and i thank you for taking the time!

Karasu · November 11, 2013

This is what ive been looking for, ur autoenchant system rocks! gz happy

xdem · November 11, 2013

Disagree, the variables in this class are only being accessed by it's own class/itself. It is not being called by any other outside class or instance.

Why would you want to make all the variables global? This will keep them in memory even when this instance/class is unloaded/not in use.

Having them as non static, dynamic, will only access them and keep them in memory while the instance of that class is still being used/in memory.

You should only use static methods/variables etc when you need to access them from other classes/instances, and dont need to initiate a new instance of the class holding the needed variables/methods. Hope I explained it well, try the example program and you should see.

They Should be -> private final int

Example:
void main(){
{
dynamic int a = 1;
static int b = 1;
}
// a deleted from memory but b still is there
cout << b;
cout << a; // error occured because a deleted
}

it should be static since the variable belongs to the class and not neceserly to the object, just like config variables... Static variables have better perfomance than non-static, for example they are faster.

I find no reason for them to be nonstatic since I see no OOP here

However I will neither argue with you, your argument is valid, since the "perfomance" while alocating memory is nowaday useless due to the modern JVMs

Edited November 11, 2013 by xdem

davidBm · November 11, 2013

Error. Help. http://postimg.org/image/r28k0kbw1/ For all items he say is no't encantable!!!

Here is the code what i make for freya. Some help plz thx

package custom.Enchant;

import java.util.logging.Logger;

import com.l2jserver.gameserver.model.actor.L2Npc;

import com.l2jserver.gameserver.model.actor.instance.L2PcInstance;

import com.l2jserver.gameserver.model.itemcontainer.Inventory;

import com.l2jserver.gameserver.model.L2ItemInstance;

import com.l2jserver.gameserver.model.olympiad.OlympiadManager;

import com.l2jserver.gameserver.model.quest.Quest;

import com.l2jserver.gameserver.model.quest.QuestState;

import com.l2jserver.gameserver.network.serverpackets.CharInfo;

import com.l2jserver.gameserver.network.serverpackets.ExBrExtraUserInfo;

import com.l2jserver.gameserver.network.serverpackets.InventoryUpdate;

import com.l2jserver.gameserver.network.serverpackets.UserInfo;

public class Enchant extends Quest

{

public static final Logger _log = Logger.getLogger(Enchant.class.getName());

private final static int npcId = 9994;

// Item required to enchant armor +1

private final static int itemRequiredArmor = 6393;

private final static int itemRequiredArmorCount = 50;

// Item required to enchant jewels +1

private final static int itemRequiredJewels = 6393;

private final static int itemRequiredJewelsCount = 50;

// Item required to enchant weapon +1

private final static int itemRequiredWeapon = 6393;

private final static int itemRequiredWeaponCount = 150;

// Item required to enchant belt/shirt +1

private final static int itemRequiredBeltShirt = 6393;

private final static int itemRequiredBeltShirtCount = 100;

public Enchant(int questId, String name, String descr)

{

super(questId, name, descr);

addStartNpc(npcId);

addFirstTalkId(npcId);

addTalkId(npcId);

}

public static void main(String[] args)

{

new Enchant(-1, Enchant.class.getSimpleName(), "custom");

}

public String onFirstTalk(L2Npc npc, L2PcInstance player)

{

String enchantType = "Enchant.htm";

if (player.getQuestState(getName()) == null)

{

newQuestState(player);

}

else if (player.isInCombat())

{

return drawHtml("You are in combat", "Don't fight if you want to talk with me!", enchantType);

}

else if (player.getPvpFlag() == 1)

{

return drawHtml("You are flagged", "Don't fight if you want to talk with me!", enchantType);

}

else if (player.getKarma() != 0)

{

return drawHtml("You are in chaotic state", "Don't fight if you want to talk with me!", enchantType);

}

else if (OlympiadManager.getInstance().isRegistered(player))

{

return drawHtml("You are registered for Olympiad", "You can't use my services<br1>while playing the Olympiad.", enchantType);

}

return "Enchant.htm";

}

public String onAdvEvent(String event, L2Npc npc, L2PcInstance player)

{

String htmlText = event;

String enchantType = "Enchant.htm";

int armorType = -1;

// Armor parts

if (event.equals("enchantHelmet"))

{

armorType = Inventory.PAPERDOLL_HEAD;

enchantType = "EnchantArmor.htm";