Jump to content
  • 0

Question

Posted

1. ERROR in \PartyTeleporter.java <at line 74>

                For,L2Character character : zone.getCharactersInside<>.Values<>>

                                                                                                            ^^^^

The method values<> is undefined for the tybe L2tintObjectHashMap<L2Character>

----------

2. ERROR in \PartyTeleporter.java <at line 89>

                For,L2Character character : zone.getCharactersInside<>.Values<>>

----------

The method values<> is undefined for the tybe L2tintObjectHashMap<L2Character>

Recommended Posts

  • 0
Posted

  [javac] C:\Documents and Settings\Administrator\Desktop\WorckSpace\l2j-high-five\trunk\L2J_Server_High_Five\java\com\l2jserver\gameserver\model\zone\L2ZoneType.java:482: error: illegal start of expression

    [javac] public FastMap<Integer, L2Character> getCharactersInside()

    [javac] ^

    [javac] C:\Documents and Settings\Administrator\Desktop\WorckSpace\l2j-high-five\trunk\L2J_Server_High_Five\java\com\l2jserver\gameserver\model\zone\L2ZoneType.java:482: error: ';' expected

    [javac] public FastMap<Integer, L2Character> getCharactersInside()

    [javac]                                                         ^

    [javac] C:\Documents and Settings\Administrator\Desktop\WorckSpace\l2j-high-five\trunk\L2J_Server_High_Five\java\com\l2jserver\gameserver\model\zone\L2ZoneType.java:486: error: reached end of file while parsing

    [javac] }

    [javac] ^

    [javac] 3 errors

 

  • 0
Posted

Lock how i add the line.

 

 

public void visualizeZone(int z)

{

getZone().visualizeZone(z);

}

{

public FastMap<Integer, L2Character> getCharactersInside()

{

return _characterList;

}

}

  • 0
Posted
  public void visualizeZone(int z)

  {

      getZone().visualizeZone(z);

  }

 

      public FastMap<Integer, L2Character> getCharactersInside()

        {

            return _characterList;

        }

 

 

Try make it like that

  • 0
Posted

 

 

Try make it like that

 

javac] Compiling 1629 source files to C:\Documents and Settings\Administrator\Desktop\WorckSpace\l2j-high-five\trunk\L2J_Server_High_Five\build\classes

    [javac] C:\Documents and Settings\Administrator\Desktop\WorckSpace\l2j-high-five\trunk\L2J_Server_High_Five\java\com\l2jserver\gameserver\model\zone\L2ZoneType.java:485: error: reached end of file while parsing

    [javac]         }

    [javac]           ^

    [javac] 1 error

 

BUILD FAILED

C:\Documents and Settings\Administrator\Desktop\WorckSpace\l2j-high-five\trunk\L2J_Server_High_Five\build.xml:59: Compile failed; see the compiler error output for details.

 

 

If i put like this >>            public FastMap<Integer, L2Character> getCharactersInside()

        {

            return _characterList;

    }

    }

 

He give me the error

 

  [javac] Compiling 1629 source files to C:\Documents and Settings\Administrator\Desktop\WorckSpace\l2j-high-five\trunk\L2J_Server_High_Five\build\classes

    [javac] C:\Documents and Settings\Administrator\Desktop\WorckSpace\l2j-high-five\trunk\L2J_Server_High_Five\java\com\l2jserver\gameserver\model\zone\L2ZoneType.java:482: error: method getCharactersInside() is already defined in class L2ZoneType

    [javac]       public FastMap<Integer, L2Character> getCharactersInside()

    [javac]                                           ^

    [javac] C:\Documents and Settings\Administrator\Desktop\WorckSpace\l2j-high-five\trunk\L2J_Server_High_Five\java\com\l2jserver\gameserver\model\zone\L2ZoneType.java:484: error: incompatible types

    [javac]             return _characterList;

    [javac]                   ^

    [javac]  required: FastMap<Integer,L2Character>

    [javac]  found:    L2TIntObjectHashMap<L2Character>

    [javac] 2 errors

 

BUILD FAILED

C:\Documents and Settings\Administrator\Desktop\WorckSpace\l2j-high-five\trunk\L2J_Server_High_Five\build.xml:59: Compile failed; see the compiler error output for details.

  • 0
Posted

Show me the whole part of this code.

/*

* This program is free software: you can redistribute it and/or modify it under

* the terms of the GNU General Public License as published by the Free Software

* Foundation, either version 3 of the License, or (at your option) any later

* version.

*

* This program is distributed in the hope that it will be useful, but WITHOUT

* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS

* FOR A PARTICULAR PURPOSE. See the GNU General Public License for more

* details.

*

* You should have received a copy of the GNU General Public License along with

* this program. If not, see <http://www.gnu.org/licenses/>.

*/

package com.l2jserver.gameserver.model.zone;

 

import gnu.trove.TObjectProcedure;

 

import java.util.Map;

import java.util.logging.Logger;

 

import javolution.util.FastList;

import javolution.util.FastMap;

 

import com.l2jserver.gameserver.model.L2Object;

import com.l2jserver.gameserver.model.L2Object.InstanceType;

import com.l2jserver.gameserver.model.actor.L2Character;

import com.l2jserver.gameserver.model.actor.instance.L2PcInstance;

import com.l2jserver.gameserver.model.quest.Quest;

import com.l2jserver.gameserver.network.serverpackets.L2GameServerPacket;

import com.l2jserver.gameserver.util.L2TIntObjectHashMap;

 

/**

* Abstract base class for any zone type

* Handles basic operations

*

* @author  durgus

*/

public abstract class L2ZoneType

{

protected static final Logger _log = Logger.getLogger(L2ZoneType.class.getName());

 

private final int _id;

protected L2ZoneForm _zone;

protected L2TIntObjectHashMap<L2Character> _characterList;

 

/** Parameters to affect specific characters */

private boolean _checkAffected = false;

 

private String _name = null;

private int _minLvl;

private int _maxLvl;

private int[] _race;

private int[] _class;

private char _classType;

private Map<Quest.QuestEventType, FastList<Quest>> _questEvents;

private InstanceType _target = InstanceType.L2Character; // default all chars

 

protected L2ZoneType(int id)

{

_id = id;

_characterList = new L2TIntObjectHashMap<L2Character>();

 

_minLvl = 0;

_maxLvl = 0xFF;

 

_classType = 0;

 

_race = null;

_class = null;

}

 

/**

* @return Returns the id.

*/

public int getId()

{

return _id;

}

 

/**

* Setup new parameters for this zone

* @param type

* @param value

*/

public void setParameter(String name, String value)

{

_checkAffected = true;

 

// Zone name

if (name.equals("name"))

{

_name = value;

}

// Minimum level

else if (name.equals("affectedLvlMin"))

{

_minLvl = Integer.parseInt(value);

}

// Maximum level

else if (name.equals("affectedLvlMax"))

{

_maxLvl = Integer.parseInt(value);

}

// Affected Races

else if (name.equals("affectedRace"))

{

// Create a new array holding the affected race

if (_race == null)

{

_race = new int[1];

_race[0] = Integer.parseInt(value);

}

else

{

int[] temp = new int[_race.length + 1];

 

int i = 0;

for (; i < _race.length; i++)

temp = _race;

 

temp = Integer.parseInt(value);

 

_race = temp;

}

}

// Affected classes

else if (name.equals("affectedClassId"))

{

// Create a new array holding the affected classIds

if (_class == null)

{

_class = new int[1];

_class[0] = Integer.parseInt(value);

}

else

{

int[] temp = new int[_class.length + 1];

 

int i = 0;

for (; i < _class.length; i++)

temp = _class;

 

temp = Integer.parseInt(value);

 

_class = temp;

}

}

// Affected class type

else if (name.equals("affectedClassType"))

{

if (value.equals("Fighter"))

{

_classType = 1;

}

else

{

_classType = 2;

}

}

else if (name.equals("targetClass"))

{

_target = Enum.valueOf(InstanceType.class, value);

}

else

_log.info(getClass().getSimpleName()+": Unknown parameter - "+name+" in zone: "+getId());

}

 

/**

* Checks if the given character is affected by this zone

* @param character

* @return

*/

private boolean isAffected(L2Character character)

{

// Check lvl

if (character.getLevel() < _minLvl || character.getLevel() > _maxLvl)

return false;

 

// check obj class

if (!character.isInstanceType(_target))

return false;

 

if (character instanceof L2PcInstance)

{

// Check class type

if (_classType != 0)

{

if (((L2PcInstance) character).isMageClass())

{

if (_classType == 1)

return false;

}

else if (_classType == 2)

return false;

}

 

// Check race

if (_race != null)

{

boolean ok = false;

 

for (int i = 0; i < _race.length; i++)

{

if (((L2PcInstance) character).getRace().ordinal() == _race)

{

ok = true;

break;

}

}

 

if (!ok)

return false;

}

 

// Check class

if (_class != null)

{

boolean ok = false;

 

for (int i = 0; i < _class.length; i++)

{

if (((L2PcInstance) character).getClassId().ordinal() == _class)

{

ok = true;

break;

}

}

 

if (!ok)

return false;

}

}

return true;

}

 

/**

* Set the zone for this L2ZoneType Instance

* @param zone

*/

public void setZone(L2ZoneForm zone)

{

if (_zone != null)

throw new IllegalStateException("Zone already set");

_zone = zone;

}

 

/**

* Returns this zones zone form

* @param zone

* @return

*/

public L2ZoneForm getZone()

{

return _zone;

}

 

/**

* Set the zone name.

* @param name

*/

public void setName(String name)

{

_name = name;

}

 

/**

* Returns zone name

* @return

*/

public String getName()

{

return _name;

}

 

/**

* Checks if the given coordinates are within zone's plane

* @param x

* @param y

*/

public boolean isInsideZone(int x, int y)

{

return _zone.isInsideZone(x, y, _zone.getHighZ());

}

 

/**

* Checks if the given coordinates are within the zone

* @param x

* @param y

* @param z

*/

public boolean isInsideZone(int x, int y, int z)

{

return _zone.isInsideZone(x, y, z);

}

 

/**

* Checks if the given object is inside the zone.

*

* @param object

*/

public boolean isInsideZone(L2Object object)

{

return isInsideZone(object.getX(), object.getY(), object.getZ());

}

 

public double getDistanceToZone(int x, int y)

{

return getZone().getDistanceToZone(x, y);

}

 

public double getDistanceToZone(L2Object object)

{

return getZone().getDistanceToZone(object.getX(), object.getY());

}

 

public void revalidateInZone(L2Character character)

{

// If the character can't be affected by this zone return

if (_checkAffected)

{

if (!isAffected(character))

return;

}

 

// If the object is inside the zone...

if (isInsideZone(character.getX(), character.getY(), character.getZ()))

{

// Was the character not yet inside this zone?

if (!_characterList.containsKey(character.getObjectId()))

{

FastList<Quest> quests = this.getQuestByEvent(Quest.QuestEventType.ON_ENTER_ZONE);

if (quests != null)

{

for (Quest quest : quests)

{

quest.notifyEnterZone(character, this);

}

}

_characterList.put(character.getObjectId(), character);

onEnter(character);

}

}

else

{

// Was the character inside this zone?

if (_characterList.containsKey(character.getObjectId()))

{

FastList<Quest> quests = this.getQuestByEvent(Quest.QuestEventType.ON_EXIT_ZONE);

if (quests != null)

{

for (Quest quest : quests)

{

quest.notifyExitZone(character, this);

}

}

_characterList.remove(character.getObjectId());

onExit(character);

}

}

}

 

/**

* Force fully removes a character from the zone

* Should use during teleport / logoff

* @param character

*/

public void removeCharacter(L2Character character)

{

if (_characterList.containsKey(character.getObjectId()))

{

FastList<Quest> quests = this.getQuestByEvent(Quest.QuestEventType.ON_EXIT_ZONE);

if (quests != null)

{

for (Quest quest : quests)

{

quest.notifyExitZone(character, this);

}

}

_characterList.remove(character.getObjectId());

onExit(character);

}

}

 

/**

* Will scan the zones char list for the character

* @param character

* @return

*/

public boolean isCharacterInZone(L2Character character)

{

return _characterList.containsKey(character.getObjectId());

}

 

protected abstract void onEnter(L2Character character);

 

protected abstract void onExit(L2Character character);

 

public abstract void onDieInside(L2Character character);

 

public abstract void onReviveInside(L2Character character);

 

public L2TIntObjectHashMap<L2Character> getCharactersInside()

{

return _characterList;

}

 

public L2Character[] getCharactersInsideArray()

{

return _characterList.getValues(new L2Character[_characterList.size()]);

}

 

public void addQuestEvent(Quest.QuestEventType EventType, Quest q)

{

if (_questEvents == null)

_questEvents = new FastMap<Quest.QuestEventType, FastList<Quest>>();

FastList<Quest> questByEvents = _questEvents.get(EventType);

if (questByEvents == null)

questByEvents = new FastList<Quest>();

if (!questByEvents.contains(q))

questByEvents.add(q);

_questEvents.put(EventType, questByEvents);

}

 

public FastList<Quest> getQuestByEvent(Quest.QuestEventType EventType)

{

if (_questEvents == null)

return null;

return _questEvents.get(EventType);

}

 

/**

* Broadcasts packet to all players inside the zone

*/

public void broadcastPacket(L2GameServerPacket packet)

{

if (_characterList.isEmpty())

return;

 

_characterList.forEachValue(new BroadcastPacket(packet));

}

 

private final class BroadcastPacket implements TObjectProcedure<L2Character>

{

final L2GameServerPacket _packet;

private BroadcastPacket(L2GameServerPacket packet)

{

_packet = packet;

}

 

@Override

public final boolean execute(final L2Character character)

{

if (character != null && character instanceof L2PcInstance)

character.sendPacket(_packet);

return true;

}

}

 

public InstanceType getTargetType()

{

return _target;

}

 

public void setTargetType(InstanceType type)

{

_target = type;

_checkAffected = true;

}

 

@Override

public String toString()

{

return getClass().getSimpleName()+"["+ _id + "]";

}

 

  public void visualizeZone(int z)

  {

      getZone().visualizeZone(z);

  }

 

      public FastMap<Integer, L2Character> getCharactersInside()

        {

            return _characterList;

    }

    }

  • 0
Posted

-public L2TIntObjectHashMap<L2Character> getCharactersInside()
-        {
-		return _characterList;
-	}
+	public FastMap<Integer, L2Character> getCharactersInside()
+  {
+      return _characterList;
+	}

 

 

Press a lot of times Ctrl+Z till code gets to retail. Then try to change this

Guest
This topic is now closed to further replies.


  • Posts

    • in conclusion when somebody who has a project for 10+ years still on development writes an e-say to try until you succeed and then advertises his project, one of the reasons is he needs money, so l2j has once more become pure expensive hobby, you wont make money out of it.   You can still use L2jFrozen and get better results for this, i know some people that done it    keep in mind that C in aCis stands for Crappy, and after all these years its not a cool wordplay anymore, its a fact, prove me wrong.
    • First, don't really follow the "main voice", moreover if you consider it an hobby. Simply do what you want, you got only one life so use it as you want. If you make it an hobby, it's exactly like piano, or velo - only practice makes you better.   Secondly, how do you learn things ? It's actually a really important question, since some can simply be scholar, read books (theory) then practice ; and some simply can't read books. I'm the second type, I hated school, I find it boring - my knowledge in Java comes from try-and-fail. You improve your coding style every year or so, I can myself rewrite my own code (which I already considered top-notched) after a while. You always learn something new - even if Java barely evolves. L2J is a fun way to learn programming, it's a giant sandbox where you can edit anything, and I believe it should be taken as it.   My own way of learning was as follow : Add existing customs, no matter what they are : the point is to know main classes used by L2J / customs. L2J is barely Java knowledge ; the true knowledge is to know WHAT to search in WHICH location (what I call, organization). You have to understand than EVERYTHING you think already exists, in a form on another, in the source code. A custom is only the association of the different mechanisms you found "here and there", glued together in a proper goal. Once you know main classes to edit, and the customs you added are compiling fine, the main point is to know WHAT exactly you DID. Try to understand WHY and WHERE you actually copied the code. Third point would be to MANIPULATE the customs you added in order to fit your wish. First edit little values, then logic conditions ; eventually add a new Config, or a new functionality to the custom. Fourth point would be to begin to craft your own ideas. Once again, EVERYTHING already exists, in a form or another. You want a cycled event ? You got Seven Signs main task as exemple. Npc ? Search any type of Npc and figure out what it does. Fifth point would be to understand Java - mostly containers (WHAT and WHERE to use them), variables types and main Java mechanisms (inheritance, static modifier, etc). You should also begin to cut your code into maintainable classes or methods. Java can actually run without optimization, but bigger your ideas, more optimized and well-thought it should be. It's direct saved time in the future, and you would thank yourself doing so. Main tips : ALWAYS use any type of versioning system - GIT or SVN. It allows to save your work, step by step and eventually revert back anytime you want if you terribly messed up. L2J is 80% organization knowledge, and 20% Java knowledge. Basically, if you know WHAT and WHERE to search, if you aren't dumb, it's easy to replicate and re-use things. Cherry on top is to use a already good coded pack to avoid copy-paste crap and get bad habits. Avoid any type of russian or brazilian packs, for exemple - their best ability is to leak someone's else code. Obviously you need some default sense of logic, but Java and programming in general help you to improve it.   Finally, most of your questions could be solved joining related Discord (at least for aCis, I can't speak for others) - from the moment your question was correctly asked (and you seemed to search for the answer). My community (and myself) welcomes newbies, but got some issues with noobies.   The simpliest is to try, fail and repeat until you succeed - it sounds stupid, but that's basically how life works.   PS : about Java ressources, before ChatGPT, it was mostly about stackoverflow website, and site like Baeldung's one. With ChatGPT and alike, you generally double-cross AI output to avoid fucked up answers. Also, care about AI, they are often hallucinating really hard, even today. They can give you complete wrong answer, you tell them they are wrong, and they say "indeed, I suck, sorry - here's a new fucked up answer". You shouldn't 100% rely over AI answer, even if that can give sometimes legit answers, full code or just skeletons of ideas.   PPS : I don't think there are reliable ressources regarding L2J itself, also most of the proposed code decays pretty fast if the source code is actually maintained (at least for aCis). Still, old coded customs for old aCis sources are actually a good beginner challenge to apply on latest source.
    • WTS: - AQ - Baium - Zaken  - Frintezza - Vesper Fighter Focus Fire Element   pm for detalis
  • Topics

×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock