[HELP] Check this .. bug with private store :@ check photo.

[GsL]

Hello guys

 

in my old rev on frozen i havent this bug and when i change to last i find this one ...

 

 

When i do private store and abort shop change my items to a random item and if i try to do shop again i get DC for ilegal

 

in few min i will upload images ,

 

i changed at clientpackets all new codes with old but problem exist ... wtf is this :/

i try everything without find any solution

which code give em this error?

 

 

I place 4 different items,  Max sell is 3 items , char  sit without any warning ..

and when i abort private store i see this .. if i sit again i get dc ...

 

[dpbBryan]

Hello guys

 

in my old rev on frozen i havent this bug and when i change to last i find this one ...

 

 

When i do private store and abort shop change my items to a random item and if i try to do shop again i get DC for ilegal

 

in few min i will upload images ,

 

i changed at clientpackets all new codes with old but problem exist ... wtf is this :/

i try everything without find any solution

which code give em this error?

 

 

I place 4 different items,  Max sell is 3 items , char  sit without any warning ..

and when i abort private store i see this .. if i sit again i get dc ...

 

 

Have you enabled debugging in the gameserver configuration files? What does the gameserver console say?

[xdem]

Hello guys

 

in my old rev on frozen i havent this bug and when i change to last i find this one ...

 

 

When i do private store and abort shop change my items to a random item and if i try to do shop again i get DC for ilegal

 

in few min i will upload images ,

 

i changed at clientpackets all new codes with old but problem exist ... wtf is this :/

i try everything without find any solution

which code give em this error?

 

 

I place 4 different items,  Max sell is 3 items , char  sit without any warning ..

and when i abort private store i see this .. if i sit again i get dc ...

 

 

Attention: not based on adena, yet another crappy packet modification on your files leading to packet failure... nvm

[Tryskell]

Invalid packet format, enough said.

[skaraz]

tell us pliz the old revision and the new revision and you if you just add the code by your self show us the code...

[GsL]

tell us pliz the old revision and the new revision and you if you just add the code by your self show us the code...

 

 

948 old and last rev of l2jfrozen .. i dint add anything .. gameserver dont spam any error , i done a lot tests on eclipse with old codes from 948 and problem exist ..

[GsL]

Invalid packet format, enough said.

 

i cant decrypt wht u mean :/

[dpbBryan]

i cant decrypt wht u mean :/

 

The packets of information being sent from your client are not compatible with the information the server expects.

[xdem]

i cant decrypt wht u mean :/

 

sou ipa re ili9ie exeis fail costums kapios sou xalase to packet, dld to code tou shop

[GsL]

all codes are clean l2jfrozen last revision .. i had add one check for one custom zoen i remove it thats all but that work at old rev without problem i remove it and replace all with last rev and problem exist ..

[GsL]

So isnt any standar file that check private store when is aborted? like RequestPrivateStoreQuestSell ...

 

i change it with old revisiona nd problem exist ..

[Mayra]

Pata to 0  :troll:

[GsL]

After days searching and replace new codes with old codes i replace this one and bug fixed ...

 

 

WTF is wrong here..

 

this last revision code dont work..

/*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2, or (at your option)
* any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
* 02111-1307, USA.
*
* http://www.gnu.org/copyleft/gpl.html
*/
package com.l2jfrozen.gameserver.network.serverpackets;

import com.l2jfrozen.Config;
import com.l2jfrozen.gameserver.model.TradeList;
import com.l2jfrozen.gameserver.model.TradeList.TradeItem;
import com.l2jfrozen.gameserver.model.actor.instance.L2PcInstance;

/**
* 3 section to this packet 1)playerinfo which is always sent dd 2)list of items which can be added to sell d(hhddddhhhd) 3)list of items which have already been setup for sell in previous sell private store sell manageent d(hhddddhhhdd) *
* @version $Revision: 1.3.2.1.2.3 $ $Date: 2005/03/27 15:29:39 $
*/
public class PrivateStoreManageListSell extends L2GameServerPacket
{
private static final String _S__B3_PRIVATESELLLISTSELL = "[s] 9a PrivateSellListSell";
private L2PcInstance _activeChar;
private int _playerAdena;
private boolean _packageSale;
private TradeList.TradeItem[] _itemList;
private TradeList.TradeItem[] _sellList;

public PrivateStoreManageListSell(L2PcInstance player)
{
	_activeChar = player;

	if (Config.SELL_BY_ITEM)
	{
		_playerAdena = _activeChar.getItemCount(Config.SELL_ITEM, -1);
	}
	else
	{
		_playerAdena = _activeChar.getAdena();
	}

	_activeChar.getSellList().updateItems();
	_packageSale = _activeChar.getSellList().isPackaged();
	_itemList = _activeChar.getInventory().getAvailableItems(_activeChar.getSellList());
	_sellList = _activeChar.getSellList().getItems();
}

/**
 * During store set no packets will be received from client just when store definition is finished.
 */
@Override
protected final void writeImpl()
{
	writeC(0x9a);
	// section 1
	writeD(_activeChar.getObjectId());
	writeD(_packageSale ? 1 : 0); // Package sell
	writeD(_playerAdena);

	// section2
	writeD(_itemList.length - _sellList.length); // for potential sells
	for (TradeList.TradeItem item : _itemList)
	{
		if (isItemInSelling(item) == false)
		{
			writeD(item.getItem().getType2());
			writeD(item.getObjectId());
			writeD(item.getItem().getItemId());
			writeD(item.getCount());
			writeH(0);
			writeH(item.getEnchant());// enchant lvl
			writeH(0);
			writeD(item.getItem().getBodyPart());
			writeD(item.getPrice()); // store price
		}
	}
	// section 3
	writeD(_sellList.length); // count for any items already added for sell
	for (TradeList.TradeItem item : _sellList)
	{
		writeD(item.getItem().getType2());
		writeD(item.getObjectId());
		writeD(item.getItem().getItemId());
		writeD(item.getCount());
		writeH(0);
		writeH(item.getEnchant());// enchant lvl
		writeH(0x00);
		writeD(item.getItem().getBodyPart());
		writeD(item.getPrice());// your price
		writeD(item.getItem().getReferencePrice()); // store price
	}
}

private boolean isItemInSelling(TradeItem item_)
{
	for (TradeList.TradeItem itemSell : _sellList)
	{
		if (itemSell.getObjectId() == item_.getObjectId())
		{
			return true;
		}
	}
	return false;
}

/*
 * (non-Javadoc)
 * @see com.l2jfrozen.gameserver.serverpackets.ServerBasePacket#getType()
 */
@Override
public String getType()
{
	return _S__B3_PRIVATESELLLISTSELL;
}
}

 

 

old code work

this one

 

/*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2, or (at your option)
* any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
* 02111-1307, USA.
*
* http://www.gnu.org/copyleft/gpl.html
*/
package com.l2jfrozen.gameserver.network.serverpackets;

import com.l2jfrozen.Config;
import com.l2jfrozen.gameserver.model.TradeList;
import com.l2jfrozen.gameserver.model.actor.instance.L2PcInstance;

/**
* 3 section to this packet 1)playerinfo which is always sent dd 2)list of items which can be added to sell
* d(hhddddhhhd) 3)list of items which have already been setup for sell in previous sell private store sell manageent
* d(hhddddhhhdd) *
* 
* @version $Revision: 1.3.2.1.2.3 $ $Date: 2005/03/27 15:29:39 $
*/
public class PrivateStoreManageListSell extends L2GameServerPacket
{
private static final String _S__B3_PRIVATESELLLISTSELL = "[s] 9a PrivateSellListSell";
private L2PcInstance _activeChar;
private int _playerAdena;
private boolean _packageSale;
private TradeList.TradeItem[] _itemList;
private TradeList.TradeItem[] _sellList;

public PrivateStoreManageListSell(L2PcInstance player)
{
	_activeChar = player;

	if(Config.SELL_BY_ITEM){
		_playerAdena = _activeChar.getItemCount(Config.SELL_ITEM, -1);
	}else{
		_playerAdena = _activeChar.getAdena();
	}

	_activeChar.getSellList().updateItems();
	_packageSale = _activeChar.getSellList().isPackaged();
	_itemList = _activeChar.getInventory().getAvailableItems(_activeChar.getSellList());
	_sellList = _activeChar.getSellList().getItems();
}

/**
 * During store set no packets will be received from client
 * just when store definition is finished.
 */
@Override
protected final void writeImpl()
{
	writeC(0x9a);
	//section 1
	writeD(_activeChar.getObjectId());
	writeD(_packageSale ? 1 : 0); // Package sell
	writeD(_playerAdena);

	//section2
	writeD(_itemList.length); //for potential sells
	for(TradeList.TradeItem item : _itemList)
	{
		writeD(item.getItem().getType2());
		writeD(item.getObjectId());
		writeD(item.getItem().getItemId());
		writeD(item.getCount());
		writeH(0);
		writeH(item.getEnchant());//enchant lvl
		writeH(0);
		writeD(item.getItem().getBodyPart());
		writeD(item.getPrice()); //store price
	}
	//section 3
	writeD(_sellList.length); //count for any items already added for sell
	for(TradeList.TradeItem item : _sellList)
	{
		writeD(item.getItem().getType2());
		writeD(item.getObjectId());
		writeD(item.getItem().getItemId());
		writeD(item.getCount());
		writeH(0);
		writeH(item.getEnchant());//enchant lvl
		writeH(0x00);
		writeD(item.getItem().getBodyPart());
		writeD(item.getPrice());//your price
		writeD(item.getItem().getReferencePrice()); //store price
	}
}

/* (non-Javadoc)
 * @see com.l2jfrozen.gameserver.serverpackets.ServerBasePacket#getType()
 */
@Override
public String getType()
{
	return _S__B3_PRIVATESELLLISTSELL;
}
}

[skaraz]

invalid packets or packets are sending during store......what problem you try to solve ?

[GsL]

almost fixed