[Help]Instance warning

[leoadrian]

Hi all i hope make this right in the right forum.

 

i have a problem or a warning extrage when i put anty cheat warehouse.

 

here a picture is more expresive :P

 

 

i go to apreciate any help ^^ tnx a lot.

[Pauler]

You dont really need to worry about warnings..

 

By the way, I think its shows that warning because target already is a instance of L2WarehouseInstance.

 

Look at the line above the warning:

L2WarehouseInstance target = null;

[Fanky]

you'll need a null check..

[^Wyatt]

@Fanky

Here a null check has nothing to do... in the code is specified to be null in the upper line...

L2WarehouseInstance target = null;
if (player.getActiveEnchantItem != null && target instanceof L2WarehouseInstance)
{

 

@author

Just remove it, it has not sense, it must be instanceof L2WarehouseInstance, it doesn't need to be checked.

 

L2WarehouseInstance target = null;
if (player.getActiveEnchantItem != null)
{

[Fanky]

@Fanky

Here a null check has nothing to do... in the code is specified to be null in the upper line...

L2WarehouseInstance target = null;
if (player.getActiveEnchantItem != null && target instanceof L2WarehouseInstance)
{

 

@author

Just remove it, it has not sense, it must be instanceof L2WarehouseInstance, it doesn't need to be checked.

 

L2WarehouseInstance target = null;
if (player.getActiveEnchantItem != null)
{

hm,seems I misunderstood it

[^Wyatt]

@Fanky

Here a null check has nothing to do... in the code is specified to be null in the upper line...

L2WarehouseInstance target = null;
if (player.getActiveEnchantItem != null && target instanceof L2WarehouseInstance)
{

 

@author

Just remove it, it has not sense, it must be instanceof L2WarehouseInstance, it doesn't need to be checked.

 

L2WarehouseInstance target = null;
if (player.getActiveEnchantItem != null)
{

 

Or maybe that part of code is wrong, try it:

 

-L2WarehouseInstance target = null;
+L2Object target = player.getTarget();

 

Sorry for double post.

 

[Tryskell]

Simply reading the screen, it misses something.

 

A correct check would be eventually

L2Object target = player.getTarget();

And then your target check about "if object instanceof blabla" would be ok. Actually target is always null.

 

But it depends entirely of complete method. Perhaps such check on target has already been made higher in the code, and so it's pointless to remake one.

[leoadrian]

tnx for answer the post, cant fix them so i add @SuppressWarnings("cast") maeby in other java i have something missing.

[Tryskell]

tnx for answer the post, cant fix them so i add @SuppressWarnings("cast") maeby in other java i have something missing.

Eva, save him.

[Pauler]

tnx for answer the post, cant fix them so i add @SuppressWarnings("cast") maeby in other java i have something missing.

(facepalm)