[Help] Pvp points from Mobs

[dymek1984]

Hello i have pvp points on my server. From each killed pleyera gets his 10% pvpPoints and that points has stored in db new column in characters

Wanna know how to add these points to the mobs and get them together with exp and sp.

but if exp is set to 7000 is a mob would give me 7 pvppoints.

hope u understand me cuz my english is more funny than the understandable.

[dymek1984]

 

 

 

public boolean doDie(L2Character killer)
{
	if (!super.doDie(killer))
		return false;

	L2PcInstance player = null;
	if (killer instanceof L2PcInstance)
		player = (L2PcInstance) killer;
	else if (killer instanceof L2Summon)
		player = ((L2Summon) killer).getOwner();

	if (player != null)
	{
		int numberToAdd = 500;
		broadcastPacket(new SystemMessage(SystemMessageId.RAID_WAS_SUCCESSFUL));

		if (player.getParty() != null)
		{

			numberToAdd = (500/(player.getParty().getMemberCount()));
			for (L2PcInstance member : player.getParty().getPartyMembers())
			{
				if  (!Util.checkIfInRange(Config.ALT_PARTY_RANGE2, player, member, true));
				{
				member.setPvpPoints(member.getPvpPoints() + numberToAdd);
				member.sendMessage("You have earned " + numberToAdd + " PvP Points");
				RaidBossPointsManager.addPoints(member, this.getNpcId(), (this.getLevel() / 2) + Rnd.get(-5, 5));

				if(member.isNoble())
					Hero.getInstance().setRBkilled(member.getObjectId(), this.getNpcId());
				}
			}
		}
		else
		{
			player.setPvpPoints(player.getPvpPoints() + numberToAdd );
			player.sendMessage("You have earned " + numberToAdd + " PvP Points");				
			RaidBossPointsManager.addPoints(player, this.getNpcId(), (this.getLevel() / 2) + Rnd.get(-5, 5));
			if(player.isNoble())
				Hero.getInstance().setRBkilled(player.getObjectId(), this.getNpcId());

		}
	}

	RaidBossSpawnManager.getInstance().updateStatus(this, true);
	return true;
}

 

the same as in the previous post

[Tryskell]

if  (!Util.checkIfInRange(Config.ALT_PARTY_RANGE2, player, member, true));

 

Try to explain with words what does this line. Explain all, variables, [glow=red,2,300]symbols[/glow] (one word is important in this post).

 

Basically, your code is good, but you do a mistake. Check again the important word of the post.

 

Another thing I can say to help you. Basically, the code works if you're FAR but not if you're NEAR. It means the range checker works (if it wasn't working at all, you will never have points in party), but not like you want. Why ? This was another big tip :).

[dymek1984]

"if (!Util[util is class for calculating x, y, z, range angle etc for object from L2Object].checkIfInRange(range from object1 to object2, object1, object2, include zAxis[false or true]   ));"  

 that is my thinking on this

 

for me i think important word is "count members in range"

 

 

 

and the whole time I think on this

[Tryskell]

Well I give you the answer because you're blind or you don't know the use of this symbol.

 

The "!" located before "Util." means basically "if it's not / different of". Aka it's reverse the condition true/false.

 

So your check means currently : if the range is more than 1400/1600, give pvp points to each members. If the range is lower, skip the statement.

 

So if you're far of the killer, it will be true, when you're near the killer, it will be false. And it's why you earn rewards from far and not near.

 

Delete the symbol to make the correct check.

 

And merry christmas :p.

[dymek1984]

Merry chrismas for you too ;]

I can not think, it hurts my tooth, broke a bone tomorrow I have to go to work.

And i do as u wrote removed "!" and effect the same.

and it does not matter whether the member is near or far.

[Tryskell]

Let's see what can be wrong :

 

- this formula isn't the good one ;

- checkIfInRange is broken ;

- The range put in config (in this case, ALT_PARTY_RANGE2) is too low ;

- you're not in the good range ingame, so basically even if it works you think it's broken.

- you didn't updated your l2jserver.jar but think you did ;

- you found a way to make another error correcting this one ;

 

------

 

Here is a code showing you the use (basically, pick a random party member in range)

 

	private L2PcInstance getCheckedRandomMember(int ItemId, L2Character target)
{
	List<L2PcInstance> availableMembers = new FastList<L2PcInstance>();
	for (L2PcInstance member : getPartyMembers())
	{
		if (member.getInventory().validateCapacityByItemId(ItemId) &&
				Util.checkIfInRange(Config.ALT_PARTY_RANGE2, target, member, true)) availableMembers.add(member);
	}
	if (!availableMembers.isEmpty()) return availableMembers.get(Rnd.get(availableMembers.size()));
	else return null;
}

 

That removes those points :

- this formula isn't the good one ;

- checkIfInRange is broken ;

 

The others errors are users errors, so guess what :D.

 

Another thing, rewrite your code like that :

 

					if  (Util.checkIfInRange(Config.ALT_PARTY_RANGE2, player, member, true));
				{
				     member.setPvpPoints(member.getPvpPoints() + numberToAdd);
				     member.sendMessage("You have earned " + numberToAdd + " PvP Points");
				}

				RaidBossPointsManager.addPoints(member, this.getNpcId(), (this.getLevel() / 2) + Rnd.get(-5, 5));

				if(member.isNoble())
					Hero.getInstance().setRBkilled(member.getObjectId(), this.getNpcId());

[dymek1984]

I do not know what I do, but I do not want to give up. In addition, the tooth hurts my head, I have the impression that you matches.

do not know the fundamentals of programming in Java.

 

public boolean doDie(L2Character killer)
{
	if (!super.doDie(killer))
		return false;

	L2PcInstance player = null;
	if (killer instanceof L2PcInstance)
		player = (L2PcInstance) killer;
	else if (killer instanceof L2Summon)
		player = ((L2Summon) killer).getOwner();

	if (player != null)
	{

		broadcastPacket(new SystemMessage(SystemMessageId.RAID_WAS_SUCCESSFUL));

		if (player.getParty() != null)
		{			
		List<L2PcInstance> availableMembers = new FastList<L2PcInstance>();
		for (L2PcInstance member : player.getParty().getPartyMembers())
			{
				int numberToAdd = (500/(player.getParty().getMemberCount()));
				if (Util.checkIfInRange(Config.ALT_PARTY_RANGE2, player, member, true)) availableMembers.add(member);
				member.setPvpPoints(member.getPvpPoints() + numberToAdd);
				member.sendMessage("You have earned " + numberToAdd + " PvP Points");
				RaidBossPointsManager.addPoints(member, this.getNpcId(), (this.getLevel() / 2) + Rnd.get(-5, 5));

				if(member.isNoble())
					Hero.getInstance().setRBkilled(member.getObjectId(), this.getNpcId());
			}
			if (!availableMembers.isEmpty()) return availableMembers.get(availableMembers.size()) != null;
			else return null != null;
		}		

 

Do not compile with this code cuz "if (!availableMembers.isEmpty()) return availableMembers.get(availableMembers.size()) != null;" < -- here eclipse give me quick fix [insert null check]

here the same "else return null != null;"     -      It is strange, but I will not contradict with the eclipse.

 

Or not what you meant and I'm stupid;] If I did everything wrong gives it a rest

 

 

Edit; i read yor edit and did as written,  but unfortunately the same story

 

[Tryskell]

Ouahou, perhaps you should take some time. You know, it's pointless to code if you are ill or if you can't think correctly.

 

Just re-think to the code in some days, you melt all what I said and it's not good.

 

The first code I posted was only to show one use of checkIfInRange, nothing more. Just saying "heeee, the code is used in this method, so it should normally work".

 

Edit your previous code to remove this crappy code and put the updated version.

 

And forget Java for 2-3 days. To avoid mental self-side issues :P.

[dymek1984]

Hello how do you feel in the new year? ;]

I wrote a post on l2jforum for help and now have this code;

 

	@Override
public boolean doDie(L2Character killer)
{
	if (!super.doDie(killer))
		return false;

	L2PcInstance player = null;
	if (killer instanceof L2PcInstance)
		player = (L2PcInstance) killer;
	else if (killer instanceof L2Summon)
		player = ((L2Summon) killer).getOwner();

	if (player != null)
	{
		broadcastPacket(new SystemMessage(SystemMessageId.RAID_WAS_SUCCESSFUL));
		if (player.getParty() != null)
		{
			int numberToAdd = 500 /player.getParty().getMemberCount();
			for (L2PcInstance member : player.getParty().getPartyMembers())
			{
				RaidBossPointsManager.addPoints(member, this.getNpcId(), (this.getLevel() / 2) + Rnd.get(-5, 5));
				if(member.isNoble())
					Hero.getInstance().setRBkilled(member.getObjectId(), this.getNpcId());
                  if (Util.checkIfInRange(Config.ALT_PARTY_RANGE2, this, member, true))
                	
                   {
                	  member.setFame(member.getFame() + numberToAdd);
                      member.sendMessage("You have earned " + numberToAdd + " Fame Points");
                   }
                
			}
		}
		else
		{
			RaidBossPointsManager.addPoints(player, this.getNpcId(), (this.getLevel() / 2) + Rnd.get(-5, 5));
			if(player.isNoble())
				Hero.getInstance().setRBkilled(player.getObjectId(), this.getNpcId());

               if  (Util.checkIfInRange(Config.ALT_PARTY_RANGE2, this, player, true))
               {
                   player.setFame(player.getFame() + 500);
                   player.sendMessage("You have earned " + 500 + " Fame Points");
               }
		}
	}

	RaidBossSpawnManager.getInstance().updateStatus(this, true);
	return true;
}

 

 

This code works like this: The player does not get PvP Points out of the range, but the Rb killer gets only half cuz 2 players is in party

Noe need added code here

 

int numberToAdd = 500 / ??? );

 

??? = get int members in range

[Tryskell]

Any error with this code ?

 

Btw, some parts are useless. So I don't think it comes from L2Jserver forum :P.

 

And they changed PvPKill for Fame.

 

Use indentation too, it's boring to read broken code.

[dymek1984]

I changed to fame  so as not to explain too much

but I gave up. I added the item to  drop  for the bosses, who can replace for pvp points.

Sorry I took your time and nothing came, and thank you very much for the Java science ;]

[Tryskell]

I changed to fame  so as not to explain too much

but I gave up. I added the item to  drop  for the bosses, who can replace for pvp points.

Sorry I took your time and nothing came, and thank you very much for the Java science ;]

 

w_w

 

Anyway, when you will be more experienced, you will see it wasn't an hard code.

 

Sometimes you have to give up to find the solution.

 

Don't hesitate to re-post if you got problems anew.

[dymek1984]

Hi have one more question how add here

 

      if (killer != null)
      {
         L2PcInstance pk = killer.getActingPlayer();
            {
                       // if the victim was pvpflagged
                       if (getPvpFlag() != 0)
                       {
                             int pointsToAdd = (int) (_pvpPoints*0.10);
                             int pointsToRemove = _pvpPoints - pointsToAdd < 0 ? 0 : _pvpPoints - pointsToAdd;

                            // remove points to the victims and add points to the killer.
                             pk.setpvpPoints(pk.getpvpPoints() + pointsToAdd);
                             setpvpPoints(pointsToRemove);
                        }

 

int pointsToAdd = (int) (_pvpPoints*0.10); but no more than 1000 points

I tried to do it myself but I do not know where I am proud to idea

[Tryskell]

You have to use math min.

 

http://download.oracle.com/javase/1.4.2/docs/api/java/lang/Math.html

 

static double 	min(double a, double b)
         Returns the smaller of two double values.

 

If A value is higher than B value, it will return B value.

 

There aren't a lot of example in L2J, but still there are some (like 2 database connections minimum using math max).