WTF is going on

[FDB]

i added dont loose your buffs on death code

 

// Same thing if the Character isn't a Noblesse Blessed L2PlayableInstance
        else if (this instanceof L2Playable && ((L2Playable)this).isNoblesseBlessed())
        { 
			((L2Playable)this).stopNoblesseBlessing(null); 

        	if (((L2Playable)this).getCharmOfLuck()) //remove Lucky Charm if player have Nobless blessing buff 
				((L2Playable)this).stopCharmOfLuck(null); 
		} 
		else

 

and i got this error

 

[javac] Compiling 1298 source files to C:\L2GateAway\L2JGateway\L2J_CORE\build\classes
    [javac] C:\L2GateAway\L2JGateway\L2J_CORE\java\com\it\br\gameserver\model\L2Character.java:1513: 'else' without 'if'
    [javac] 		else if (this instanceof L2PlayableInstance && ((L2PlayableInstance)this).isPhoenixBlessed()) 
    [javac] 		^
    [javac] 1 error

[adenaman]

  On 8/2/2010 at 2:26 PM, FDB said:

 

'else' without 'if'

 

show us more code before that else

[FDB]

  On 8/2/2010 at 2:57 PM, adenaman said:

show us more code before that else

 

i just put one line on it lawl

[adenaman]

  On 8/2/2010 at 3:04 PM, FDB said:

i just put one line on it lawl

nvm, i found what is it

 

        	if (((L2Playable)this).getCharmOfLuck()) //remove Lucky Charm if player have Nobless blessing buff 
				((L2Playable)this).stopCharmOfLuck(null); 
		} 

change to

if ( ( (L2Playable)this).getCharmOfLuck())   {      //remove Lucky Charm if player have Nobless blessing buff 

[FDB]

100 errors :/

[adenaman]

  On 8/2/2010 at 3:14 PM, FDB said:

100 errors :/

 

i mean to just put the {

 

anyway, i will take a look at the complete L2character, sec

[FDB]

okz

[FDB]

i removed

 

if (((L2Playable)this).getCharmOfLuck()) //remove Lucky Charm if player have Nobless blessing buff 

will it work?

 

i got succesfull build but i am not sure that will work

[adenaman]

ok, when some1 copy the code here, it lose some spaces

       // Same thing if the Character isn't a Noblesse Blessed L2PlayableInstance
       else if (this instanceof L2Playable && ((L2Playable)this).isNoblesseBlessed())
       { 
	((L2Playable)this).stopNoblesseBlessing(null); 

       	if (((L2Playable)this).getCharmOfLuck()) //remove Lucky Charm if player have Nobless blessing buff 
		((L2Playable)this).stopCharmOfLuck(null); 
} 
else
	stopAllEffectsExceptThoseThatLastThroughDeath();
       

 

all that is ok, you should take a look here (the if before your code)

 

// Stop all active skills effects in progress on the L2Character,
// if the Character isn't affected by Soul of The Phoenix or Salvation
       if (this instanceof L2Playable && ((L2Playable)this).isPhoenixBlessed())
       {
          if (((L2Playable)this).getCharmOfLuck()) //remove Lucky Charm if player has SoulOfThePhoenix/Salvation buff
             ((L2Playable)this).stopCharmOfLuck(null);
           if (((L2Playable)this).isNoblesseBlessed())
              ((L2Playable)this).stopNoblesseBlessing(null);
       }

 

without this if, you cant have a else

If you want to not lose buffs when die, just delete

else
	stopAllEffectsExceptThoseThatLastThroughDeath();

but take a look at all things that could happen with this.

 

 

EDIT

 

  On 8/2/2010 at 3:39 PM, FDB said:

i removed

 

if (((L2Playable)this).getCharmOfLuck()) //remove Lucky Charm if player have Nobless blessing buff 

will it work?

 

i got succesfull build but i am not sure that will work

if you remove that, then you will allways try to

((L2Playable)this).stopCharmOfLuck(null); 

even if you dont have it

 

 

[FDB]

ok but what i must write in order to go not loosing buffs on death cause y confused me

[adenaman]

// Stop all active skills effects in progress on the L2Character,
// if the Character isn't affected by Soul of The Phoenix or Salvation
        if (this instanceof L2Playable && ((L2Playable)this).isPhoenixBlessed())
        {
           if (((L2Playable)this).getCharmOfLuck()) //remove Lucky Charm if player has SoulOfThePhoenix/Salvation buff
              ((L2Playable)this).stopCharmOfLuck(null);
            if (((L2Playable)this).isNoblesseBlessed())
               ((L2Playable)this).stopNoblesseBlessing(null);
        }
        // Same thing if the Character isn't a Noblesse Blessed L2PlayableInstance
        else if (this instanceof L2Playable && ((L2Playable)this).isNoblesseBlessed())
        { 
	((L2Playable)this).stopNoblesseBlessing(null); 

        	if (((L2Playable)this).getCharmOfLuck()) //remove Lucky Charm if player have Nobless blessing buff 
		((L2Playable)this).stopCharmOfLuck(null); 
} 
else
	stopAllEffectsExceptThoseThatLastThroughDeath();
        

this have 3 steps

-check if the char has salvation

-else check if the char has noblesse

-else delete all buffs

so you can chose, to

a) remove salvation and noblesse (if the char has this buffs), but never remove normall buff

        then delete

else
	stopAllEffectsExceptThoseThatLastThroughDeath();

 

b) never remove salvation, noblesse or any other buff

        then delete all the code quoted in the post (from

// Stop all active skills effects in progress on the L2Character,
// if the Character isn't affected by Soul of The Phoenix or Salvation
        if (this instanceof L2Playable && ((L2Playable)this).isPhoenixBlessed())

to

else
	stopAllEffectsExceptThoseThatLastThroughDeath();
        

[FDB]

ah ok now 11 errors man anyway i wont aDd this

[adenaman]

  On 8/2/2010 at 4:03 PM, FDB said:

ah ok now 11 errors man anyway i wont aDd this

post here the whole doDie function, or at least where are those errors

[FDB]

no ok i wont add it

[eKo]

someone realy sucks at java here ^^

[FDB]

not me the code was posted badly no + - or where to put something just a shit code nevermind i will add other things