Help EnchantItemOptions.xml

[InFocus]

Can explain me how i can add more options in EnchantItemOptions,xml? Now it is max 3 options: 

<options level="1" option1="xxxx" option2="xxxx"  option3="xxxx" />

Thank you

[SillverShadow]

Every xml needs an xsd to tell it how to work and what to accept 

http://prntscr.com/katwav

you find that xsd file and you make the changes there first

http://prntscr.com/katwt7

 

then you can use them in your xml 

( if i am not mistaken )

still give it a go. gl

[sepultribe]

Oh so there is a built-in way to add custom effects based on the enchant value. So as @SilverShadow said, you have to add a fourth option to olf's shirt, but first you must modify the xsd in order for it to be expected to exist.

 

From the xsd you can see that level, option1 and id have the "required" parameter which means that they are always there for all entries, option2 and option3 don't have it so they are optional. You will need to create an option4 that resembles the latter then.

 

add this after option3 in the data/xsd/enchantItemOptions.xsd

<xs:attribute name="option4">
	<xs:simpleType>
		<xs:restriction base="xs:positiveInteger">
			<xs:minInclusive value="1" />
			<xs:maxInclusive value="65535" />
		</xs:restriction>
	</xs:simpleType>
</xs:attribute>

 

then in the data/stats/options/24900-24999.xml you need to create the option to be used

<option id="id_here" name="name_here">
  <for>
      <add stat="STR" val="1" />
      <add stat="INT" val="1" />
      <add stat="CON" val="1" />
      <add stat="DEX" val="1" />
      <!--etc...-->
  </for>
</option>

finally you will add the new parameter to olf's shirt in data/enchantItemOptions.xml

 

<item id="21580"> <!-- Olf's T-shirt -->
  <options level="0" option1="24965" />
  <options level="1" option1="24966" />
  <options level="2" option1="24967" />
  <options level="3" option1="24968" />
  <options level="4" option1="24969" option2="24975" />
  <options level="5" option1="24970" option2="24976" />
  <options level="6" option1="24971" option2="24977" />
  <options level="7" option1="24972" option2="24978" option3="24982" />
  <options level="8" option1="24973" option2="24979" option3="24982" />
  <options level="9" option1="24974" option2="24980" option3="24983" />
  <options level="10" option1="24984" option2="24985" option3="24983" />
  <options level="11" option1="24984" option2="24985" option3="24983" option4="id_here"/>
</item>

 

[InFocus]

Ok, i make all steps how u say, but i get on item just 3 options. 

<item id="21580"> <!-- Olf's T-shirt -->
		<options level="0" option1="24963" />
		<options level="1" option1="24907" />
		<options level="2" option1="24908" />
		<options level="3" option1="24909" />
		<options level="4" option1="24910" />
		<options level="5" option1="24911" />
		<options level="6" option1="24912" />
		<options level="7" option1="24913" option2="24950" />
		<options level="8" option1="24914" option2="24951" />
		<options level="9" option1="24915" option2="24952" />
		<options level="10" option1="24916" option2="24953" />
		<options level="11" option1="24917" option2="24953" />
		<options level="12" option1="24918" option2="24953" />
		<options level="13" option1="24919" option2="24953" option3="24612" />
		<options level="14" option1="24920" option2="24954" option3="24613" />
		<options level="15" option1="24921" option2="24958" option3="24613" option4="24641" />
	</item>

and in game 

[InFocus]

So, for level +15 i put 4 options, and i get just 3, ( I edit enchantItemOptions.xsd, i edit max enchant item to +15)

[sepultribe]

post your exact changes in the 3 files mentioned

[InFocus]

Option 1:

<option id="24921" name="o_july_shirt_stat_23">
		<!-- INT +5. STR +5. CON +5. MEN +5. -->
		<for>
			<add stat="STR" val="5" />
			<add stat="INT" val="5" />
			<add stat="CON" val="5" />
			<add stat="DEX" val="5" />
		</for>
	</option>

Option 2:

<option id="24958" name="o_s_76_85_opt_earring_drop_up4">
		<!-- Passive: Item drop rate increases by 40%. -->
		<passive_skill id="8416" level="4" /> <!-- Earring Ability - Drop Rate Up -->
	</option>

Option 3:

<option id="24691" name="o_s_84_2u_47">
		<!-- Passive: Increases the rate of critical attacks. -->
		<passive_skill id="3249" level="10" /> <!-- Item Skill: Focus -->
	</option>

Option 4:

<option id="24641" name="o_s_84_2r_104">
		<!-- Passive: Increases one's own P. Atk. -->
		<passive_skill id="3240" level="10" /> <!-- Item Skill: Might -->
	</option>

Edited July 26, 2018 by InFocus

[InFocus]

<?xml version="1.0" encoding="UTF-8"?>
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema">
	<xs:element name="list">
		<xs:complexType>
			<xs:sequence maxOccurs="1" minOccurs="1">
				<xs:element name="item" maxOccurs="unbounded" minOccurs="1">
					<xs:complexType>
						<xs:sequence maxOccurs="1" minOccurs="1">
							<xs:element name="options" maxOccurs="51" minOccurs="1">
								<xs:complexType>
									<xs:attribute name="level" use="required">
										<xs:simpleType>
											<xs:restriction base="xs:nonNegativeInteger">
												<xs:minInclusive value="0" />
												<xs:maxInclusive value="50" />
											</xs:restriction>
										</xs:simpleType>
									</xs:attribute>
									<xs:attribute name="option1" use="required">
										<xs:simpleType>
											<xs:restriction base="xs:positiveInteger">
												<xs:minInclusive value="1" />
												<xs:maxInclusive value="65535" />
											</xs:restriction>
										</xs:simpleType>
									</xs:attribute>
									<xs:attribute name="option2">
										<xs:simpleType>
											<xs:restriction base="xs:positiveInteger">
												<xs:minInclusive value="1" />
												<xs:maxInclusive value="65535" />
											</xs:restriction>
										</xs:simpleType>
									</xs:attribute>
									<xs:attribute name="option3">
										<xs:simpleType>
											<xs:restriction base="xs:positiveInteger">
												<xs:minInclusive value="1" />
												<xs:maxInclusive value="65535" />
											</xs:restriction>
										</xs:simpleType>
									</xs:attribute>
									<xs:attribute name="option4">
										<xs:simpleType>
											<xs:restriction base="xs:positiveInteger">
												<xs:minInclusive value="1" />
												<xs:maxInclusive value="65535" />
											</xs:restriction>
										</xs:simpleType>
									</xs:attribute>
								</xs:complexType>
							</xs:element>
						</xs:sequence>
						<xs:attribute name="id" use="required">
							<xs:simpleType>
								<xs:restriction base="xs:positiveInteger">
									<xs:minInclusive value="1" />
									<xs:maxInclusive value="65535" />
								</xs:restriction>
							</xs:simpleType>
						</xs:attribute>
					</xs:complexType>
				</xs:element>
			</xs:sequence>
		</xs:complexType>
	</xs:element>
</xs:schema>

 

[SillverShadow]

 

do you have that last option in optiondata_cleint-e.dat ?

[InFocus]

I don't create new file, i get few options from exist options. But no wrk last option

[SillverShadow]

hmm if am probably wrong but if the packet needs to be edited ...good luck...

[SweeTs]

Dunno how it's coded, but I doubt it's as simple as that, still you have to edit core. So simply search where it is loaded and how data is parsed.

 

Ps: didn't read whole topic just few first posts. 

[InFocus]

i think, here is 

public void parseDocument(Document doc)
	{
		int counter = 0;
		for (Node n = doc.getFirstChild(); n != null; n = n.getNextSibling())
		{
			if ("list".equalsIgnoreCase(n.getNodeName()))
			{
				for (Node d = n.getFirstChild(); d != null; d = d.getNextSibling())
				{
					if ("item".equalsIgnoreCase(d.getNodeName()))
					{
						int itemId = parseInteger(d.getAttributes(), "id");
						if (!_data.containsKey(itemId))
						{
							_data.put(itemId, new HashMap<Integer, EnchantOptions>());
						}
						for (Node cd = d.getFirstChild(); cd != null; cd = cd.getNextSibling())
						{
							if ("options".equalsIgnoreCase(cd.getNodeName()))
							{
								final EnchantOptions op = new EnchantOptions(parseInteger(cd.getAttributes(), "level"));
								_data.get(itemId).put(op.getLevel(), op);
								
								for (byte i = 0; i < 3; i++)
								{
									final Node att = cd.getAttributes().getNamedItem("option" + (i + 1));
									if ((att != null) && Util.isDigit(att.getNodeValue()))
									{
										op.setOption(i, parseInteger(att));
									}
								}
								counter++;
							}
						}
					}
				}
			}
		}
		LOGGER.log(Level.INFO, getClass().getSimpleName() + ": Loaded: " + _data.size() + " Items and " + counter + " Options.");
	}
	

 

[sepultribe]

for (byte i = 0; i < 3; i++)

 

try with 4 instead of 3

[InFocus]

I try, no work :/

here it is all code 

/*
 * Copyright (C) 2004-2015 L2J Server
 * 
 * This file is part of L2J Server.
 * 
 * L2J Server is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 * 
 * L2J Server is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
 * General Public License for more details.
 * 
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */
package com.l2jserver.gameserver.data.xml.impl;

import java.util.HashMap;
import java.util.Map;
import java.util.logging.Level;

import org.w3c.dom.Document;
import org.w3c.dom.Node;

import com.l2jserver.gameserver.model.items.instance.L2ItemInstance;
import com.l2jserver.gameserver.model.options.EnchantOptions;
import com.l2jserver.gameserver.util.Util;
import com.l2jserver.util.data.xml.IXmlReader;

/**
 * @author UnAfraid
 */
public class EnchantItemOptionsData implements IXmlReader
{
	private final Map<Integer, Map<Integer, EnchantOptions>> _data = new HashMap<>();
	
	protected EnchantItemOptionsData()
	{
		load();
	}
	
	@Override
	public synchronized void load()
	{
		_data.clear();
		parseDatapackFile("data/enchantItemOptions.xml");
	}
	
	@Override
	public void parseDocument(Document doc)
	{
		int counter = 0;
		for (Node n = doc.getFirstChild(); n != null; n = n.getNextSibling())
		{
			if ("list".equalsIgnoreCase(n.getNodeName()))
			{
				for (Node d = n.getFirstChild(); d != null; d = d.getNextSibling())
				{
					if ("item".equalsIgnoreCase(d.getNodeName()))
					{
						int itemId = parseInteger(d.getAttributes(), "id");
						if (!_data.containsKey(itemId))
						{
							_data.put(itemId, new HashMap<Integer, EnchantOptions>());
						}
						for (Node cd = d.getFirstChild(); cd != null; cd = cd.getNextSibling())
						{
							if ("options".equalsIgnoreCase(cd.getNodeName()))
							{
								final EnchantOptions op = new EnchantOptions(parseInteger(cd.getAttributes(), "level"));
								_data.get(itemId).put(op.getLevel(), op);
								
								for (byte i = 0; i < 4; i++)
								{
									final Node att = cd.getAttributes().getNamedItem("option" + (i + 1));
									if ((att != null) && Util.isDigit(att.getNodeValue()))
									{
										op.setOption(i, parseInteger(att));
									}
								}
								counter++;
							}
						}
					}
				}
			}
		}
		LOGGER.log(Level.INFO, getClass().getSimpleName() + ": Loaded: " + _data.size() + " Items and " + counter + " Options.");
	}
	
	/**
	 * @param itemId
	 * @param enchantLevel
	 * @return enchant effects information.
	 */
	public EnchantOptions getOptions(int itemId, int enchantLevel)
	{
		if (!_data.containsKey(itemId) || !_data.get(itemId).containsKey(enchantLevel))
		{
			return null;
		}
		return _data.get(itemId).get(enchantLevel);
	}
	
	/**
	 * @param item
	 * @return enchant effects information.
	 */
	public EnchantOptions getOptions(L2ItemInstance item)
	{
		return item != null ? getOptions(item.getId(), item.getEnchantLevel()) : null;
	}
	
	/**
	 * Gets the single instance of EnchantOptionsData.
	 * @return single instance of EnchantOptionsData
	 */
	public static final EnchantItemOptionsData getInstance()
	{
		return SingletonHolder._instance;
	}
	
	private static class SingletonHolder
	{
		protected static final EnchantItemOptionsData _instance = new EnchantItemOptionsData();
	}
}

 

[InFocus]

Why it is so complicated to explain me how i can add 1 more option? i don't must edit half server in java. i try to add changes in EnchantItemOptionsData.java but no work. Where somewhere else i must edit?