Help Stucksub system errors

[sotid]

Hello

 

So my stuck sub system seems that it doesnt work properly, when I do subs I have to return to the main class afterwards to get the skills and sometimes it stucks some other times it doenst.

 

It seems that the main gets all the skills but the subs arent.

 

Also many times it stucks when you try to do a sub and it gets this error.

 

https://ibb.co/cjjtx7

 

https://ibb.co/kzdQAS

Does anyone has a working code for stucksub.

 

Also why is popping this everytime a new character is being created??

 

 

Edited March 24, 2018 by sotid

[sotid]

So I found out about the dublicate entry I just deleted all skills and no more of this error..

 

 

Also about this error

https://ibb.co/cjjtx7

 

I found out that when you buff up and try to do subclass your character stucks and doenst do the sub and kicks the error on the console.

[SweeTs]

If you make sub stuck then simply, don't change the class. Edit code to handle sub info addition, skill addition and remove setclassid or whatever method it uses, simply skip the class change and you should be ok. I guess.. Since changing class display is pointless when you stuck skills right? 

 

Or add all class info but don't 'remove skills' :D

 

BTW error is on skill removal. 

[sotid]

ok how about if I add something that checks my buffs and ignore the command to add/change subclass and write a text

 

 

example (copied for VillageMasterInstance cause I suck)

 

 

 // Fix exploit stuck subclass and skills
	   	if(player.isLearningSkill() || player.isLocked())
    		return;
	   	
		if(actualCommand.equalsIgnoreCase("create_clan"))
		{
			if(cmdParams.equals(""))
				return;

			ClanTable.getInstance().createClan(player, cmdParams);
		}
		else if(actualCommand.equalsIgnoreCase("create_academy"))
		{
			if(cmdParams.equals(""))
				return;

			createSubPledge(player, cmdParams, null, L2Clan.SUBUNIT_ACADEMY, 5);
		}

          

 

or

if(player.isCastingNow() || player.isAllSkillsDisabled())
			{
				player.sendPacket(new SystemMessage(SystemMessageId.SUBCLASS_NO_CHANGE_OR_CREATE_WHILE_SKILL_IN_USE));
				return;
			}
			
			if(player.isInCombat()){
			    player.sendMessage("You can't change Subclass when you are in combact.");
			    return;
			}

 

[SweeTs]

Say what? 

[sotid]

I mean add a code to check  if I have any buffs on and if I have it doenst let me do buff.

And send a message to the player that you cannot do subclasses when buffed or something like that..

Edited March 26, 2018 by sotid

[SweeTs]

Lol but why.. You better check why it throw error or simply remove buffs removal - kinda pointless. 

[sotid]

Thanks SweeTs I did what you said and is working fine you can lock it