Jump to content

Question

Posted (edited)

Hello people,

i've tried to make a code for L2GuardInstance. I wanted add some checks to guard's target list and make them give more hate (focus) on targets that have the proper checks.

Example if a player hit a guard the guard will attack him and by that time a Karma player can move in tower without guard change target and him him.

 

So basically what i did. 

 

In L2GuardInstance.java i added some small code:

public ScheduledFuture<?> getScheduler()
{
	return _schedule;
}

public void setScheduledTask(ScheduledFuture<?> task)
{
       _schedule = task;
}

and then i made a ThreadPoolManager (check every 1250 ms) 

for (PcInstance player : guard.getKnownList().getKnownPlayers().values)
{
     if (player.getKarma > 0)
     {
        guard.setTarget(player);
        guard.dotAttack(player);
     }
{

The threadpool is activated upon @Override addKnonwObject  and stop  at @Override removeKnownObject. (Like bellow)

@Override
public boolean addKnownObject(final L2Object object)
{
      //blablabla

       getActiveChar().setScheduled(ThreadPoolManager.getInstance().scheduledAiFixedRate(new CheckForKarma(getActiveChar()), 1000, 1000);
}

So basically whenever a object enter in knownList, if task == null it will start scheduler. 

 

It didn't work at all.. Any advice or how i should do this? 

Edited by Ο Χάρος

4 answers to this question

Recommended Posts

  • 0
Posted (edited)

You should forget the whole idea, Guards already have a AI, and that AI is called every second. L2J is legendary wrong about crafting AI system, no need to spread it more. Moreover you schedule a different task EACH TIME ANYONE is entering inside his range.

 

You only have to tweak AggroList in order first entry becomes second, and the PK becomes the first. I'm lazy to check, but by default the whole system already exists... Guards aggro at sight, probably adding 1 hate. The only problem is the value is too low, so whoever hits him will turn the aggro down. Simply put max value allowed as hate value, if the Ai is correctly done it will choose the new target accordingly his aggroList during the next ATTACK intention.

 

You can also override aggrolist system for guards and add a lock system if you want guards keep aggro no matter what. The lock/release could be done if "most hated" is/isn't a PK. That will avoid things like "confusion" and other operations on aggrolist to work (even if biggest allowed value is probably extremely hard to deny even using aggro skills).

Edited by Tryskell
  • 0
Posted (edited)

You should forget the whole idea, Guards already have a AI, and that AI is called every second. L2J is legendary wrong about crafting AI system, no need to spread it more. Moreover you schedule a different task EACH TIME ANYONE is entering inside his range.

 

You only have to tweak AggroList in order first entry becomes second, and the PK becomes the first. I'm lazy to check, but by default the whole system already exists... Guards aggro at sight, probably adding 1 hate. The only problem is the value is too low, so whoever hits him will turn the aggro down. Simply put max value allowed as hate value, if the Ai is correctly done it will choose the new target accordingly his aggroList during the next ATTACK intention.

 

You can also override aggrolist system for guards and add a lock system if you want guards keep aggro no matter what. The lock/release could be done if "most hated" is/isn't a PK.

 

 

actually its supposed to be like this. guard is not changing aggro unless the target is dead since c4.

 

Thanks for respond both.

 

Tryskell i would like to ask since im not familiar with big structure code, where exactly it check the aggro in which file, current i check guardKnownList and l2guardInstance

 

I smell something like L2Attackable as im checking now. but where it has the Next intention and check the aggroList? 

Edited by Ο Χάρος
  • 0
Posted (edited)

Regular guards use AttackableAI (L2AttackableAI on other forks), castle guards use their own system. AI system works based on intentions (ATTACK, CAST, ACTIVE, etc).

 

The generic behavior is handled by AbstractAI and underlayers, but it's overidden on AttackableAI on thinkActive() / thinkAttack().

 

AggroList is stored on Attackable (L2Attackable on other forks) under _aggroList. Useful methods used by AI (at least on aCis) include getMostHated(), addDamageHate(), reduceHate(), stopHating().

 

PS : naming conventions can and will differ.

	protected void thinkAttack()
	{
		final Attackable npc = getActiveChar();
		if (npc.isCastingNow())
			return;
		
		// Pickup most hated character.
		Creature attackTarget = npc.getMostHated();
		
		// If target doesn't exist, is too far or if timeout is expired.
		if (attackTarget == null || _attackTimeout < System.currentTimeMillis() || MathUtil.calculateDistance(npc, attackTarget, true) > 2000)
		{
			// Stop hating this target after the attack timeout or if target is dead
			npc.stopHating(attackTarget);
			setIntention(CtrlIntention.ACTIVE);
			npc.setWalking();
			return;
		}
Edited by Tryskell

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Posts

    • My official facebook profile!: https://www.facebook.com/spectrumL2 Specifications: Revamped L2JACIS revision FROM the core Private project!!! Revision that has been receiving corrections for over 3 years!!! Events already installed in the revision: TVT CTF KTB PARTY FARM SPOIL EVENT CRAZY RATES TOURNAMENT TIME ZONE (INSTANCE) All working correctly!!! SIEGE ESSENTIAL FEATURES: Walls fix Gates fix Flags fix 100% functional: OLYMPIADS: Implemented settings Hero receives enchanted Weapons with equal status PvP Weapons Optional /true/false Hero can acquire all Hero Weapons Optional true/false OTHER IMPLEMENTATIONS: Teleport fixed (directly to Giran) Teleport effect classic Vip skins vip collor name Pack NPCs with effect already configured BOSES already configured Mobs already configured CLASS BALANCE SPECIAL SYSTEM We have a SPECIAL system developed for Class Balance with only 1 digit in XML %tage of configurable debuffs Player limitation system in BOSES or PvP zones BS blocking system in FLEG zones or events Among others dozens of improvements made in the review... price: 390 USD !  OBS: WE CAN CHANGE THE BANNER AND NAME OF THE SERVICE TO THE ONE OF YOUR PREFERENCE BUT THE SETTINGS MUST BE KEPT ANY CHANGES REQUIRE ADDITION        
    • Server is Online – 1,000+ Active Players! We’re excited to announce the addition of a Europe Proxy to improve connectivity for our EU players! Clans can now benefit from VIP Access to help you catch up faster. 🎯 If you're a clan leader with at least 9 active members, join our Discord and open a ticket to claim your VIP rewards!  
    • The Telegram team is rolling out a new batch of Stars-only gifts you’ll be able to mint as NFTs. Don’t miss your chance to join the next Telegram trend and earn from it! Buy Telegram Stars cheap and KYC-free 1 Star from $0.0149 (min. 50 Stars, bulk discounts available) Promo code STARS5 — 5 % off Pay any way you like: bank cards · crypto · other popular methods How to purchase: ➡Online Store — Click ➡ Telegram bot — Click Other services: ➡ SMM panel — Click Regular buyers get extra discounts and promo codes. Support: ➡ Telegram: https://t.me/solomon_bog ➡ Telegram channel: https://t.me/accsforyou_shop ➡ Discord: https://discord.gg/y9AStFFsrh ➡ WhatsApp: https://wa.me/79051904467 ➡ Email: solomonbog@socnet.store Use these contacts to discuss wholesale orders, partnerships (current list: https://socnet.bgng.io/partners) or to become a supplier. SocNet — your shop for digital goods and premium subscriptions
  • Topics

×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock