Help Idk How...help Me On That Please

[Kelrzher]

1. I want to put if Human , Elf , Dwarf female setGood(true)  and if Orc , delf, male dwarf setEvil(true) i made the code but doesnt work correctly , thinking to delete setevil and change the setGood retail code here:http://pastebin.com/0wdWBjT5
2.  generally i deleted the setevil and changed the setgood to setdestiny i want just to press the button and check if race suits then go to the faction.. Goods : human , elf , female dwarf 

   evil : orc, d.elf , male dwarf

3. package net.sf.l2j;
   	
   	
   	 
   	
   	
   	import java.sql.Connection;
   	
   	
   	import java.sql.PreparedStatement;
   	
   	
   	import java.sql.ResultSet;
   	
   	
   	import java.util.StringTokenizer;
   	
   	
   	import java.util.logging.Logger;
   	
   	
   	 
   	
   	
   	import net.sf.l2j.commons.random.Rnd;
   	
   	
   	import net.sf.l2j.gameserver.ai.CtrlIntention;
   	
   	
   	import net.sf.l2j.gameserver.model.L2World;
   	
   	
   	import net.sf.l2j.gameserver.model.actor.instance.L2NpcInstance;
   	
   	
   	import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
   	
   	
   	import net.sf.l2j.gameserver.model.actor.template.NpcTemplate;
   	
   	
   	import net.sf.l2j.gameserver.network.serverpackets.ActionFailed;
   	
   	
   	import net.sf.l2j.gameserver.network.serverpackets.MyTargetSelected;
   	
   	
   	import net.sf.l2j.gameserver.network.serverpackets.NpcHtmlMessage;
   	
   	
   	import net.sf.l2j.gameserver.network.serverpackets.SocialAction;
   	
   	
   	import net.sf.l2j.gameserver.network.serverpackets.ValidateLocation;
   	
   	
   	 
   	
   	
   	 
   	
   	
   	 
   	
   	
   	public class L2FactionInstance extends L2NpcInstance
   	
   	
   	{
   	
   	
   	 
   	
   	
   	    public L2FactionInstance(int objectId, NpcTemplate template)
   	
   	
   	    {
   	
   	
   	        super(objectId, template);
   	
   	
   	    }
   	
   	
   	 
   	
   	
   	    private final static Logger _log = Logger.getLogger(L2FactionInstance.class.getName());
   	
   	
   	 
   	
   	
   	    @Override
   	
   	
   	    public void onBypassFeedback(L2PcInstance player, String command)
   	
   	
   	    {
   	
   	
   	        player.sendPacket(ActionFailed.STATIC_PACKET);
   	
   	
   	        StringTokenizer st = new StringTokenizer(command, " ");
   	
   	
   	        String actualCommand = st.nextToken();
   	
   	
   	        @SuppressWarnings("unused")
   	
   	
   	        String val = "";
   	
   	
   	        if (st.countTokens() >= 1)
   	
   	
   	        {
   	
   	
   	            val = st.nextToken();
   	
   	
   	    }
   	
   	
   	 
   	
   	
   	        else if (actualCommand.equalsIgnoreCase("setdestiny"))
   	
   	
   	        {
   	
   	
   	           
   	
   	
   	        setTarget(player);
   	
   	
   	       
   	
   	
   	            if (player.isGood())
   	
   	
   	            {
   	
   	
   	                player.sendMessage("You already are in " + Config.FACTION_NAME_TEAM_GOOD + " faction ");
   	
   	
   	                player.sendPacket(new ActionFailed());
   	
   	
   	            }
   	
   	
   	           if(player.getRace blabla bla 
   	
   	
   	                    {
   	
   	
   	                    player.setGood(true);
   	
   	
   	                    Connection connection = null;
   	
   	
   	                        try
   	
   	
   	                        {
   	
   	
   	                            connection = L2DatabaseFactory.getInstance().getConnection();
   	
   	
   	                            PreparedStatement statement = connection.prepareStatement("SELECT obj_Id FROM characters where char_name=?");
   	
   	
   	                            statement.setString(1, player.getName());
   	
   	
   	                            ResultSet rset = statement.executeQuery();
   	
   	
   	                            int objId = 0;
   	
   	
   	                        if (rset.next())
   	
   	
   	                            {
   	
   	
   	                                objId = rset.getInt(1);
   	
   	
   	                            }
   	
   	
   	                            rset.close();
   	
   	
   	                            statement.close();
   	
   	
   	                            if (objId == 0)
   	
   	
   	                            {
   	
   	
   	                                connection.close();
   	
   	
   	                                return;
   	
   	
   	                            }
   	
   	
   	                            statement = connection.prepareStatement("UPDATE characters SET good=1 WHERE obj_Id=?");
   	
   	
   	                        statement.setInt(1, objId);
   	
   	
   	                            statement.execute();
   	
   	
   	                            statement.close();
   	
   	
   	                            connection.close();
   	
   	
   	                        }
   	
   	
   	                        catch (Exception e)
   	
   	
   	                        {
   	
   	
   	                            _log.info("could not set good status of char:");
   	
   	
   	                        }
   	
   	
   	                        finally
   	
   	
   	                        {
   	
   	
   	                            try
   	
   	
   	                            {
   	
   	
   	                                connection.close();
   	
   	
   	                            }
   	
   	
   	                            catch (Exception e)
   	
   	
   	                            {
   	
   	
   	                            }
   	
   	
   	                        }
   	
   	
   	                   
   	
   	
   	                        if (player.isGood())
   	
   	
   	                        {
   	
   	
   	                            player.broadcastUserInfo();
   	
   	
   	                            player.sendMessage("You Are fighiting Now for" + Config.FACTION_NAME_TEAM_GOOD + " Faction ");
   	
   	
   	                            player.getAppearance().setNameColor(Config.FACTION_COLOR_NAME_GOOD);
   	
   	
   	                            player.teleToLocation(Config.GOODX, Config.GOODY, Config.GOODZ);
   	
   	
   	                            player.setTitle(Config.FACTION_NAME_TEAM_GOOD);
   	
   	
   	                        }
   	
   	
   	                    }
   	
   	
   	                }
   	
   	
   	        }
   	
   	
   	        }
   	
   	
   	           
   	
   	
   	                    else if(player.getRace() == Race.Orc() bla bla bla
   	
   	
   	                    {
   	
   	
   	                        player.setEvil(true);
   	
   	
   	                        Connection connection = null;
   	
   	
   	                        try
   	
   	
   	                        {
   	
   	
   	                            connection = L2DatabaseFactory.getInstance().getConnection();
   	
   	
   	                            PreparedStatement statement = connection.prepareStatement("SELECT obj_Id FROM characters where char_name=?");
   	
   	
   	                            statement.setString(1, player.getName());
   	
   	
   	                            ResultSet rset = statement.executeQuery();
   	
   	
   	                            int objId = 0;
   	
   	
   	                            if (rset.next())
   	
   	
   	                        {
   	
   	
   	                                objId = rset.getInt(1);
   	
   	
   	                        }
   	
   	
   	                            rset.close();
   	
   	
   	                            statement.close();
   	
   	
   	                            if (objId == 0)
   	
   	
   	                            {
   	
   	
   	                                connection.close();
   	
   	
   	                                return;
   	
   	
   	                            }
   	
   	
   	                            statement = connection.prepareStatement("UPDATE characters SET evil=1 WHERE obj_Id=?");
   	
   	
   	                            statement.setInt(1, objId);
   	
   	
   	                            statement.execute();
   	
   	
   	                            statement.close();
   	
   	
   	                            connection.close();
   	
   	
   	                        }
   	
   	
   	                        catch (Exception e)
   	
   	
   	                        {
   	
   	
   	                            _log.info("could not set evil status of char:");
   	
   	
   	                        }
   	
   	
   	                        finally
   	
   	
   	                        {
   	
   	
   	                            try
   	
   	
   	                            {
   	
   	
   	                                connection.close();
   	
   	
   	                            }
   	
   	
   	                            catch (Exception e)
   	
   	
   	                            {
   	
   	
   	                            }
   	
   	
   	                        }
   	
   	
   	                   
   	
   	
   	                        if (player.isEvil())
   	
   	
   	                        {
   	
   	
   	                            player.broadcastUserInfo();
   	
   	
   	                            player.sendMessage("You Are fighiting Now for " + Config.FACTION_NAME_TEAM_EVIL + " Faction ");
   	
   	
   	                            player.getAppearance().setNameColor(Config.FACTION_COLOR_NAME_EVIL);
   	
   	
   	                            player.teleToLocation(Config.EVILX, Config.EVILY, Config.EVILZ);
   	
   	
   	                            player.setTitle(Config.FACTION_NAME_TEAM_EVIL);
   	
   	
   	                        }
   	
   	
   	                    }
   	
   	
   	                }
   	
   	
   	            
   	
   	
   	        else if (actualCommand.equalsIgnoreCase("setnobless"))
   	
   	
   	        {
   	
   	
   	       
   	
   	
   	            L2PcInstance activeChar = player;
   	
   	
   	            if (activeChar.isNoble())
   	
   	
   	                activeChar.sendMessage("You Are Already A Noblesse!.");
   	
   	
   	            else
   	
   	
   	            {
   	
   	
   	                activeChar.setNoble(true, true);
   	
   	
   	                activeChar.sendMessage("You Are Now a Noble,You Are Granted With Noblesse Status , And Noblesse Skills.");
   	
   	
   	                activeChar.broadcastUserInfo();
   	
   	
   	                activeChar.getInventory().addItem("Tiara", 7694, 1, activeChar, null);
   	
   	
   	            }
   	
   	
   	        }
   	
   	
   	        else
   	
   	
   	        {
   	
   	
   	            super.onBypassFeedback(player, command);
   	
   	
   	        }
   	
   	
   	    }
   	
   	
   	   
   	
   	
   	    @Override
   	
   	
   	    public String getHtmlPath(int npcId, int val)
   	
   	
   	    {
   	
   	
   	        return "data/html/mods/faction/main.htm";
   	
   	
   	    }
   	
   	
   	 
   	
   	
   	}

Edited December 7, 2016 by Kelrzher

[Tessa]

 

trolling ... not just kidding lul

 

 

if(....){

...

return true;

}

return false;

 

ftw style

 

It's style actually, because the code is still clear and it doesn't cause any performance issues... I've never written "return smth == smthelse;" in my practice, so, I wouldn't start now. :lol:

Edited December 8, 2016 by Tessa

[bravetobe]

It's style actually, because the code is still clear and it doesn't cause any performance issues... I've never written "return smth == smthelse;" in my practice, so, I wouldn't start now. :lol:

well,i m neither familiar with it,even if i use(d) it in other languages from time to time like python

 

anyway,gonna grab popcorn again ... fighting for the best l2j dev "throne".damn

Edited December 8, 2016 by bravetobe

[Tessa]

well,i m neither familiar with it,even if i use(d) it in other languages from time to time like python

 

anyway,gonna grab popcorn again ... fighting for the best l2j dev "throne".damn

Wait till the devs wake up, I'm not pretending to be a dev at all... :lol:

Edited December 8, 2016 by Tessa

[Versus]

Well 3 pages of nonsense :D Tryskell gave you the best solution on the first reply of this topic :D No idea why you completely ignored him and kept posting more trash code.

[Sdw]

It's style actually, because the code is still clear and it doesn't cause any performance issues... I've never written "return smth == smthelse;" in my practice, so, I wouldn't start now. :lol:

It does.

[Tessa]

It does.

Inline comparsion is faster than if statement?

[Tessa]

It does.

Lol, damn it... it really does! :lol:

Thanks, I will use this from now on... ^^

[xxdem]

Inline comparsion is faster than if statement?

 

inline instructions exist in asm level and there are ways to do it in C++, in Java theoretically it is possible aswell but not in all cases

[Tessa]

inline instructions exist in asm level and there are ways to do it in C++, in Java theoretically it is possible aswell but not in all cases

I'm editing my answer right now, I just benchmarket it, and I saw the difference. :lol:

[Kelrzher]

thanks for the code guys .. perfect working 

[Tessa]

I'm thankful too, I just learned something new. :lol:

[Kelrzher]

I'm thankful too, I just learned something new. :lol:

rofl

[Tessa]

rofl

I'm not afraid to say that I'm noob. :lol:

[Kelrzher]

I'm not afraid to say that I'm noob. :lol:

neither do i , so to be honest i wait someone to give me de solution

[Tessa]

neither do i , so to be honest i wait someone to give me de solution

What solution? Just implement the code from the first page. :lol: