Help Acis Hopzone Reward

[devil12pl]

Hello. I have little problem with code which is getting votes count from hopzone website. It worked perfectly but now it doesn't work at all. I'm using aCis files.

/*
 * This program is free software: you can redistribute it and/or modify it under
 * the terms of the GNU General Public License as published by the Free Software
 * Foundation, either version 3 of the License, or (at your option) any later
 * version.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
 * details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program. If not, see <http://www.gnu.org/licenses/>.
 */
package net.sf.l2j.gameserver.votereward;

import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.net.URL;
import java.net.URLConnection;
import java.util.Map;

import net.sf.l2j.Config;


public class Hopzone extends VoteSystem
{
       public Hopzone(int votesDiff, boolean allowReport, int boxes, Map<Integer, Integer> rewards, int checkMins)
       {
               super(votesDiff, allowReport, boxes, rewards, checkMins);
       }
      
       @Override
       public void run()
       {
               reward();
       }
      
       @Override
       public int getVotes()
       {
               InputStreamReader isr = null;
               BufferedReader br = null;
              
               try
               {
                       URLConnection con = new URL(Config.HOPZONE_SERVER_LINK).openConnection();
                       con.addRequestProperty("User-Agent", "Mozilla/4.76");
                       isr = new InputStreamReader(con.getInputStream());
                       br = new BufferedReader(isr);
                      
                       String line;
                       while ((line = br.readLine()) != null)
                       {
                               if (line.contains("<li><span class=\"rank tooltip\" title"))
                               {
                                       int votes = Integer.valueOf(line.split(">")[2].replace("</span", ""));
                                       return votes;
                               }
                       }
                      
                       br.close();
                       isr.close();
               }
               catch (Exception e)
               {
                       e.printStackTrace();
                       System.out.println("Error while getting server vote count from "+getSiteName()+".");
               }
              
               return -1;
       }
      
       @Override
       public String getSiteName()
       {
               return "Hopzone";
       }
}

[Reborn12]

Your if line is too long without any reason, keep only "Total Votes" and it's gonna be fine  ^_^

like this?

 

String line;
           while ((line = in.readLine()) != null)
           {
               if (line.contains("Total Votes") )
               {
                   String inputLine = line.split(">")[2].replace("</span", "");
                   votes = Integer.parseInt(inputLine);
                   break;

[Reborn12]

Addapt this method to yours

public int getHopzoneVotes()
    {
        int votes = -1;
        try
        {
            final URL obj = new URL(Config.VOTES_SITE_HOPZONE_URL);
            final HttpURLConnection con = (HttpURLConnection) obj.openConnection();
           
            con.addRequestProperty("User-Agent", "L2Hopzone");
            con.setConnectTimeout(5000);
           
            final int responseCode = con.getResponseCode();
            if (responseCode == 200)
            {
                try (BufferedReader in = new BufferedReader(new InputStreamReader(con.getInputStream())))
                {
                    String inputLine;
                    while ((inputLine = in.readLine()) != null)
                    {
                        if (inputLine.contains("<li><span class=\"rank anonymous tooltip\" title"))
                        {
                            votes = Integer.valueOf(inputLine.split(">")[2].replace("</span", ""));
                            break;
                        }
                    }
                }
            }
        }
        catch (Exception e)
        {
            announce("HOPZONE is offline. We will check reward as it will be online again.");
        }
        return votes;
    }

[devil12pl]

Thanks for reply. I'm at very first stage of learning java but I edited it and compilet and still doesn't work. Code looks like this right now:

/*
 * This program is free software: you can redistribute it and/or modify it under
 * the terms of the GNU General Public License as published by the Free Software
 * Foundation, either version 3 of the License, or (at your option) any later
 * version.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
 * details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program. If not, see <http://www.gnu.org/licenses/>.
 */
package net.sf.l2j.gameserver.votereward;


import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.net.HttpURLConnection;
import java.net.URL;
import java.util.Map;

import net.sf.l2j.Config;


public class Hopzone extends VoteSystem
{
       public Hopzone(int votesDiff, boolean allowReport, int boxes, Map<Integer, Integer> rewards, int checkMins)
       {
               super(votesDiff, allowReport, boxes, rewards, checkMins);
       }
      
       @Override
       public void run()
       {
               reward();
       }
      
       @Override
       public int getVotes()
       {
 
               try
               {
                       final URL obj = new URL(Config.HOPZONE_SERVER_LINK);
                       final HttpURLConnection con = (HttpURLConnection) obj.openConnection();
                      
                       con.addRequestProperty("User-Agent", "L2Hopzone");
                       con.setConnectTimeout(5000);
                      
                       final int responseCode = con.getResponseCode();
                       if (responseCode == 200)
                       {
                           try (BufferedReader in2 = new BufferedReader(new InputStreamReader(con.getInputStream())))
                           {
                               String inputLine;
                               while ((inputLine = in2.readLine()) != null)
                               {
                                   if (inputLine.contains("<li><span class=\"rank anonymous tooltip\" title"))
                                   {
                                       int votes = Integer.valueOf(inputLine.split(">")[2].replace("</span", ""));
                                       return votes;
                                   }
                               }
                           }
                       }
               }
               catch (Exception e)
               {
                   e.printStackTrace();
                   System.out.println("Error while getting server vote count from "+getSiteName()+".");
               }
               return -1;
           }
      
      
       @Override
       public String getSiteName()
       {
               return "Hopzone";
       }
}

[iAlreadyExist]

-con.addRequestProperty("User-Agent", "L2Hopzone");

 

+con.addRequestProperty("User-Agent", "Mozilla/4.76");

[Reborn12]

Change all the method and rename it to

public int getVotes()

 

Then add this final URL obj = new URL(Config.HOPZONE_SERVER_LINK);To this    final URL obj = new URL(Config.VOTES_SITE_HOPZONE_URL);

And you will be need this too  where method is like this.
System.out.println("Error while getting server vote count from "+getSiteName()+".")

Edited August 22, 2016 by Reborn12

[devil12pl]

Change all the method and rename it to

public int getVotes()

 

Then add this final URL obj = new URL(Config.HOPZONE_SERVER_LINK);To this    final URL obj = new URL(Config.VOTES_SITE_HOPZONE_URL);

And you will be need this too  where method is like this.
System.out.println("Error while getting server vote count from "+getSiteName()+".")

I have no idea what you just told me :D

I would be thankfull for more detailed explanation, also if you can tell me what's wrong with the first code, cause it worked and then stopped to work.

[Reborn12]

I have no idea what you just told me :D

I would be thankfull for more detailed explanation, also if you can tell me what's wrong with the first code, cause it worked and then stopped to work.

Read the lines and just do what i said and send me here your config settings what link you use?

[devil12pl]

But which methods I have to change? Give me an exmaple pelase. Whole hopzone Config:
 

# Vote reward for Hopzone.
AllowHopzoneVoteReward = True
# Vote reward server link. (IMPORTANT!!!! Always add .html at the end of the link)
HopzoneServerLink = http://l2.hopzone.net/lineage2/details/93067/L2-DAMAGE.html
# Votes for next reward needed.
HopzoneVotesDifference = 5
# Minutes between rewards.
# Eg. You put 5 it checks every 5 minutes for reward.
HopzoneRewardCheckTime = 1
# Reward(s).
HopzoneReward = 9905,5;
# Topzone reward max dual boxes reward.
# For example if you put 2 and someone has 3 boxes open 2 will be rewarded.
HopzoneDuaboxesAllowed = 1
# Game server console report.
# If set to true, game server console will get a report of
# current vote count, votes needed for next reward and votes needed for first page.
AllowHopzoneGameServerReport = True

[Reborn12]

But which methods I have to change? Give me an exmaple pelase. Whole hopzone Config:

 

 

# Vote reward for Hopzone.
AllowHopzoneVoteReward = True
# Vote reward server link. (IMPORTANT!!!! Always add .html at the end of the link)
HopzoneServerLink = http://l2.hopzone.net/lineage2/details/93067/L2-DAMAGE.html
# Votes for next reward needed.
HopzoneVotesDifference = 5
# Minutes between rewards.
# Eg. You put 5 it checks every 5 minutes for reward.
HopzoneRewardCheckTime = 1
# Reward(s).
HopzoneReward = 9905,5;
# Topzone reward max dual boxes reward.
# For example if you put 2 and someone has 3 boxes open 2 will be rewarded.
HopzoneDuaboxesAllowed = 1
# Game server console report.
# If set to true, game server console will get a report of
# current vote count, votes needed for next reward and votes needed for first page.
AllowHopzoneGameServerReport = True
 

With this what i have told you to change you will be not need the .html at the end just read what i have wrote and change your method

[devil12pl]

Yeah but what do I have to do with methods? Change all the methods to public int getVotes(), or what. This is what I don't understand that's why I'm asking for more explanation. What changes I need to do in methods?

[SweeTs]

Use above getVotes method and link without .htm, like

 

 

http://l2.hopzone.net/lineage2/details/100010/L2MIRACLE

[devil12pl]

Thanks for reply. It doesn't work for me. Deleted .html from the link and still same. Code looks like this right now. I think I need something like a guide for people resistant to knowledge :D

/*
 * This program is free software: you can redistribute it and/or modify it under
 * the terms of the GNU General Public License as published by the Free Software
 * Foundation, either version 3 of the License, or (at your option) any later
 * version.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
 * details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program. If not, see <http://www.gnu.org/licenses/>.
 */
package net.sf.l2j.gameserver.votereward;


import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.net.HttpURLConnection;
import java.net.URL;
import java.util.Map;

import net.sf.l2j.Config;


public class Hopzone extends VoteSystem
{
       public Hopzone(int votesDiff, boolean allowReport, int boxes, Map<Integer, Integer> rewards, int checkMins)
       {
               super(votesDiff, allowReport, boxes, rewards, checkMins);
       }
      
       @Override
       public void run()
       {
               reward();
       }
      
       @Override
       public int getVotes()
       {
 
               try
               {
                       final URL obj = new URL(Config.HOPZONE_SERVER_LINK);
                       final HttpURLConnection con = (HttpURLConnection) obj.openConnection();
                      
                       con.addRequestProperty("User-Agent", "Mozilla/4.76");
                       con.setConnectTimeout(5000);
                      
                       final int responseCode = con.getResponseCode();
                       if (responseCode == 200)
                       {
                           try (BufferedReader in2 = new BufferedReader(new InputStreamReader(con.getInputStream())))
                           {
                               String inputLine;
                               while ((inputLine = in2.readLine()) != null)
                               {
                                   if (inputLine.contains("<li><span class=\"rank anonymous tooltip\" title"))
                                   {
                                       int votes = Integer.valueOf(inputLine.split(">")[2].replace("</span", ""));
                                       return votes;
                                   }
                               }
                           }
                       }
               }
               catch (Exception e)
               {
                   e.printStackTrace();
                   System.out.println("Error while getting server vote count from "+getSiteName()+".");
               }
               return -1;
           }
      
      
       @Override
       public String getSiteName()
       {
               return "Hopzone";
       }
}

[Reborn12]

paste this on you java file 

 

/*
 * This program is free software: you can redistribute it and/or modify it under
 * the terms of the GNU General Public License as published by the Free Software
 * Foundation, either version 3 of the License, or (at your option) any later
 * version.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
 * details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program. If not, see <http://www.gnu.org/licenses/>.
 */
package net.sf.l2j.gameserver.votereward;
 
import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.net.HttpURLConnection;
import java.net.URL;
import java.net.URLConnection;
import java.util.Map;
 
import net.sf.l2j.Config;
 
 
public class Hopzone extends VoteSystem
{
       public Hopzone(int votesDiff, boolean allowReport, int boxes, Map<Integer, Integer> rewards, int checkMins)
       {
               super(votesDiff, allowReport, boxes, rewards, checkMins);
       }
      
       @Override
       public void run()
       {
               reward();
       }
      
       @Override
       public int getVotes()
       {
           int votes = -1;
           try
           {
               final URL obj = new URL(Config.HOPZONE_SERVER_LINK);
               final HttpURLConnection con = (HttpURLConnection) obj.openConnection();
              
               con.addRequestProperty("User-Agent", "L2Hopzone");
               con.setConnectTimeout(5000);
              
               final int responseCode = con.getResponseCode();
               if (responseCode == 200)
               {
                   try (BufferedReader in = new BufferedReader(new InputStreamReader(con.getInputStream())))
                   {
                       String inputLine;
                       while ((inputLine = in.readLine()) != null)
                       {
                           if (inputLine.contains("<li><span class=\"rank anonymous tooltip\" title"))
                           {
                               votes = Integer.valueOf(inputLine.split(">")[2].replace("</span", ""));
                               break;
                           }
                       }
                   }
               }
           }
           catch (Exception e)
           {
                       e.printStackTrace();
                       System.out.println("Error while getting server vote count from "+getSiteName()+".");
           }
           return votes;
       }
      
       @Override
       public String getSiteName()
       {
               return "Hopzone";
       }
}

[devil12pl]

Thanks for your reply. Pasted, compiled and restarted server but still doesn't work. I have no idea what is wrong here.

[Reborn12]

Thanks for your reply. Pasted, compiled and restarted server but still doesn't work. I have no idea what is wrong here.

did you replace the jar file?