Custom Scripts In Last Acis Rev

[pasha95]

Hello guys. How i can add this script ("Announce spawn RB") in acis rev 352. In 340 rev this work perfectly.

Sorry 4 my bad english.

 

The script:

package custom.NpcScriptThree;

import net.sf.l2j.gameserver.util.Broadcast;
import net.sf.l2j.gameserver.model.actor.L2Npc;
import net.sf.l2j.gameserver.scripting.Quest;

public class NpcScriptThree extends Quest
{
	//Ид боссов
	private static final int[] BossId =
	{
		25035,
		25220,
		25054,
		25126,
		25325,
		25309,
		25312,
		25299,
		25302,
		25269,
		25163,
		25453,
		25328,
		25202,
		25109,
		25319,
	};
	
	public NpcScriptThree(int questId, String descr)
	{
		super(questId, descr);
		for (int BossIds : BossId)
			addSpawnId(BossIds);
	}
	
	@Override
	public String onSpawn(L2Npc raidboss)
	{
		int npcId = raidboss.getNpcId();
		for (int id : BossId)
			if (npcId == id)
				Broadcast.announceToOnlinePlayers("RaidBoss : " + raidboss.getName() + " spawn in the world!");
		return super.onSpawn(raidboss);
	}
	
	public static void main(String[] args)
	{
		new NpcScriptThree(-1, "custom");
	}
}

I need put this to source or not? Help pls

[Tryskell]

Drop "main" method, edit constructor to remove parameters, edit package, add on scripts.xml and voila.

 

Finally your for loop is pointless on onSpawn, because possible ids are already managed inside constructor via addSpawnId.

	@Override
	public String onSpawn(L2Npc raidboss)
	{
		Broadcast.announceToOnlinePlayers("RaidBoss : " + raidboss.getName() + " spawn in the world!");
		return super.onSpawn(raidboss);
	}

Edited September 18, 2015 by Tryskell

[pasha95]

 

Drop "main" method, edit constructor to remove parameters, edit package, add on scripts.xml and voila.

 

Finally your for loop is pointless on onSpawn, because possible ids are already managed inside constructor via addSpawnId.

	@Override
	public String onSpawn(L2Npc raidboss)
	{
		Broadcast.announceToOnlinePlayers("RaidBoss : " + raidboss.getName() + " spawn in the world!");
		return super.onSpawn(raidboss);
	}

 

How about this?

package net.sf.l2j.gameserver.scripting.scripts.custom;

import net.sf.l2j.gameserver.util.Broadcast;
import net.sf.l2j.gameserver.model.actor.L2Npc;
import net.sf.l2j.gameserver.scripting.Quest;

public class NpcScriptThree extends Quest
{
	//Ид боссов
	private final static int[] BossIds =
	{
		25035,
		25220,
		25054,
		25126,
		25325,
		25309,
		25312,
		25299,
		25302,
		25269,
		25163,
		25453,
		25328,
		25202,
		25109,
		25319,
	};
	
	public NpcScriptThree()
	{
		super(-1, "custom");
		for (int BossId : BossIds)
			addSpawnId(BossId);
	}
	
	@Override
	public String onSpawn(L2Npc raidboss)
	{
		int npcId = raidboss.getNpcId();
		for (int id : BossIds)
			if (npcId == id)
				Broadcast.announceToOnlinePlayers("RaidBoss : " + raidboss.getName() + " spawn in the world!");
		return super.onSpawn(raidboss);
	}
}

i don't very good know java :( But i wan't it... and teach english too :D

[Tryskell]

I copy pasted what should be onSpawn section on my previous post.

 

Otherwise, it looks good.

[pasha95]

I copy pasted what should be onSpawn section on my previous post.

 

Otherwise, it looks good.

Oh yes, don't see changes. Ty man, it works! 

[SweeTs]

Locked.