Help Pvp Flag Time Inside Zone

[ton3]

I have this code and still when my char kill another char inside zone the pvp flag is gone after 30sec.

public void updatePvPStatus()
	{
		if (isInsideZone(ZoneId.PVP) || isInsideZone(ZoneId.FLAG_ZONE)) 
			return;
		
		PvpFlagTaskManager.getInstance().add(this, Config.PVP_NORMAL_TIME);
		
		if (getPvpFlag() == 0)
			updatePvPFlag(1);
	}

and

public void updatePvPStatus(L2Character target)
	{
		final L2PcInstance player = target.getActingPlayer();
		if (player == null)
			return;
		
		if (isInDuel() && player.getDuelId() == getDuelId())
			return;
		
		if ((!isInsideZone(ZoneId.PVP) || !target.isInsideZone(ZoneId.PVP)) && player.getKarma() == 0)
		{
			PvpFlagTaskManager.getInstance().add(this, checkIfPvP(player) ? Config.PVP_PVP_TIME : Config.PVP_NORMAL_TIME);
			
			if (getPvpFlag() == 0)
				updatePvPFlag(1);
		}
	}

can someone point me what is wrong? thanks.

Edited July 13, 2015 by ton3

[SweeTs]

You almost did it. But why you put " ! " and " || " .. :)

 

Remove ! and change || to &&

Edited July 14, 2015 by SweeTs

[Tryskell]

What's your goal ? It's supposed to be like that, no ?

 

If you speak about aCis, PvpFlagTaskManager registers the player on a permanent task, which verify every second if the timer is reached. If you don't flag anew, and the timer is reached then the player is removed from the task and flag is cleared.

 

This global task replaces the old system which was creating a task per player, generating a lot of objects.

Edited July 13, 2015 by Tryskell

[ton3]

My goal is to keep the player flagged when inside zone, even if u kill someone the PvPflag shouldnt disappear when inside zone.

[Tryskell]

You have to rework the way PvpFlagTaskManager works then. If you don't want to keep traditional pvp system, drop it otherwise you have to rework.

[ton3]

I think it will be easier to rework my flagzone then and make it like siege.

protected void onEnter(L2Character character)
	{

          character.setInsideZone(ZoneId.PVP, true);
          character.setInsideZone(ZoneId.NO_SUMMON_FRIEND, true);
          ((L2PcInstance) character).sendMessage("You have entered a chaotic zone.");
        }

My question now is, would PvP points count inside the zone? or I have to add it in l2pcinstance?

[SweeTs]

You miss the check here

 

 

public void updatePvPStatus(L2Character target)

[ton3]

what check? this?

if (isInsideZone(ZoneId.PVP) || isInsideZone(ZoneId.FLAG_ZONE))

[ton3]

public void updatePvPStatus(L2Character target)
    {    
        final L2PcInstance player = target.getActingPlayer();
        if (player == null)
            return;
        
        if (isInDuel() && player.getDuelId() == getDuelId())
            return;
        
        if ((!isInsideZone(ZoneId.FLAG_ZONE) || !target.isInsideZone(ZoneId.FLAG_ZONE)))
            return;
        
        if ((!isInsideZone(ZoneId.PVP) || !target.isInsideZone(ZoneId.PVP)) && player.getKarma() == 0)
        {
            PvpFlagTaskManager.getInstance().add(this, checkIfPvP(player) ? Config.PVP_PVP_TIME : Config.PVP_NORMAL_TIME);
            
            if (getPvpFlag() == 0)
                updatePvPFlag(1);
        }
                
            
    }

this worked but im wondering if I will have any problem with this?

 

Edit: Yes I will have problems when outside FLAG_ZONE, removing return; would fix it?

Edit2: Removing return; didnt fix, I dont know what else to, if anyone could help I would be grateful!

Edited July 14, 2015 by ton3

[netoluan]

http://www.maxcheaters.com/topic/193906-acis-inside-pvpzone/

any people can help me? pleease   :-\

Edited July 14, 2015 by netoluan

[ton3]

SweeTs, I have to register character to FLAG_ZONE when he enters the zone? like this on flagzone.java

protected void onEnter(L2Character character)
       {
                  L2PcInstance activeChar = ((L2PcInstance) character);
               character.setInsideZone(ZoneId.NO_SUMMON_FRIEND, true);
               character.setInsideZone(ZoneId.FLAG_ZONE, true);
               activeChar.updatePvPFlag(1);
               if (character instanceof L2PcInstance)
               {
                           activeChar.sendMessage("You have entered a chaotic zone.");
               }
       }

Edit: working 100% thank you

Edited July 14, 2015 by ton3

[ton3]

Now im having another problem related to pvp flag when player enter the zone while flagged.

 

I have this code:

@Override
       protected void onEnter(L2Character character)
       {
                  L2PcInstance activeChar = ((L2PcInstance) character);
                  activeChar.updatePvPFlag(0);
                  activeChar.updatePvPFlag(1);
               character.setInsideZone(ZoneId.NO_SUMMON_FRIEND, true);
               character.setInsideZone(ZoneId.FLAG_ZONE, true);
               
               if (character instanceof L2PcInstance)
               {
                       
                           activeChar.sendMessage("You have entered a chaotic zone.");
               }
       }

and still doesnt cancel flag when enter zone, sorry for so many questions but im still learning.

[SweeTs]

You are canceling the flag and right after you are setting the flag.

activeChar.updatePvPFlag(0);
activeChar.updatePvPFlag(1);

Also, your onEnter is kinda errrm :P

if (character instanceof L2PcInstance

This should be as first, before your updatePvPFlag, like

    @Override
    protected void onEnter(L2Character character)
    {
        if (character instanceof L2PcInstance)
        {
            L2PcInstance activeChar = ((L2PcInstance) character);
            
            activeChar.updatePvPFlag(1);
            activeChar.sendPacket(SystemMessageId.ENTERED_COMBAT_ZONE);
        }
        
        character.setInsideZone(ZoneId.FLAG_ZONE, true);
        character.setInsideZone(ZoneId.NO_SUMMON_FRIEND, true);
    }

Edited July 14, 2015 by SweeTs

[ton3]

yea I want to cancel flag from players who came flagged from outside zone, I will try to explain what is going on below;

 

exit zone > hit a white player > enter zone > ur flag disappears after 30 seconds even if u are inside FLAG_ZONE.

[SweeTs]

The flag should not disappear, since you update the flag once again onEnter. Test the structure I gave you. Most likely it's cause of your messy logic (wrong order).. :P

 

Else, you forgot about the check about update pvp status.

Edited July 14, 2015 by SweeTs

[ton3]

I added the pvp check and still not working, flag is gone after 15sec when inside flag_zone.

 @Override
       protected void onEnter(L2Character character)
       {
           if (character instanceof L2PcInstance)
           {
                  L2PcInstance activeChar = ((L2PcInstance) character);
                  
                  //set pvpflag
                  if (activeChar.getPvpFlag() == 0)
                  activeChar.updatePvPFlag(1);
                  activeChar.sendMessage("You have entered a chaotic zone.");
           }
                
                  character.setInsideZone(ZoneId.FLAG_ZONE, true);
               character.setInsideZone(ZoneId.NO_SUMMON_FRIEND, true);                                       
                                            
       }

Edited July 14, 2015 by ton3