Jump to content
  • 0

Item Duping,loading


StealthyS4m

Question

Hello guys,
I am not sure,but I guess that some players in my server are using this method to dupe items: http://www.maxcheaters.com/topic/189012-new-bug-duplicate-freya-hi5/
I've given it a thought and came with few solutions.

1) Change method when you enter the world,the last thing program does is load your inventory.
2) Change the way deleting item method works,load items from databse every time you delete something.Just thought of one downside for this method,wouldn't the said duping method work if instead of deleting item just trade it to someone or using other transfer method.Plus,I believe, it's really hitting on performance.
Any help guys?
EDIT: aCis rev 320

Edited by StealthyS4m
Link to comment
Share on other sites

Recommended Posts

  • 0

 

Index: trunk/aCis_gameserver/java/net/sf/l2j/gameserver/network/clientpackets/AuthLogin.java
===================================================================
--- trunk/aCis_gameserver/java/net/sf/l2j/gameserver/network/clientpackets/AuthLogin.java    (revision 236)
+++ trunk/aCis_gameserver/java/net/sf/l2j/gameserver/network/clientpackets/AuthLogin.java    (revision 323)
@@ -15,8 +15,7 @@
 package net.sf.l2j.gameserver.network.clientpackets;
 
-import net.sf.l2j.Config;
 import net.sf.l2j.gameserver.LoginServerThread;
 import net.sf.l2j.gameserver.LoginServerThread.SessionKey;
-import net.sf.l2j.gameserver.network.L2GameClient;
+import net.sf.l2j.gameserver.network.serverpackets.L2GameServerPacket;
 
 /**
@@ -44,14 +43,13 @@
     protected void runImpl()
     {
-        final SessionKey key = new SessionKey(_loginKey1, _loginKey2, _playKey1, _playKey2);
-        if (Config.DEBUG)
-            _log.info("User:" + _loginName + "key:" + key);
-        
-        final L2GameClient client = getClient();
-        if (client.getAccountName() == null)
+        if (getClient().getAccountName() == null)
         {
-            client.setAccountName(_loginName);
-            LoginServerThread.getInstance().addGameServerLogin(_loginName, client);
-            LoginServerThread.getInstance().addWaitingClientAndSendRequest(_loginName, client, key);
+            if (LoginServerThread.getInstance().addGameServerLogin(_loginName, getClient()))
+            {
+                getClient().setAccountName(_loginName);
+                LoginServerThread.getInstance().addWaitingClientAndSendRequest(_loginName, getClient(), new SessionKey(_loginKey1, _loginKey2, _playKey1, _playKey2));
+            }
+            else
+                getClient().close((L2GameServerPacket) null);
         }
     }
 

 

 

Index: trunk/aCis_gameserver/java/net/sf/l2j/gameserver/LoginServerThread.java
===================================================================
--- trunk/aCis_gameserver/java/net/sf/l2j/gameserver/LoginServerThread.java    (revision 274)
+++ trunk/aCis_gameserver/java/net/sf/l2j/gameserver/LoginServerThread.java    (revision 323)
@@ -419,7 +419,10 @@
     }
     
-    public void addGameServerLogin(String account, L2GameClient client)
-    {
-        _accountsInGameServer.put(account, client);
+    public boolean addGameServerLogin(String account, L2GameClient client)
+    {
+        if (_accountsInGameServer.containsKey(account))
+            return false;
+        
+        return _accountsInGameServer.put(account, client) == null;
     }
Link to comment
Share on other sites

  • 0

Mhmm,I got those lines in my source.
Back to the problem-item duping.
I just know that this player is using phx,using warehouse(standing nearby) and reconnects a few times.In just looks like that he is doing the bug shown in the video,but if double login isn't working then...idk.
If anyone knows how it's done,Thanks!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Posts

    • Hello, I recently Installed the h5 Interface from emu-dev   Everything is working great but i was wondering if anyone can help me add the monster book and item book buttons on my community board to make it more accessible. Or if there is a way to add a button with HTML that calls these windows. I have xdat editor installed and i have located the relevant windows, but i don't know what to do with them. Thank you for your time.  
    • Add Support ShortCutPanel https://jumpshare.com/s/VTm9x1wvHmPokrqomNun
    • Καλησπερα μαγκες θα ηθελα εναν Dev ( που να γνωριζει καλα την δουλεια ) να ξεκινησουμε εξολοκληρου ενα Interlude PVP σερβερ που εχω στο μυαλο μου! Παρακαλω πολυ στειλτε μου προσωπικο στο προφιλ μου εδω για περαιτερω πληροφοριες! Ευχαριστω!
    • Open github. Find sdark94 account. Enter sdark94/trinity repository. Search for the DB backup. It is still there. I would've posted it here, if there was a HIDE_FOR_USER(S) feature, but there isn't one. You can DM me on Discord and I'll slip you a STRUCTURE-only DB export.   Yall lazy to even search the web bro. 😄 See the old videos from 3 years ago -> YOUTUBE Regarding java version, it is also visible in the source:
    • Welcome to my store : https://topestore.mysellix.io/fr/ 2015-2022 Aged Discord Account 2015 Discord Account : 60.99 $ 2016 Discord Account : 10.50 $ 2017 Discord Account :4.99 $ 2018 Discord Account : 3.99 $ 2019 Discord Account : 2.99 $ 2020 Discord Account :1.99$ 2021 Discord Account :1.50$ 2022 Discord Account :0.99$ Warranty :Lifetime Payment Methods : Crypto/ PayPal Contact Me On Discord Or Telegram Discord : @ultrasstore11 Telegram : https://t.me/ultrastore11 Whatsapp ; +212614849119 Welcome to my store : https://topestore.mysellix.io/fr/ 2015-2022 Aged Discord Account 2015 Discord Account : 60.99 $ 2016 Discord Account : 10.50 $ 2017 Discord Account :4.99 $ 2018 Discord Account : 3.99 $ 2019 Discord Account : 2.99 $ 2020 Discord Account :1.99$ 2021 Discord Account :1.50$ 2022 Discord Account :0.99$ Warranty :Lifetime Payment Methods : Crypto/ PayPal Contact Me On Discord Or Telegram Discord : @ultrasstore11 Telegram : https://t.me/ultrastore11 Whatsapp ; +212614849119 Welcome to my store : https://topestore.mysellix.io/fr/ 2015-2022 Aged Discord Account 2015 Discord Account : 60.99 $ 2016 Discord Account : 10.50 $ 2017 Discord Account :4.99 $ 2018 Discord Account : 3.99 $ 2019 Discord Account : 2.99 $ 2020 Discord Account :1.99$ 2021 Discord Account :1.50$ 2022 Discord Account :0.99$ Warranty :Lifetime Payment Methods : Crypto/ PayPal Contact Me On Discord Or Telegram Discord : @ultrasstore11 Telegram : https://t.me/ultrastore11 Whatsapp ; +212614849119
  • Topics

×
×
  • Create New...