Failed <100x times with somewhat simple voice command script...help please! :(

[Explos]

I wrote and rewrote this script time's and times again, and just can't get it to work...

The main problem is that i can't make the script to understand a subcommand (ex.: play_sound sound_file)

Here's the script:

package com.l2jfrozen.gameserver.handler.voicedcommandhandlers;

import java.util.StringTokenizer;

import com.l2jfrozen.Config;
import com.l2jfrozen.gameserver.handler.IVoicedCommandHandler;
import com.l2jfrozen.gameserver.model.actor.instance.L2PcInstance;
import com.l2jfrozen.gameserver.network.serverpackets.PlaySound;

public class Music implements IVoicedCommandHandler
{
   private static String[] _voicedCommands =
   {
      "play_music"
   };

   @Override
   public boolean useVoicedCommand(String command, L2PcInstance activeChar, String target)
   {
      if(command.startsWith("play_music"))
      {
         hearMusic(command, activeChar);
      }
      return true;
   }
   
   private void hearMusic(String command, L2PcInstance activeChar)
   {
      StringTokenizer st = new StringTokenizer(command, " ");
      st.nextToken();
      String music_name = st.nextToken();
      PlaySound _snd = new PlaySound(1, music_name, 0, 0, 0, 0, 0);
      activeChar.sendPacket(_snd);
      activeChar.broadcastPacket(_snd);
      //activeChar.sendMessage("Playing " + music_name + ".");
   }

   @Override
   public String[] getVoicedCommandList()
   {
      return _voicedCommands;
   }
}

it returns.:

Client: [Character: [Admin]Explos - Account: explos - IP: XX.XX.XX.XX] - Failed reading: [C] 38 Say2 ; null
java.util.NoSuchElementException
at java.util.StringTokenizer.nextToken(Unknown Source)
at com.l2jfrozen.gameserver.handler.voicedcommandhandlers.Music.hearMusic(Music.java:32)
at com.l2jfrozen.gameserver.handler.voicedcommandhandlers.Music.useVoicedCommand(Music.java:22)
at com.l2jfrozen.gameserver.network.clientpackets.Say2.runImpl(Say2.java:463)
at com.l2jfrozen.gameserver.network.clientpackets.L2GameClientPacket.run(L2GameClientPacket.java:75)
at com.l2jfrozen.gameserver.network.L2GameClient.run(L2GameClient.java:1202)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

 

Yes, my java knowledge is less than mediocre, but I try hard to get myself in the wheel of it, and it seem's to be harder than i thought it to be, i am (like to call myself) a programmer (not java ofc...yet).

I'm new to OOP and other swears...so please help me..i don't know what to do from here and lost hope to understand my problem even with google by my side (god bless google xD).

[Tryskell]

			StringTokenizer st = new StringTokenizer(command);
		st.nextToken();
		String type = st.nextToken();

 

//reload blabla is build like that.

 

Added to that (once you will correct), PlaySound got a special behavior, and I don't think L2JFrozen corrected it. You can't play all sounds with current implementation. Still it shouldn't send you that sort of errors.

[Explos]

Heh, so I digged in deeper into the pack (why i didin't do it earlier - dunno), and in

C:\Users\Explos\workspace\L2jFrozen_GameServer\head-src\com\l2jfrozen\gameserver\network\clientpackets\Say2.java

found this block:

if(st.countTokens() > 1)
{
   command = st.nextToken().substring(1);
   target = _text.substring(command.length() + 2);
   vch = VoicedCommandHandler.getInstance().getVoicedCommandHandler(command);
}

It instantly opened my eyes, as I tried to do, what is already done in the pack...lol for me..  ::)

Everything is working now, next time i'll look more to errors i'm getting, everything is a lot easier in java than i thought it was when I got shitload of errors in n tries ;D

However, thank you for quick reply, didin't get any replies in frozen's forum.. :-\

You didn't showed me anything that would solve my problem, but gave me a purpose to rethink everything from start, thnx ;)

[adenaman]

String has a function split

http://download.oracle.com/javase/1.4.2/docs/api/java/lang/String.html#split%28java.lang.String%29

You should not use it, cos it could make more problems, or is inefficient (dont remmember why xD) but next time you should try with it