[Help] Customs Halls

largirucho · June 23, 2011

i have some syntaxes errors on L2ClanhallTeleporterInstance.java. I use L2jServer interlude LAST REV.

when i try to compile i got this...

[javac] C:\Users\Roberto 3\Documents\workspace\L2jServer GS\java\net\sf\l2j\gameserver\model\actor\instance\L2ClanHallTeleporterInstance.java:36: cannot find symbol
    [javac] symbol  : variable InstanceType
    [javac] location: class net.sf.l2j.gameserver.model.actor.instance.L2ClanHallTeleporterInstance
    [javac] 		setInstanceType(InstanceType.L2ClanHallDoormenInstance);
    [javac] 		                ^
    [javac] C:\Users\Roberto 3\Documents\workspace\L2jServer GS\java\net\sf\l2j\gameserver\model\actor\instance\L2ClanHallTeleporterInstance.java:42: cannot find symbol
    [javac] symbol  : variable STATIC_PACKET
    [javac] location: class net.sf.l2j.gameserver.serverpackets.ActionFailed
    [javac] 		player.sendPacket(ActionFailed.STATIC_PACKET);
    [javac] 		                              ^
    [javac] C:\Users\Roberto 3\Documents\workspace\L2jServer GS\java\net\sf\l2j\gameserver\model\actor\instance\L2ClanHallTeleporterInstance.java:51: cannot find symbol
    [javac] symbol  : method getHtmlPrefix()
    [javac] location: class net.sf.l2j.gameserver.model.actor.instance.L2PcInstance
    [javac] 				html.setFile(player.getHtmlPrefix(), "data/html/clanHallDoormen/doormen-tele.htm");
    [javac] 				                   ^
    [javac] C:\Users\Roberto 3\Documents\workspace\L2jServer GS\java\net\sf\l2j\gameserver\model\actor\instance\L2ClanHallTeleporterInstance.java:58: cannot find symbol
    [javac] symbol  : method getHtmlPrefix()
    [javac] location: class net.sf.l2j.gameserver.model.actor.instance.L2PcInstance
    [javac] 					html.setFile(player.getHtmlPrefix(), "data/html/clanHallDoormen/doormen-no.htm");
    [javac] 					                   ^
    [javac] C:\Users\Roberto 3\Documents\workspace\L2jServer GS\java\net\sf\l2j\gameserver\model\actor\instance\L2ClanHallTeleporterInstance.java:64: cannot find symbol
    [javac] symbol  : method getHtmlPrefix()
    [javac] location: class net.sf.l2j.gameserver.model.actor.instance.L2PcInstance
    [javac] 					html.setFile(player.getHtmlPrefix(), "data/html/clanHallDoormen/emptyowner.htm");
    [javac] 					                   ^
    [javac] C:\Users\Roberto 3\Documents\workspace\L2jServer GS\java\net\sf\l2j\gameserver\model\actor\instance\L2ClanHallTeleporterInstance.java:79: cannot find symbol
    [javac] symbol  : method getSpawnLoc()
    [javac] location: class net.sf.l2j.gameserver.model.zone.type.L2ClanHallZone
    [javac] 		Location _loc = getClanHall().getZone().getSpawnLoc();
    [javac] 		                                       ^
    [javac] C:\Users\Roberto 3\Documents\workspace\L2jServer GS\java\net\sf\l2j\gameserver\model\actor\instance\L2ClanHallTeleporterInstance.java:76: method does not override or implement a method from a supertype
    [javac] 	@Override
    [javac] 	^
    [javac] C:\Users\Roberto 3\Documents\workspace\L2jServer GS\java\net\sf\l2j\gameserver\model\actor\instance\L2ClanHallTeleporterInstance.java:92: cannot find symbol
    [javac] symbol  : method getChaoticSpawnLoc()
    [javac] location: class net.sf.l2j.gameserver.model.zone.type.L2ClanHallZone
    [javac] 		Location _loc = getClanHall().getZone().getChaoticSpawnLoc();
    [javac] 		                                       ^
    [javac] C:\Users\Roberto 3\Documents\workspace\L2jServer GS\java\net\sf\l2j\gameserver\model\actor\instance\L2ClanHallTeleporterInstance.java:89: method does not override or implement a method from a supertype
    [javac] 	@Override
    [javac] 	^
    [javac] C:\Users\Roberto 3\Documents\workspace\L2jServer GS\java\net\sf\l2j\gameserver\model\actor\instance\L2ClanHallTeleporterInstance.java:107: getClanHall() in net.sf.l2j.gameserver.model.actor.instance.L2ClanHallTeleporterInstance cannot override getClanHall() in net.sf.l2j.gameserver.model.actor.instance.L2DoormenInstance; overridden method is final
    [javac] 	private final ClanHall getClanHall()
    [javac] 	                       ^
    [javac] C:\Users\Roberto 3\Documents\workspace\L2jServer GS\java\net\sf\l2j\gameserver\model\actor\instance\L2ClanHallTeleporterInstance.java:123: method does not override or implement a method from a supertype
    [javac] 	@Override
    [javac] 	^
    [javac] Note: C:\Users\Roberto 3\Documents\workspace\L2jServer GS\java\net\sf\l2j\gameserver\GeoEngine.java uses or overrides a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 11 errors

And here you have the file...

package net.sf.l2j.gameserver.model.actor.instance;

import net.sf.l2j.gameserver.datatables.ClanTable;
import net.sf.l2j.gameserver.datatables.MapRegionTable;
import net.sf.l2j.gameserver.instancemanager.ClanHallManager;
import net.sf.l2j.gameserver.model.L2Clan;
import net.sf.l2j.gameserver.model.Location;
import net.sf.l2j.gameserver.model.entity.ClanHall;
import net.sf.l2j.gameserver.serverpackets.ActionFailed;
import net.sf.l2j.gameserver.serverpackets.NpcHtmlMessage;
import net.sf.l2j.gameserver.templates.L2NpcTemplate;


public class L2ClanHallTeleporterInstance extends L2DoormenInstance
{
private boolean _init = false;
private ClanHall _clanHall = null;

public L2ClanHallTeleporterInstance(int objectID, L2NpcTemplate template)
{
	super(objectID, template);
	setInstanceType([color=red]InstanceType[/color].L2ClanHallDoormenInstance);
}

@Override
public void showChatWindow(L2PcInstance player)
{
	player.sendPacket([color=red]ActionFailed.STATIC_PACKET[/color]);

	NpcHtmlMessage html = new NpcHtmlMessage(getObjectId());

	if (getClanHall() != null)
	{
		L2Clan owner = ClanTable.getInstance().getClan(getClanHall().getOwnerId());
		if (isOwnerClan(player))
		{
			html.setFile(player.[color=red]getHtmlPrefix[/color](), "data/html/clanHallDoormen/doormen-tele.htm");
			html.replace("%clanname%", owner.getName());
		}
		else
		{
			if (owner != null && owner.getLeader() != null)
			{
				html.setFile(player.[color=red]getHtmlPrefix[/color](), "data/html/clanHallDoormen/doormen-no.htm");
				html.replace("%leadername%", owner.getLeaderName());
				html.replace("%clanname%", owner.getName());
			}
			else
			{
				html.setFile(player.[color=red]getHtmlPrefix[/color](), "data/html/clanHallDoormen/emptyowner.htm");
				html.replace("%hallname%", getClanHall().getName());
			}
		}
	}
	else
		return;

	html.replace("%objectId%", String.valueOf(getObjectId()));
	player.sendPacket(html);
}

@Override
protected final void [color=red]openDoors(L2PcInstance player, String command)[/color]
{
	Location _loc = getClanHall().getZone().[color=red]getSpawnLoc[/color]();

	if (_loc != null)
	{
		player.teleToLocation(_loc, false);
		if (player.getPet() != null)
			player.getPet().teleToLocation(_loc, false);
	}
}

@Override
protected final void [color=red]closeDoors(L2PcInstance player, String command)[/color]
{
	Location _loc = getClanHall().getZone().[color=red]getChaoticSpawnLoc[/color]();
	if (_loc != null)
	{
		player.teleToLocation(_loc, false);
		if (player.getPet() != null)
			player.getPet().teleToLocation(_loc, false);			
	}
	else
	{
		player.teleToLocation(MapRegionTable.TeleportWhereType.Town);
		if (player.getPet() != null)
			player.getPet().teleToLocation(MapRegionTable.TeleportWhereType.Town);
	}
}

private final ClanHall [color=red]getClanHall[/color]()
{
	if (!_init)
	{
	synchronized (this)
		{
			if (!_init)
			{
				_clanHall = ClanHallManager.getInstance().getNearbyClanHall(getX(), getY(), 500);
				_init = true;
			}
		}
	}
	return _clanHall;
}

@Override
protected final boolean [color=red]isOwnerClan(L2PcInstance player)[/color]
{
	if (player.getClan() != null && getClanHall() != null)
	{
		if (player.getClanId() == getClanHall().getOwnerId())
			return true;
	}
	return false;
}
}

i don't know how to fix it... Please help :(

Tryskell · June 24, 2011

2 errors are related to a zoneManager rework.

2 others errors are related to L2Npc rework (implementing main methods).

1 need actionFailed rework.

------

Just use one existing IL pack. You can correct only 4 errors from pure syntax. Others need partial or full rework.

largirucho · June 24, 2011

But all the projects of IL SUCKS! the only serverfiles good (But old) are L2jSERVER...

How can i fix it? i must rewrite all the code?

Tryskell · June 24, 2011

But all the projects of IL SUCKS! the only serverfiles good (But old) are L2jSERVER...

How can i fix it? i must rewrite all the code?

Ty for my own pack ;D.

I gave you the answer, and I don't think others will reply about it. What you try to do is basically to create another pack. Your errors are simple, and you didn't manage to compare files. Here are what you can correct :

html.setFile(player.getHtmlPrefix(), "data/html/clanHallDoormen/emptyowner.htm");

must be

html.setFile("data/html/clanHallDoormen/emptyowner.htm");

(drop of "player.getHtmlPrefix(), ")

setInstanceType(InstanceType.L2ClanHallDoormenInstance);

delete the line there is no comparing stuff on IL.

ActionFailed.STATIC_PACKET

Rework of the ActionFailed packet, 3 min being clever.

http://trac.assembla.com/acis_project/changeset/18

Others changes need partial or full rework, as I already said.

If you think ALL IL packs are crappy, I can't do nothing for you :D.

Tk.

largirucho · June 24, 2011

Ty for my own pack ;D.

I gave you the answer, and I don't think others will reply about it. What you try to do is basically to create another pack. Your errors are simple, and you didn't manage to compare files. Here are what you can correct :
html.setFile(player.getHtmlPrefix(), "data/html/clanHallDoormen/emptyowner.htm");
must be
html.setFile("data/html/clanHallDoormen/emptyowner.htm");
(drop of "player.getHtmlPrefix(), ")
setInstanceType(InstanceType.L2ClanHallDoormenInstance);
delete the line there is no comparing stuff on IL.
ActionFailed.STATIC_PACKET
Rework of the ActionFailed packet, 3 min being clever.

http://trac.assembla.com/acis_project/changeset/18

Others changes need partial or full rework, as I already said.

If you think ALL IL packs are crappy, I can't do nothing for you :D.

Tk.

But all the packets i probe (like l2jfrozen) are bad... the olys doesn't work properly and something more like enchant skills...

If you have 1 that work properly and have bad issues with something that players can't see (like trades, or another topics) send me a pm.

Sorry if i insult your serverfiles I did not mean what I meant

Tryskell · June 24, 2011

Each pack got his own errors, support one or other project instead of making your own stuff in your side. There are more than 1 project, and if you count russian projects, it goes high.

My pack is named "another Crappy interlude server", so about the insulting part, I won't cry if you say it sux.

I think my previous answers say all, so, gl.

PS : you got the will, but not the knowledge. I invite you to check more little codes and go crescendo instead of doing the reverse. Cause atm, you're not able to fix anything.

PS2 : Compiling fine doesn't mean it's not entirely bugged ingame.

largirucho · June 24, 2011

Each pack got his own errors, support one or other project instead of making your own stuff in your side. There are more than 1 project, and if you count russian projects, it goes high.

My pack is named "another Crappy interlude server", so about the insulting part, I won't cry if you say it sux.

I think my previous answers say all, so, gl.

PS : you got the will, but not the knowledge. I invite you to check more little codes and go crescendo instead of doing the reverse. Cause atm, you're not able to fix anything.

PS2 : Compiling fine doesn't mean it's not entirely bugged ingame.

i know i will test your pack, and it's full security?

Tryskell · June 25, 2011

i know i will test your pack, and it's full security?

I didn't bother with security, "before to correct the outside, you correct the inside". Feel free to test and report.

[Help] Customs Halls

Question

largirucho

7 answers to this question

Recommended Posts

Tryskell

largirucho

Tryskell

largirucho

Tryskell

largirucho

Tryskell

Join the conversation

Posts

Topics

Browse

Activity

Store