- 0
[Help]Quest Script Edit
-
Posts
-
in conclusion when somebody who has a project for 10+ years still on development writes an e-say to try until you succeed and then advertises his project, one of the reasons is he needs money, so l2j has once more become pure expensive hobby, you wont make money out of it. You can still use L2jFrozen and get better results for this, i know some people that done it keep in mind that C in aCis stands for Crappy, and after all these years its not a cool wordplay anymore, its a fact, prove me wrong.
-
First, don't really follow the "main voice", moreover if you consider it an hobby. Simply do what you want, you got only one life so use it as you want. If you make it an hobby, it's exactly like piano, or velo - only practice makes you better. Secondly, how do you learn things ? It's actually a really important question, since some can simply be scholar, read books (theory) then practice ; and some simply can't read books. I'm the second type, I hated school, I find it boring - my knowledge in Java comes from try-and-fail. You improve your coding style every year or so, I can myself rewrite my own code (which I already considered top-notched) after a while. You always learn something new - even if Java barely evolves. L2J is a fun way to learn programming, it's a giant sandbox where you can edit anything, and I believe it should be taken as it. My own way of learning was as follow : Add existing customs, no matter what they are : the point is to know main classes used by L2J / customs. L2J is barely Java knowledge ; the true knowledge is to know WHAT to search in WHICH location (what I call, organization). You have to understand than EVERYTHING you think already exists, in a form on another, in the source code. A custom is only the association of the different mechanisms you found "here and there", glued together in a proper goal. Once you know main classes to edit, and the customs you added are compiling fine, the main point is to know WHAT exactly you DID. Try to understand WHY and WHERE you actually copied the code. Third point would be to MANIPULATE the customs you added in order to fit your wish. First edit little values, then logic conditions ; eventually add a new Config, or a new functionality to the custom. Fourth point would be to begin to craft your own ideas. Once again, EVERYTHING already exists, in a form or another. You want a cycled event ? You got Seven Signs main task as exemple. Npc ? Search any type of Npc and figure out what it does. Fifth point would be to understand Java - mostly containers (WHAT and WHERE to use them), variables types and main Java mechanisms (inheritance, static modifier, etc). You should also begin to cut your code into maintainable classes or methods. Java can actually run without optimization, but bigger your ideas, more optimized and well-thought it should be. It's direct saved time in the future, and you would thank yourself doing so. Main tips : ALWAYS use any type of versioning system - GIT or SVN. It allows to save your work, step by step and eventually revert back anytime you want if you terribly messed up. L2J is 80% organization knowledge, and 20% Java knowledge. Basically, if you know WHAT and WHERE to search, if you aren't dumb, it's easy to replicate and re-use things. Cherry on top is to use a already good coded pack to avoid copy-paste crap and get bad habits. Avoid any type of russian or brazilian packs, for exemple - their best ability is to leak someone's else code. Obviously you need some default sense of logic, but Java and programming in general help you to improve it. Finally, most of your questions could be solved joining related Discord (at least for aCis, I can't speak for others) - from the moment your question was correctly asked (and you seemed to search for the answer). My community (and myself) welcomes newbies, but got some issues with noobies. The simpliest is to try, fail and repeat until you succeed - it sounds stupid, but that's basically how life works. PS : about Java ressources, before ChatGPT, it was mostly about stackoverflow website, and site like Baeldung's one. With ChatGPT and alike, you generally double-cross AI output to avoid fucked up answers. Also, care about AI, they are often hallucinating really hard, even today. They can give you complete wrong answer, you tell them they are wrong, and they say "indeed, I suck, sorry - here's a new fucked up answer". You shouldn't 100% rely over AI answer, even if that can give sometimes legit answers, full code or just skeletons of ideas. PPS : I don't think there are reliable ressources regarding L2J itself, also most of the proposed code decays pretty fast if the source code is actually maintained (at least for aCis). Still, old coded customs for old aCis sources are actually a good beginner challenge to apply on latest source.
-
Topics

Question
Bobi
Hello this is original quest for clan rep point .
So problem is if you get 2 quest items in your inventory npc dont accept quest items
If you have 1 quest items NPC accept that and u get reward
So how to make if u have 2-3-4-5-6 quest items in your inventory npc to accept all and you will get reward for all
For example if 1 quest item resard is 200 rep point when u give 6 quest items to get 1200 rep point
##################################################################### # # # "The Clan's Reputation" # # "Raise the Clan's Reputation" # # "Sir Eric Rodemai in Aden Castle Town is looking # # for a brave adventurer to raise the clan's reputation." # # "Clan Leader, Clan Level 5 and above" # # # # Start NPC: Sir Eric Rodemai[30868] # # # # fixed and completed by chris_00 @katmai and DrLecter # # # ##################################################################### import sys from com.it.br.gameserver.model.quest import State from com.it.br.gameserver.model.quest import QuestState from com.it.br.gameserver.model.quest.jython import QuestJython as JQuest from com.it.br.gameserver.serverpackets import PledgeShowInfoUpdate from com.it.br.gameserver.serverpackets import RadarControl from com.it.br.gameserver.serverpackets import SystemMessage qn="508_TheClansReputation" qd="The Clans Reputation" # Quest NPC SIR_ERIC_RODEMAI = 30868 # Quest Items NUCLEUS_OF_FLAMESTONE_GIANT = 8494 # Nucleus of Flamestone Giant : Nucleus obtained by defeating Flamestone Giant THEMIS_SCALE = 8277 # Themis' Scale : Obtain this scale by defeating Palibati Queen Themis. NUCLEUS_OF_HEKATON_PRIME = 8279 # Nucleus of Hekaton Prime : Nucleus obtained by defeating Hekaton Prime TIPHON_SHARD = 8280 # Tiphon Shard : Debris obtained by defeating Tiphon, Gargoyle Lord. GLAKIS_NUCLEUS = 8281 # Glaki's Necleus : Nucleus obtained by defeating Glaki, the last lesser Giant. RAHHAS_FANG = 8282 # Rahha's Fang : Fangs obtained by defeating Rahha. #Quest Raid Bosses FLAMESTONE_GIANT = 25524 PALIBATI_QUEEN_THEMIS = 25252 HEKATON_PRIME = 25140 GARGOYLE_LORD_TIPHON = 25255 LAST_LESSER_GIANT_GLAKI = 25245 RAHHA = 25051 # Reward CLAN_POINTS_REWARD = 1000 # 1000 Point Per Boss # id:[RaidBossNpcId,questItemId] REWARDS_LIST={ 1:[PALIBATI_QUEEN_THEMIS, THEMIS_SCALE], 2:[HEKATON_PRIME, NUCLEUS_OF_HEKATON_PRIME], 3:[GARGOYLE_LORD_TIPHON, TIPHON_SHARD], 4:[LAST_LESSER_GIANT_GLAKI,GLAKIS_NUCLEUS], 5:[RAHHA, RAHHAS_FANG], 6:[FLAMESTONE_GIANT, NUCLEUS_OF_FLAMESTONE_GIANT] } RADAR={ 1:[192346,21528,-3648], 2:[191979,54902,-7658], 3:[170038,-26236,-3824], 4:[171762,55028,-5992], 5:[117232,-9476,-3320], 6:[144218,-5816,-4722], } class Quest (JQuest) : def __init__(self,id,name,descr) : JQuest.__init__(self,id,name,descr) def onAdvEvent (self,event,npc,player) : st = player.getQuestState(qn) if not st: return cond = st.getInt("cond") htmltext=event if event == "30868-0.htm" : if cond == 0 : st.set("cond","1") st.setState(STARTED) elif event.isdigit() : if int(event) in REWARDS_LIST.keys(): st.set("raid",event) htmltext="30868-"+event+".htm" x,y,z=RADAR[int(event)] if x+y+z: player.sendPacket(RadarControl(2, 2, x, y, z)) player.sendPacket(RadarControl(0, 1, x, y, z)) st.playSound("ItemSound.quest_accept") elif event == "30868-7.htm" : st.playSound("ItemSound.quest_finish") st.exitQuest(1) return htmltext def onTalk (self,npc,player) : htmltext = "<html><body>You are either not carrying out your quest or don't meet the criteria.</body></html>" st = player.getQuestState(qn) if not st : return htmltext clan = player.getClan() npcId = npc.getNpcId() if player.getClan() == None or player.isClanLeader() == 0 : st.exitQuest(1) htmltext = "30868-0a.htm" elif player.getClan().getLevel() < 5 : st.exitQuest(1) htmltext = "30868-0b.htm" else : cond = st.getInt("cond") raid = st.getInt("raid") id = st.getState() if id == CREATED and cond == 0 : htmltext = "30868-0c.htm" elif id == STARTED and cond == 1 and raid in REWARDS_LIST.keys() : npc,item=REWARDS_LIST[raid] count = st.getQuestItemsCount(item) if not count : htmltext = "30868-"+str(raid)+"a.htm" elif count == 1 : htmltext = "30868-"+str(raid)+"b.htm" st.takeItems(item,1) clan.setReputationScore(clan.getReputationScore()+CLAN_POINTS_REWARD,True) player.sendPacket(SystemMessage(1777).addNumber(CLAN_POINTS_REWARD)) clan.broadcastToOnlineMembers(PledgeShowInfoUpdate(clan)) return htmltext def onKill(self,npc,player,isPet) : st = 0 if player.isClanLeader() : st = player.getQuestState(qn) else: clan = player.getClan() if clan: leader=clan.getLeader() if leader : pleader= leader.getPlayerInstance() if pleader : if player.isInsideRadius(pleader, 1600, 1, 0) : st = pleader.getQuestState(qn) if not st : return option=st.getInt("raid") if st.getInt("cond") == 1 and st.getState() == STARTED and option in REWARDS_LIST.keys(): raid,item = REWARDS_LIST[option] npcId=npc.getNpcId() if npcId == raid and not st.getQuestItemsCount(item) : st.giveItems(item,1) st.playSound("ItemSound.quest_middle") return # Quest class and state definition QUEST = Quest(508,qn,qd) CREATED = State('Start',QUEST) STARTED = State('Started',QUEST) QUEST.setInitialState(CREATED) QUEST.addStartNpc(SIR_ERIC_RODEMAI) QUEST.addTalkId(SIR_ERIC_RODEMAI) for npc,item in REWARDS_LIST.values(): QUEST.addKillId(npc) STARTED.addQuestDrop(npc,item,1)3 answers to this question
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now