Jump to content

[Share]Little pvp/pk color engine


B1ggBoss

Recommended Posts

nop, theres an unclosed connecton in my code. go to ColorNameManager.loadValues and at the botton of the method add

try{ if(con != null) con.close(); } catch(Exception e){ if(Config.DEBUG) e.printStackTrace(); }

 

where exactly i must add this? cause i am a little stupid in java

Link to comment
Share on other sites

where exactly i must add this? cause i am a little stupid in java

 

go to ColorNameManager.java

find the method called public static void loadValues()

at the end of the method (before the last " } " ), add the

code i posted

Link to comment
Share on other sites

symbol  : variable Config
location: class com.l2jserver.gameserver.model.actor.appearance.ColorNameManager
try{ if(con != null) con.close(); } catch(Exception e){ if(Config.DEBUG) e.printStackTrace(); }
		                                           ^

 

this is the error i see now when i try to add the code that you told me in the end of the method

Link to comment
Share on other sites

  • 2 months later...

System.out.println("ColorNameManager: Loaded " + _pvpColor.size() + " colors for pvp kills!");

System.out.println("ColorNameManager: Loaded " + _pkColor.size() + " colors for pk kills!");

 

try

   {

if(con != null) con.close();

}

catch(Exception e)

   {  

}

}

 

This is my code after this fix but still i have unclosed connection when i relog a char with pvp/pk color.Can u help me BB ?

 

Ah forgot to ask u say in ur last post "public static void loadValues()" but in the script is "public void loadValues()" is that a problem?

Link to comment
Share on other sites

  • 2 weeks later...

I try to use it but as i see from posts i have some of the problems.1st how can i remove primary key and second pls write the fix us a code here pls cause i dodn't understans what you try to tell :/ (i don't understand verygood english so i'm a little stupid :P)

Link to comment
Share on other sites

  • 4 weeks later...

B1ggBoss Here you can put the diff with the changes already made?

 

(Puedes postear aqui el diff con los cambios ya echos?

B1ggBoss eres un monstruo y perdon por eres XDDD. Gracias un autentico genio!)

Link to comment
Share on other sites

look for com.l2jserver.gameserver.model.actor.appearance.ColorNameManager.java

 

and replace it for:

/*
* This program is free software: you can redistribute it and/or modify it under
* the terms of the GNU General Public License as published by the Free Software
* Foundation, either version 3 of the License, or (at your option) any later
* version.
*
* This program is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
* FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
* details.
*
* You should have received a copy of the GNU General Public License along with
* this program. If not, see <http://www.gnu.org/licenses/>.
*/
package com.l2jserver.gameserver.model.actor.appearance;

import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.Set;

import com.l2jserver.L2DatabaseFactory;

import javolution.util.FastMap;

/**
* @author BiggBoss
*/
public class ColorNameManager
{
   private static FastMap<Integer, String> _pvpColor = new FastMap<Integer, String>();
   private static FastMap<Integer, String> _pkColor = new FastMap<Integer, String>();
   
   private ColorNameManager()
   {
   }
   
   public static ColorNameManager getInstance()
   {
      return SingletonHolder._cne;
   }
   
   /**
    * Will load all pvp count with their respective color at server start up
    * Also will set up the higher pvp/pk count rank for future purposes
    */
   public void loadValues()
   {
      Connection con = null;
      try
      {
         _pvpColor.put(0, "FFFFFF");
         _pkColor.put(0, "FFFFFF");
         con = L2DatabaseFactory.getInstance().getConnection();
         PreparedStatement pvpStatement = con.prepareStatement("SELECT * FROM pvp_color_nick WHERE type = ?");
         pvpStatement.setString(1, "pvp");
         
         ResultSet pvpRset = pvpStatement.executeQuery();
         while(pvpRset.next())
         {
            _pvpColor.put(pvpRset.getInt("pvppk_count"), pvpRset.getString("color"));
         }
         pvpRset.close();
         pvpStatement.close();
         
         PreparedStatement pkStatement = con.prepareStatement("SELECT * FROM pvp_color_nick WHERE type = ?");
         pkStatement.setString(1, "pk");
         
         ResultSet pkRset = pkStatement.executeQuery();
         while(pkRset.next())
         {
            _pkColor.put(pkRset.getInt("pvppk_count"), pkRset.getString("color"));
         }
         pkRset.close();
         pkStatement.close();
      }
      catch(SQLException sqle)
      {
         sqle.printStackTrace();
      }
      finally
      {
         try
         {
            if(con != null)
               con.close();
         }
         catch(Exception e)
         {
            e.printStackTrace();
         }
      }
      System.out.println("ColorNameManager: Loaded " + _pvpColor.size() + " colors for pvp kills!");
      System.out.println("ColorNameManager: Loaded " + _pkColor.size() + " colors for pk kills!");
   }
   
   /**
    * Returns a string-representative with the color of the rank
    * @param kills
    * @param forPvp
    * @return a String containing the Hexadecimal color
    */
   public String getColor(int kills, boolean forPvp)
   {
      String color = "";
      if(forPvp)
         color = _pvpColor.get(getValueBefore(kills, _pvpColor.keySet()));
      else
         color = _pkColor.get(getValueBefore(kills, _pkColor.keySet()));
      
      return color;
   }
   
   /**
    * Will return the value just before the given value contained
    * in the provided Set of integers
    * @param value
    * @param set
    * @return the value just before the provided one
    */
   private static int getValueBefore(int value, Set<Integer> set)
   {
      int counter = 0;
      for(int i : set)
      {
         if(i > counter && value > i)
            counter = i;
      }
      return counter;
   }
         
   static class SingletonHolder
   {
      static ColorNameManager _cne = new ColorNameManager();
   }
}

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.




×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock