Jump to content
MaxCheaters Official Group on X
MaxCheaters Official Group on Discord
--> Place your ad text here <--
  • 0

Java / enchant8_skill + enchant12_skill

killer666

Asked by killer666,

 Share

Question

killer666 Rookie

killer666

Posted
Posted

Seems easy enough, but last days after many tests, i failed hard multiple times, so i have to ask for help.

Pretty sure some fella can give me the solution here. xml / item / skill all done correctly. Also by compiling there is no error. 

  

#Weapon.java	
  
	private IntIntHolder _enchant4Skill;
+	private IntIntHolder _enchant8Skill;
+	private IntIntHolder _enchant12Skill;

		
		if (set.containsKey("enchant4_skill"))
			_enchant4Skill = set.getIntIntHolder("enchant4_skill");
+	
+		if (set.containsKey("enchant8_skill"))
+			_enchant8Skill = set.getIntIntHolder("enchant8_skill");
+
+		if (set.containsKey("enchant12_skill"))
+			_enchant12Skill = set.getIntIntHolder("enchant12_skill");
+
  
  	public L2Skill getEnchant4Skill()
	{
		return (_enchant4Skill == null) ? null : _enchant4Skill.getSkill();
	}
+	
+	public L2Skill getEnchant8Skill()
+	{
+		return (_enchant8Skill == null) ? null : _enchant8Skill.getSkill();
+	}
+	
+	public L2Skill getEnchant12Skill()
+	{
+		return (_enchant12Skill == null) ? null : _enchant12Skill.getSkill();
+	}
+	
  
  ------------------------------------------------------
  #RequestEnchantItem.java
  
  					if (it instanceof Weapon && item.getEnchantLevel() == 4)
					{
						final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
						if (enchant4Skill != null)
						{
							player.addSkill(enchant4Skill, false);
							player.sendSkillList();
						}
					}
+					else if (it instanceof Weapon && item.getEnchantLevel() == 8)
+					{
+						final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+						if (enchant8Skill != null)
+						{
+							player.addSkill(enchant8Skill, false);
+							player.sendSkillList();
+						}
+					}
+					else if (it instanceof Weapon && item.getEnchantLevel() == 12)
+					{
+						final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+						if (enchant12Skill != null)
+						{
+							player.addSkill(enchant12Skill, false);
+							player.sendSkillList();
+						}
+					}
+

  
  					if (it instanceof Weapon && item.getEnchantLevel() >= 4)
					{
						final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
						if (enchant4Skill != null)
						{
							player.removeSkill(enchant4Skill.getId(), false);
							player.sendSkillList();
						}
					}
+					else if (it instanceof Weapon && item.getEnchantLevel() >= 8)
+					{
+						final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+						if (enchant8Skill != null)
+						{
+							player.removeSkill(enchant8Skill.getId(), false);
+							player.sendSkillList();
+						}
+					}
+					else if (it instanceof Weapon && item.getEnchantLevel() >= 12)
+					{
+						final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+						if (enchant12Skill != null)
+						{
+							player.removeSkill(enchant12Skill.getId(), false);
+							player.sendSkillList();
+						}
+					}
+

  ------------------------------------------------
  
  #ItemPassiveSkillsListener.java
  
  
  			if (item.getEnchantLevel() >= 4)
			{
				final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
				if (enchant4Skill != null)
				{
					player.addSkill(enchant4Skill, false);
					update = true;
				}
			}
+			
+			else if (item.getEnchantLevel() >= 8)
+			{
+				final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+				if (enchant8Skill != null)
+				{
+					player.addSkill(enchant8Skill, false);
+					update = true;
+				}
+			}
+
+			else if (item.getEnchantLevel() >= 12)
+			{
+				final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+				if (enchant12Skill != null)
+				{
+					player.addSkill(enchant12Skill, false);
+					update = true;
+				}
+			}
+
  
  			if (item.getEnchantLevel() >= 4)
			{
				final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
				if (enchant4Skill != null)
				{
					player.removeSkill(enchant4Skill.getId(), false, enchant4Skill.isPassive() || enchant4Skill.isToggle());
					update = true;
				}
			}
+			
+			else if (item.getEnchantLevel() >= 8)
+			{
+				final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+				if (enchant8Skill != null)
+				{
+					player.removeSkill(enchant8Skill.getId(), false, enchant8Skill.isPassive() || enchant8Skill.isToggle());
+					update = true;
+				}
+			}
+			
+			else if (item.getEnchantLevel() >= 12)
+			{
+				final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+				if (enchant12Skill != null)
+				{
+					player.removeSkill(enchant12Skill.getId(), false, enchant12Skill.isPassive() || enchant12Skill.isToggle());
+					update = true;
+				}
+			}

 

4 answers to this question

Recommended Posts

  • 0
ratchet Enthusiast

ratchet

Posted
Posted

Hello,  to be honest with you, your question is a bit unclear, at least to me.

Are you trying to give special skills to players based upon their weapon enchant level?

 

Also there are parts of the code that are wrong, for example you do: 

if (item.getEnchantLevel() >= 4)

and then immediately after 

else if (item.getEnchantLevel() >= 8)

This last block will never be evaluated since the previous one will be true, and so on.

From the snippets you posted I can't figure out, maybe try to post the whole files somewhere 😄

  • 0
Salty Mike Community Regular

Salty Mike

Posted
Posted
On 7/11/2024 at 10:15 AM, killer666 said:

Seems easy enough, but last days after many tests, i failed hard multiple times, so i have to ask for help.

Pretty sure some fella can give me the solution here. xml / item / skill all done correctly. Also by compiling there is no error. 

  

#Weapon.java	
  
	private IntIntHolder _enchant4Skill;
+	private IntIntHolder _enchant8Skill;
+	private IntIntHolder _enchant12Skill;

		
		if (set.containsKey("enchant4_skill"))
			_enchant4Skill = set.getIntIntHolder("enchant4_skill");
+	
+		if (set.containsKey("enchant8_skill"))
+			_enchant8Skill = set.getIntIntHolder("enchant8_skill");
+
+		if (set.containsKey("enchant12_skill"))
+			_enchant12Skill = set.getIntIntHolder("enchant12_skill");
+
  
  	public L2Skill getEnchant4Skill()
	{
		return (_enchant4Skill == null) ? null : _enchant4Skill.getSkill();
	}
+	
+	public L2Skill getEnchant8Skill()
+	{
+		return (_enchant8Skill == null) ? null : _enchant8Skill.getSkill();
+	}
+	
+	public L2Skill getEnchant12Skill()
+	{
+		return (_enchant12Skill == null) ? null : _enchant12Skill.getSkill();
+	}
+	
  
  ------------------------------------------------------
  #RequestEnchantItem.java
  
  					if (it instanceof Weapon && item.getEnchantLevel() == 4)
					{
						final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
						if (enchant4Skill != null)
						{
							player.addSkill(enchant4Skill, false);
							player.sendSkillList();
						}
					}
+					else if (it instanceof Weapon && item.getEnchantLevel() == 8)
+					{
+						final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+						if (enchant8Skill != null)
+						{
+							player.addSkill(enchant8Skill, false);
+							player.sendSkillList();
+						}
+					}
+					else if (it instanceof Weapon && item.getEnchantLevel() == 12)
+					{
+						final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+						if (enchant12Skill != null)
+						{
+							player.addSkill(enchant12Skill, false);
+							player.sendSkillList();
+						}
+					}
+

  
  					if (it instanceof Weapon && item.getEnchantLevel() >= 4)
					{
						final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
						if (enchant4Skill != null)
						{
							player.removeSkill(enchant4Skill.getId(), false);
							player.sendSkillList();
						}
					}
+					else if (it instanceof Weapon && item.getEnchantLevel() >= 8)
+					{
+						final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+						if (enchant8Skill != null)
+						{
+							player.removeSkill(enchant8Skill.getId(), false);
+							player.sendSkillList();
+						}
+					}
+					else if (it instanceof Weapon && item.getEnchantLevel() >= 12)
+					{
+						final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+						if (enchant12Skill != null)
+						{
+							player.removeSkill(enchant12Skill.getId(), false);
+							player.sendSkillList();
+						}
+					}
+

  ------------------------------------------------
  
  #ItemPassiveSkillsListener.java
  
  
  			if (item.getEnchantLevel() >= 4)
			{
				final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
				if (enchant4Skill != null)
				{
					player.addSkill(enchant4Skill, false);
					update = true;
				}
			}
+			
+			else if (item.getEnchantLevel() >= 8)
+			{
+				final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+				if (enchant8Skill != null)
+				{
+					player.addSkill(enchant8Skill, false);
+					update = true;
+				}
+			}
+
+			else if (item.getEnchantLevel() >= 12)
+			{
+				final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+				if (enchant12Skill != null)
+				{
+					player.addSkill(enchant12Skill, false);
+					update = true;
+				}
+			}
+
  
  			if (item.getEnchantLevel() >= 4)
			{
				final L2Skill enchant4Skill = ((Weapon) it).getEnchant4Skill();
				if (enchant4Skill != null)
				{
					player.removeSkill(enchant4Skill.getId(), false, enchant4Skill.isPassive() || enchant4Skill.isToggle());
					update = true;
				}
			}
+			
+			else if (item.getEnchantLevel() >= 8)
+			{
+				final L2Skill enchant8Skill = ((Weapon) it).getEnchant8Skill();
+				if (enchant8Skill != null)
+				{
+					player.removeSkill(enchant8Skill.getId(), false, enchant8Skill.isPassive() || enchant8Skill.isToggle());
+					update = true;
+				}
+			}
+			
+			else if (item.getEnchantLevel() >= 12)
+			{
+				final L2Skill enchant12Skill = ((Weapon) it).getEnchant12Skill();
+				if (enchant12Skill != null)
+				{
+					player.removeSkill(enchant12Skill.getId(), false, enchant12Skill.isPassive() || enchant12Skill.isToggle());
+					update = true;
+				}
+			}

 


The solution is what the guy before me said. You need to either place the higher value before the smaller value or limit the range.

Ex. 1: 
  

if (item.getEnchantLevel() >= 12)
{
     // do whatever
}
else if (item.getEnchantLevel() >= 8)
{
     // do whatever
}
else if (item.getEnchantLevel() >= 4)
{
     // do whatever
}


Ex. 2:
  

if (item.getEnchantLevel() >= 4 && item.getEnchantLevel() <= 7)
{
     // do whatever
}
else if (item.getEnchantLevel() >= 8 && item.getEnchantLevel() <= 11)
{
     // do whatever
}
else if (item.getEnchantLevel() >= 12)
{
     // do whatever
}

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to question listing


×
×
  • Create New...