Jump to content
  • 0

Raking pvp/pk in Community Board custom /mobius c6 ct0


Question

Posted

 


Hello everyone,

I hope you're all having a good afternoon. I wanted to ask for your help with an issue I've been having while trying to create a community board for the Interlude chronicle using the L2JMobius CT 0 Interlude datapack. My goal is to make a top PvP and PK ranking and implement it into the custom community board that comes with this datapack.

I've adapted some code that works with the Interlude datapack from L2JMobius which I found in this link: Link. The creator of this code is "StinkyMadness".

Continuing on, I've created the RankingsBoard class and added it into the MasterHandlers, but the client throws a critical error. No errors are shown in the game server.

One idea that occurred to me is to implement this method in HomeBoard.java, but it also encounters the same error in the client. Since there are no errors shown in the game server, I'm having trouble finding a solution.

I would greatly appreciate any help or suggestions you can offer. Thank you in advance!

 

Here class RankingsBoard

 * This file is part of the L2J Mobius project.
 * 
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 * 
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
 * General Public License for more details.
 * 
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */
package handlers.communityboard;

import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.util.stream.IntStream;

import org.l2jmobius.commons.database.DatabaseFactory;
import org.l2jmobius.commons.util.StringUtil;
import org.l2jmobius.gameserver.cache.HtmCache;
import org.l2jmobius.gameserver.handler.CommunityBoardHandler;
import org.l2jmobius.gameserver.handler.IParseBoardHandler;
import org.l2jmobius.gameserver.model.World;
import org.l2jmobius.gameserver.model.actor.Player;

/**
 
 */
public class RankingsBoard implements IParseBoardHandler
{
	private static final StringBuilder PVP = new StringBuilder();
	private static final StringBuilder PKS = new StringBuilder();
	
	private static final int PAGE_LIMIT_15 = 15;
	
	private long _nextUpdate;
	
	public RankingsBoard()
	{
		
	}
	
	private static final String[] COMMANDS =
	{
		"_bbsranking",
	
	};
	
	@Override
	public boolean parseCommunityBoardCommand(String command, Player player)
	{
		try
		{
			if (command.equals("_bbsranking"))
			{
				showRakingList(player);
				return true;
			}
			
		}
		catch (Exception exc)
		{
			System.out.println(exc);
		}
		return false;
	}
	
	public void showRakingList(Player player)
	{
		if (_nextUpdate < System.currentTimeMillis())
		{
			PVP.setLength(0);
			PKS.setLength(0);
			
			try (Connection con = DatabaseFactory.getConnection();)
			{
				try (PreparedStatement ps = con.prepareStatement("SELECT char_name, pvpkills FROM characters WHERE pvpkills > 0 ORDER BY pvpkills DESC LIMIT " + PAGE_LIMIT_15);
					ResultSet rs = ps.executeQuery())
				{
					int index = 1;
					while (rs.next())
					{
						final String name = rs.getString("char_name");
						final Player databasePlayer = World.getInstance().getPlayer(name);
						final String status = "L2UI_CH3.msnicon" + ((databasePlayer != null) && databasePlayer.isOnline() ? "1" : "4");
						
						StringUtil.append(PVP, "<table width=300 bgcolor=000000><tr><td width=20 align=right>", getColor(index), String.format("%02d", index), "</td>");
						StringUtil.append(PVP, "<td width=20 height=18><img src=", status, " width=16 height=16></td><td width=160 align=left>", name, "</td>");
						StringUtil.append(PVP, "<td width=100 align=right>", StringUtil.formatNumber(rs.getInt("pvpkills")), "</font></td></tr></table><img src=L2UI.SquareGray width=296 height=1>");
						index++;
					}
					IntStream.range(index - 1, PAGE_LIMIT_15).forEach(x -> applyEmpty(PVP));
				}
				
				try (PreparedStatement ps = con.prepareStatement("SELECT char_name, pkkills FROM characters WHERE pkkills > 0 ORDER BY pkkills DESC LIMIT " + PAGE_LIMIT_15);
					ResultSet rs = ps.executeQuery())
				{
					int index = 1;
					while (rs.next())
					{
						final String name = rs.getString("char_name");
						final Player databasePlayer = World.getInstance().getPlayer(name);
						final String status = "L2UI_CH3.msnicon" + ((databasePlayer != null) && databasePlayer.isOnline() ? "1" : "4");
						
						StringUtil.append(PKS, "<table width=300 bgcolor=000000><tr><td width=20 align=right>", getColor(index), String.format("%02d", index), "</td>");
						StringUtil.append(PKS, "<td width=20 height=18><img src=", status, " width=16 height=16></td><td width=160 align=left>", name, "</td>");
						StringUtil.append(PKS, "<td width=100 align=right>", StringUtil.formatNumber(rs.getInt("pkkills")), "</font></td></tr></table><img src=L2UI.SquareGray width=296 height=1>");
						index++;
					}
					IntStream.range(index - 1, PAGE_LIMIT_15).forEach(x -> applyEmpty(PKS));
				}
			}
			catch (Exception e)
			{
			}
			
			_nextUpdate = System.currentTimeMillis() + 60000L;
		}
		String content = HtmCache.getInstance().getHtm(player, "data/html/CommunityBoard/Custom/ranking/rankinglist.html");
		
		if (content != null)
		{
			content = content.replaceAll("%name%", player.getName());
			content = content.replaceAll("%pvp%", PVP.toString());
			content = content.replaceAll("%pks%", PKS.toString());
			content = content.replaceAll("%time%", String.valueOf((_nextUpdate - System.currentTimeMillis()) / 1000));
			CommunityBoardHandler.separateAndSend(content, player);
			
		}
		else
		{
			
		}
	}
	
	public String getColor(int index)
	{
		switch (index)
		{
			case 1:
				return "<font color=FFFF00>";
			case 2:
				return "<font color=FFA500>";
			case 3:
				return "<font color=E9967A>";
		}
		return "";
	}
	
	@Override
	public String[] getCommunityBoardCommands()
	{
		return COMMANDS;
	}
	
	public void applyEmpty(StringBuilder sb)
	{
		sb.append("<table width=300 bgcolor=000000><tr>");
		sb.append("<td width=20 align=right><font color=B09878>--</font></td><td width=20 height=18></td>");
		sb.append("<td width=160 align=left><font color=B09878>----------------</font></td>");
		sb.append("<td width=100 align=right><font color=FF0000>0</font></td>");
		sb.append("</tr></table><img src=L2UI.SquareGray width=296 height=1>");
	}
	
	public static RankingsBoard getInstance()
	{
		return SingletonHolder.INSTANCE;
	}
	
	private static class SingletonHolder
	{
		protected static final RankingsBoard INSTANCE = new RankingsBoard();
	}
	
}

 

 

 

Here the method implemented in the HomeBoard.java class in an else if, I do not put the entire class because it is very large and I think it is unnecessary, but the constants it uses

	constanst
	private static final StringBuilder PVP = new StringBuilder();
	private static final StringBuilder PKS = new StringBuilder();
	
	private static final int PAGE_LIMIT_15 = 15;
	
	private long _nextUpdate;
	



else if (command.startsWith("_bbsranking"))
		{
			if (_nextUpdate < System.currentTimeMillis())
			{
				PVP.setLength(0);
				PKS.setLength(0);
				
				try (Connection con = DatabaseFactory.getConnection();)
				{
					try (PreparedStatement ps = con.prepareStatement("SELECT char_name, pvpkills FROM characters WHERE pvpkills > 0 ORDER BY pvpkills DESC LIMIT " + PAGE_LIMIT_15);
						ResultSet rs = ps.executeQuery())
					{
						int index = 1;
						while (rs.next())
						{
							final String name = rs.getString("char_name");
							final Player databasePlayer = World.getInstance().getPlayer(name);
							final String status = "L2UI_CH3.msnicon" + ((databasePlayer != null) && databasePlayer.isOnline() ? "1" : "4");
							
							StringUtil.append(PVP, "<table width=300 bgcolor=000000><tr><td width=20 align=right>", getColor(index), String.format("%02d", index), "</td>");
							StringUtil.append(PVP, "<td width=20 height=18><img src=", status, " width=16 height=16></td><td width=160 align=left>", name, "</td>");
							StringUtil.append(PVP, "<td width=100 align=right>", StringUtil.formatNumber(rs.getInt("pvpkills")), "</font></td></tr></table><img src=L2UI.SquareGray width=296 height=1>");
							index++;
						}
						IntStream.range(index - 1, PAGE_LIMIT_15).forEach(x -> applyEmpty(PVP));
					}
					
					try (PreparedStatement ps = con.prepareStatement("SELECT char_name, pkkills FROM characters WHERE pkkills > 0 ORDER BY pkkills DESC LIMIT " + PAGE_LIMIT_15);
						ResultSet rs = ps.executeQuery())
					{
						int index = 1;
						while (rs.next())
						{
							final String name = rs.getString("char_name");
							final Player databasePlayer = World.getInstance().getPlayer(name);
							final String status = "L2UI_CH3.msnicon" + ((databasePlayer != null) && databasePlayer.isOnline() ? "1" : "4");
							
							StringUtil.append(PKS, "<table width=300 bgcolor=000000><tr><td width=20 align=right>", getColor(index), String.format("%02d", index), "</td>");
							StringUtil.append(PKS, "<td width=20 height=18><img src=", status, " width=16 height=16></td><td width=160 align=left>", name, "</td>");
							StringUtil.append(PKS, "<td width=100 align=right>", StringUtil.formatNumber(rs.getInt("pkkills")), "</font></td></tr></table><img src=L2UI.SquareGray width=296 height=1>");
							index++;
						}
						IntStream.range(index - 1, PAGE_LIMIT_15).forEach(x -> applyEmpty(PKS));
					}
				}
				catch (Exception e)
				{
				}
				
				_nextUpdate = System.currentTimeMillis() + 60000L;
			}
			final String customPath = Config.CUSTOM_CB_ENABLED ? "Custom/" : "";
			final String path = command.replace("_bbsranking;", "");
			String content = HtmCache.getInstance().getHtm(player, "data/html/CommunityBoard/" + customPath + path);
			
			if (content != null)
			{
				content = content.replaceAll("%name%", player.getName());
				content = content.replaceAll("%pvp%", PVP.toString());
				content = content.replaceAll("%pks%", PKS.toString());
				content = content.replaceAll("%time%", String.valueOf((_nextUpdate - System.currentTimeMillis()) / 1000));
				CommunityBoardHandler.separateAndSend(content, player);
				
			}
		}

 

Critical Error: 

image.png.9b5d35610b6f630f16eead8a18de2e33.png

2 answers to this question

Recommended Posts

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Posts

    • It's also the players' fault, because there have been decent servers implementing some of the things you said plus some other 'innovations', plus many QOL things for newbies (ingame bestiary, with drops searchers, etc). In the end, it's the players who decide to feed into that shit and play the most garbage servers simply because the owners of the servers gave their clan leaders 100 euros, or they insta quit the server because they didn't win the first QA, etc, etc, etc.   In the end, if a server is garbage or great it doesn't really matter if the players don't wanna stay in there.   Players are no better than the devs themselves, in the end it seems there are abusive devs who will milk the shit out of their willingly milkable players, or there are none, goes both ways.
    • In my opinion, L2 is dead because the people who make servers didn’t adapt to today’s reality. People are getting older, life moves faster, there are more responsibilities, and less free time. And I’m not even talking about newcomers—how can you expect someone new to this game to learn by Googling every drop location or quest requirement? These things should’ve been integrated into the game, made accessible with just a few clicks through the interface. Instead, so much time was wasted trying to recreate retail-like features that no one asked for. Everyone hates autofarm, but why? Because admins never found a smart way to implement it. You could have made it available only in specific zones, with reduced drops, working like Adrenaline, or auto-teleporting to farm for a limited time per day—just enough to help people with limited time stay relevant in-game. There should also be zones with better drops, where active farming actually matters. Other features feel pointless—like the Life Stone system. Spamming LS to get a skill? Instead, you could create a system where you level up the skill with low chances per level, something that feels progressive and fair. Crafting should be simpler too. Right-click a recipe, and the required materials should show up right there. As for sieges, why not create daily clan war events at peak hours—one for Europeans, one for Latinos? You could spawn crystals inside or outside castles that give points and trigger PvP. Add a boss during the event that gives even more points, and let the top clan in the ranking take the castle. I could go on forever, but what’s the point? The community died because the people who had the knowledge to improve the game just took the easy way out, copying the same server formula over and over until no one could enjoy playing it anymore.
    • It's not because I'm an admin that he treated me differently. I actually gave him several clients from my side without him even knowing they came from me, and most of them had no issues. I was also waiting 3–4 weeks at times for things I bought from AvE, even when I was in a rush. He still delivered in the end. That said, I'm not defending him blindly. I'm just saying it's unlikely he’d risk scamming someone over 60–100€, especially knowing how quickly word spreads here.
    • For exact same reason - there were accusation that I scammed. When was it? 2016? But in that time, admins actually didn't listen. I got banned, then unbaned (when I prooved I've refunded) but I was trash talking to mods. When few months later same shit happened, Grisom (?) old global mod, banned me anyway. You can read somewhere on forum how I was shitting on him for doing that (from other account because original account was banned) - which was banned too. He is not here anymore I think. Back in the days I was well know for not carring that much if I was talking to mod or admin, I didn't hold my tongue. Now You know. Just like You know - if I delay, I deliver or refund. I'm not a scammer, even if my old time haterz love to repeat themselfs like mantra. I don't care.
    • Okay I respect that but why is your other account banned?   I don't think this happened just because you delayed somebodys work even in 2012
  • Topics

×
×
  • Create New...