Help Grade Penalty

[TreVor]

Hello all dear members how to fix grade penalty on l2jfrozen ?

 

This option doesnt work i have on config ExpertisePenalty=True and dont work players can equip weapon s on 40 lvl

 

/**

* Refresh expertise penalty.

*/

public void refreshExpertisePenalty()

{

if (!Config.EXPERTISE_PENALTY)

return;

 

 

int intensityW = 0; // Default value

int intensityA = 0; // Default value.

// Level of grade penalty.

 

for (final L2ItemInstance item : getInventory().getItems())

{

// Checks if items equipped

if (item != null && item.isEquipped()) 

{

// Gets grade of item

final int crystaltype = item.getItem().getCrystalType(); 

if (item.isWeapon())

{

if (crystaltype-getExpertiseIndex()>=intensityW)

{

intensityW = crystaltype-getExpertiseIndex();

}

}

else

{

if (item.isArmor())

{

if (crystaltype-getExpertiseIndex()>=intensityA)

{

intensityA = crystaltype-getExpertiseIndex();

}

}

}

}

}

 

 

int intensity = intensityW + intensityA;

 

if (getExpertisePenalty() != intensity)

{

int penalties = _masteryPenalty + _masteryWeapPenalty + intensity;

if (penalties > 10) // Checks if penalties are out of bounds for skill level on XML

{

penalties = 10;

}

 

_expertisePenalty = intensity;

 

if (penalties > 0)

{

super.addSkill(SkillTable.getInstance().getInfo(4267,1));

sendSkillList();

}

else

{

super.removeSkill(getKnownSkill(4267));

sendSkillList();

_expertisePenalty = 0;

}

}

}

 

 [javac] if (item.isArmor())

    [javac]        ^

    [javac]   symbol:   method isArmor()

    [javac]   location: variable item of type L2ItemInstance

    [javac] 1 error

 

Edited August 4, 2017 by TreVor

[melron]

its different than frozen's code ... check this

public void refreshExpertisePenalty()
{
	if (!Config.EXPERTISE_PENALTY)
		return;
	// This code works on principle that first 1-5 levels of penalty is for weapon and 6-10levels are for armor
	int intensityW = 0; // Default value
	int intensityA = 5; // Default value.
	int intensity = 0; // Level of grade penalty.
	for (final L2ItemInstance item : getInventory().getItems())
	{
		if (item != null && item.isEquipped()) // Checks if items equipped
		{
			final int crystaltype = item.getItem().getCrystalType(); // Gets grade of item
			// Checks if item crystal levels is above character levels and also if last penalty for weapon was lower.
			if (crystaltype > getExpertiseIndex() && item.isWeapon() && crystaltype > intensityW)
			{
				intensityW = crystaltype - getExpertiseIndex();
			}
			// Checks if equiped armor, accesories are above character level and adds each armor penalty.
			if (crystaltype > getExpertiseIndex() && !item.isWeapon())
			{
				intensityA += crystaltype - getExpertiseIndex();
			}
		}
	}
	if (intensityA == 5)// Means that there isn't armor penalty.
	{
		intensity = intensityW;
	}
	else
	{
		intensity = intensityW + intensityA;
	}
	// Checks if penalty is above maximum and sets it to maximum.
	if (intensity > 10)
	{
		intensity = 10;
	}
	if (getExpertisePenalty() != intensity)
	{
		int penalties = _masteryPenalty + _masteryWeapPenalty + intensity;
		if (penalties > 10) // Checks if penalties are out of bounds for skill level on XML
		{
			penalties = 10;
		}
		_expertisePenalty = intensity;
		if (penalties > 0)
		{
			super.addSkill(SkillTable.getInstance().getInfo(4267, intensity));
			sendSkillList();
		}
		else
		{
			super.removeSkill(getKnownSkill(4267));
			sendSkillList();
			_expertisePenalty = 0;
		}
	}
}

[TreVor]

Yes on this code grade penalty dont work ;/ how to fix it ?

Edited August 4, 2017 by TreVor

[melron]

u posted another code. on which one is the problem? what's the first code?

[TreVor]

This is fix code i search this code and dont work i have problem on compilation  [javac] if (item.isArmor())

    [javac]        ^

    [javac]   symbol:   method isArmor()

    [javac]   location: variable item of type L2ItemInstance

    [javac] 1 error

[TreVor]

How to fixed this problem ? on l2jfrozen rev 1372 dont work grade penalty dont give skill and restrictions all players can equip a sgrade weapon on 1lvl , config dont work.

[melron]

I already gave you the fix via skype and you answered me too lol

 

https://gyazo.com/e6e0d318c2610fd78af6699705f51b35